ByTIC\MediaLibrary\Loaders\Database::tryDatabase()

Complexity

Conditions	4
Paths	3

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	1
Bugs	0	Features	1

<?php
    protected function tryDatabase()
    {
        $propertiesRecord = MediaModels::properties()->forCollection($this->getCollection());

        if (!is_object($propertiesRecord) || $propertiesRecord->dbLoaded() === false) {
            return false;
        }

        $mediaRecords = MediaModels::records()->for(
            $this->getCollection()->getRecord(),

It seems like $this->getCollection()->getRecord() can also be of type ByTIC\MediaLibrary\HasMedia\HasMediaTrait; however, parameter $model of ByTIC\MediaLibrary\Models\MediaRecords\MediaRecords::for() does only seem to accept Nip\Records\AbstractModels\Record, maybe add an additional type check?

            $this->getCollection()->getName()
        );
        $files = [];
        foreach ($mediaRecords as $mediaRecord) {
            $files[] = new File($this->getFilesystem(), $mediaRecord->path);

The property path does not exist on ByTIC\MediaLibrary\Models\MediaProperties\MediaProperty. Since you implemented __get, consider adding a @property annotation.

        }
        return $files;
    }