bytesfield / simple-kyc

src/services/IdVerification.php

<?php

namespace Bytesfield\SimpleKyc\Services;

use Noodlehaus\Config;
use Mpociot\Pipeline\Pipeline;
use Bytesfield\SimpleKyc\Pipes\Smile;
use Bytesfield\SimpleKyc\Pipes\Appruve;
use Bytesfield\SimpleKyc\Classes\IdFilter;
use Bytesfield\SimpleKyc\Classes\Validation;
use Bytesfield\SimpleKyc\Pipes\Credequity;

class IdVerification
{

    public function __construct($data)
    {
        $this->country = filterCountry($data->country);

The property country does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->id_type = strtoupper($data->id_type) ?? null;

The property id_type does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->id_number = $data->id ?? null;

The property id_number does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->first_name = $data->first_name ?? null;

The property first_name does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->last_name = $data->last_name ?? null;

The property last_name does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->middle_name = $data->middle_name ?? null;

The property middle_name does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->date_of_birth = $data->date_of_birth ?? null;

The property date_of_birth does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->phone = $data->phone_number ?? null;

The property phone does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->pin = $data->pin ?? null;

The property pin does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->tin = $data->tin ?? null;

The property tin does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->gender = $data->gender ?? null;

The property gender does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->full_name = $this->first_name . ' ' . $this->last_name;

The property full_name does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->user_id = $data->user_id ?? null;

The property user_id does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->company = $data->company ?? null;

The property company does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->registration_number = $data->registration_number ?? null;

The property registration_number does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->config = new Config(__DIR__ . '/../config');

The property config does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->appruveHandler = $this->config->get('appruve.handler');

The property appruveHandler does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->smileHandler = $this->config->get('smile.handler');

The property smileHandler does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->credequityHandler = $this->config->get('credequity.handler');

The property credequityHandler does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    public function verify()
    {
        $IdFilter = new IdFilter(
            $this->country,
            $this->id_type,
            $this->id_number,
            $this->first_name,
            $this->last_name,
            $this->middle_name,
            $this->date_of_birth,
            $this->phone,
            $this->pin,
            $this->tin,
            $this->gender,
            $this->full_name,
            $this->user_id,
            $this->company,
            $this->registration_number

        );

        $response = null;

The assignment to $response is dead and can be removed.

        $pipes = [Smile::class, Appruve::class, Credequity::class,];

        $response = (new Pipeline)->send($IdFilter)
            ->through($pipes)
            ->then(function ($result) {
                return $result;
            });

        $executedHandler = strtoupper($IdFilter->getHandler());

        $validation = new Validation();

        //Validate Appruve Handler result
        if ($executedHandler == strtoupper($this->appruveHandler)) {

It seems like $this->appruveHandler can also be of type null; however, parameter $string of strtoupper() does only seem to accept string, maybe add an additional type check?

            return $validation->validateAppruve($response, $IdFilter);
        }

        //Validate Smile Handler result
        if ($executedHandler == strtoupper($this->smileHandler)) {
            return $validation->validateSmile($response, $IdFilter);

The call to Bytesfield\SimpleKyc\Classes\Validation::validateSmile() has too many arguments starting with $IdFilter.

        }

        //Validate Credequity Handler result
        if ($executedHandler == strtoupper($this->credequityHandler)) {
            return $validation->validateCredequity($response, $IdFilter);
        }

        return $response;
    }
}