Bytesfield\SimpleKyc\Services\IdVerification::verify()

Complexity

Conditions	4
Paths	4

Size

Total Lines	51
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

<?php
    public function verify()
    {
        $IdFilter = new IdFilter(
            $this->country,
            $this->id_type,
            $this->id_number,
            $this->first_name,
            $this->last_name,
            $this->middle_name,
            $this->date_of_birth,
            $this->phone,
            $this->pin,
            $this->tin,
            $this->gender,
            $this->full_name,
            $this->user_id,
            $this->company,
            $this->registration_number

        );

        $response = null;

The assignment to $response is dead and can be removed.

        $pipes = [Smile::class, Appruve::class, Credequity::class,];

        $response = (new Pipeline)->send($IdFilter)
            ->through($pipes)
            ->then(function ($result) {
                return $result;
            });

        $executedHandler = strtoupper($IdFilter->getHandler());

        $validation = new Validation();

        //Validate Appruve Handler result
        if ($executedHandler == strtoupper($this->appruveHandler)) {

It seems like $this->appruveHandler can also be of type null; however, parameter $string of strtoupper() does only seem to accept string, maybe add an additional type check?

            return $validation->validateAppruve($response, $IdFilter);
        }

        //Validate Smile Handler result
        if ($executedHandler == strtoupper($this->smileHandler)) {
            return $validation->validateSmile($response, $IdFilter);

The call to Bytesfield\SimpleKyc\Classes\Validation::validateSmile() has too many arguments starting with $IdFilter.

        }

        //Validate Credequity Handler result
        if ($executedHandler == strtoupper($this->credequityHandler)) {
            return $validation->validateCredequity($response, $IdFilter);
        }

        return $response;
    }