Completed
Push — master ( cb1331...b738e0 )
by Joao
02:11
created
src/UsersBase.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
      * @param string $userName
65 65
      * @param string $email
66 66
      * @param string $password
67
-     * @return bool
67
+     * @return boolean|null
68 68
      */
69 69
     public function addUser($name, $userName, $email, $password)
70 70
     {
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
      * Remove the user based on his login.
130 130
      *
131 131
      * @param string $username
132
-     * @return bool
132
+     * @return boolean|null
133 133
      * */
134 134
     public function removeUserName($username)
135 135
     {
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
      * @param int $userId User login
234 234
      * @param string $propertyName Property name
235 235
      * @param string $value Property value with a site
236
-     * @return bool
236
+     * @return boolean|null
237 237
      * */
238 238
     public function removeProperty($userId, $propertyName, $value)
239 239
     {
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
      *
247 247
      * @param string $propertyName Property name
248 248
      * @param string $value Property value with a site
249
-     * @return bool
249
+     * @return boolean|null
250 250
      * */
251 251
     public function removeAllProperties($propertyName, $value)
252 252
     {
Please login to merge, or discard this patch.
src/UsersMoodleDataset.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -54,6 +54,9 @@
 block discarded – undo
54 54
         throw new NotImplementedException('Add new user is not implemented');
55 55
     }
56 56
 
57
+    /**
58
+     * @param string $password
59
+     */
57 60
     protected function passwordIsLegacyHash($password)
58 61
     {
59 62
         return (bool) preg_match('/^[0-9a-f]{32}$/', $password);
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -184,7 +184,7 @@
 block discarded – undo
184 184
             $this->_userTable = new UserTable(
185 185
                 "mdl_user",
186 186
                 "id",
187
-                "concat(firstname, ' ', lastname)",  // This disable update data
187
+                "concat(firstname, ' ', lastname)", // This disable update data
188 188
                 "email",
189 189
                 "username",
190 190
                 "password",
Please login to merge, or discard this patch.
src/UsersDBDataset.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -285,7 +285,7 @@
 block discarded – undo
285 285
 
286 286
     protected function sqlRemoveUserById()
287 287
     {
288
-        return "DELETE FROM @@Table WHERE @@Id = [[id]]" ;
288
+        return "DELETE FROM @@Table WHERE @@Id = [[id]]";
289 289
     }
290 290
 
291 291
     /**
Please login to merge, or discard this patch.