byKolev / MultilingualExtension

src/Context/MultilingualContext.php

Unused Use Statements -6 removed lines

@@ -4,13 +4,7 @@
 
 use Behat\Behat\Context\Context;
 use Symfony\Component\Yaml\Yaml;
-use Drupal\DrupalExtension\Context\DrupalContext;
-use Behat\MinkExtension;
-use Behat\Behat\Context\TranslatableContext;
 use Behat\Mink\Element\Element;
-use Behat\Gherkin\Node\TableNode;
-use Behat\Behat\Hook\Scope\BeforeScenarioScope;
-use Behat\MinkExtension\Context\RawMinkContext;
 
 /**
  * This is the file for Multilingual context for Drupal. The context is working based on specifications

Spacing +12 added lines, -12 removed lines

@@ -47,14 +47,14 @@ 
         $file_path = $base_path.$this->multilingual_parameters['translations'];
         $yaml = file_get_contents($file_path);
         $yaml_parse_array_check = Yaml::parse($yaml);
-        if(is_array($yaml_parse_array_check)) {
+        if (is_array($yaml_parse_array_check)) {
             $this->translations = $yaml_parse_array_check;
         }
     }
 
     // Checks whether the translations file variable is set in the Behat profile and parses it to array.
     public function initializeMultilanguage() {
-        if(isset($this->multilingual_parameters['translations'])) {
+        if (isset($this->multilingual_parameters['translations'])) {
             $this->parseTranslationFile();
         }
         $this->parseLanguageCodes();
@@ -80,12 +80,12 @@ 
         }
         $base_url_length = strlen($base_url);
         //Get the 2 symbols in current URL after the base_url when Clean URLs is enabled
-        $clean_url_language_code = substr($current_url,$base_url_length,2);
-        $not_clean_url_language_code = substr($current_url,$base_url_length+3,2);
-        if(in_array($clean_url_language_code,$this->languages_iso_codes) && substr($current_url,$base_url_length+2,1) == "/") {
+        $clean_url_language_code = substr($current_url, $base_url_length, 2);
+        $not_clean_url_language_code = substr($current_url, $base_url_length + 3, 2);
+        if (in_array($clean_url_language_code, $this->languages_iso_codes)&&substr($current_url, $base_url_length + 2, 1) == "/") {
             return $clean_url_language_code;
         }
-        else if (in_array($not_clean_url_language_code,$this->languages_iso_codes) && substr($current_url,$base_url_length+5,1) == "/"){
+        else if (in_array($not_clean_url_language_code, $this->languages_iso_codes)&&substr($current_url, $base_url_length + 5, 1) == "/") {
             return $not_clean_url_language_code;
         }
         else return $this->multilingual_parameters['default_language'];
@@ -100,14 +100,14 @@ 
 
     public function localizeTarget($target) {
         $translations = $this->multilingual_parameters['translations'];
-        if(isset($this->translations[$target][$this->multilingual_parameters['default_language']])){
+        if (isset($this->translations[$target][$this->multilingual_parameters['default_language']])) {
             $target = $this->translations[$target][$this->languageDetection()];
             return $target;
         }
         elseif (isset($this->translations[$target])) {
             return $target;
         }
-        else throw new \Exception ("The text '$target'' is not defined in '$translations' translation file.");
+        else throw new \Exception("The text '$target'' is not defined in '$translations' translation file.");
     }
 
     /**
@@ -117,7 +117,7 @@ 
     public function localizeField($field) {
         $re = "/(?:[-])(".$this->multilingual_parameters['default_language'].")(?:[-])/";
         $language = "-".$this->languageDetection()."-";
-        $field = preg_replace($re, $language,$field);
+        $field = preg_replace($re, $language, $field);
         return $field;
     }
 
@@ -206,7 +206,7 @@ 
      *
      * @When /^I wait for localized text "([^"]*)" to appear with max time "([^"]+)"(?: seconds)?$/
      */
-    public function iWaitForLocalizedTextToAppearWithMaxTime($target, $maxExecutionTime){
+    public function iWaitForLocalizedTextToAppearWithMaxTime($target, $maxExecutionTime) {
         $target = $this->localizeTarget($target);
         $this->iWaitForTextToAppearWithMaxTime($target, $maxExecutionTime);
     }
@@ -230,7 +230,7 @@ 
      * @Given I click localized :link in the :rowText row
      * @Then I (should )see the localized :link in the :rowText row
      */
-    public function assertLocalizedClickInTableRow($link, $rowText){
+    public function assertLocalizedClickInTableRow($link, $rowText) {
         $link = $this->localizeTarget($link);
         $page = $this->getSession()->getPage();
         if ($link_element = $this->getTableRow($page, $rowText)->findLink($link)) {
@@ -259,7 +259,7 @@ 
      *
      * @When /^I click on the localized text "([^"]*)" in the "(?P<region>[^"]*)"(?:| region)$/
      */
-    public function iClickOnTheLocalizedTextInRegion($text, $region){
+    public function iClickOnTheLocalizedTextInRegion($text, $region) {
         $text = $this->localizeTarget($text);
         $this->iClickOnTheTextInRegion($text, $region);
     }

Braces +6 added lines, -6 removed lines

@@ -84,11 +84,11 @@ 
         $not_clean_url_language_code = substr($current_url,$base_url_length+3,2);
         if(in_array($clean_url_language_code,$this->languages_iso_codes) && substr($current_url,$base_url_length+2,1) == "/") {
             return $clean_url_language_code;
-        }
-        else if (in_array($not_clean_url_language_code,$this->languages_iso_codes) && substr($current_url,$base_url_length+5,1) == "/"){
+        } else if (in_array($not_clean_url_language_code,$this->languages_iso_codes) && substr($current_url,$base_url_length+5,1) == "/"){
             return $not_clean_url_language_code;
+        } else {
+            return $this->multilingual_parameters['default_language'];
         }
-        else return $this->multilingual_parameters['default_language'];
     }
 
     /**
@@ -103,11 +103,11 @@ 
         if(isset($this->translations[$target][$this->multilingual_parameters['default_language']])){
             $target = $this->translations[$target][$this->languageDetection()];
             return $target;
-        }
-        elseif (isset($this->translations[$target])) {
+        } elseif (isset($this->translations[$target])) {
             return $target;
+        } else {
+            throw new \Exception ("The text '$target'' is not defined in '$translations' translation file.");
         }
-        else throw new \Exception ("The text '$target'' is not defined in '$translations' translation file.");
     }
 
     /**

Doc Comments +1 added lines

@@ -112,6 +112,7 @@
 
     /**
      * This function localizes the field based on Drupal standards. default_language variable is used as a base.
+     * @return string
      */
 
     public function localizeField($field) {

src/Context/RawMultilingualContext.php

Spacing +9 added lines, -9 removed lines

@@ -50,7 +50,7 @@ 
         $session = $this->getSession();
         $element = $session->getPage()->find(
             'xpath',
-            $session->getSelectorsHandler()->selectorToXpath('xpath', '//*[contains(text(),"' . $text . '")]'));
+            $session->getSelectorsHandler()->selectorToXpath('xpath', '//*[contains(text(),"'.$text.'")]'));
 
         if (null === $element) {
             throw new \InvalidArgumentException(sprintf('Cannot find text: "%s"', $text));
@@ -61,19 +61,19 @@ 
 
     public function assertValueInInput($value, $input) {
 
-        if (substr($input,0,1) != "#") {
-            $input = "#" . $input;
+        if (substr($input, 0, 1) != "#") {
+            $input = "#".$input;
         }
         $session = $this->getSession();
         $element = $session->getPage()->find('css', $input);
-        if(isset($element)) {
+        if (isset($element)) {
             $text = $element->getValue();
         }
         else {
             throw new \Exception(sprintf("Element is null"));
         }
 
-        if($text === $value) {
+        if ($text === $value) {
             return true;
         }
         else {
@@ -105,12 +105,12 @@ 
 
         $html = $this->getSession()->getDriver()->getContent();
         $text = $this->validateTextForSearchInSource($text);
-        $regex = '/' . $text . '/';
+        $regex = '/'.$text.'/';
 
         preg_match($regex, $html, $results);
 
         if ($results == null) {
-            throw new \Exception('The searched text ' . $text . ' was not found in the source of the page.');
+            throw new \Exception('The searched text '.$text.' was not found in the source of the page.');
         }
 
         return true;
@@ -129,7 +129,7 @@ 
 
         $session = $this->getSession();
         $element = $session->getPage()->find('region', $region)->find('xpath', $session->getSelectorsHandler()->selectorToXpath('xpath',
-            '//*[contains(text(),"' . $text . '")]'));
+            '//*[contains(text(),"'.$text.'")]'));
         if (null === $element) {
             throw new \InvalidArgumentException(sprintf('Cannot find text: "%s"', $text));
         }
@@ -141,7 +141,7 @@ 
 
         $session = $this->getSession();
         $element = $session->getPage()->find('region', $region)->find('xpath', $session->getSelectorsHandler()->selectorToXpath('xpath',
-            '//*[contains(text(),"' . $text . '")]'));
+            '//*[contains(text(),"'.$text.'")]'));
 
         if (null === $element) {
             throw new \InvalidArgumentException(sprintf('Cannot find text: "%s"', $text));

Braces +3 added lines, -6 removed lines

@@ -68,15 +68,13 @@ 
         $element = $session->getPage()->find('css', $input);
         if(isset($element)) {
             $text = $element->getValue();
-        }
-        else {
+        } else {
             throw new \Exception(sprintf("Element is null"));
         }
 
         if($text === $value) {
             return true;
-        }
-        else {
+        } else {
             throw new \Exception(sprintf('Value of input : "%s" does not match the text "%s"', $text, $value));
         }
     }
@@ -90,8 +88,7 @@ 
                 $this->iShouldSeeInTheSourceOfThePage($text);
                 $isTextFound = true;
                 break;
-            }
-            catch (\Exception $e) {
+            } catch (\Exception $e) {
                 sleep(1);
             }
         }