butcherman / Tech_Bench

routes/web.php

Spacing +45 added lines, -45 removed lines

@@ -8,8 +8,8 @@ 
 /*
 *   Non user Routes
 */
-Route::get('/',         'Auth\LoginController@showLoginForm')->name('index');
-Route::get('logout',    'Auth\LoginController@logout')       ->name('logout');
+Route::get('/', 'Auth\LoginController@showLoginForm')->name('index');
+Route::get('logout', 'Auth\LoginController@logout')       ->name('logout');
 Route::get('no-script', 'Controller@noScript')               ->name('noscript');
 
 
@@ -21,52 +21,52 @@ 
 /*
 *   Download File Routes
 */
-Route::get('download/{id}/{filename}',    'DownloadController@index')          ->name('download');
+Route::get('download/{id}/{filename}', 'DownloadController@index')          ->name('download');
 Route::get('download-archive/{filename}', 'DownloadController@downloadArchive')->name('downloadArchive');
-Route::put('download-archive',            'DownloadController@archiveFiles')   ->name('archiveFiles');
+Route::put('download-archive', 'DownloadController@archiveFiles')   ->name('archiveFiles');
 
 /*
 *   User Settings Routes
 */
-Route::get('account',                   'AccountController@index')         ->name('account');
-Route::post('account',                  'AccountController@submit')        ->name('account');
-Route::put('account',                   'AccountController@notifications') ->name('account');
-Route::get('/account/change-password',  'AccountController@changePassword')->name('changePassword');
+Route::get('account', 'AccountController@index')         ->name('account');
+Route::post('account', 'AccountController@submit')        ->name('account');
+Route::put('account', 'AccountController@notifications') ->name('account');
+Route::get('/account/change-password', 'AccountController@changePassword')->name('changePassword');
 Route::post('/account/change-password', 'AccountController@submitPassword')->name('changePassword');
 
 /*
 *   Basic Logged In Routes
 */
-Route::get('about',                  'DashboardController@about')           ->name('about');
-Route::get('dashboard',              'DashboardController@index')           ->name('dashboard');
-Route::get('notifications',          'DashboardController@getNotifications')->name('getNotifications');
+Route::get('about', 'DashboardController@about')           ->name('about');
+Route::get('dashboard', 'DashboardController@index')           ->name('dashboard');
+Route::get('notifications', 'DashboardController@getNotifications')->name('getNotifications');
 Route::get('mark-notification/{id}', 'DashboardController@markNotification')->name('markNotification');
-Route::delete('notifications/{id}',  'DashboardController@delNotification') ->name('delNotification');
+Route::delete('notifications/{id}', 'DashboardController@delNotification') ->name('delNotification');
 
 /*
 *   File Link Routes
 */
-Route::prefix('links')->name('links.')->group(function () {
+Route::prefix('links')->name('links.')->group(function() {
     //  Resource controllers for base access
-    Route::resource('data',           'FileLinks\FileLinksController');
-    Route::get('new',                 'FileLinks\FileLinksController@create')     ->name('new');
-    Route::get('find/{id}',           'FileLinks\FileLinksController@find')       ->name('user');
+    Route::resource('data', 'FileLinks\FileLinksController');
+    Route::get('new', 'FileLinks\FileLinksController@create')     ->name('new');
+    Route::get('find/{id}', 'FileLinks\FileLinksController@find')       ->name('user');
     Route::get('details/{id}/{name}', 'FileLinks\FileLinksController@details')    ->name('details');
-    Route::get('disable/{id}',        'FileLinks\FileLinksController@disableLink')->name('disable');
+    Route::get('disable/{id}', 'FileLinks\FileLinksController@disableLink')->name('disable');
     //  File Link Files
-    Route::resource('files',          'FileLinks\LinkFilesController');
+    Route::resource('files', 'FileLinks\LinkFilesController');
     //  Index landing page
-    Route::get('/',                   'FileLinks\FileLinksController@index')      ->name('index');
+    Route::get('/', 'FileLinks\FileLinksController@index')      ->name('index');
 });
 
 /*
 *   Guest File Link Routes
 */
 Route::get('file-links/{id}/get-files', 'FileLinks\GuestLinksController@getFiles')->name('file-links.getFiles');
-Route::put('file-links/{id}',           'FileLinks\GuestLinksController@notify')  ->name('file-links.show');
-Route::post('file-links/{id}',          'FileLinks\GuestLinksController@update')  ->name('file-links.show');
-Route::get('file-links/{id}',           'FileLinks\GuestLinksController@show')    ->name('file-links.show');
-Route::get('file-links',                'FileLinks\GuestLinksController@index')   ->name('file-links.index');
+Route::put('file-links/{id}', 'FileLinks\GuestLinksController@notify')  ->name('file-links.show');
+Route::post('file-links/{id}', 'FileLinks\GuestLinksController@update')  ->name('file-links.show');
+Route::get('file-links/{id}', 'FileLinks\GuestLinksController@show')    ->name('file-links.show');
+Route::get('file-links', 'FileLinks\GuestLinksController@index')   ->name('file-links.index');
 
 /*
 *   Customer Routes
@@ -74,53 +74,53 @@ 
 Route::prefix('customer')->name('customer.')->group(function()
 {
     //  Customer Files
-    Route::resource('files',                   'Customers\CustomerFilesController');
+    Route::resource('files', 'Customers\CustomerFilesController');
     //  Custome Notes
-    Route::get('download-note/{id}',           'DownloadController@downloadCustNote')        ->name('download-note');
-    Route::resource('notes',                   'Customers\CustomerNotesController');
+    Route::get('download-note/{id}', 'DownloadController@downloadCustNote')        ->name('download-note');
+    Route::resource('notes', 'Customers\CustomerNotesController');
     //  Customer Contacts
-    Route::resource('contacts',                'Customers\CustomerContactsController');
+    Route::resource('contacts', 'Customers\CustomerContactsController');
     //  Customer Systems
-    Route::resource('systems',                 'Customers\CustomerSystemsController');
+    Route::resource('systems', 'Customers\CustomerSystemsController');
     //  Customer Details
-    Route::get('id/{id}/{name}',               'Customers\CustomerDetailsController@details')->name('details');
-    Route::resource('id',                      'Customers\CustomerDetailsController');
+    Route::get('id/{id}/{name}', 'Customers\CustomerDetailsController@details')->name('details');
+    Route::resource('id', 'Customers\CustomerDetailsController');
     //  check Id and bookmark customer
     Route::get('toggle-fav/{action}/{custID}', 'Customers\CustomerController@toggleFav')     ->name('toggle-fav');
-    Route::get('check-id/{id}',                'Customers\CustomerController@checkID')       ->name('check-id');
+    Route::get('check-id/{id}', 'Customers\CustomerController@checkID')       ->name('check-id');
     //  Index landing/search page
-    Route::get('search',                       'Customers\CustomerController@search')        ->name('search');
-    Route::get('/',                            'Customers\CustomerController@index')         ->name('index');
+    Route::get('search', 'Customers\CustomerController@search')        ->name('search');
+    Route::get('/', 'Customers\CustomerController@index')         ->name('index');
 });
 
 /*
 *   Tech Tip Routes
 */
-Route::resource('tips',                       'TechTips\TechTipsController');
-Route::post('submit-edit/{id}',               'TechTips\TechTipsController@update')      ->name('tips.submit-edit');
+Route::resource('tips', 'TechTips\TechTipsController');
+Route::post('submit-edit/{id}', 'TechTips\TechTipsController@update')      ->name('tips.submit-edit');
 Route::prefix('tip')->name('tip.')->group(function()
 {
-    Route::resource('comments',               'TechTips\TechTipCommentsController');
-    Route::get('search',                      'TechTips\TechTipsController@search')      ->name('search');
-    Route::get('details/{id}/{name}',         'TechTips\TechTipsController@details')     ->name('details');
-    Route::post('process-image',              'TechTips\TechTipsController@processImage')->name('processImage');
+    Route::resource('comments', 'TechTips\TechTipCommentsController');
+    Route::get('search', 'TechTips\TechTipsController@search')      ->name('search');
+    Route::get('details/{id}/{name}', 'TechTips\TechTipsController@details')     ->name('details');
+    Route::post('process-image', 'TechTips\TechTipsController@processImage')->name('processImage');
     Route::get('toggle-fav/{action}/{tipID}', 'TechTips\TechTipsController@toggleFav')   ->name('toggle-fav');
-    Route::get('download-tip/{id}',           'DownloadController@downloadTechTip')      ->name('downloadTip');
+    Route::get('download-tip/{id}', 'DownloadController@downloadTechTip')      ->name('downloadTip');
 });
 
 /*
     *   Administration Routes
 */
-Route::prefix('admin')->name('admin.')->group(function () {
+Route::prefix('admin')->name('admin.')->group(function() {
 
 
 
     //  Administrative routes for users
-    Route::resource('user',                'Admin\UserController');
-    Route::post('user/change-password',     'Admin\UserController@submitPassword')->name('user.changePassword');
+    Route::resource('user', 'Admin\UserController');
+    Route::post('user/change-password', 'Admin\UserController@submitPassword')->name('user.changePassword');
     Route::get('check-user/{name}/{type}', 'Admin\UserController@checkUser')      ->name('checkUser');
-    Route::get('links/show/{id}',          'Admin\AdminController@showLinks')     ->name('user.showLinks');
-    Route::get('links',                    'Admin\AdminController@userLinks')     ->name('user.links');
+    Route::get('links/show/{id}', 'Admin\AdminController@showLinks')     ->name('user.showLinks');
+    Route::get('links', 'Admin\AdminController@userLinks')     ->name('user.links');
 
 
 

app/Http/Controllers/Admin/UserController.php

Spacing +16 added lines, -16 removed lines

@@ -31,8 +31,8 @@ 
     public function __construct()
     {
         $this->middleware('auth')->except('initializeUser', 'submitInitializeUser');
-        $this->middleware(function ($request, $next) {
-            $this->user = auth()->user();  //  TODO - is this correct????
+        $this->middleware(function($request, $next) {
+            $this->user = auth()->user(); //  TODO - is this correct????
             $this->authorize('hasAccess', 'Manage Users');
             return $next($request);
         });
@@ -41,12 +41,12 @@ 
     //  Show the list of current users to edit
     public function index()
     {
-        $userList = new UserCollection(User::where('active', 1)->with(['UserLogins' => function ($query) {
+        $userList = new UserCollection(User::where('active', 1)->with(['UserLogins' => function($query) {
             $query->latest()->limit(1);
         }])->get()
             /** @scrutinizer ignore-call */
             ->makeVisible('user_id'));
-        $route    = 'admin.user.edit';
+        $route = 'admin.user.edit';
 
         return view('admin.userIndex', [
             'userList' => $userList,
@@ -109,7 +109,7 @@ 
     {
         //  Validate the new user form
         $request->validate([
-            'role'       => 'required|numeric',  //  TODO - add validation rule - is in user roles table
+            'role'       => 'required|numeric', //  TODO - add validation rule - is in user roles table
             'username'   => 'required|unique:users|regex:/^[a-zA-Z0-9_]*$/',
             'first_name' => 'required',
             'last_name'  => 'required',
@@ -187,17 +187,17 @@ 
         $user  = new UserResource(User::findOrFail($id));
 
         //  Make sure that the user is not trying to deactivate someone with more permissions
-        if ($user->role_id < Auth::user()->role_id) 
+        if($user->role_id < Auth::user()->role_id) 
         {
             return abort(403);
         }
 
         //  Good to go - update user password
         $roleArr = [];
-        foreach ($roles as $role) {
-            if ($role->role_id == 1 && Auth::user()->role_id != 1) {
+        foreach($roles as $role) {
+            if($role->role_id == 1 && Auth::user()->role_id != 1) {
                 continue;
-            } else if ($role->role_id == 2 && Auth::user()->role_id > 1) {
+            } else if($role->role_id == 2 && Auth::user()->role_id > 1) {
                 continue;
             } else {
                 // $roleArr[$role->role_id] = $role->name;
@@ -208,7 +208,7 @@ 
             }
         }
 
-        Log::debug('Route ' . Route::currentRouteName() . ' visited by User ID-' . Auth::user()->user_id);
+        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
         return view('admin.userEdit', [
             'roles' => $roleArr,
             'user'  => $user->makeVisible(['user_id', 'username']),
@@ -235,7 +235,7 @@ 
         //  Update the user data
         $user = User::findOrFail($id);
 
-        if ($user->role_id < Auth::user()->role_id) 
+        if($user->role_id < Auth::user()->role_id) 
         {
             return abort(403);
         }
@@ -278,12 +278,12 @@ 
         $user = User::find($request->user_id);
 
         //  Verify this is a valid user ID
-        if (!$user) {
+        if(!$user) {
             $success = false;
             $reason  = 'Cannot find user with this ID';
         }
         //  Make sure that the user is not trying to deactivate someone with more permissions
-        else if ($user->role_id < Auth::user()->role_id) {
+        else if($user->role_id < Auth::user()->role_id) {
             $success = false;
             $reason  = 'You cannot change password for a user with higher permissions that you.  If this user has locked themselves out, have then use the reset link on the login page.';
         }
@@ -296,11 +296,11 @@ 
                 'password_expires' => $nextChange
             ]);
             $success = true;
-            $reason  = 'Password for ' . $user->full_name . ' successfully reset.';
+            $reason  = 'Password for '.$user->full_name.' successfully reset.';
         }
 
-        Log::debug('Route ' . Route::currentRouteName() . ' visited by User ID-' . Auth::user()->user_id);
-        Log::notice('User ID-' . $request->user_id . ' password chagned by ' . Auth::user()->user_id, [
+        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
+        Log::notice('User ID-'.$request->user_id.' password chagned by '.Auth::user()->user_id, [
             'success' => $success,
             'reason'  => $reason,
         ]);

app/Http/Controllers/Admin/AdminController.php

Spacing +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
     //  Show the links for the selected user
     public function showLinks($id)
     {
-        $user     = User::find($id);
+        $user = User::find($id);
 
         Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
         return view('admin.linkDetails', [

Braces +1 added lines, -2 removed lines

@@ -34,8 +34,7 @@
                         User::where('active', 1)
                             ->withCount([
                                 'FileLinks',
-                                'FileLinks as expired_file_links_count' => function($query)
-                                {
+                                'FileLinks as expired_file_links_count' => function($query) {
                                     $query->where('expire', '<', Carbon::now());
                                 }
                             ])