App\Notifications\NewUserEmail

Complexity

Total Complexity

4

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

40%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	via()	0	4	1
A	toMail()	0	11	1
A	toArray()	0	8	1

<?php

namespace App\Notifications;

use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Notifications\Messages\MailMessage;
use Illuminate\Notifications\Notification;

class NewUserEmail extends Notification implements ShouldQueue
{
    use Queueable;
    protected $user, $hash;

    /**
     * Create a new notification instance.
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct($user, $hash)
    {
        //
        $this->user = $user;
        $this->hash = $hash;
    }

    /**
     * Get the notification's delivery channels.
     *
     * @param  mixed  $notifiable
     * @return array
     */
    public function via(/** @scrutinizer ignore-unused */$notifiable)

The parameter $notifiable is not used and could be removed.

    {
        return ['mail'];
    }

    /**
     * Get the mail representation of the notification.
     *
     * @param  mixed  $notifiable
     * @return \Illuminate\Notifications\Messages\MailMessage
     */
    public function toMail(
    /** @scrutinizer ignore-unused */
    $notifiable)

The parameter $notifiable is not used and could be removed.

    {
        return (new MailMessage)
        ->greeting('Hello '.$this->user->full_name)
                    ->line('A new '.config('app.name').' account has been created for you.')
                    ->line('Your new username is:  **'.$this->user->username.'**')
                    ->line('You can click the link below to finsh setting up your account.')
                    ->action('Setup Account', url(route('initialize', $this->hash)));

It seems like url(route('initialize', $this->hash)) targeting url() can also be of type object<Illuminate\Contracts\Routing\UrlGenerator>; however, Illuminate\Notifications\Messages\SimpleMessage::action() does only seem to accept string, maybe add an additional type check?

    }

    /**
     * Get the array representation of the notification.
     *
     * @param  mixed  $notifiable
     * @return array
     */
    public function toArray(
    /** @scrutinizer ignore-unused */
    $notifiable)

The parameter $notifiable is not used and could be removed.

    {
        return [
            //
        ];
    }
}