NewUserEmail::toMail() - Code Metrics - Inspection of "Updated CustomerAdminController.php" - butcherman/Tech_Bench - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev5 ( 1140b1...da16e0 )

by Ron

created 2020-04-09 02:26 UTC

NewUserEmail::toMail() A

↳ Parent: NewUserEmail

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	0
cts	7
cp	0
rs	9.9
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	2

<?php

namespace App\Notifications;

use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Notifications\Messages\MailMessage;
use Illuminate\Notifications\Notification;

class NewUserEmail extends Notification implements ShouldQueue
{
    use Queueable;
    protected $user, $hash;

    /**
     * Create a new notification instance.
     *
     * @return void

     */
    public function __construct($user, $hash)
    {
        //
        $this->user = $user;
        $this->hash = $hash;
    }

    /**
     * Get the notification's delivery channels.
     *
     * @param  mixed  $notifiable
     * @return array
     */
    public function via(/** @scrutinizer ignore-unused */$notifiable)

    {
        return ['mail'];
    }

    /**
     * Get the mail representation of the notification.
     *
     * @param  mixed  $notifiable
     * @return \Illuminate\Notifications\Messages\MailMessage
     */
    public function toMail(
    /** @scrutinizer ignore-unused */
    $notifiable)

    {
        return (new MailMessage)
        ->greeting('Hello '.$this->user->full_name)
                    ->line('A new '.config('app.name').' account has been created for you.')
                    ->line('Your new username is:  **'.$this->user->username.'**')
                    ->line('You can click the link below to finsh setting up your account.')
                    ->action('Setup Account', url(route('initialize', $this->hash)));

    }

    /**
     * Get the array representation of the notification.
     *
     * @param  mixed  $notifiable
     * @return array
     */
    public function toArray(
    /** @scrutinizer ignore-unused */
    $notifiable)

    {
        return [
            //
        ];
    }
}


1		<?php
2
3		namespace App\Notifications;
4
5		use Illuminate\Bus\Queueable;
6		use Illuminate\Contracts\Queue\ShouldQueue;
7		use Illuminate\Notifications\Messages\MailMessage;
8		use Illuminate\Notifications\Notification;
9
10		class NewUserEmail extends Notification implements ShouldQueue
11		{
12		use Queueable;
13		protected $user, $hash;
14
15		/**
16		* Create a new notification instance.
17		*
18		* @return void
		0 ignored issues – show Comprehensibility Best Practice introduced 2020-04-09 02:35 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
19		*/
20	2	public function __construct($user, $hash)
21		{
22		//
23	2	$this->user = $user;
24	2	$this->hash = $hash;
25	2	}
26
27		/**
28		* Get the notification's delivery channels.
29		*
30		* @param mixed $notifiable
31		* @return array
32		*/
33	2	public function via(/** @scrutinizer ignore-unused */$notifiable)
		0 ignored issues – show Unused Code introduced 2020-04-09 02:35 UTC by Report Bug Copy Issue Report The parameter `$notifiable` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
34		{
35	2	return ['mail'];
36		}
37
38		/**
39		* Get the mail representation of the notification.
40		*
41		* @param mixed $notifiable
42		* @return \Illuminate\Notifications\Messages\MailMessage
43		*/
44		public function toMail(
45		/** @scrutinizer ignore-unused */
46		$notifiable)
		0 ignored issues – show Unused Code introduced 2020-04-09 02:35 UTC by Report Bug Copy Issue Report The parameter `$notifiable` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
47		{
48		return (new MailMessage)
49		->greeting('Hello '.$this->user->full_name)
50		->line('A new '.config('app.name').' account has been created for you.')
51		->line('Your new username is: '.$this->user->username.'')
52		->line('You can click the link below to finsh setting up your account.')
53		->action('Setup Account', url(route('initialize', $this->hash)));
		0 ignored issues – show Bug introduced 2020-04-09 02:35 UTC by Report Bug Copy Issue Report It seems like `url(route('initialize', $this->hash))` targeting `url()` can also be of type `object<Illuminate\Contracts\Routing\UrlGenerator>`; however, `Illuminate\Notifications...SimpleMessage::action()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
54		}
55
56		/**
57		* Get the array representation of the notification.
58		*
59		* @param mixed $notifiable
60		* @return array
61		*/
62		public function toArray(
63		/** @scrutinizer ignore-unused */
64		$notifiable)
		0 ignored issues – show Unused Code introduced 2020-04-09 02:35 UTC by Report Bug Copy Issue Report The parameter `$notifiable` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
65		{
66		return [
67		//
68		];
69		}
70		}
71

butcherman / Tech_Bench

Push — dev5 ( 1140b1...da16e0 )

NewUserEmail::toMail() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like