bristol-su / assign-roles

app/Rules/PositionCanBeUsed.php

<?php

Missing file doc comment

namespace BristolSU\Module\AssignRoles\Rules;

use BristolSU\ControlDB\Contracts\Repositories\Role;
use BristolSU\Module\AssignRoles\Support\PositionSettingRetrieval;
use BristolSU\Support\Authentication\Contracts\Authentication;
use BristolSU\Support\Logic\Contracts\LogicRepository;
use BristolSU\Support\Logic\Facade\LogicTester;
use Illuminate\Contracts\Validation\Rule;

class PositionCanBeUsed implements Rule

Missing doc comment for class PositionCanBeUsed

{

    /**

Missing short description in doc comment

     * @var PositionSettingRetrieval
     */
    private $positionSettingRetrieval;

Private member variable "positionSettingRetrieval" must be prefixed with an underscore

    /**

Missing short description in doc comment

     * @var Role
     */
    private $roleRepository;

Private member variable "roleRepository" must be prefixed with an underscore

    /**

Missing short description in doc comment

     * @var Authentication
     */
    private $authentication;

Private member variable "authentication" must be prefixed with an underscore

    public function __construct(PositionSettingRetrieval $positionSettingRetrieval, Role $roleRepository, Authentication $authentication)

Missing doc comment for function __construct()

    {
        $this->positionSettingRetrieval = $positionSettingRetrieval;
        $this->roleRepository = $roleRepository;
        $this->authentication = $authentication;
    }

    /**

Missing short description in doc comment

Parameter $attribute should have a doc-comment as per coding-style.

Parameter $value should have a doc-comment as per coding-style.

     * @inheritDoc
     */

Missing @return tag in function comment

    public function passes($attribute, $value)
    {
        try {
            $settings = $this->positionSettingRetrieval->getSettings($this->group());

It seems like $this->group() can also be of type null; however, parameter $group of BristolSU\Module\AssignRoles\Support\PositionSettingRetrieval::getSettings() does only seem to accept BristolSU\ControlDB\Contracts\Models\Group, maybe add an additional type check?

        } catch (\Exception $e) {
            return false;
        }
        if(in_array($value, $settings['only_one_role'])) {

Expected "if (...) {\n"; found "if(...) {\n"

            $roles = $this->roleRepository->allThroughGroup($this->group());

It seems like $this->group() can also be of type null; however, parameter $group of BristolSU\ControlDB\Contracts\Repositories\Role::allThroughGroup() does only seem to accept BristolSU\ControlDB\Contracts\Models\Group, maybe add an additional type check?

            
            return $roles->filter(function(\BristolSU\ControlDB\Contracts\Models\Role $role) use ($value) {

The opening parenthesis of a multi-line function call should be the last content on the line.

Expected 1 space after FUNCTION keyword; 0 found

                return $role->positionId() === (int) $value;
            })->count() === 0;

For multi-line function calls, the closing parenthesis should be on a new line.

        }
        return true;
    }

    protected function group()

Missing doc comment for function group()

    {
        return $this->authentication->getGroup();
    }
    
    /**

Missing short description in doc comment

     * @inheritDoc
     */

Missing @return tag in function comment

    public function message()
    {
        return 'The position has already been used in another role';
    }
}