BristolSU\Module\AssignRoles\Rules\PositionCanBeUsed::passes()

Complexity

Conditions	3
Paths	3

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3.0987

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function passes($attribute, $value)
    {
        try {
            $settings = $this->positionSettingRetrieval->getSettings($this->group());

It seems like $this->group() can also be of type null; however, parameter $group of BristolSU\Module\AssignRoles\Support\PositionSettingRetrieval::getSettings() does only seem to accept BristolSU\ControlDB\Contracts\Models\Group, maybe add an additional type check?

        } catch (\Exception $e) {
            return false;
        }
        if(in_array($value, $settings['only_one_role'])) {

Expected "if (...) {\n"; found "if(...) {\n"

            $roles = $this->roleRepository->allThroughGroup($this->group());

It seems like $this->group() can also be of type null; however, parameter $group of BristolSU\ControlDB\Contracts\Repositories\Role::allThroughGroup() does only seem to accept BristolSU\ControlDB\Contracts\Models\Group, maybe add an additional type check?

            
            return $roles->filter(function(\BristolSU\ControlDB\Contracts\Models\Role $role) use ($value) {

The opening parenthesis of a multi-line function call should be the last content on the line.

Expected 1 space after FUNCTION keyword; 0 found

                return $role->positionId() === (int) $value;
            })->count() === 0;

For multi-line function calls, the closing parenthesis should be on a new line.

        }
        return true;
    }
}