View GitHub Repository assign-roles

Schedule Inspection
Subscribe

GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Passed
Push — develop ( d9ddd1...73f1fe )
by Toby
05:25
created
Status
Category
Toggle Patches
app/CompletionConditions/RequiredPositionsFilled.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -31,7 +31,7 @@
 
 block discarded – undo
31 31 
             return false;
32 32 
         }
33 33
34 
-       return count($remainingRoles) === 0;
34 
+        return count($remainingRoles) === 0;
35 35 
     }
36 36
37 37 
     public function percentage($settings, ActivityInstance $activityInstance, ModuleInstance $moduleInstance): int
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch 
@@ -36,9 +36,9 @@  discard block
 
 block discarded – undo
36 36
37 37 
     public function percentage($settings, ActivityInstance $activityInstance, ModuleInstance $moduleInstance): int
38 38 
     {
39 
-        if($activityInstance->resource_type === 'group') {
39 
+        if ($activityInstance->resource_type === 'group') {
40 40 
             $group = $activityInstance->participant();
41 
-        } else if($activityInstance->resource_type === 'role') {
41 
+        } else if ($activityInstance->resource_type === 'role') {
42 42 
             $group = $activityInstance->participant()->group();
43 43 
         } else {
44 44 
             return collect();
 
@@ -51,15 +51,15 @@  discard block
 
 block discarded – undo
51 51 
             return false;
52 52 
         }
53 53
54 
-        if(count($requiredPositions) === 0) {
54 
+        if (count($requiredPositions) === 0) {
55 55 
             return 100;
56 56 
         }
57 57
58 58 
         $filled = count($requiredPositions) - count($remainingPositions);
59 59
60 
-        $percentage = (int) round(($filled/count($requiredPositions)) * 100, 0);
60 
+        $percentage = (int) round(($filled / count($requiredPositions)) * 100, 0);
61 61
62 
-        if($percentage > 100) {
62 
+        if ($percentage > 100) {
63 63 
             return 100;
64 64 
         }
65 65 
         return $percentage;
 
@@ -67,9 +67,9 @@  discard block
 
 block discarded – undo
67 67
68 68 
     protected function rolesNeededtoFill($settings, ActivityInstance $activityInstance, ModuleInstance $moduleInstance)
69 69 
     {
70 
-        if($activityInstance->resource_type === 'group') {
70 
+        if ($activityInstance->resource_type === 'group') {
71 71 
             $group = $activityInstance->participant();
72 
-        } else if($activityInstance->resource_type === 'role') {
72 
+        } else if ($activityInstance->resource_type === 'role') {
73 73 
             $group = $activityInstance->participant()->group();
74 74 
         } else {
75 75 
             return collect();
 
@@ -78,7 +78,7 @@  discard block
 
 block discarded – undo
78 78 
         $requiredPositions = $this->getRequiredPositions($settings, $group);
79 79 
         $roles = $group->roles();
80 80 
         $logicGroupId = $moduleInstance->setting('logic_group', null);
81 
-        if($logicGroupId !== null) {
81 
+        if ($logicGroupId !== null) {
82 82 
             $logic = app(LogicRepository::class)->getById($logicGroupId);
83 83
84 84 
             $roles = $roles->filter(function(\BristolSU\ControlDB\Contracts\Models\Role $role) use ($logic) {
Please login to merge, or discard this patch.