bristol-su / assign-roles

app/CompletionConditions/RequiredPositionsFilled.php

Indentation +2 added lines, -2 removed lines

@@ -22,9 +22,9 @@
      */
     public function isComplete($settings, ActivityInstance $activityInstance, ModuleInstance $moduleInstance): bool
     {
-       $remainingRoles = $this->rolesNeededtoFill($settings, $activityInstance, $moduleInstance);
+        $remainingRoles = $this->rolesNeededtoFill($settings, $activityInstance, $moduleInstance);
        
-       return count($remainingRoles) === 0;
+        return count($remainingRoles) === 0;
     }
     
     public function percentage($settings, ActivityInstance $activityInstance, ModuleInstance $moduleInstance): int

Spacing +8 added lines, -8 removed lines

@@ -31,9 +31,9 @@ 
     
     public function percentage($settings, ActivityInstance $activityInstance, ModuleInstance $moduleInstance): int
     {
-        if($activityInstance->resource_type === 'group') {
+        if ($activityInstance->resource_type === 'group') {
             $group = $activityInstance->participant();
-        } else if($activityInstance->resource_type === 'role') {
+        } else if ($activityInstance->resource_type === 'role') {
             $group = $activityInstance->participant()->group();
         } else {
             return collect();
@@ -42,15 +42,15 @@ 
         $requiredPositions = $this->getRequiredPositions($settings, $group);
         $remainingPositions = $this->rolesNeededtoFill($settings, $activityInstance, $moduleInstance);
         
-        if(count($requiredPositions) === 0) {
+        if (count($requiredPositions) === 0) {
             return 100;
         }
         
         $filled = count($requiredPositions) - count($remainingPositions);
         
-        $percentage = (int) round(($filled/count($requiredPositions)) * 100, 0);
+        $percentage = (int) round(($filled / count($requiredPositions)) * 100, 0);
 
-        if($percentage > 100) {
+        if ($percentage > 100) {
             return 100;
         }
         return $percentage;
@@ -58,9 +58,9 @@ 
 
     protected function rolesNeededtoFill($settings, ActivityInstance $activityInstance, ModuleInstance $moduleInstance)
     {
-        if($activityInstance->resource_type === 'group') {
+        if ($activityInstance->resource_type === 'group') {
             $group = $activityInstance->participant();
-        } else if($activityInstance->resource_type === 'role') {
+        } else if ($activityInstance->resource_type === 'role') {
             $group = $activityInstance->participant()->group();
         } else {
             return collect();
@@ -69,7 +69,7 @@ 
         $requiredPositions = $this->getRequiredPositions($settings, $group);
         $roles = $group->roles();
         $logicGroupId = $moduleInstance->setting('logic_group', null);
-        if($logicGroupId !== null) {
+        if ($logicGroupId !== null) {
             $logic = app(LogicRepository::class)->getById($logicGroupId);
             
             $roles = $roles->filter(function(\BristolSU\ControlDB\Contracts\Models\Role $role) use ($logic) {

app/ModuleServiceProvider.php

Spacing +1 added lines, -1 removed lines

@@ -98,7 +98,7 @@
 
     public function baseDirectory()
     {
-        return __DIR__ . '/..';
+        return __DIR__.'/..';
     }
 
     public function boot()

app/Rules/PositionCanBeUsed.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
         } catch (\Exception $e) {
             return false;
         }
-        if(in_array($value, $settings['only_one_role'])) {
+        if (in_array($value, $settings['only_one_role'])) {
             $roles = $this->roleRepository->allThroughGroup($this->group());
             return $roles->filter(function(\BristolSU\ControlDB\Contracts\Models\Role $role) use ($value) {
                 return $role->positionId() === (int) $value;

app/Rules/RoleHasSpaceToAssign.php

Spacing +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
         } catch (\Exception $e) {
             return false;
         }
-        if(in_array($value, $settings['only_one_user'])) {
+        if (in_array($value, $settings['only_one_user'])) {
             return $this->roleRepository->getById($value)->users()->count() === 0;
         }
         return true;

app/Http/Controllers/Controller.php

Spacing +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
     public function authorize($ability, $arguments = [])
     {
         return $this->baseAuthorize(
-            'assign-roles.' . $ability,
+            'assign-roles.'.$ability,
             $arguments
         );
     }

app/Http/Requests/ParticipantApi/RoleController/StoreRequest.php

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
     public function rules()
     {
         return [
-            'position_id' => ['required', app(PositionIsAllowed::class),  app(PositionCanBeUsed::class)],
+            'position_id' => ['required', app(PositionIsAllowed::class), app(PositionCanBeUsed::class)],
             'role_name' => ['required', 'string', 'max:255', 'min:3'],
             'email' => ['nullable', 'sometimes', 'email']
         ];

app/Http/Controllers/ParticipantApi/RoleController.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
         $roles = $role->allThroughGroup(
             $authentication->getGroup()
         );
-        if(settings('logic_group', null) !== null) {
+        if (settings('logic_group', null) !== null) {
             $logic = $logicRepository->getById(settings('logic_group'));
             
             $roles = $roles->filter(function(\BristolSU\ControlDB\Contracts\Models\Role $role) use ($logic) {

app/Support/PositionSettingRetrieval.php

Spacing +3 added lines, -3 removed lines

@@ -34,7 +34,7 @@ 
 
     public function getSettings(Group $group)
     {
-        if(Cache::has($this->getCacheKey($group))) {
+        if (Cache::has($this->getCacheKey($group))) {
             return Cache::get($this->getCacheKey($group));
         }
         $settings = settings('position_settings', []);
@@ -53,7 +53,7 @@ 
             return false;
         }
         $logic = $this->logicRepository->getById($setting['logic_id']);
-        $groups = collect($this->logicAudience->groupAudience($logic))->map(function (Group $group) {
+        $groups = collect($this->logicAudience->groupAudience($logic))->map(function(Group $group) {
             return $group->id();
         });
         return $groups->contains($group->id());
@@ -61,7 +61,7 @@ 
 
     protected function getCacheKey(Group $group)
     {
-        return PositionSettingRetrieval::class . '.' . $group->id();
+        return PositionSettingRetrieval::class.'.'.$group->id();
     }
     
     public function parse($setting)

app/Support/RequiredSettingRetrieval.php

Spacing +3 added lines, -3 removed lines

@@ -34,7 +34,7 @@ 
 
     public function getSettings(Group $group, array $settings)
     {
-        if(Cache::has($this->getCacheKey($group))) {
+        if (Cache::has($this->getCacheKey($group))) {
             return Cache::get($this->getCacheKey($group));
         }
         foreach ($settings as $setting) {
@@ -48,7 +48,7 @@ 
 
     protected function getCacheKey(Group $group)
     {
-        return RequiredSettingRetrieval::class . '.' . $group->id();
+        return RequiredSettingRetrieval::class.'.'.$group->id();
     }
     
     protected function groupIsForSetting(Group $group, array $setting): bool
@@ -57,7 +57,7 @@ 
             return false;
         }
         $logic = $this->logicRepository->getById($setting['logic_id']);
-        $groups = collect($this->logicAudience->groupAudience($logic))->map(function (Group $group) {
+        $groups = collect($this->logicAudience->groupAudience($logic))->map(function(Group $group) {
             return $group->id();
         });
         return $groups->contains($group->id());