bristol-su / assign-roles

app/CompletionConditions/RequiredPositionsFilled.php

Indentation +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
             return false;
         }
        
-       return count($remainingPositions) === 0;
+        return count($remainingPositions) === 0;
     }
     
     public function percentage($settings, ActivityInstance $activityInstance, ModuleInstance $moduleInstance): int

Spacing +6 added lines, -6 removed lines

@@ -59,15 +59,15 @@ 
             return false;
         }
         
-        if(count($requiredPositions) === 0) {
+        if (count($requiredPositions) === 0) {
             return 100;
         }
         
         $filled = count($requiredPositions) - count($remainingPositions);
         
-        $percentage = (int) round(($filled/count($requiredPositions)) * 100, 0);
+        $percentage = (int) round(($filled / count($requiredPositions)) * 100, 0);
 
-        if($percentage > 100) {
+        if ($percentage > 100) {
             return 100;
         }
         return $percentage;
@@ -152,7 +152,7 @@ 
      */
     private function getGroup(ActivityInstance $activityInstance)
     {
-        if($activityInstance->resource_type === 'group') {
+        if ($activityInstance->resource_type === 'group') {
             return $activityInstance->participant();
         }
         return $activityInstance->participant()->group();
@@ -166,7 +166,7 @@ 
     private function rolesThroughGroup(Group $group, ModuleInstance $moduleInstance)
     {
         $roles = $group->roles();
-        if($this->logicGroupId($moduleInstance) !== null) {
+        if ($this->logicGroupId($moduleInstance) !== null) {
             $logicGroup = app(LogicRepository::class)->getById($this->logicGroupId($moduleInstance));
             return $roles->filter(function(\BristolSU\ControlDB\Contracts\Models\Role $role) use ($moduleInstance, $logicGroup) {
                 return LogicTester::evaluate($logicGroup, null, $role->group(), $role);
@@ -178,7 +178,7 @@ 
     private function logicGroupId(ModuleInstance $moduleInstance)
     {
         $id = $moduleInstance->setting('logic_group', null);
-        if($id === null) {
+        if ($id === null) {
             return null;
         }
         return (int) $id;

app/Support/RequiredSettingRetrieval.php

Spacing +3 added lines, -3 removed lines

@@ -35,10 +35,10 @@ 
 
     public function getSettings(Group $group, array $settings, ModuleInstance $moduleInstance)
     {
-        if(Cache::has($this->getCacheKey($group, $moduleInstance))) {
+        if (Cache::has($this->getCacheKey($group, $moduleInstance))) {
             return Cache::get($this->getCacheKey($group, $moduleInstance));
         }
-        foreach ((array_key_exists('required', $settings)?$settings['required']:[]) as $setting) {
+        foreach ((array_key_exists('required', $settings) ? $settings['required'] : []) as $setting) {
             if ($this->groupIsForSetting($group, $setting)) {
                 Cache::put($this->getCacheKey($group, $moduleInstance), $setting['required'], 7200);
                 return $setting['required'];
@@ -49,7 +49,7 @@ 
 
     protected function getCacheKey(Group $group, ModuleInstance $moduleInstance)
     {
-        return RequiredSettingRetrieval::class . '.' . $moduleInstance->id() . '.' . $group->id();
+        return RequiredSettingRetrieval::class.'.'.$moduleInstance->id().'.'.$group->id();
     }
     
     protected function groupIsForSetting(Group $group, array $setting): bool

app/Support/PositionSettingRetrieval.php

Spacing +3 added lines, -3 removed lines

@@ -65,10 +65,10 @@
     protected function getCacheKey(Group $group)
     {
         $moduleInstance = app(ModuleInstance::class);
-        if($moduleInstance->exists) {
-            throw new \Exception('Module instance was used in ' . static::class . ' but was not bound to the container');
+        if ($moduleInstance->exists) {
+            throw new \Exception('Module instance was used in '.static::class.' but was not bound to the container');
         }
-        return PositionSettingRetrieval::class . '.' . $moduleInstance->id() . '.' . $group->id();
+        return PositionSettingRetrieval::class.'.'.$moduleInstance->id().'.'.$group->id();
     }
     
     public function parse($setting)