Inspection of "Update change log." - brightnucleus/shortcodes - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 85fe75...3c67a7 )

by Alain

created 2016-03-08 06:34 UTC

Status

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 /**
- * Shortcode Attributes Parser Base Implementation.
- *
- * @package   BrightNucleus\Shortcode
- * @author    Alain Schlesser <[email protected]>
- * @license   GPL-2.0+
- * @link      http://www.brightnucleus.com/
- * @copyright 2015-2016 Alain Schlesser, Bright Nucleus
- */
+	 * Shortcode Attributes Parser Base Implementation.
+	 *
+	 * @package   BrightNucleus\Shortcode
+	 * @author    Alain Schlesser <[email protected]>
+	 * @license   GPL-2.0+
+	 * @link      http://www.brightnucleus.com/
+	 * @copyright 2015-2016 Alain Schlesser, Bright Nucleus
+	 */
 
 namespace BrightNucleus\Shortcode;
 

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -78,7 +78,7 @@  discard block
 block discarded – undo
 		$atts_config = $this->getConfigKey( 'atts' );
 		array_walk( $atts_config,
 			function ( $att_properties, $att_label ) use ( &$atts ) {
-				$atts[ $att_label ] = $att_properties['default'];
+				$atts[ $att_label ] = $att_properties[ 'default' ];
 			}
 		);
 
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
 		array_walk( $atts_config,
 			function ( $att_properties, $att_label ) use ( &$atts ) {
 				if ( array_key_exists( $att_label, $atts ) ) {
-					$validate_function  = $att_properties['validate'];
+					$validate_function  = $att_properties[ 'validate' ];
 					$atts[ $att_label ] = $validate_function( $atts[ $att_label ] );
 				}
 			}

Please login to merge, or discard this patch.

src/ShortcodeUIInterface.php 1 patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 /**
- * ShortcodeUIInterface Interface.
- *
- * @package   BrightNucleus\Shortcode
- * @author    Alain Schlesser <[email protected]>
- * @license   GPL-2.0+
- * @link      http://www.brightnucleus.com/
- * @copyright 2015-2016 Alain Schlesser, Bright Nucleus
- */
+	 * ShortcodeUIInterface Interface.
+	 *
+	 * @package   BrightNucleus\Shortcode
+	 * @author    Alain Schlesser <[email protected]>
+	 * @license   GPL-2.0+
+	 * @link      http://www.brightnucleus.com/
+	 * @copyright 2015-2016 Alain Schlesser, Bright Nucleus
+	 */
 
 namespace BrightNucleus\Shortcode;
 

Please login to merge, or discard this patch.

src/ShortcodeManagerInterface.php 1 patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 /**
- * Shortcode Manager Interface.
- *
- * @package   BrightNucleus\Shortcode
- * @author    Alain Schlesser <[email protected]>
- * @license   GPL-2.0+
- * @link      http://www.brightnucleus.com/
- * @copyright 2015-2016 Alain Schlesser, Bright Nucleus
- */
+	 * Shortcode Manager Interface.
+	 *
+	 * @package   BrightNucleus\Shortcode
+	 * @author    Alain Schlesser <[email protected]>
+	 * @license   GPL-2.0+
+	 * @link      http://www.brightnucleus.com/
+	 * @copyright 2015-2016 Alain Schlesser, Bright Nucleus
+	 */
 
 namespace BrightNucleus\Shortcode;
 

Please login to merge, or discard this patch.

src/ShortcodeTemplateLoader.php 1 patch

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -1,18 +1,18 @@
 block discarded – undo
 <?php
 /**
- * Templated Shortcode Implementation.
- *
- * This version of the shortcode uses Gamajo/TemplateLoader to let you override
- * the shortcode views from your theme.
- *
- * @see       https://github.com/gamajo/TemplateLoader
- *
- * @package   BrightNucleus\Shortcode
- * @author    Alain Schlesser <[email protected]>
- * @license   GPL-2.0+
- * @link      http://www.brightnucleus.com/
- * @copyright 2015-2016 Alain Schlesser, Bright Nucleus
- */
+	 * Templated Shortcode Implementation.
+	 *
+	 * This version of the shortcode uses Gamajo/TemplateLoader to let you override
+	 * the shortcode views from your theme.
+	 *
+	 * @see       https://github.com/gamajo/TemplateLoader
+	 *
+	 * @package   BrightNucleus\Shortcode
+	 * @author    Alain Schlesser <[email protected]>
+	 * @license   GPL-2.0+
+	 * @link      http://www.brightnucleus.com/
+	 * @copyright 2015-2016 Alain Schlesser, Bright Nucleus
+	 */
 
 namespace BrightNucleus\Shortcode;
 

Please login to merge, or discard this patch.

src/CheckNeedTrait.php 1 patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 /**
- * Check Need Trait.
- *
- * @package   BrightNucleus\Shortcode
- * @author    Alain Schlesser <[email protected]>
- * @license   GPL-2.0+
- * @link      http://www.brightnucleus.com/
- * @copyright 2015-2016 Alain Schlesser, Bright Nucleus
- */
+	 * Check Need Trait.
+	 *
+	 * @package   BrightNucleus\Shortcode
+	 * @author    Alain Schlesser <[email protected]>
+	 * @license   GPL-2.0+
+	 * @link      http://www.brightnucleus.com/
+	 * @copyright 2015-2016 Alain Schlesser, Bright Nucleus
+	 */
 
 namespace BrightNucleus\Shortcode;
 

Please login to merge, or discard this patch.

src/Shortcode.php 1 patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 /**
- * Shortcode Base Implementation.
- *
- * @package   BrightNucleus\Shortcode
- * @author    Alain Schlesser <[email protected]>
- * @license   GPL-2.0+
- * @link      http://www.brightnucleus.com/
- * @copyright 2015-2016 Alain Schlesser, Bright Nucleus
- */
+	 * Shortcode Base Implementation.
+	 *
+	 * @package   BrightNucleus\Shortcode
+	 * @author    Alain Schlesser <[email protected]>
+	 * @license   GPL-2.0+
+	 * @link      http://www.brightnucleus.com/
+	 * @copyright 2015-2016 Alain Schlesser, Bright Nucleus
+	 */
 
 namespace BrightNucleus\Shortcode;
 

Please login to merge, or discard this patch.

src/ShortcodeInterface.php 1 patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 /**
- * Shortcode Interface.
- *
- * @package   BrightNucleus\Shortcode
- * @author    Alain Schlesser <[email protected]>
- * @license   GPL-2.0+
- * @link      http://www.brightnucleus.com/
- * @copyright 2015-2016 Alain Schlesser, Bright Nucleus
- */
+	 * Shortcode Interface.
+	 *
+	 * @package   BrightNucleus\Shortcode
+	 * @author    Alain Schlesser <[email protected]>
+	 * @license   GPL-2.0+
+	 * @link      http://www.brightnucleus.com/
+	 * @copyright 2015-2016 Alain Schlesser, Bright Nucleus
+	 */
 
 namespace BrightNucleus\Shortcode;
 

Please login to merge, or discard this patch.

src/ShortcodeManager.php 2 patches

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 /**
- * Shortcode Manager.
- *
- * @package   BrightNucleus\Shortcode
- * @author    Alain Schlesser <[email protected]>
- * @license   GPL-2.0+
- * @link      http://www.brightnucleus.com/
- * @copyright 2015-2016 Alain Schlesser, Bright Nucleus
- */
+	 * Shortcode Manager.
+	 *
+	 * @package   BrightNucleus\Shortcode
+	 * @author    Alain Schlesser <[email protected]>
+	 * @license   GPL-2.0+
+	 * @link      http://www.brightnucleus.com/
+	 * @copyright 2015-2016 Alain Schlesser, Bright Nucleus
+	 */
 
 namespace BrightNucleus\Shortcode;
 

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -123,7 +123,7 @@  discard block
 block discarded – undo
 		$atts_parser        = new $shortcode_atts_parser(
 			$this->config->getSubConfig( $tag )
 		);
-		$this->shortcodes[] = new $shortcode_class(
+		$this->shortcodes[ ] = new $shortcode_class(
 			$tag,
 			$this->config->getSubConfig( $tag ),
 			$atts_parser,
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
 	protected function init_shortcode_ui( $tag ) {
 		$shortcode_ui_class = $this->get_shortcode_ui_class( $tag );
 
-		$this->shortcode_uis[] = new $shortcode_ui_class(
+		$this->shortcode_uis[ ] = new $shortcode_ui_class(
 			$tag,
 			$this->config->getSubConfig( $tag, self::KEY_UI ),
 			$this->dependencies
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
 	 */
 	public function register( $context = null ) {
 		$context                  = $this->validate_context( $context );
-		$context['page_template'] = $this->get_page_template();
+		$context[ 'page_template' ] = $this->get_page_template();
 
 		array_walk( $this->shortcodes,
 			function ( $shortcode ) use ( $context ) {

Please login to merge, or discard this patch.

src/TemplatedShortcode.php 1 patch

Indentation +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -1,16 +1,16 @@
 block discarded – undo
 <?php
 /**
- * Templated Shortcode Implementation.
- *
- * This version of the shortcode uses Gamajo/TemplateLoader to let you override
- * the shortcode views from your theme.
- *
- * @package   BrightNucleus\Shortcode
- * @author    Alain Schlesser <[email protected]>
- * @license   GPL-2.0+
- * @link      http://www.brightnucleus.com/
- * @copyright 2015-2016 Alain Schlesser, Bright Nucleus
- */
+	 * Templated Shortcode Implementation.
+	 *
+	 * This version of the shortcode uses Gamajo/TemplateLoader to let you override
+	 * the shortcode views from your theme.
+	 *
+	 * @package   BrightNucleus\Shortcode
+	 * @author    Alain Schlesser <[email protected]>
+	 * @license   GPL-2.0+
+	 * @link      http://www.brightnucleus.com/
+	 * @copyright 2015-2016 Alain Schlesser, Bright Nucleus
+	 */
 
 namespace BrightNucleus\Shortcode;
 

Please login to merge, or discard this patch.

		@@ -78,7 +78,7 @@ discard block
		block discarded – undo
78	78	$atts_config = $this->getConfigKey( 'atts' );
79	79	array_walk( $atts_config,
80	80	function ( $att_properties, $att_label ) use ( &$atts ) {
81		- $atts[ $att_label ] = $att_properties['default'];
	81	+ $atts[ $att_label ] = $att_properties[ 'default' ];
82	82	}
83	83	);
84	84
		@@ -104,7 +104,7 @@ discard block
		block discarded – undo
104	104	array_walk( $atts_config,
105	105	function ( $att_properties, $att_label ) use ( &$atts ) {
106	106	if ( array_key_exists( $att_label, $atts ) ) {
107		- $validate_function = $att_properties['validate'];
	107	+ $validate_function = $att_properties[ 'validate' ];
108	108	$atts[ $att_label ] = $validate_function( $atts[ $att_label ] );
109	109	}
110	110	}

		@@ -123,7 +123,7 @@ discard block
		block discarded – undo
123	123	$atts_parser = new $shortcode_atts_parser(
124	124	$this->config->getSubConfig( $tag )
125	125	);
126		- $this->shortcodes[] = new $shortcode_class(
	126	+ $this->shortcodes[ ] = new $shortcode_class(
127	127	$tag,
128	128	$this->config->getSubConfig( $tag ),
129	129	$atts_parser,
		@@ -176,7 +176,7 @@ discard block
		block discarded – undo
176	176	protected function init_shortcode_ui( $tag ) {
177	177	$shortcode_ui_class = $this->get_shortcode_ui_class( $tag );
178	178
179		- $this->shortcode_uis[] = new $shortcode_ui_class(
	179	+ $this->shortcode_uis[ ] = new $shortcode_ui_class(
180	180	$tag,
181	181	$this->config->getSubConfig( $tag, self::KEY_UI ),
182	182	$this->dependencies
		@@ -208,7 +208,7 @@ discard block
		block discarded – undo
208	208	*/
209	209	public function register( $context = null ) {
210	210	$context = $this->validate_context( $context );
211		- $context['page_template'] = $this->get_page_template();
	211	+ $context[ 'page_template' ] = $this->get_page_template();
212	212
213	213	array_walk( $this->shortcodes,
214	214	function ( $shortcode ) use ( $context ) {

		@@ -1,13 +1,13 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * Shortcode Attributes Parser Base Implementation.
4		- *
5		- * @package BrightNucleus\Shortcode
6		- * @author Alain Schlesser <[email protected]>
7		- * @license GPL-2.0+
8		- * @link http://www.brightnucleus.com/
9		- * @copyright 2015-2016 Alain Schlesser, Bright Nucleus
10		- */
	3	+ * Shortcode Attributes Parser Base Implementation.
	4	+ *
	5	+ * @package BrightNucleus\Shortcode
	6	+ * @author Alain Schlesser <[email protected]>
	7	+ * @license GPL-2.0+
	8	+ * @link http://www.brightnucleus.com/
	9	+ * @copyright 2015-2016 Alain Schlesser, Bright Nucleus
	10	+ */
11	11
12	12	namespace BrightNucleus\Shortcode;
13	13

		@@ -1,18 +1,18 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * Templated Shortcode Implementation.
4		- *
5		- * This version of the shortcode uses Gamajo/TemplateLoader to let you override
6		- * the shortcode views from your theme.
7		- *
8		- * @see https://github.com/gamajo/TemplateLoader
9		- *
10		- * @package BrightNucleus\Shortcode
11		- * @author Alain Schlesser <[email protected]>
12		- * @license GPL-2.0+
13		- * @link http://www.brightnucleus.com/
14		- * @copyright 2015-2016 Alain Schlesser, Bright Nucleus
15		- */
	3	+ * Templated Shortcode Implementation.
	4	+ *
	5	+ * This version of the shortcode uses Gamajo/TemplateLoader to let you override
	6	+ * the shortcode views from your theme.
	7	+ *
	8	+ * @see https://github.com/gamajo/TemplateLoader
	9	+ *
	10	+ * @package BrightNucleus\Shortcode
	11	+ * @author Alain Schlesser <[email protected]>
	12	+ * @license GPL-2.0+
	13	+ * @link http://www.brightnucleus.com/
	14	+ * @copyright 2015-2016 Alain Schlesser, Bright Nucleus
	15	+ */
16	16
17	17	namespace BrightNucleus\Shortcode;
18	18

		@@ -1,16 +1,16 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * Templated Shortcode Implementation.
4		- *
5		- * This version of the shortcode uses Gamajo/TemplateLoader to let you override
6		- * the shortcode views from your theme.
7		- *
8		- * @package BrightNucleus\Shortcode
9		- * @author Alain Schlesser <[email protected]>
10		- * @license GPL-2.0+
11		- * @link http://www.brightnucleus.com/
12		- * @copyright 2015-2016 Alain Schlesser, Bright Nucleus
13		- */
	3	+ * Templated Shortcode Implementation.
	4	+ *
	5	+ * This version of the shortcode uses Gamajo/TemplateLoader to let you override
	6	+ * the shortcode views from your theme.
	7	+ *
	8	+ * @package BrightNucleus\Shortcode
	9	+ * @author Alain Schlesser <[email protected]>
	10	+ * @license GPL-2.0+
	11	+ * @link http://www.brightnucleus.com/
	12	+ * @copyright 2015-2016 Alain Schlesser, Bright Nucleus
	13	+ */
14	14
15	15	namespace BrightNucleus\Shortcode;
16	16

brightnucleus / shortcodes

Push — master ( 85fe75...3c67a7 )

Status

Category

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +11 added lines, -11 removed lines patch added patch discarded remove patch