brightnucleus / phpfeature

src/SemanticVersion.php

Doc Comments +2 added lines, -2 removed lines

@@ -187,7 +187,7 @@ 
 	 *
 	 * @since 0.1.0
 	 *
-	 * @return int The patch version that is used. '' if not defined.
+	 * @return string The patch version that is used. '' if not defined.
 	 */
 	public function get_pre_release() {
 		return (string) $this->get_component( 'pre-release' ) ?: '';
@@ -198,7 +198,7 @@ 
 	 *
 	 * @since 0.1.0
 	 *
-	 * @return int The build metadata for the version that is used. '' if not
+	 * @return string The build metadata for the version that is used. '' if not
 	 *             defined.
 	 */
 	public function get_build() {

Indentation +8 added lines, -8 removed lines

@@ -1,13 +1,13 @@
 <?php
 /**
- * SemanticVersion Class
- *
- * @package   phpfeature
- * @author    Alain Schlesser <alain.schlesser@gmail.com>
- * @license   GPL-2.0+
- * @link      http://www.brightnucleus.com/
- * @copyright 2016 Alain Schlesser, Bright Nucleus
- */
+	 * SemanticVersion Class
+	 *
+	 * @package   phpfeature
+	 * @author    Alain Schlesser <alain.schlesser@gmail.com>
+	 * @license   GPL-2.0+
+	 * @link      http://www.brightnucleus.com/
+	 * @copyright 2016 Alain Schlesser, Bright Nucleus
+	 */
 
 /**
  * Class SemanticVersion

Spacing +30 added lines, -30 removed lines

@@ -58,13 +58,13 @@ 
 	 *                             throwing an exception.
 	 * @throws RuntimeException When the version fails to validate.
 	 */
-	public function __construct( $version = null, $partial = false ) {
+	public function __construct($version = null, $partial = false) {
 
-		if ( ! $version ) {
+		if ( ! $version) {
 			$version = '0.0.0';
 		}
 
-		$version = $this->validate( $version, $partial );
+		$version = $this->validate($version, $partial);
 
 		$this->version = $version;
 	}
@@ -81,33 +81,33 @@ 
 	 * @return string
 	 * @throws RuntimeException When the version fails to validate.
 	 */
-	protected function validate( $version, $partial = false ) {
+	protected function validate($version, $partial = false) {
 
-		$version = trim( $version );
+		$version = trim($version);
 		$pattern = self::VERSION_PATTERN;
 
 		$components = array();
-		$result     = preg_match( $pattern, $version, $components );
+		$result     = preg_match($pattern, $version, $components);
 
-		if ( ! $result ) {
-			throw new RuntimeException( sprintf(
+		if ( ! $result) {
+			throw new RuntimeException(sprintf(
 				'Failed to validate version "%1$s".',
 				(string) $version
-			) );
+			));
 		}
 
-		if ( ! $partial && ( ! isset( $components[2] ) || ! isset( $components[3] ) ) ) {
-			throw new RuntimeException( sprintf(
+		if ( ! $partial && ( ! isset($components[2]) || ! isset($components[3]))) {
+			throw new RuntimeException(sprintf(
 				'Could not accept partial version "%1$s", requested full versions only.',
 				(string) $version
-			) );
+			));
 		}
 
-		$this->set_component( 'major', isset( $components[1] ) ? (int) $components[1] : 0 );
-		$this->set_component( 'minor', isset( $components[2] ) ? (int) $components[2] : 0 );
-		$this->set_component( 'patch', isset( $components[3] ) ? (int) $components[3] : 0 );
-		$this->set_component( 'pre-release', isset( $components[4] ) ? (string) $components[4] : '' );
-		$this->set_component( 'build', isset( $components[5] ) ? (string) $components[5] : '' );
+		$this->set_component('major', isset($components[1]) ? (int) $components[1] : 0);
+		$this->set_component('minor', isset($components[2]) ? (int) $components[2] : 0);
+		$this->set_component('patch', isset($components[3]) ? (int) $components[3] : 0);
+		$this->set_component('pre-release', isset($components[4]) ? (string) $components[4] : '');
+		$this->set_component('build', isset($components[5]) ? (string) $components[5] : '');
 
 		$version = $this->get_version_from_components();
 
@@ -122,7 +122,7 @@ 
 	 * @return string The version that is used. '0.0.0' if not defined.
 	 */
 	public function get_version() {
-		return (string) isset( $this->version ) ? $this->version : '0.0.0';
+		return (string) isset($this->version) ? $this->version : '0.0.0';
 	}
 
 	/**
@@ -134,8 +134,8 @@ 
 	 */
 	protected function get_version_from_components() {
 
-		$pre_release = $this->get_pre_release() ? '-' . $this->get_pre_release() : '';
-		$build       = $this->get_build() ? '+' . $this->get_build() : '';
+		$pre_release = $this->get_pre_release() ? '-'.$this->get_pre_release() : '';
+		$build       = $this->get_build() ? '+'.$this->get_build() : '';
 
 		$version = sprintf(
 			'%1$s.%2$s.%3$s%4$s%5$s',
@@ -157,7 +157,7 @@ 
 	 * @return int The major version that is used. 0 if not defined.
 	 */
 	public function get_major() {
-		return (int) $this->get_component( 'major' ) ?: 0;
+		return (int) $this->get_component('major') ?: 0;
 	}
 
 	/**
@@ -168,7 +168,7 @@ 
 	 * @return int The minor version that is used. 0 if not defined.
 	 */
 	public function get_minor() {
-		return (int) $this->get_component( 'minor' ) ?: 0;
+		return (int) $this->get_component('minor') ?: 0;
 	}
 
 	/**
@@ -179,7 +179,7 @@ 
 	 * @return int The patch version that is used. 0 if not defined.
 	 */
 	public function get_patch() {
-		return (int) $this->get_component( 'patch' ) ?: 0;
+		return (int) $this->get_component('patch') ?: 0;
 	}
 
 	/**
@@ -190,7 +190,7 @@ 
 	 * @return int The patch version that is used. '' if not defined.
 	 */
 	public function get_pre_release() {
-		return (string) $this->get_component( 'pre-release' ) ?: '';
+		return (string) $this->get_component('pre-release') ?: '';
 	}
 
 	/**
@@ -202,7 +202,7 @@ 
 	 *             defined.
 	 */
 	public function get_build() {
-		return (string) $this->get_component( 'build' ) ?: '';
+		return (string) $this->get_component('build') ?: '';
 	}
 
 	/**
@@ -214,9 +214,9 @@ 
 	 *                      'major', 'minor', 'patch'
 	 * @return int The requested version component. null if not defined.
 	 */
-	protected function get_component( $level ) {
-		return array_key_exists( $level, $this->components )
-			? $this->components[ $level ]
+	protected function get_component($level) {
+		return array_key_exists($level, $this->components)
+			? $this->components[$level]
 			: null;
 	}
 
@@ -229,8 +229,8 @@ 
 	 *                        'major', 'minor', 'patch'
 	 * @param int    $version What version to set that component to.
 	 */
-	protected function set_component( $level, $version ) {
-		$this->components[ $level ] = $version;
+	protected function set_component($level, $version) {
+		$this->components[$level] = $version;
 	}
 
 	/**

src/Config.php

Indentation +8 added lines, -8 removed lines

@@ -1,13 +1,13 @@
 <?php
 /**
- * Config Class.
- *
- * @package   phpfeature
- * @author    Alain Schlesser <alain.schlesser@gmail.com>
- * @license   GPL-2.0+
- * @link      http://www.brightnucleus.com/
- * @copyright 2016 Alain Schlesser, Bright Nucleus
- */
+	 * Config Class.
+	 *
+	 * @package   phpfeature
+	 * @author    Alain Schlesser <alain.schlesser@gmail.com>
+	 * @license   GPL-2.0+
+	 * @link      http://www.brightnucleus.com/
+	 * @copyright 2016 Alain Schlesser, Bright Nucleus
+	 */
 
 /**
  * Config loader used to load config PHP files as objects.

Spacing +11 added lines, -11 removed lines

@@ -25,9 +25,9 @@ 
 	 *
 	 * @param  array $config Array with settings.
 	 */
-	public function __construct( array $config ) {
+	public function __construct(array $config) {
 		// Make sure the config entries can be accessed as properties.
-		parent::__construct( $config, ArrayObject::ARRAY_AS_PROPS );
+		parent::__construct($config, ArrayObject::ARRAY_AS_PROPS);
 	}
 
 	/**
@@ -42,12 +42,12 @@ 
 	 * @return mixed
 	 * @throws BadMethodCallException
 	 */
-	public function __call( $function, $arguments ) {
-		if ( ! is_callable( $function ) || substr( $function, 0, 6 ) !== 'array_' ) {
-			throw new BadMethodCallException( __CLASS__ . '->' . $function );
+	public function __call($function, $arguments) {
+		if ( ! is_callable($function) || substr($function, 0, 6) !== 'array_') {
+			throw new BadMethodCallException(__CLASS__.'->'.$function);
 		}
 
-		return call_user_func_array( $function, array_merge( array( $this->getArrayCopy() ), $arguments ) );
+		return call_user_func_array($function, array_merge(array($this->getArrayCopy()), $arguments));
 	}
 
 	/**
@@ -58,8 +58,8 @@ 
 	 * @param string $key The key to check the existence for.
 	 * @return bool
 	 */
-	public function has_key( $key ) {
-		return array_key_exists( $key, (array) $this );
+	public function has_key($key) {
+		return array_key_exists($key, (array) $this);
 	}
 
 	/**
@@ -70,8 +70,8 @@ 
 	 * @param string $key The key to get the value for.
 	 * @return mixed
 	 */
-	public function get_key( $key ) {
-		return $this[ $key ];
+	public function get_key($key) {
+		return $this[$key];
 	}
 
 	/**
@@ -81,6 +81,6 @@ 
 	 * @return mixed
 	 */
 	public function get_keys() {
-		return array_keys( (array) $this );
+		return array_keys((array) $this);
 	}
 }

src/ConfigInterface.php

Indentation +8 added lines, -8 removed lines

@@ -1,13 +1,13 @@
 <?php
 /**
- * ConfigInterface Interface.
- *
- * @package   phpfeature
- * @author    Alain Schlesser <alain.schlesser@gmail.com>
- * @license   GPL-2.0+
- * @link      http://www.brightnucleus.com/
- * @copyright 2016 Alain Schlesser, Bright Nucleus
- */
+	 * ConfigInterface Interface.
+	 *
+	 * @package   phpfeature
+	 * @author    Alain Schlesser <alain.schlesser@gmail.com>
+	 * @license   GPL-2.0+
+	 * @link      http://www.brightnucleus.com/
+	 * @copyright 2016 Alain Schlesser, Bright Nucleus
+	 */
 
 /**
  * Interface ConfigInterface

Spacing +2 added lines, -2 removed lines

@@ -40,7 +40,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function has_key( $key );
+	public function has_key($key);
 
 	/**
 	 * Get the value of a specific key.
@@ -51,7 +51,7 @@ 
 	 *
 	 * @return mixed
 	 */
-	public function get_key( $key );
+	public function get_key($key);
 
 	/**
 	 * Get the an array with all the keys

src/FeatureInterface.php

Indentation +8 added lines, -8 removed lines

@@ -1,13 +1,13 @@
 <?php
 /**
- * FeatureInterface Interface
- *
- * @package   phpfeature
- * @author    Alain Schlesser <alain.schlesser@gmail.com>
- * @license   GPL-2.0+
- * @link      http://www.brightnucleus.com/
- * @copyright 2016 Alain Schlesser, Bright Nucleus
- */
+	 * FeatureInterface Interface
+	 *
+	 * @package   phpfeature
+	 * @author    Alain Schlesser <alain.schlesser@gmail.com>
+	 * @license   GPL-2.0+
+	 * @link      http://www.brightnucleus.com/
+	 * @copyright 2016 Alain Schlesser, Bright Nucleus
+	 */
 
 /**
  * Interface FeatureInterface

Spacing +2 added lines, -2 removed lines

@@ -30,7 +30,7 @@ 
 	 * @param string|array $features What features to check the support of.
 	 * @return bool
 	 */
-	public function is_supported( $features );
+	public function is_supported($features);
 
 	/**
 	 * Get the minimum required version that supports all of the requested
@@ -46,5 +46,5 @@ 
 	 * @param string|array $features What features to check the support of.
 	 * @return SemanticVersion|bool
 	 */
-	public function get_minimum_required( $features );
+	public function get_minimum_required($features);
 }
\ No newline at end of file

src/PHPFeature.php

Indentation +8 added lines, -8 removed lines

@@ -1,13 +1,13 @@
 <?php
 /**
- * PHPFeature Class
- *
- * @package   phpfeature
- * @author    Alain Schlesser <alain.schlesser@gmail.com>
- * @license   GPL-2.0+
- * @link      http://www.brightnucleus.com/
- * @copyright 2016 Alain Schlesser, Bright Nucleus
- */
+	 * PHPFeature Class
+	 *
+	 * @package   phpfeature
+	 * @author    Alain Schlesser <alain.schlesser@gmail.com>
+	 * @license   GPL-2.0+
+	 * @link      http://www.brightnucleus.com/
+	 * @copyright 2016 Alain Schlesser, Bright Nucleus
+	 */
 
 /**
  * Class PHPFeature

Spacing +49 added lines, -49 removed lines

@@ -58,25 +58,25 @@ 
 	 *                                                     features.
 	 * @throws RuntimeException If the PHP version could not be validated.
 	 */
-	public function __construct( $php_version = null, ConfigInterface $config = null ) {
+	public function __construct($php_version = null, ConfigInterface $config = null) {
 
 		// TODO: Better way to bootstrap this while still allowing DI?
-		if ( ! $config ) {
-			$config = new Config( include( __DIR__ . '/../config/known_features.php' ) );
+		if ( ! $config) {
+			$config = new Config(include(__DIR__.'/../config/known_features.php'));
 		}
 
 		$this->config = $config;
 
-		if ( null === $php_version ) {
+		if (null === $php_version) {
 			$php_version = phpversion();
 		}
 
-		if ( is_integer( $php_version ) ) {
+		if (is_integer($php_version)) {
 			$php_version = (string) $php_version;
 		}
 
-		if ( is_string( $php_version ) ) {
-			$php_version = new SemanticVersion( $php_version, true );
+		if (is_string($php_version)) {
+			$php_version = new SemanticVersion($php_version, true);
 		}
 
 		$this->version = $php_version;
@@ -97,24 +97,24 @@ 
 	 *                                  in.
 	 * @throws RuntimeException         If a requirement could not be parsed.
 	 */
-	public function is_supported( $features ) {
+	public function is_supported($features) {
 
-		if ( is_string( $features ) ) {
-			$features = array( $features );
+		if (is_string($features)) {
+			$features = array($features);
 		}
 
-		if ( ! is_array( $features ) ) {
-			throw new InvalidArgumentException( sprintf(
+		if ( ! is_array($features)) {
+			throw new InvalidArgumentException(sprintf(
 				'Wrong type of argument passed in to is_supported(): "%1$s".',
-				gettype( $features )
-			) );
+				gettype($features)
+			));
 		}
 
 		$is_supported = true;
 
-		while ( $is_supported && count( $features ) > 0 ) {
-			$feature = array_pop( $features );
-			$is_supported &= (bool) $this->check_support( $feature );
+		while ($is_supported && count($features) > 0) {
+			$feature = array_pop($features);
+			$is_supported &= (bool) $this->check_support($feature);
 		}
 
 		return (bool) $is_supported;
@@ -137,28 +137,28 @@ 
 	 *                                  in.
 	 * @throws RuntimeException         If a requirement could not be parsed.
 	 */
-	public function get_minimum_required( $features ) {
+	public function get_minimum_required($features) {
 
-		if ( is_string( $features ) ) {
-			$features = array( $features );
+		if (is_string($features)) {
+			$features = array($features);
 		}
 
-		if ( ! is_array( $features ) ) {
-			throw new InvalidArgumentException( sprintf(
+		if ( ! is_array($features)) {
+			throw new InvalidArgumentException(sprintf(
 				'Wrong type of argument passed in to get_minimum_required(): "%1$s".',
-				gettype( $features )
-			) );
+				gettype($features)
+			));
 		}
 
 		$minimum_required = '0.0.0';
 		$is_supported     = true;
 
-		while ( count( $features ) > 0 ) {
-			$feature = array_pop( $features );
-			$is_supported &= (bool) $this->check_support( $feature, $minimum_required );
+		while (count($features) > 0) {
+			$feature = array_pop($features);
+			$is_supported &= (bool) $this->check_support($feature, $minimum_required);
 		}
 
-		return $minimum_required !== '0.0.0' ? new SemanticVersion( $minimum_required, true ) : false;
+		return $minimum_required !== '0.0.0' ? new SemanticVersion($minimum_required, true) : false;
 	}
 
 	/**
@@ -172,23 +172,23 @@ 
 	 * @return bool
 	 * @throws RuntimeException If the requirement could not be parsed.
 	 */
-	protected function check_support( $feature, &$minimum_required = null ) {
+	protected function check_support($feature, &$minimum_required = null) {
 
-		if ( ! $this->config->has_key( $feature ) ) {
+		if ( ! $this->config->has_key($feature)) {
 			return false;
 		}
 
-		$requirements = $this->config->get_key( $feature );
+		$requirements = $this->config->get_key($feature);
 
-		if ( ! is_array( $requirements ) ) {
-			$requirements = array( $requirements );
+		if ( ! is_array($requirements)) {
+			$requirements = array($requirements);
 		}
 
 		$is_supported = true;
 
-		while ( ( $is_supported || $minimum_required ) && count( $requirements ) > 0 ) {
-			$requirement = array_pop( $requirements );
-			$is_supported &= (bool) $this->check_requirement( $requirement, $minimum_required );
+		while (($is_supported || $minimum_required) && count($requirements) > 0) {
+			$requirement = array_pop($requirements);
+			$is_supported &= (bool) $this->check_requirement($requirement, $minimum_required);
 		}
 
 		return (bool) $is_supported;
@@ -206,29 +206,29 @@ 
 	 * @return bool
 	 * @throws RuntimeException If the requirement could not be parsed.
 	 */
-	protected function check_requirement( $requirement, &$minimum_required = null ) {
+	protected function check_requirement($requirement, &$minimum_required = null) {
 
-		$requirement = trim( $requirement );
+		$requirement = trim($requirement);
 		$pattern     = self::COMPARISON_PATTERN;
 
 		$arguments = array();
-		$result    = preg_match( $pattern, $requirement, $arguments );
+		$result    = preg_match($pattern, $requirement, $arguments);
 
-		if ( ! $result || ! isset( $arguments[1] ) || ! isset( $arguments[2] ) ) {
-			throw new RuntimeException( sprintf(
+		if ( ! $result || ! isset($arguments[1]) || ! isset($arguments[2])) {
+			throw new RuntimeException(sprintf(
 				'Could not parse the requirement "%1$s".',
 				(string) $requirement
-			) );
+			));
 		}
 
-		$operator  = isset( $arguments[1] ) ? (string) $arguments[1] : '>=';
-		$milestone = isset( $arguments[2] ) ? (string) $arguments[2] : '0.0.0';
+		$operator  = isset($arguments[1]) ? (string) $arguments[1] : '>=';
+		$milestone = isset($arguments[2]) ? (string) $arguments[2] : '0.0.0';
 
-		$is_supported = (bool) version_compare( $this->version->get_version(), $milestone, $operator );
+		$is_supported = (bool) version_compare($this->version->get_version(), $milestone, $operator);
 
-		if ( $minimum_required ) {
-			$required_version = $this->get_required_version( $milestone, $operator );
-			if ( version_compare( $required_version, $minimum_required, '>' ) ) {
+		if ($minimum_required) {
+			$required_version = $this->get_required_version($milestone, $operator);
+			if (version_compare($required_version, $minimum_required, '>')) {
 				$minimum_required = $required_version;
 			}
 		}
@@ -249,7 +249,7 @@ 
 	 *                          'ne'
 	 * @return string
 	 */
-	protected function get_required_version( $milestone, $operator ) {
+	protected function get_required_version($milestone, $operator) {
 
 		// TODO: Algorithm is still missing, the `$operator` is simply ignored
 		// and the pure `$milestone` is returned.