Failed Conditions
Pull Request — master (#72)
by Sander
03:09
created
lib/Service/SettingsService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@
 block discarded – undo
62 62
 	 * Get a app setting
63 63
 	 *
64 64
 	 * @param $key string
65
-	 * @param null $default_value The default value if key does not exist
65
+	 * @param string|false $default_value The default value if key does not exist
66 66
 	 * @return mixed
67 67
 	 */
68 68
 	public function getAppSetting($key, $default_value = null) {
Please login to merge, or discard this patch.
controller/notebookapicontroller.php 1 patch
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -23,10 +23,7 @@  discard block
 block discarded – undo
23 23
 
24 24
 namespace OCA\NextNote\Controller;
25 25
 
26
-use OCA\NextNote\Db\Notebook;
27
-use OCA\NextNote\Fixtures\ShareFix;
28 26
 use OCA\NextNote\Service\NotebookService;
29
-use OCA\NextNote\Service\NoteService;
30 27
 use OCA\NextNote\ShareBackend\NextNoteShareBackend;
31 28
 use OCA\NextNote\Utility\NotFoundJSONResponse;
32 29
 use OCA\NextNote\Utility\UnauthorizedJSONResponse;
@@ -38,7 +35,6 @@  discard block
 block discarded – undo
38 35
 use OCP\ILogger;
39 36
 use \OCP\IRequest;
40 37
 use OCP\IUserManager;
41
-use OCP\Share;
42 38
 
43 39
 
44 40
 class NotebookApiController extends ApiController {
Please login to merge, or discard this patch.
lib/Db/NotebookMapper.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -37,6 +37,9 @@
 block discarded – undo
37 37
 	}
38 38
 
39 39
 
40
+	/**
41
+	 * @param string $user_id
42
+	 */
40 43
 	public function find($group_id, $user_id = null, $deleted = false) {
41 44
 		$params = [];
42 45
 		$where = [];
Please login to merge, or discard this patch.
lib/Db/NoteMapper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@
 block discarded – undo
81 81
 
82 82
 	/**
83 83
 	 * @param $userId
84
-	 * @param int|bool $deleted
84
+	 * @param integer $deleted
85 85
 	 * @param string|bool $group
86 86
 	 * @return Note[] if not found
87 87
 	 */
Please login to merge, or discard this patch.
lib/Service/NoteService.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,6 @@
 block discarded – undo
23 23
 
24 24
 namespace OCA\NextNote\Service;
25 25
 
26
-use OCA\NextNote\Db\Notebook;
27 26
 use OCA\NextNote\Db\Note;
28 27
 use OCA\NextNote\Fixtures\ShareFix;
29 28
 use OCA\NextNote\ShareBackend\NextNoteShareBackend;
Please login to merge, or discard this patch.