Code Quality Summary - borisguery/oauth2-server - Measure and Improve Code Quality continuously with Scrutinizer

2016-04-06 21:50 UTC

Inspected remove useless return statemen...

Good job, 1 issue was fixed.

2016-04-06 21:35 UTC

Inspected use own implementation of asse...

Good job, 1 issue was fixed.

2016-04-06 21:15 UTC

Inspected move static keyword after visi...

Good job, 6 issues were fixed.

2016-04-06 21:00 UTC

Inspected configuration builder doesn't...

Good job, 1 issue was fixed.

2016-04-06 20:45 UTC

Inspected replace keyword by actual cla...

Good job, 2 issues were fixed.

2016-04-06 15:46 UTC

Inspected Directly inject storages to au...

3 issues (1 major, 2 minor) were introduced.
5 added classes/operations
	A	RefreshToken::isRevoked() added
	A	RefreshToken::getRevokedAt() added
	A	RefreshToken::revoke() added
	A	AuthorizationServerConfigurationBuilder::shouldRevokeRefreshTokenWhenU... added
	A	AuthorizationServerConfiguration::shouldRevokeRefreshTokenWhenUsed() added

2016-04-05 09:55 UTC

Inspected Improve date handling, add an...

	3 added classes/operations
		A	RefreshToken::getExpiresAt() added
		A	AuthorizationServerConfiguration::getRefreshTokenTTL() added
		A	AccessToken::isExpired() added
A	↘	B	AuthorizationServer::buildRefreshToken() got worse

2016-04-04 20:15 UTC

Inspected add refresh token grant type

1 issue (minor) was introduced. 2 issues were fixed.
9 added classes/operations
	B	RefreshTokenGrantType::grant() added
	A	RefreshTokenGrantType::getRequiredInputData() added
	A	RefreshToken::getAssociatedAccessToken() added
	A	RefreshTokenGrantType::getIdentifier() added
	A	RefreshTokenGrantType::setRefreshTokenStorage() added
	A	AccessToken::getResourceOwner() added
	A	GrantDecision::getResourceOwner() added
	A	RefreshTokenGrantType::__construct() added
	A	RefreshTokenGrantType added

2016-04-04 16:40 UTC

Inspected refactor authorization server...

	1 issue (minor) was introduced.
	8 added classes/operations
		A	AuthorizationServer::checkIfClientSupportsRequestedGrantType() added
		B	AuthorizationServer::buildAccessToken() added
		A	AuthorizationServer::buildRefreshToken() added
		A	AuthorizationServer::checkIfTheProvidedClientIsValid() added
		A	AuthorizationServer::checkIfAClientIsProvided() added
		A	AuthorizationServer::checkGrantType() added
		A	AuthorizationServer::checkIfAClientIsAlwaysRequired() added
		A	AccessToken::getExpiresAt() added
B	↘	C	AuthorizationServer::requestAccessToken() got worse

2016-03-31 20:20 UTC

Inspected add some tests, model resource...

	4 issues (1 major, 3 informational) were introduced. 8 issues were newly filtered.
	42 added classes/operations
		B	AuthorizationServerConfigurationBuilder::build() added
		A	AuthorizationServerConfigurationBuilder::reset() added
		A	AuthorizationServerConfigurationBuilder::getAuthorizationServerConfigu... added
		A	ClientCredentialsGrantType::__construct() added
		A	AuthorizationServerConfigurationBuilder::addGrantType() added
		A	AuthorizationServerConfigurationBuilder::setAccessTokenGenerator() added
		A	AuthorizationServerConfigurationBuilder::alwaysRequireAClient() added
		B	AuthorizationServer added
		A	AuthorizationServerConfigurationBuilder::alwaysGenerateARefreshToken() added
		A	AuthorizationServerConfigurationBuilder::setAccessTokenTTL() added
view all

2016-03-29 16:35 UTC

Inspected fix scrutinizer issues

	8 issues (8 informational) were introduced. 33 issues were fixed. 1 issue was newly filtered.
	1 added class/operation
		A	GrantError::__construct() added
A	↘	B	ResourceServer got worse