Completed
Pull Request — master (#52)
by
unknown
01:56
created
src/Codor/Sniffs/ControlStructures/NoElseSniff.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
 {
13 13
     public function register()
14 14
     {
15
-        return [T_ELSE, T_ELSEIF];
15
+        return [ T_ELSE, T_ELSEIF ];
16 16
     }
17 17
 
18 18
     /**
Please login to merge, or discard this patch.
src/Codor/Sniffs/Files/FunctionLengthSniff.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -12,25 +12,25 @@
 block discarded – undo
12 12
 
13 13
     public function register()
14 14
     {
15
-        return [T_FUNCTION];
15
+        return [ T_FUNCTION ];
16 16
     }
17 17
 
18 18
     public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
19 19
     {
20 20
         $tokens = $phpcsFile->getTokens();
21
-        $token = $tokens[$stackPtr];
21
+        $token = $tokens[ $stackPtr ];
22 22
 
23 23
         // Skip function without body.
24
-        if (isset($token['scope_opener']) === false) {
24
+        if (isset($token[ 'scope_opener' ]) === false) {
25 25
             return 0;
26 26
         }
27 27
 
28
-        $firstToken = $tokens[$token['scope_opener']];
29
-        $lastToken = $tokens[$token['scope_closer']];
30
-        $length = $lastToken['line'] - $firstToken['line'];
28
+        $firstToken = $tokens[ $token[ 'scope_opener' ] ];
29
+        $lastToken = $tokens[ $token[ 'scope_closer' ] ];
30
+        $length = $lastToken[ 'line' ] - $firstToken[ 'line' ];
31 31
 
32 32
         if ($length > $this->maxLength) {
33
-            $tokenType = strtolower(substr($token['type'], 2));
33
+            $tokenType = strtolower(substr($token[ 'type' ], 2));
34 34
             $error = "Function is {$length} lines. Must be {$this->maxLength} lines or fewer.";
35 35
             $phpcsFile->addError($error, $stackPtr, sprintf('%sTooBig', ucfirst($tokenType)));
36 36
         }
Please login to merge, or discard this patch.
src/Codor/Sniffs/Files/ReturnNullSniff.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
      */
15 15
     public function register()
16 16
     {
17
-        return [T_RETURN];
17
+        return [ T_RETURN ];
18 18
     }
19 19
 
20 20
     /**
@@ -32,8 +32,8 @@  discard block
 block discarded – undo
32 32
 
33 33
         $returnValueToken = '';
34 34
         for ($index = $returnTokenIndex; $index < count($tokens); $index++) { 
35
-            if ($tokens[$index]['type'] === 'T_SEMICOLON') {
36
-                $returnValueToken = $tokens[$index - 1];
35
+            if ($tokens[ $index ][ 'type' ] === 'T_SEMICOLON') {
36
+                $returnValueToken = $tokens[ $index - 1 ];
37 37
                 break;
38 38
             }
39 39
         }
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
             return;
43 43
         }
44 44
 
45
-        if ($returnValueToken['type'] === 'T_NULL') {
45
+        if ($returnValueToken[ 'type' ] === 'T_NULL') {
46 46
             $error = "Return null value found.";
47 47
             $phpcsFile->addError($error, $stackPtr);
48 48
         }
Please login to merge, or discard this patch.
src/Codor/Sniffs/Classes/ClassLengthSniff.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
      */
22 22
     public function register()
23 23
     {
24
-        return [T_CLASS];
24
+        return [ T_CLASS ];
25 25
     }
26 26
 
27 27
     /**
@@ -35,12 +35,12 @@  discard block
 block discarded – undo
35 35
     public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
36 36
     {
37 37
         $tokens = $phpcsFile->getTokens();
38
-        $token = $tokens[$stackPtr];
38
+        $token = $tokens[ $stackPtr ];
39 39
         
40
-        $openParenthesis = $tokens[$token['scope_opener']];
41
-        $closedParenthesis = $tokens[$token['scope_closer']];
40
+        $openParenthesis = $tokens[ $token[ 'scope_opener' ] ];
41
+        $closedParenthesis = $tokens[ $token[ 'scope_closer' ] ];
42 42
 
43
-        $length = $closedParenthesis['line'] - $openParenthesis['line'];
43
+        $length = $closedParenthesis[ 'line' ] - $openParenthesis[ 'line' ];
44 44
 
45 45
         if ($length > $this->maxLength) {
46 46
             $phpcsFile->addError("Class is {$length} lines. Must be {$this->maxLength} lines or fewer.", $stackPtr);
Please login to merge, or discard this patch.
src/Codor/Sniffs/Files/FunctionNameContainsAndOrSniff.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@  discard block
 block discarded – undo
12 12
      * The forbidden strings this sniff looks for.
13 13
      * @var array
14 14
      */
15
-    protected $keywords = ['And', '_and', 'Or', '_or'];
15
+    protected $keywords = [ 'And', '_and', 'Or', '_or' ];
16 16
 
17 17
     /**
18 18
      * Returns the token types that this sniff is interested in.
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
      */
21 21
     public function register()
22 22
     {
23
-        return [T_FUNCTION];
23
+        return [ T_FUNCTION ];
24 24
     }
25 25
 
26 26
     /**
@@ -34,10 +34,10 @@  discard block
 block discarded – undo
34 34
     public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
35 35
     {
36 36
         $tokens = $phpcsFile->getTokens();
37
-        $functionNameToken = $tokens[$stackPtr + 2];
38
-        $functionName = $functionNameToken['content'];
37
+        $functionNameToken = $tokens[ $stackPtr + 2 ];
38
+        $functionName = $functionNameToken[ 'content' ];
39 39
         
40
-        if (! $this->containsKeywords($functionName)) {
40
+        if (!$this->containsKeywords($functionName)) {
41 41
             return;
42 42
         }
43 43
 
Please login to merge, or discard this patch.
src/Codor/Sniffs/Files/FunctionParameterSniff.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
      */
21 21
     public function register()
22 22
     {
23
-        return [T_FUNCTION];
23
+        return [ T_FUNCTION ];
24 24
     }
25 25
 
26 26
     /**
@@ -34,13 +34,13 @@  discard block
 block discarded – undo
34 34
     public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
35 35
     {
36 36
         $tokens           = $phpcsFile->getTokens();
37
-        $token            = $tokens[$stackPtr];
38
-        $openParenIndex   = $token['parenthesis_opener'];
39
-        $closedParenIndex = $token['parenthesis_closer'];
37
+        $token            = $tokens[ $stackPtr ];
38
+        $openParenIndex   = $token[ 'parenthesis_opener' ];
39
+        $closedParenIndex = $token[ 'parenthesis_closer' ];
40 40
 
41 41
         $numberOfParameters = 0;
42
-        for ($index=$openParenIndex+1; $index <= $closedParenIndex; $index++) {
43
-            $tokens[$index]['type'] == 'T_VARIABLE' ? $numberOfParameters++ : null;
42
+        for ($index = $openParenIndex + 1; $index <= $closedParenIndex; $index++) {
43
+            $tokens[ $index ][ 'type' ] == 'T_VARIABLE' ? $numberOfParameters++ : null;
44 44
         }
45 45
 
46 46
         if ($numberOfParameters > $this->maxParameters) {
Please login to merge, or discard this patch.
src/Codor/Sniffs/ControlStructures/NestedIfSniff.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@
 block discarded – undo
10 10
 
11 11
     /**
12 12
      * Returns the token types that this sniff is interested in.
13
-     * @return array
13
+     * @return integer[]
14 14
      */
15 15
     public function register()
16 16
     {
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
      */
15 15
     public function register()
16 16
     {
17
-        return [T_IF];
17
+        return [ T_IF ];
18 18
     }
19 19
 
20 20
     /**
@@ -29,13 +29,13 @@  discard block
 block discarded – undo
29 29
     {
30 30
         $this->phpcsFile = $phpcsFile;
31 31
         $tokens          = $phpcsFile->getTokens();
32
-        $token           = $tokens[$stackPtr];
33
-        $start           = $token['scope_opener'];
34
-        $end             = $token['scope_closer'];
32
+        $token           = $tokens[ $stackPtr ];
33
+        $start           = $token[ 'scope_opener' ];
34
+        $end             = $token[ 'scope_closer' ];
35 35
 
36
-        $this->errorStack = [];
37
-        for ($index=$start; $index <= $end; $index++) {
38
-            $this->checkForNestedIf($tokens[$index], $stackPtr);
36
+        $this->errorStack = [ ];
37
+        for ($index = $start; $index <= $end; $index++) {
38
+            $this->checkForNestedIf($tokens[ $index ], $stackPtr);
39 39
         }
40 40
     }
41 41
 
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
      */
48 48
     protected function checkForNestedIf(array $token, $stackPtr)
49 49
     {
50
-        if (! $this->isIfStatement($token)) {
50
+        if (!$this->isIfStatement($token)) {
51 51
             return;
52 52
         }
53 53
 
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
         }
57 57
 
58 58
         $this->phpcsFile->addError('Nested if statement found.', $stackPtr);
59
-        $this->errorStack[] = $stackPtr;
59
+        $this->errorStack[ ] = $stackPtr;
60 60
     }
61 61
 
62 62
     /**
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
      */
82 82
     protected function isIfStatement(array $token)
83 83
     {
84
-        if ($token['type'] === 'T_IF') {
84
+        if ($token[ 'type' ] === 'T_IF') {
85 85
             return true;
86 86
         }
87 87
 
Please login to merge, or discard this patch.
src/Codor/Sniffs/Files/IndentationLevelSniff.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
      */
26 26
     public function register()
27 27
     {
28
-        return [T_FUNCTION, T_CLOSURE, T_SWITCH];
28
+        return [ T_FUNCTION, T_CLOSURE, T_SWITCH ];
29 29
     }
30 30
 
31 31
     /**
@@ -39,11 +39,11 @@  discard block
 block discarded – undo
39 39
     public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
40 40
     {
41 41
         $tokens = $phpcsFile->getTokens();
42
-        $token = $tokens[$stackPtr];
42
+        $token = $tokens[ $stackPtr ];
43 43
         $this->maxIndentationFound = 0;
44 44
 
45 45
         // Ignore functions with no body
46
-        if (isset($token['scope_opener']) === false) {
46
+        if (isset($token[ 'scope_opener' ]) === false) {
47 47
             return;
48 48
         }
49 49
 
@@ -64,15 +64,15 @@  discard block
 block discarded – undo
64 64
      */
65 65
     protected function inspectScope(array $token, array $tokens)
66 66
     {
67
-        $start = $token['scope_opener'];
68
-        $length = $token['scope_closer'] - $start + 1;
69
-        $relativeScopeLevel = $tokens[$start]['level'];
67
+        $start = $token[ 'scope_opener' ];
68
+        $length = $token[ 'scope_closer' ] - $start + 1;
69
+        $relativeScopeLevel = $tokens[ $start ][ 'level' ];
70 70
 
71 71
         $scope = array_slice($tokens, $start, $length, true);
72 72
         $scope = $this->removeTokenScopes($scope, 'T_SWITCH');
73 73
 
74
-        $this->maxIndentationFound = array_reduce($scope, function ($max, $nestedToken) use ($relativeScopeLevel) {
75
-            $max = max($max, $nestedToken['level'] - $relativeScopeLevel);
74
+        $this->maxIndentationFound = array_reduce($scope, function($max, $nestedToken) use ($relativeScopeLevel) {
75
+            $max = max($max, $nestedToken[ 'level' ] - $relativeScopeLevel);
76 76
             return $max;
77 77
         });
78 78
     }
@@ -85,12 +85,12 @@  discard block
 block discarded – undo
85 85
      */
86 86
     protected function removeTokenScopes(array $scope, $type)
87 87
     {
88
-        $typeTokens = array_filter($scope, function ($token) use ($type) {
89
-            return $token['type'] == $type;
88
+        $typeTokens = array_filter($scope, function($token) use ($type) {
89
+            return $token[ 'type' ] == $type;
90 90
         });
91 91
 
92 92
         foreach ($typeTokens as $token) {
93
-            $range = array_flip(range($token['scope_opener'], $token['scope_closer']));
93
+            $range = array_flip(range($token[ 'scope_opener' ], $token[ 'scope_closer' ]));
94 94
             $scope = array_diff_key($scope, $range);
95 95
         }
96 96
 
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
         // indentation limit.
109 109
         $indentationFound = $this->maxIndentationFound - 1;
110 110
         $indentationLimit = $this->indentationLimit - 1;
111
-        return "{$indentationFound} indentation levels found. " .
111
+        return "{$indentationFound} indentation levels found. ".
112 112
         "Maximum of {$indentationLimit} indentation levels allowed.";
113 113
     }
114 114
 }
Please login to merge, or discard this patch.