Blocktrail\SDK\V3Crypt\KeyDerivation::compute()

Complexity

Conditions	6
Paths	5

Size

Total Lines	19
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function compute(BufferInterface $password, BufferInterface $salt, $iterations) {
        if (!($iterations >= 0 && $iterations < pow(2, 32))) {
            throw new \RuntimeException('Iterations must be a number between 1 and 2^32');
        }

        if ($iterations < 512) {
            throw new \RuntimeException('Iteration count should be at least 512');
        }

        if ($salt->getSize() === 0) {
            throw new \RuntimeException('Salt must not be empty');
        }

        if ($salt->getSize() > 0x80) {
            throw new \RuntimeException('Sanity check: Invalid salt, length can never be greater than 128');
        }

        return new Buffer(hash_pbkdf2(self::HASHER, $password->getBinary(), $salt->getBinary(), $iterations, self::KEYLEN_BITS / 8, true));

It seems like hash_pbkdf2(self::HASHER, $password->getBinary(), $salt->getBinary(), $iterations, self::KEYLEN_BITS / 8, true) targeting hash_pbkdf2() can also be of type false or null; however, BitWasp\Buffertools\Buffer::__construct() does only seem to accept string, maybe add an additional type check?

    }
}