Blocktrail\SDK\V3Crypt\KeyDerivation

Complexity

Total Complexity

6

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	compute()	0	19	6

<?php

namespace Blocktrail\SDK\V3Crypt;

use BitWasp\Buffertools\Buffer;
use BitWasp\Buffertools\BufferInterface;

class KeyDerivation
{
    const HASHER = 'sha512';
    const DEFAULT_ITERATIONS = 35000;
    const KEYLEN_BITS = 256;

    /**
     * @param BufferInterface $password
     * @param BufferInterface $salt
     * @param int $iterations
     * @return BufferInterface
     */
    public static function compute(BufferInterface $password, BufferInterface $salt, $iterations) {
        if (!($iterations >= 0 && $iterations < pow(2, 32))) {
            throw new \RuntimeException('Iterations must be a number between 1 and 2^32');
        }

        if ($iterations < 512) {
            throw new \RuntimeException('Iteration count should be at least 512');
        }

        if ($salt->getSize() === 0) {
            throw new \RuntimeException('Salt must not be empty');
        }

        if ($salt->getSize() > 0x80) {
            throw new \RuntimeException('Sanity check: Invalid salt, length can never be greater than 128');
        }

        return new Buffer(hash_pbkdf2(self::HASHER, $password->getBinary(), $salt->getBinary(), $iterations, self::KEYLEN_BITS / 8, true));

It seems like hash_pbkdf2(self::HASHER, $password->getBinary(), $salt->getBinary(), $iterations, self::KEYLEN_BITS / 8, true) targeting hash_pbkdf2() can also be of type false or null; however, BitWasp\Buffertools\Buffer::__construct() does only seem to accept string, maybe add an additional type check?

    }
}