blocktrail / blocktrail-sdk-php

coverage-checker.php

Spacing +7 added lines, -7 removed lines

@@ -10,7 +10,7 @@ 
 }
 
 $inputFile  = $argv[1];
-$percentage = min(100, max(0, (int) $argv[2]));
+$percentage = min(100, max(0, (int)$argv[2]));
 
 if (!file_exists($inputFile)) {
     throw new InvalidArgumentException('Invalid input file provided');
@@ -26,10 +26,10 @@ 
 $checkedElements = 0;
 
 $excludes = [
-    "/^Blocktrail\\\\SDK\\\\Console/",  // just wrappers and a pain in the ass to test
-    "/Compiler\\.php/",                 // just a tool and copy paste from Composer
-    "/BackupGenerator\\.php/",          // tmp excluding, it's rather hard to test the whole process
-    "/WalletSweeper\\.php/",            // because we're running it's test without coverage (because xdebug is REALLY slow)
+    "/^Blocktrail\\\\SDK\\\\Console/", // just wrappers and a pain in the ass to test
+    "/Compiler\\.php/", // just a tool and copy paste from Composer
+    "/BackupGenerator\\.php/", // tmp excluding, it's rather hard to test the whole process
+    "/WalletSweeper\\.php/", // because we're running it's test without coverage (because xdebug is REALLY slow)
 ];
 
 foreach ($xml->xpath("//package") as $package) {
@@ -82,8 +82,8 @@ 
 }
 
 foreach ($xml->xpath("//project/file/metrics") as $metric) {
-    $totalElements   += (int) $metric['elements'];
-    $checkedElements += (int) $metric['coveredelements'];
+    $totalElements   += (int)$metric['elements'];
+    $checkedElements += (int)$metric['coveredelements'];
 }
 
 var_dump($totalElements);

src/Bitcoin/BIP32Path.php

Spacing +2 added lines, -2 removed lines

@@ -24,7 +24,7 @@ 
     public function insert($insert, $offset) {
         $path = $this->path;
 
-        array_splice($path, $offset+1, 0, [$insert]);
+        array_splice($path, $offset + 1, 0, [$insert]);
 
         return new static($path);
     }
@@ -205,7 +205,7 @@ 
      * @return string
      */
     public function getLast() {
-        return $this->path[count($this->path)-1];
+        return $this->path[count($this->path) - 1];
     }
 
     /**

src/BlocktrailSDK.php

Indentation -1 removed lines

@@ -1097,7 +1097,6 @@
 
     /**
      * convert a Satoshi value to a BTC value and return it as a string
-
      * @param int       $satoshi
      * @return string
      */

Spacing +11 added lines, -14 removed lines

@@ -323,7 +323,7 @@ 
      * @return array[]            array containing the response
      */
     public function transactions($txhashes) {
-        $response = $this->client->get("transactions/" . implode(",", $txhashes));
+        $response = $this->client->get("transactions/".implode(",", $txhashes));
         return self::jsonDecode($response->body(), true);
     }
     
@@ -590,7 +590,7 @@ 
             } else {
                 // create new primary seed
                 /** @var HierarchicalKey $primaryPrivateKey */
-                list($primaryMnemonic, , $primaryPrivateKey) = $this->newPrimarySeed($options['passphrase']);
+                list($primaryMnemonic,, $primaryPrivateKey) = $this->newPrimarySeed($options['passphrase']);
                 if ($storePrimaryMnemonic !== false) {
                     $storePrimaryMnemonic = true;
                 }
@@ -629,7 +629,7 @@ 
         $backupPublicKey = null;
         if (!isset($options['backup_mnemonic']) && !isset($options['backup_public_key'])) {
             /** @var HierarchicalKey $backupPrivateKey */
-            list($backupMnemonic, , ) = $this->newBackupSeed();
+            list($backupMnemonic,,) = $this->newBackupSeed();
         } else if (isset($options['backup_mnemonic'])) {
             $backupMnemonic = $options['backup_mnemonic'];
         } elseif (isset($options['backup_public_key'])) {
@@ -653,7 +653,7 @@ 
         $data = $this->storeNewWalletV1($options['identifier'], $primaryPublicKey->tuple(), $backupPublicKey->tuple(), $primaryMnemonic, $checksum, $options['key_index']);
 
         // received the blocktrail public keys
-        $blocktrailPublicKeys = Util::arrayMapWithIndex(function ($keyIndex, $pubKeyTuple) {
+        $blocktrailPublicKeys = Util::arrayMapWithIndex(function($keyIndex, $pubKeyTuple) {
             return [$keyIndex, BIP32Key::create(HierarchicalKeyFactory::fromExtended($pubKeyTuple[0]), $pubKeyTuple[1])];
         }, $data['blocktrail_public_keys']);
 
@@ -771,7 +771,7 @@ 
         );
 
         // received the blocktrail public keys
-        $blocktrailPublicKeys = Util::arrayMapWithIndex(function ($keyIndex, $pubKeyTuple) {
+        $blocktrailPublicKeys = Util::arrayMapWithIndex(function($keyIndex, $pubKeyTuple) {
             return [$keyIndex, BIP32Key::create(HierarchicalKeyFactory::fromExtended($pubKeyTuple[0]), $pubKeyTuple[1])];
         }, $data['blocktrail_public_keys']);
 
@@ -804,7 +804,7 @@ 
                 'backup_seed' => $backupSeed ? MnemonicFactory::bip39()->entropyToMnemonic(new Buffer($backupSeed)) : null,
                 'recovery_encrypted_secret' => $recoveryEncryptedSecret ? MnemonicFactory::bip39()->entropyToMnemonic(new Buffer(base64_decode($recoveryEncryptedSecret))) : null,
                 'encrypted_secret' => $encryptedSecret ? MnemonicFactory::bip39()->entropyToMnemonic(new Buffer(base64_decode($encryptedSecret))) : null,
-                'blocktrail_public_keys' => Util::arrayMapWithIndex(function ($keyIndex, BIP32Key $pubKey) {
+                'blocktrail_public_keys' => Util::arrayMapWithIndex(function($keyIndex, BIP32Key $pubKey) {
                     return [$keyIndex, $pubKey->tuple()];
                 }, $blocktrailPublicKeys),
             ],
@@ -909,7 +909,7 @@ 
         );
 
         // received the blocktrail public keys
-        $blocktrailPublicKeys = Util::arrayMapWithIndex(function ($keyIndex, $pubKeyTuple) {
+        $blocktrailPublicKeys = Util::arrayMapWithIndex(function($keyIndex, $pubKeyTuple) {
             return [$keyIndex, BIP32Key::create(HierarchicalKeyFactory::fromExtended($pubKeyTuple[0]), $pubKeyTuple[1])];
         }, $data['blocktrail_public_keys']);
 
@@ -942,7 +942,7 @@ 
                 'backup_seed'               => $backupSeed ? MnemonicFactory::bip39()->entropyToMnemonic($backupSeed) : null,
                 'recovery_encrypted_secret' => $recoveryEncryptedSecret ? EncryptionMnemonic::encode($recoveryEncryptedSecret) : null,
                 'encrypted_secret'          => $encryptedSecret ? EncryptionMnemonic::encode($encryptedSecret) : null,
-                'blocktrail_public_keys'    => Util::arrayMapWithIndex(function ($keyIndex, BIP32Key $pubKey) {
+                'blocktrail_public_keys'    => Util::arrayMapWithIndex(function($keyIndex, BIP32Key $pubKey) {
                     return [$keyIndex, $pubKey->tuple()];
                 }, $blocktrailPublicKeys),
             ]
@@ -1104,10 +1104,7 @@ 
         }
 
         $identifier = $options['identifier'];
-        $readonly = isset($options['readonly']) ? $options['readonly'] :
-                    (isset($options['readOnly']) ? $options['readOnly'] :
-                        (isset($options['read-only']) ? $options['read-only'] :
-                            false));
+        $readonly = isset($options['readonly']) ? $options['readonly'] : (isset($options['readOnly']) ? $options['readOnly'] : (isset($options['read-only']) ? $options['read-only'] : false));
 
         // get the wallet data from the server
         $data = $this->getWallet($identifier);
@@ -1752,7 +1749,7 @@ 
      */
     public static function sortMultisigKeys(array $pubKeys) {
         $result = array_values($pubKeys);
-        usort($result, function (PublicKeyInterface $a, PublicKeyInterface $b) {
+        usort($result, function(PublicKeyInterface $a, PublicKeyInterface $b) {
             $av = $a->getHex();
             $bv = $b->getHex();
             return $av == $bv ? 0 : $av > $bv ? 1 : -1;
@@ -1778,7 +1775,7 @@ 
     }
 
     public static function normalizeBIP32KeyArray($keys) {
-        return Util::arrayMapWithIndex(function ($idx, $key) {
+        return Util::arrayMapWithIndex(function($idx, $key) {
             return [$idx, self::normalizeBIP32Key($key)];
         }, $keys);
     }

Doc Comments +18 added lines, -10 removed lines

@@ -74,7 +74,7 @@ 
     /**
      * normalize network string
      *
-     * @param $network
+     * @param string $network
      * @param $testnet
      * @return array
      * @throws \Exception
@@ -662,6 +662,11 @@ 
         ];
     }
 
+    /**
+     * @param integer $bits
+     *
+     * @return string
+     */
     public static function randomBits($bits) {
         return self::randomBytes($bits / 8);
     }
@@ -956,7 +961,7 @@ 
      * create wallet using the API
      *
      * @param string    $identifier             the wallet identifier to create
-     * @param array     $primaryPublicKey       BIP32 extended public key - [key, path]
+     * @param string[]     $primaryPublicKey       BIP32 extended public key - [key, path]
      * @param string    $backupPublicKey        plain public key
      * @param string    $primaryMnemonic        mnemonic to store
      * @param string    $checksum               checksum to store
@@ -983,9 +988,9 @@ 
      * @param string $identifier       the wallet identifier to create
      * @param array  $primaryPublicKey BIP32 extended public key - [key, path]
      * @param string $backupPublicKey  plain public key
-     * @param        $encryptedPrimarySeed
-     * @param        $encryptedSecret
-     * @param        $recoverySecret
+     * @param        string|false $encryptedPrimarySeed
+     * @param        string|false $encryptedSecret
+     * @param        string|false $recoverySecret
      * @param string $checksum         checksum to store
      * @param int    $keyIndex         account that we expect to use
      * @return mixed
@@ -1014,8 +1019,8 @@ 
      * @param string $identifier       the wallet identifier to create
      * @param array  $primaryPublicKey BIP32 extended public key - [key, path]
      * @param string $backupPublicKey  plain public key
-     * @param        $encryptedPrimarySeed
-     * @param        $encryptedSecret
+     * @param        string|false $encryptedPrimarySeed
+     * @param        string|false $encryptedSecret
      * @param        $recoverySecret
      * @param string $checksum         checksum to store
      * @param int    $keyIndex         account that we expect to use
@@ -1681,7 +1686,7 @@ 
      * convert a Satoshi value to a BTC value
      *
      * @param int       $satoshi
-     * @return float
+     * @return string
      */
     public static function toBTC($satoshi) {
         return bcdiv((int)(string)$satoshi, 100000000, 8);
@@ -1711,7 +1716,7 @@ 
      * convert a BTC value to a Satoshi value
      *
      * @param float     $btc
-     * @return string
+     * @return integer
      */
     public static function toSatoshi($btc) {
         return (int)self::toSatoshiString($btc);
@@ -1720,7 +1725,7 @@ 
     /**
      * json_decode helper that throws exceptions when it fails to decode
      *
-     * @param      $json
+     * @param      string $json
      * @param bool $assoc
      * @return mixed
      * @throws \Exception
@@ -1772,6 +1777,9 @@ 
         }
     }
 
+    /**
+     * @param BIP32Key[] $keys
+     */
     public static function normalizeBIP32KeyArray($keys) {
         return Util::arrayMapWithIndex(function ($idx, $key) {
             return [$idx, self::normalizeBIP32Key($key)];

src/Wallet.php

Indentation -1 removed lines

@@ -55,7 +55,6 @@
 
     /**
      * BIP32 master backup public key (M/)
-
      * @var BIP32Key
      */
     protected $backupPublicKey;

Doc Comments +14 added lines, -10 removed lines

@@ -259,7 +259,7 @@ 
     }
 
     /**
-     * @param string|BIP32Path  $path
+     * @param BIP32Path  $path
      * @return BIP32Key|false
      * @throws \Exception
      *
@@ -286,7 +286,7 @@ 
     /**
      * get address for the specified path
      *
-     * @param string|BIP32Path  $path
+     * @param string  $path
      * @return string
      */
     public function getAddressByPath($path) {
@@ -360,7 +360,7 @@ 
     }
 
     /**
-     * @param string|BIP32Path  $path
+     * @param BIP32Path  $path
      * @return BIP32Key
      * @throws \Exception
      */
@@ -508,7 +508,7 @@ 
      * 'fund' the txBuilder with UTXOs (modified in place)
      *
      * @param TransactionBuilder    $txBuilder
-     * @param bool|true             $lockUTXOs
+     * @param boolean             $lockUTXOs
      * @param bool|false            $allowZeroConf
      * @param null|int              $forceFee
      * @return TransactionBuilder
@@ -629,6 +629,10 @@ 
         return [$txb->get(), $signInfo];
     }
 
+    /**
+     * @param integer $optimalFeePerKB
+     * @param integer $lowPriorityFeePerKB
+     */
     public function determineFeeAndChange(TransactionBuilder $txBuilder, $optimalFeePerKB, $lowPriorityFeePerKB) {
         $send = $txBuilder->getOutputs();
         $utxos = $txBuilder->getUtxos();
@@ -736,7 +740,7 @@ 
      *
      * @param int $utxoCnt      number of unspent inputs in transaction
      * @param int $outputCnt    number of outputs in transaction
-     * @return float
+     * @return integer
      * @access public           reminder that people might use this!
      */
     public static function estimateFee($utxoCnt, $outputCnt) {
@@ -758,7 +762,7 @@ 
     /**
      * @param int $txinSize
      * @param int $txoutSize
-     * @return float
+     * @return integer
      */
     public static function estimateSize($txinSize, $txoutSize) {
         return 4 + 4 + $txinSize + 4 + $txoutSize + 4; // version + txinVarInt + txin + txoutVarInt + txout + locktime
@@ -768,7 +772,7 @@ 
      * only supports estimating size for P2PKH/P2SH outputs
      *
      * @param int $outputCnt    number of outputs in transaction
-     * @return float
+     * @return integer
      */
     public static function estimateSizeOutputs($outputCnt) {
         return ($outputCnt * 34);
@@ -822,7 +826,7 @@ 
      *
      * @param UTXO[]  $utxos
      * @param array[] $outputs
-     * @param         $feeStrategy
+     * @param         string $feeStrategy
      * @param         $optimalFeePerKB
      * @param         $lowPriorityFeePerKB
      * @return int
@@ -921,8 +925,8 @@ 
      * @param \array[] $outputs
      * @param bool $lockUTXO
      * @param bool $allowZeroConf
-     * @param int|null|string $feeStrategy
-     * @param null $forceFee
+     * @param string $feeStrategy
+     * @param null|integer $forceFee
      * @return array
      */
     public function coinSelection($outputs, $lockUTXO = true, $allowZeroConf = false, $feeStrategy = self::FEE_STRATEGY_OPTIMAL, $forceFee = null) {

Unused Use Statements -1 removed lines

@@ -16,7 +16,6 @@
 use BitWasp\Bitcoin\Transaction\SignatureHash\SigHash;
 use BitWasp\Bitcoin\Transaction\Transaction;
 use BitWasp\Bitcoin\Transaction\TransactionInterface;
-use BitWasp\Bitcoin\Transaction\TransactionOutput;
 use BitWasp\Buffertools\Buffer;
 use Blocktrail\SDK\Bitcoin\BIP32Key;
 use Blocktrail\SDK\Bitcoin\BIP32Path;

Spacing +8 added lines, -8 removed lines

@@ -176,7 +176,7 @@ 
      * @return array[]      [ [xpub, path] ]
      */
     public function getBlocktrailPublicKeys() {
-        return array_map(function (BIP32Key $key) {
+        return array_map(function(BIP32Key $key) {
             return $key->tuple();
         }, $this->blocktrailPublicKeys);
     }
@@ -295,7 +295,7 @@ 
     public function getAddressByPath($path) {
         $path = (string)BIP32Path::path($path)->privatePath();
         if (!isset($this->derivations[$path])) {
-            list($address, ) = $this->getRedeemScriptByPath($path);
+            list($address,) = $this->getRedeemScriptByPath($path);
 
             $this->derivations[$path] = $address;
             $this->derivationsByAddress[$address] = $path;
@@ -595,7 +595,7 @@ 
             $signInfo[] = $utxo->getSignInfo();
         }
 
-        $utxoSum = array_sum(array_map(function (UTXO $utxo) {
+        $utxoSum = array_sum(array_map(function(UTXO $utxo) {
             return $utxo->value;
         }, $utxos));
         if ($utxoSum < array_sum(array_column($send, 'value'))) {
@@ -728,7 +728,7 @@ 
             throw new \Exception("Wallet needs to be unlocked to pay");
         }
 
-        assert(Util::all(function ($signInfo) {
+        assert(Util::all(function($signInfo) {
             return $signInfo instanceof SignInfo;
         }, $signInfo), '$signInfo should be SignInfo[]');
 
@@ -736,7 +736,7 @@ 
         $signed = $this->signTransaction($tx, $signInfo);
 
         // send the transaction
-        return $this->sendTransaction($signed->getHex(), array_map(function (SignInfo $r) {
+        return $this->sendTransaction($signed->getHex(), array_map(function(SignInfo $r) {
             return $r->path;
         }, $signInfo), $apiCheckFee);
     }
@@ -793,7 +793,7 @@ 
     public static function estimateSizeUTXOs($utxoCnt) {
         $txinSize = 0;
 
-        for ($i=0; $i<$utxoCnt; $i++) {
+        for ($i = 0; $i < $utxoCnt; $i++) {
             // @TODO: proper size calculation, we only do multisig right now so it's hardcoded and then we guess the size ...
             $multisig = "2of3";
 
@@ -879,7 +879,7 @@ 
      * @return int
      */
     protected function determineChange($utxos, $outputs, $fee) {
-        $inputsTotal = array_sum(array_map(function (UTXO $utxo) {
+        $inputsTotal = array_sum(array_map(function(UTXO $utxo) {
             return $utxo->value;
         }, $utxos));
         $outputsTotal = array_sum(array_column($outputs, 'value'));
@@ -898,7 +898,7 @@ 
     protected function signTransaction(Transaction $tx, array $signInfo) {
         $signer = new Signer($tx, Bitcoin::getEcAdapter());
 
-        assert(Util::all(function ($signInfo) {
+        assert(Util::all(function($signInfo) {
             return $signInfo instanceof SignInfo;
         }, $signInfo), '$signInfo should be SignInfo[]');
 

src/WalletPath.php

Spacing +1 added lines, -1 removed lines

@@ -31,7 +31,7 @@
     }
 
     protected static function BIP32Path(array $path) {
-        return BIP32Path::path(array_values(array_filter($path, function ($v) {
+        return BIP32Path::path(array_values(array_filter($path, function($v) {
             return $v !== null;
         })));
     }

src/Connection/RestClient.php

Doc Comments +9 added lines

@@ -68,6 +68,11 @@ 
      */
     protected $verboseErrors = false;
 
+    /**
+     * @param string $apiVersion
+     * @param string $apiKey
+     * @param string $apiSecret
+     */
     public function __construct($apiEndpoint, $apiVersion, $apiKey, $apiSecret) {
         $this->apiEndpoint = $apiEndpoint;
         $this->apiVersion = $apiVersion;
@@ -210,6 +215,10 @@ 
     }
 
     private static $replaceQuery = ['=' => '%3D', '&' => '%26'];
+
+    /**
+     * @param string $key
+     */
     public static function hasQueryValue(Uri $uri, $key) {
         $current = $uri->getQuery();
         $key = strtr($key, self::$replaceQuery);

Spacing +4 added lines, -4 removed lines

@@ -101,7 +101,7 @@ 
             'handler' => $handler,
             'base_uri' => $this->apiEndpoint,
             'headers' => array(
-                'User-Agent' => Blocktrail::SDK_USER_AGENT . '/' . Blocktrail::SDK_VERSION
+                'User-Agent' => Blocktrail::SDK_USER_AGENT.'/'.Blocktrail::SDK_VERSION
             ),
             'http_errors' => false,
             'connect_timeout' => 3,
@@ -246,7 +246,7 @@ 
             $contentMD5Mode = !is_null($body) ? 'body' : 'url';
         }
 
-        $request = new Request($method, $this->apiEndpoint . $endpointUrl);
+        $request = new Request($method, $this->apiEndpoint.$endpointUrl);
         $uri = $request->getUri();
 
         if ($queryString) {
@@ -341,9 +341,9 @@ 
                 throw new ObjectNotFound($this->verboseErrors ? $body : Blocktrail::EXCEPTION_OBJECT_NOT_FOUND, $httpResponseCode);
             }
         } elseif ($httpResponseCode == 500) {
-            throw new GenericServerError(Blocktrail::EXCEPTION_GENERIC_SERVER_ERROR . "\nServer Response: " . $body, $httpResponseCode);
+            throw new GenericServerError(Blocktrail::EXCEPTION_GENERIC_SERVER_ERROR."\nServer Response: ".$body, $httpResponseCode);
         } else {
-            throw new GenericHTTPError(Blocktrail::EXCEPTION_GENERIC_HTTP_ERROR . "\nServer Response: " . $body, $httpResponseCode);
+            throw new GenericHTTPError(Blocktrail::EXCEPTION_GENERIC_HTTP_ERROR."\nServer Response: ".$body, $httpResponseCode);
         }
     }
 

src/BackupGenerator.php

Doc Comments +3 added lines

@@ -185,6 +185,9 @@
         return $extraInfo;
     }
 
+    /**
+     * @param string $file
+     */
     public static function renderTemplate($file, $vars) {
         if (is_array($vars) && !empty($vars)) {
             extract($vars);

Spacing +4 added lines, -4 removed lines

@@ -54,11 +54,11 @@ 
             define('DOMPDF_ENABLE_AUTOLOAD', false);
 
             //try the different possible locations for the config file, depending on if the sdk is included as a dependency or is the main project itself
-            (@include_once __DIR__ . '/../../../dompdf/dompdf/dompdf_config.inc.php') || @include_once __DIR__ . '/../vendor/dompdf/dompdf/dompdf_config.inc.php';
+            (@include_once __DIR__.'/../../../dompdf/dompdf/dompdf_config.inc.php') || @include_once __DIR__.'/../vendor/dompdf/dompdf/dompdf_config.inc.php';
         }
 
         //set the fonts path
-        $this->fontsPath = dirname(__FILE__) . '/../resources/fonts';
+        $this->fontsPath = dirname(__FILE__).'/../resources/fonts';
 
         $this->identifier = $identifier;
         $this->backupInfo = $backupInfo;
@@ -80,7 +80,7 @@ 
             $qrCode = new QrCode();
             $qrCode
                 ->setText($key->key())
-                ->setSize(self::QR_CODE_SIZE-20)
+                ->setSize(self::QR_CODE_SIZE - 20)
                 ->setPadding(10)
                 ->setErrorCorrection('high')
                 ->setForegroundColor(array('r' => 0, 'g' => 0, 'b' => 0, 'a' => 0))
@@ -121,7 +121,7 @@ 
             $passwordEncryptedSecret = $this->backupInfo['encrypted_secret'];
         }
 
-        $html = self::renderTemplate(__DIR__ . "/../resources/templates/recovery_sheet.html.php", [
+        $html = self::renderTemplate(__DIR__."/../resources/templates/recovery_sheet.html.php", [
             'identifier' => $this->identifier,
             'totalPubKeys' => $totalPubKeys,
             'pubKeysHtml' => $pubKeysHtml,

src/Bitcoin/BIP32Key.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace Blocktrail\SDK\Bitcoin;
 
-use BitWasp\Bitcoin\Crypto\EcAdapter\Impl\PhpEcc\Key\PublicKey;
 use BitWasp\Bitcoin\Crypto\EcAdapter\Key\PublicKeyInterface;
 use BitWasp\Bitcoin\Key\Deterministic\HierarchicalKey;
 

src/WalletSweeper.php

Doc Comments +7 added lines, -7 removed lines

@@ -115,8 +115,8 @@ 
     /**
      * normalize network string
      *
-     * @param $network
-     * @param $testnet
+     * @param string $network
+     * @param boolean $testnet
      * @return array
      * @throws \Exception
      */
@@ -146,7 +146,7 @@ 
     /**
      * generate multisig address for given path
      *
-     * @param string|BIP32Path $path
+     * @param string $path
      * @return array[string, ScriptInterface]                 [address, redeemScript]
      * @throws \Exception
      */
@@ -165,8 +165,8 @@ 
     /**
      * create a batch of multisig addresses
      *
-     * @param $start
-     * @param $count
+     * @param integer $start
+     * @param integer $count
      * @param $keyIndex
      * @return array
      */
@@ -195,7 +195,7 @@ 
     /**
      * gets the blocktrail pub key for the given path from the stored array of pub keys
      *
-     * @param string|BIP32Path  $path
+     * @param BIP32Path  $path
      * @return BIP32Key
      * @throws \Exception
      */
@@ -312,7 +312,7 @@ 
     }
 
     /**
-     * @param $destinationAddress
+     * @param string $destinationAddress
      * @return TransactionInterface
      */
     protected function createTransaction($destinationAddress) {

Spacing +4 added lines, -4 removed lines

@@ -178,7 +178,7 @@ 
 
         for ($i = 0; $i < $count; $i++) {
             //create a path subsequent address
-            $path = (string)WalletPath::create($keyIndex, $_chain = 0, $start+$i)->path()->publicPath();
+            $path = (string)WalletPath::create($keyIndex, $_chain = 0, $start + $i)->path()->publicPath();
             list($address, $redeem) = $this->createAddress($path);
             $addresses[$address] = array(
                 //'address' => $address,
@@ -226,7 +226,7 @@ 
         $totalUTXOs = 0;
         $totalAddressesGenerated = 0;
 
-        $addressUTXOs = array();    //addresses and their utxos, paths and redeem scripts
+        $addressUTXOs = array(); //addresses and their utxos, paths and redeem scripts
 
         //for each blocktrail pub key, do fund discovery on batches of addresses
         foreach ($this->blocktrailPublicKeys as $keyIndex => $blocktrailPubKey) {
@@ -261,7 +261,7 @@ 
                     }
 
                     $addressUTXOs[$address]['utxos'][] = $utxo;
-                    $totalUTXOs ++;
+                    $totalUTXOs++;
 
                     //add up the total utxo value for all addresses
                     $totalBalance += $utxo['value'];
@@ -375,7 +375,7 @@ 
             $signer->redeemBitcoinCash(true);
         }
 
-        assert(Util::all(function ($signInfo) {
+        assert(Util::all(function($signInfo) {
             return $signInfo instanceof SignInfo;
         }, $signInfo), '$signInfo should be SignInfo[]');