Completed
Push — develop ( 69e1c6...6a0b8a )
by Daniel
08:16
created
services/actions/type/save.php 4 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -300,7 +300,7 @@
 block discarded – undo
300 300
 	/**
301 301
 	 * @param string $field
302 302
 	 * @param array $fields_settings
303
-	 * @param array $fields_options
303
+	 * @param array $field_options
304 304
 	 * @param array $fields_defaults
305 305
 	 * @return array
306 306
 	 */
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@
 block discarded – undo
62 62
 	 * @param string									$phpbb_admin_path       Relative admin root path
63 63
 	 * @param string									$php_ext				php file extension
64 64
 	 * @param boolean									$auto_refresh			Used for testing
65
-	*/
65
+	 */
66 66
 	public function __construct(\phpbb\auth\auth $auth, \phpbb\cache\driver\driver_interface $cache, \phpbb\config\config $config, \phpbb\db\driver\driver_interface $db, \phpbb\language\language $language, \phpbb\request\request_interface $request, \blitze\content\services\types $content_types, \blitze\sitemaker\services\forum\manager $forum_manager, \blitze\content\model\mapper_factory $mapper_factory, $phpbb_admin_path, $php_ext, $auto_refresh = true)
67 67
 	{
68 68
 		$this->auth = $auth;
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 	 * @param \blitze\content\model\entity\type $unsaved_entity
109 109
 	 * @return void
110 110
 	 */
111
-	protected function handle_content_type($type, \blitze\content\model\entity\type &$unsaved_entity)
111
+	protected function handle_content_type($type, \blitze\content\model\entity\type & $unsaved_entity)
112 112
 	{
113 113
 		$forum_perm_from = $this->request->variable('copy_forum_perm', 0);
114 114
 
@@ -187,8 +187,8 @@  discard block
 block discarded – undo
187 187
 	{
188 188
 		if (!$type)
189 189
 		{
190
-			$u_set_permission = append_sid("{$this->phpbb_admin_path}index.$this->php_ext", 'i=permissions&mode=setting_forum_local&forum_id[]=' . $forum_id, true);
191
-			$message = $this->language->lang('CONTENT_TYPE_CREATED', '<a href="' . $u_set_permission . '">', '</a>');
190
+			$u_set_permission = append_sid("{$this->phpbb_admin_path}index.$this->php_ext", 'i=permissions&mode=setting_forum_local&forum_id[]='.$forum_id, true);
191
+			$message = $this->language->lang('CONTENT_TYPE_CREATED', '<a href="'.$u_set_permission.'">', '</a>');
192 192
 		}
193 193
 		else
194 194
 		{
@@ -237,7 +237,7 @@  discard block
 block discarded – undo
237 237
 		if ($old_langname !== $new_langname)
238 238
 		{
239 239
 			$forum_name = $this->language->lang($new_langname);
240
-			$sql = 'UPDATE ' . FORUMS_TABLE . " SET forum_name = '" . $this->db->sql_escape($forum_name) . "' WHERE forum_id = " . (int) $forum_id;
240
+			$sql = 'UPDATE '.FORUMS_TABLE." SET forum_name = '".$this->db->sql_escape($forum_name)."' WHERE forum_id = ".(int) $forum_id;
241 241
 			$this->db->sql_query($sql);
242 242
 		}
243 243
 	}
Please login to merge, or discard this patch.
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -121,8 +121,7 @@  discard block
 block discarded – undo
121 121
 			$unsaved_entity->set_content_id($entity->get_content_id());
122 122
 			$this->handle_langname_change($forum_id, $entity->get_content_langname(), $unsaved_entity->get_content_langname());
123 123
 			$this->copy_forum_permissions($forum_id, $forum_perm_from);
124
-		}
125
-		else
124
+		} else
126 125
 		{
127 126
 			$forum_id = $this->create_content_forum($unsaved_entity->get_content_langname(), $forum_perm_from);
128 127
 			$unsaved_entity->set_forum_id($forum_id);
@@ -189,8 +188,7 @@  discard block
 block discarded – undo
189 188
 		{
190 189
 			$u_set_permission = append_sid("{$this->phpbb_admin_path}index.$this->php_ext", 'i=permissions&mode=setting_forum_local&forum_id[]=' . $forum_id, true);
191 190
 			$message = $this->language->lang('CONTENT_TYPE_CREATED', '<a href="' . $u_set_permission . '">', '</a>');
192
-		}
193
-		else
191
+		} else
194 192
 		{
195 193
 			$this->meta_refresh(3, $u_action);
196 194
 			$message = $this->language->lang('CONTENT_TYPE_UPDATED');
Please login to merge, or discard this patch.
controller/admin_controller.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
 		catch (\blitze\sitemaker\exception\base $e)
48 48
 		{
49 49
 			$message = $e->get_message($this->language);
50
-			trigger_error($this->language->lang($message) . adm_back_link($base_url), E_USER_WARNING);
50
+			trigger_error($this->language->lang($message).adm_back_link($base_url), E_USER_WARNING);
51 51
 		}
52 52
 	}
53 53
 }
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,8 +43,7 @@
 block discarded – undo
43 43
 		{
44 44
 			$command = $this->action_handler->create('type', $action);
45 45
 			$command->execute($base_url, $type);
46
-		}
47
-		catch (\blitze\sitemaker\exception\base $e)
46
+		} catch (\blitze\sitemaker\exception\base $e)
48 47
 		{
49 48
 			$message = $e->get_message($this->language);
50 49
 			trigger_error($this->language->lang($message) . adm_back_link($base_url), E_USER_WARNING);
Please login to merge, or discard this patch.
services/actions/type/delete.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
 	 * @param \blitze\sitemaker\model\mapper_factory	$sitemaker_mapper_factory	Sitemaker Mapper factory object
48 48
 	 * @param bool										$auto_refresh				Used during testing
49 49
 	 * @param bool										$trigger_error				Used during testing
50
-	*/
50
+	 */
51 51
 	public function __construct(\phpbb\cache\driver\driver_interface $cache, \phpbb\language\language $language, \phpbb\request\request_interface $request, \blitze\content\services\types $content_types, \blitze\sitemaker\services\forum\manager $forum_manager, \blitze\content\model\mapper_factory $content_mapper_factory, \blitze\sitemaker\model\mapper_factory $sitemaker_mapper_factory, $auto_refresh = true, $trigger_error = true)
52 52
 	{
53 53
 		$this->cache = $cache;
Please login to merge, or discard this patch.
services/actions/type/add.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
 	 * @param \blitze\sitemaker\services\auto_lang				$auto_lang				Auto add lang file
48 48
 	 * @param \blitze\content\services\form\fields_factory		$fields_factory			Fields factory  object
49 49
 	 * @param \blitze\content\services\views\views_factory		$views_factory			Views factory object
50
-	*/
50
+	 */
51 51
 	public function __construct(\phpbb\auth\auth $auth, \phpbb\language\language $language, \phpbb\template\template $template, \phpbb\user $user, \blitze\sitemaker\services\auto_lang $auto_lang, \blitze\content\services\form\fields_factory $fields_factory, \blitze\content\services\views\views_factory $views_factory)
52 52
 	{
53 53
 		$this->auth = $auth;
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 			'POST_DATE'			=> $this->user->format_date(time()),
78 78
 			'ITEMS_PER_PAGE'	=> 10,
79 79
 			'TOPICS_PER_GROUP'	=> 4,
80
-			'U_ACTION'			=> $u_action . "&amp;do=save&amp;type=$type",
80
+			'U_ACTION'			=> $u_action."&amp;do=save&amp;type=$type",
81 81
 
82 82
 			'S_TYPE_OPS'				=> $this->get_field_options(),
83 83
 			'S_FORUM_OPTIONS'			=> make_forum_select(false, $forum_id, true, false, false),
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
 		$options = '';
116 116
 		foreach ($fields as $field => $object)
117 117
 		{
118
-			$options .= '<option value="' . $field . '">' . $this->language->lang($object->get_langname()) . '</option>';
118
+			$options .= '<option value="'.$field.'">'.$this->language->lang($object->get_langname()).'</option>';
119 119
 		}
120 120
 
121 121
 		return $options;
Please login to merge, or discard this patch.
services/actions/type/edit.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
 	 * @param \blitze\content\services\form\fields_factory		$fields_factory			Fields factory  object
30 30
 	 * @param \blitze\content\model\mapper_factory				$mapper_factory			Mapper factory object
31 31
 	 * @param \blitze\content\services\views\views_factory		$views_factory			Views factory object
32
-	*/
32
+	 */
33 33
 	public function __construct(\phpbb\auth\auth $auth, \phpbb\language\language $language, \phpbb\template\template $template, \phpbb\user $user, \blitze\sitemaker\services\auto_lang $auto_lang, \blitze\content\services\types $content_types, \blitze\content\services\form\fields_factory $fields_factory, \blitze\content\model\mapper_factory $mapper_factory, \blitze\content\services\views\views_factory $views_factory)
34 34
 	{
35 35
 		parent::__construct($auth, $language, $template, $user, $auto_lang, $fields_factory, $views_factory);
Please login to merge, or discard this patch.
services/actions/type/pre_delete.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
 	 * @param \phpbb\language\language					$language			Language Object
29 29
 	 * @param \phpbb\template\template					$template			Template object
30 30
 	 * @param \blitze\content\services\types			$content_types		Content types object
31
-	*/
31
+	 */
32 32
 	public function __construct(\phpbb\language\language $language, \phpbb\template\template $template, \blitze\content\services\types $content_types)
33 33
 	{
34 34
 		$this->language = $language;
Please login to merge, or discard this patch.
services/actions/type/toggle_status.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
 	 * @param \blitze\content\services\types			$content_types			Content types object
31 31
 	 * @param \blitze\content\model\mapper_factory		$mapper_factory			Mapper factory object
32 32
 	 * @param boolean									$redirect				Used for testing
33
-	*/
33
+	 */
34 34
 	public function __construct(\phpbb\cache\driver\driver_interface $cache, \blitze\content\services\types $content_types, \blitze\content\model\mapper_factory $mapper_factory, $redirect = true)
35 35
 	{
36 36
 		$this->cache = $cache;
Please login to merge, or discard this patch.
services/actions/type/index.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
 	 * @param string								$phpbb_root_path		Path to the phpbb includes directory.
45 45
 	 * @param string								$relative_admin_path	Relative admin root path
46 46
 	 * @param string								$php_ext				php file extension
47
-	*/
47
+	 */
48 48
 	public function __construct(\phpbb\controller\helper $controller_helper, \phpbb\language\language $language, \phpbb\template\template $template, \blitze\content\services\types $content_types, $phpbb_root_path, $relative_admin_path, $php_ext)
49 49
 	{
50 50
 		$this->controller_helper = $controller_helper;
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 		$this->template = $template;
53 53
 		$this->content_types = $content_types;
54 54
 		$this->phpbb_root_path = $phpbb_root_path;
55
-		$this->phpbb_admin_path = $this->phpbb_root_path . $relative_admin_path;
55
+		$this->phpbb_admin_path = $this->phpbb_root_path.$relative_admin_path;
56 56
 		$this->php_ext = $php_ext;
57 57
 	}
58 58
 
@@ -75,16 +75,16 @@  discard block
 block discarded – undo
75 75
 				'L_FORUM_PERMS'	=> $this->language->lang('EDIT_FORUM_PERMISSIONS', $langname),
76 76
 				'S_ENABLED'		=> $entity->get_content_enabled(),
77 77
 
78
-				'U_DELETE'		=> $u_action . '&amp;do=pre_delete&amp;type=' . $type,
79
-				'U_EDIT'		=> $u_action . '&amp;do=edit&amp;type=' . $type,
80
-				'U_STATUS'		=> $u_action . '&amp;do=toggle_status&amp;type=' . $type,
78
+				'U_DELETE'		=> $u_action.'&amp;do=pre_delete&amp;type='.$type,
79
+				'U_EDIT'		=> $u_action.'&amp;do=edit&amp;type='.$type,
80
+				'U_STATUS'		=> $u_action.'&amp;do=toggle_status&amp;type='.$type,
81 81
 				'U_VIEW'		=> $this->controller_helper->route('blitze_content_index', array('type' => $type)),
82
-				'U_POST'		=> append_sid("{$this->phpbb_root_path}ucp." . $this->php_ext, "i=-blitze-content-ucp-content_module&amp;mode=content&amp;action=post&amp;type={$type}"),
83
-				'U_GROUP_PERMS'	=> append_sid("{$this->phpbb_admin_path}index." . $this->php_ext, "i=acp_permissions&amp;mode=setting_group_global"),
84
-				'U_FORUM_PERMS'	=> append_sid("{$this->phpbb_admin_path}index." . $this->php_ext, "i=acp_permissions&amp;mode=setting_forum_local&amp;forum_id[]=$forum_id"),
82
+				'U_POST'		=> append_sid("{$this->phpbb_root_path}ucp.".$this->php_ext, "i=-blitze-content-ucp-content_module&amp;mode=content&amp;action=post&amp;type={$type}"),
83
+				'U_GROUP_PERMS'	=> append_sid("{$this->phpbb_admin_path}index.".$this->php_ext, "i=acp_permissions&amp;mode=setting_group_global"),
84
+				'U_FORUM_PERMS'	=> append_sid("{$this->phpbb_admin_path}index.".$this->php_ext, "i=acp_permissions&amp;mode=setting_forum_local&amp;forum_id[]=$forum_id"),
85 85
 			));
86 86
 		}
87 87
 
88
-		$this->template->assign_var('U_ADD_TYPE', $u_action . "&amp;do=add");
88
+		$this->template->assign_var('U_ADD_TYPE', $u_action."&amp;do=add");
89 89
 	}
90 90
 }
Please login to merge, or discard this patch.