blitze / phpBB-ext-sitemaker_content

controller/main_controller.php

Doc Comments -1 removed lines

@@ -93,7 +93,6 @@
 	 * @param string $type
 	 * @param string $slug
 	 * @param int $topic_id
-	 * @param int $page
 	 * @return \Symfony\Component\HttpFoundation\Response A Symfony Response object
 	 */
 	public function show($type, $slug, $topic_id)

Indentation +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
 	 * @param \blitze\content\services\comments				$comments			Comments object
 	 * @param \blitze\content\services\types				$content_types		Content types object
 	 * @param \blitze\content\services\views\views_factory	$views_factory		Views handlers
-	*/
+	 */
 	public function __construct(\phpbb\db\driver\driver_interface $db, \phpbb\controller\helper $helper, \phpbb\request\request_interface $request, \phpbb\template\template $template, \phpbb\user $user, \blitze\content\services\comments $comments, \blitze\content\services\types $content_types, \blitze\content\services\views\views_factory $views_factory)
 	{
 		$this->db = $db;

services/actions/topic/moderate.php

Doc Comments +1 added lines, -1 removed lines

@@ -155,7 +155,7 @@
 	}
 
 	/**
-	 * @param $action
+	 * @param string $action
 	 * @param array $topic_ids
 	 */
 	protected function change_topic_type($action, array $topic_ids)

Spacing +1 added lines, -1 removed lines

@@ -73,7 +73,7 @@
 		}
 		else
 		{
-			$message =  $this->language->lang('INVALID_REQUEST', $action);
+			$message = $this->language->lang('INVALID_REQUEST', $action);
 			trigger_error($message . '<br /><br />' . $this->language->lang('RETURN_PAGE', '<a href="' . $u_action . '">', '</a>'));
 		}
 	}

Braces +2 added lines, -4 removed lines

@@ -70,8 +70,7 @@ 
 		{
 			$forum_ids = $this->get_selected_forum_ids($topic_ids);
 			$this->{$action}($topic_ids, $forum_ids);
-		}
-		else
+		} else
 		{
 			$message =  $this->language->lang('INVALID_REQUEST', $action);
 			trigger_error($message . '<br /><br />' . $this->language->lang('RETURN_PAGE', '<a href="' . $u_action . '">', '</a>'));
@@ -113,8 +112,7 @@ 
 		{
 			$this->approve($topic_ids, $forum_ids, false);
 			\mcp_queue::disapprove_posts($post_id_list, '-blitze-content-mcp-content_module', 'content');
-		}
-		else
+		} else
 		{
 			trigger_error('NO_POST_SELECTED');
 		}

services/builder.php

Doc Comments +1 added lines, -1 removed lines

@@ -88,7 +88,7 @@
 	 * @param int $forum_id
 	 * @param string $mode
 	 * @param bool $save_draft
-	 * @return string|false
+	 * @return string|boolean
 	 */
 	public function init($forum_id, $mode, $save_draft)
 	{

Braces +2 added lines, -4 removed lines

@@ -223,8 +223,7 @@ 
 		if (!$field_data['field_mod_only'] || $this->mode === 'mcp')
 		{
 			$this->form->add($field, $field_data['field_type'], $field_data, $topic_id);
-		}
-		else if (!empty($field_data['field_value']))
+		} else if (!empty($field_data['field_value']))
 		{
 			$this->form->add($field, 'hidden', $field_data, $topic_id);
 		}
@@ -271,8 +270,7 @@ 
 			{
 				$data['force_approved_state'] = $force_status;
 			}
-		}
-		else
+		} else
 		{
 			if ($this->force_state())
 			{

services/comments.php

Doc Comments +5 added lines, -1 removed lines

@@ -64,7 +64,6 @@ 
 	 * @param \phpbb\user								$user				User object
 	 * @param \blitze\content\services\form\form		$form				Form object
 	 * @param \blitze\sitemaker\services\forum\data		$forum				Forum Data object
-	 * @param \blitze\content\services\topic			$topic				Content topic object
 	 * @param string									$root_path			Path to the phpbb includes directory.
 	 * @param string									$php_ext			php file extension
 	*/
@@ -217,6 +216,11 @@ 
 		$this->template->assign_var('POST_FORM', $this->form->get_form());
 	}
 
+	/**
+	 * @param integer $topic_id
+	 * @param integer $total_comments
+	 * @param string $base_url
+	 */
 	protected function build_pagination(&$start, $forum_id, $topic_id, $post_id, $total_comments, $action, $base_url)
 	{
 		if ($post_id && !$action)

Indentation +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
 	 * @param \blitze\content\services\topic			$topic				Content topic object
 	 * @param string									$root_path			Path to the phpbb includes directory.
 	 * @param string									$php_ext			php file extension
-	*/
+	 */
 	public function __construct(\phpbb\auth\auth $auth, \phpbb\config\db $config, \phpbb\content_visibility $content_visibility, \phpbb\db\driver\driver_interface $db, \phpbb\controller\helper $helper, \phpbb\pagination $pagination, \phpbb\request\request_interface $request, \phpbb\template\template $template, \phpbb\user $user, \blitze\content\services\form\form $form, \blitze\sitemaker\services\forum\data $forum, $root_path, $php_ext)
 	{
 		$this->auth = $auth;

Spacing +4 added lines, -4 removed lines

@@ -182,9 +182,9 @@ 
 
 				$poll = array();
 				$uid = $bitfield = $options = '';
-				$allow_bbcode	= ($this->config['allow_bbcode']) ? true : false;
-				$allow_smilies	= ($this->config['allow_smilies']) ? true : false;
-				$allow_urls		= ($this->config['allow_post_links']) ? true : false;
+				$allow_bbcode = ($this->config['allow_bbcode']) ? true : false;
+				$allow_smilies = ($this->config['allow_smilies']) ? true : false;
+				$allow_urls = ($this->config['allow_post_links']) ? true : false;
 
 				generate_text_for_storage($message, $uid, $bitfield, $options, $allow_bbcode, $allow_urls, $allow_smilies);
 
@@ -206,7 +206,7 @@ 
 				submit_post($action, $topic_data['topic_title'], $this->user->data['username'], POST_NORMAL, $poll, $post_data);
 
 				$post_id = $post_data['post_id'];
-				$redirect_url = $current_page . ((strpos($current_page, '?') === false) ? '?' : '&')  . "p=$post_id#p$post_id";
+				$redirect_url = $current_page . ((strpos($current_page, '?') === false) ? '?' : '&') . "p=$post_id#p$post_id";
 				$message = $this->user->lang['COMMENT_POSTED'] . '<br /><br />' . sprintf($this->user->lang['RETURN_PAGE'], '<a href="' . $redirect_url . '">', '</a>');
 
 				meta_refresh(3, $redirect_url);

services/form/field/textarea.php

Doc Comments +4 added lines, -5 removed lines

@@ -75,10 +75,8 @@ 
 	/**
 	 * Display content field
 	 *
-	 * @param string $field_value
 	 * @param string $view_mode
 	 * @param array $topic_data
-	 * @param array $field_data
 	 * @return mixed
 	 */
 	public function display_field($value, $view_mode = 'detail', array $topic_data = array(), array $field = array())
@@ -182,7 +180,7 @@ 
 	 * @param string $value
 	 * @param string $topic_url
 	 * @param string $view_mode
-	 * @return void
+	 * @return string
 	 */
 	protected function generate_field_pages($field_name, $value, $topic_url, $view_mode)
 	{
@@ -212,8 +210,8 @@ 
 	/**
 	 * Generate pagination for topic subpages
 	 *
-	 * @param array $pages
-	 * @param array $page_titles
+	 * @param string[] $pages
+	 * @param string[] $page_titles
 	 * @param int $start
 	 * @param string $topic_url
 	 * @param string $view_mode
@@ -235,6 +233,7 @@ 
 	 *
 	 * @param int $start
 	 * @param $page_titles
+	 * @param string $topic_url
 	 * @return void
 	 */
 	protected function generate_toc($start, $page_titles, $topic_url)

Spacing +1 added lines, -1 removed lines

@@ -160,7 +160,7 @@
 
 		display_custom_bbcodes();
 
-		$bbcode_status	= ($this->config['allow_bbcode'] && $this->auth->acl_get('f_bbcode', $forum_id)) ? true : false;
+		$bbcode_status = ($this->config['allow_bbcode'] && $this->auth->acl_get('f_bbcode', $forum_id)) ? true : false;
 
 		$dataref = $this->template_context->get_data_ref();
 		$this->ptemplate->assign_block_vars_array('custom_tags', (isset($dataref['custom_tags'])) ? $dataref['custom_tags'] : array());

services/types.php

Braces +1 added lines, -2 removed lines

@@ -84,8 +84,7 @@
 			if ($trigger_error)
 			{
 				throw new \blitze\sitemaker\exception\out_of_bounds($type);
-			}
-			else
+			} else
 			{
 				return false;
 			}

services/form/form.php

Braces +2 added lines, -4 removed lines

@@ -206,14 +206,12 @@
 		if (!empty($field_value))
 		{
 			$this->errors[] = $obj->validate_field($row);
-		}
-		else if ($row['field_required'])
+		} else if ($row['field_required'])
 		{
 			if (!$row['field_mod_only'] || $cp_class === 'mcp')
 			{
 				$this->errors[] = $this->language->lang_array('FIELD_REQUIRED', array($row['field_label']));
-			}
-			else
+			} else
 			{
 				$req_mod_input = true;
 			}

services/form/field/checkbox.php

Spacing +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
 	public function get_field_value($name, $default)
 	{
 		$default = is_array($default) ? $default : explode("\n", $default);
-		$value =  $this->request->variable($name, $default, true);
+		$value = $this->request->variable($name, $default, true);
 
 		if (empty($value) && $this->request->server('REQUEST_METHOD') !== 'POST')
 		{

services/form/field/choice.php

Spacing +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
 		foreach ($data['field_settings']['field_options'] as $value => $label)
 		{
 			$this->ptemplate->assign_block_vars('option', array(
-				'ID'		=> 'field-'. $name . '-' . $count,
+				'ID'		=> 'field-' . $name . '-' . $count,
 				'LABEL'		=> $this->language->lang($label),
 				'SELECTED'	=> (in_array($value, $selected, true)) ? true : false,
 				'VALUE'		=> $value