blitze / phpBB-ext-sitemaker

model/menus/entity/item.php

Doc Comments +1 added lines, -1 removed lines

@@ -185,7 +185,7 @@
 	 * Checks if a url is an extension route
 	 *
 	 * @param string $item_url
-	 * @return true|false
+	 * @return boolean
 	 */
 	private function is_extension_route($item_url)
 	{

Spacing +4 added lines, -4 removed lines

@@ -136,7 +136,7 @@ 
 	 */
 	public function set_item_icon($icon)
 	{
-		$this->item_icon = ($icon) ? trim($icon) . ' ' : '';
+		$this->item_icon = ($icon) ? trim($icon).' ' : '';
 		return $this;
 	}
 
@@ -153,7 +153,7 @@ 
 		// add leading / for local paths, except leading hashtags
 		if ($this->is_local($this->item_url) && $this->item_url[0] !== '#')
 		{
-			$this->item_url = '/' . ltrim($this->item_url, './');
+			$this->item_url = '/'.ltrim($this->item_url, './');
 		}
 
 		return $this;
@@ -168,7 +168,7 @@ 
 
 		if ($this->is_local($item_url) && $item_url[0] === '/')
 		{
-			$item_url = $this->board_url . $item_url;
+			$item_url = $this->board_url.$item_url;
 			if ($this->mod_rewrite_enabled)
 			{
 				$item_url = str_replace('app.php/', '', $item_url);
@@ -185,6 +185,6 @@ 
 	private function is_local($item_url)
 	{
 		$host = parse_url($item_url, PHP_URL_HOST);
-		return (!$item_url || $host || substr($item_url, 0, 2) === '//') ? false: true;
+		return (!$item_url || $host || substr($item_url, 0, 2) === '//') ? false : true;
 	}
 }

services/menus/display.php

Spacing +7 added lines, -7 removed lines

@@ -70,7 +70,7 @@ 
 	 * @param string $handle
 	 * @return void
 	 */
-	public function display_navlist(array $data, \phpbb\template\twig\twig &$template, $handle = 'tree')
+	public function display_navlist(array $data, \phpbb\template\twig\twig & $template, $handle = 'tree')
 	{
 		$this->prepare_items($data);
 
@@ -84,10 +84,10 @@ 
 				$row['num_kids'] = $this->count_descendants($row);
 
 				$template->assign_block_vars($handle, array_change_key_case($row, CASE_UPPER));
-				$this->close_open_tags($template, $handle . '.close', abs($prev_depth - $this_depth));
+				$this->close_open_tags($template, $handle.'.close', abs($prev_depth - $this_depth));
 			}
 
-			$this->close_open_tags($template, 'close_' . $handle, ($this_depth - $this->min_depth));
+			$this->close_open_tags($template, 'close_'.$handle, ($this_depth - $this->min_depth));
 		}
 	}
 
@@ -126,7 +126,7 @@ 
 			}
 
 			$is_current_item = $this->is_current_item($row);
-			$this_depth	= $this->parental_depth[$row['parent_id']] + 1;
+			$this_depth = $this->parental_depth[$row['parent_id']] + 1;
 			$leaf = $this->get_leaf_node($row, $is_current_item);
 
 			$this->parental_depth[$row[$this->pk]] = $this_depth;
@@ -155,8 +155,8 @@ 
 	 */
 	protected function set_current_item(array $data)
 	{
-		$curr_page = '/' . ltrim($this->user->page['page_dir'] . '/' . $this->user->page['page_name'], './');
-		$curr_page = str_replace('/index.' . $this->php_ext, '/', $curr_page);
+		$curr_page = '/'.ltrim($this->user->page['page_dir'].'/'.$this->user->page['page_name'], './');
+		$curr_page = str_replace('/index.'.$this->php_ext, '/', $curr_page);
 		$curr_parts = explode('&', $this->user->page['query_string']);
 
 		$data = array_values($data);
@@ -239,7 +239,7 @@ 
 	 * @param int $repeat
 	 * @return void
 	 */
-	protected function close_open_tags(\phpbb\template\twig\twig &$template, $handle, $repeat)
+	protected function close_open_tags(\phpbb\template\twig\twig & $template, $handle, $repeat)
 	{
 		for ($i = 0; $i < $repeat; $i++)
 		{

services/menus/menu_block.php

Spacing +1 added lines, -1 removed lines

@@ -124,7 +124,7 @@
 	{
 		$row['is_navigable'] = $this->is_navigable($row);
 		$row['is_expandable'] = ($row['is_navigable'] && !$row['item_target']) ? true : false;
-		$row['url_path'] = str_replace('/index.' . $this->php_ext, '/', $row['url_path']);
+		$row['url_path'] = str_replace('/index.'.$this->php_ext, '/', $row['url_path']);
 	}
 
 	/**

services/blocks/display.php

Spacing +3 added lines, -3 removed lines

@@ -68,7 +68,7 @@ 
 
 			$edit_mode = $this->toggle_edit_mode();
 			$style_id = $this->get_style_id();
-			$current_route = ltrim($this->user->page['page_dir'] . '/' . $this->user->page['page_name'], './');
+			$current_route = ltrim($this->user->page['page_dir'].'/'.$this->user->page['page_name'], './');
 			$route_info = $blocks->get_route_info($current_route, $this->user->page['page_dir'], $style_id, $edit_mode);
 
 			$display_modes = $this->get_display_modes($route_info['is_sub_route']);
@@ -114,7 +114,7 @@ 
 	 */
 	protected function toggle_edit_mode()
 	{
-		$edit_mode = $this->request->variable($this->config['cookie_name'] . '_sm_edit_mode', false, false, \phpbb\request\request_interface::COOKIE);
+		$edit_mode = $this->request->variable($this->config['cookie_name'].'_sm_edit_mode', false, false, \phpbb\request\request_interface::COOKIE);
 
 		if ($this->request->is_set('edit_mode'))
 		{
@@ -170,7 +170,7 @@ 
 				);
 			}
 
-			$u_edit_mode = append_sid(generate_board_url() . '/' . ltrim(rtrim(build_url(array('edit_mode', 'sid', 'style')), '?'), './../'), 'edit_mode=' . (int) !$edit_mode);
+			$u_edit_mode = append_sid(generate_board_url().'/'.ltrim(rtrim(build_url(array('edit_mode', 'sid', 'style')), '?'), './../'), 'edit_mode='.(int) !$edit_mode);
 		}
 		else
 		{

services/blocks/routes.php

Spacing +3 added lines, -3 removed lines

@@ -175,12 +175,12 @@
 	{
 		if ($page_dir)
 		{
-			$route = ltrim(dirname($page_dir) . '/index.php', './');
+			$route = ltrim(dirname($page_dir).'/index.php', './');
 			$parent_route = $this->get_parent_route_info($routes, $route);
 		}
-		else if ($current_route === 'viewtopic.' . $this->php_ext)
+		else if ($current_route === 'viewtopic.'.$this->php_ext)
 		{
-			$route = 'viewforum.' . $this->php_ext;
+			$route = 'viewforum.'.$this->php_ext;
 			$parent_route = $this->get_parent_route_info($routes, $route);
 		}
 		else

Braces +2 added lines, -4 removed lines

@@ -177,13 +177,11 @@
 		{
 			$route = ltrim(dirname($page_dir) . '/index.php', './');
 			$parent_route = $this->get_parent_route_info($routes, $route);
-		}
-		else if ($current_route === 'viewtopic.' . $this->php_ext)
+		} else if ($current_route === 'viewtopic.' . $this->php_ext)
 		{
 			$route = 'viewforum.' . $this->php_ext;
 			$parent_route = $this->get_parent_route_info($routes, $route);
-		}
-		else
+		} else
 		{
 			$parent_route = $this->get_virtual_parent($routes, $current_route);
 		}

services/blocks/cfg_fields.php

Spacing +9 added lines, -9 removed lines

@@ -34,11 +34,11 @@ 
 	 */
 	public function build_select($option_ary, $selected_item, $key)
 	{
-		$html = '<select id="' . $key . '" name="config[' . $key . ']">';
+		$html = '<select id="'.$key.'" name="config['.$key.']">';
 		foreach ($option_ary as $value => $title)
 		{
 			$selected = ($value == $selected_item) ? ' selected="selected"' : '';
-			$html .= '<option value="' . $value . '"' . $selected . '>' . $this->translator->lang($title) . '</option>';
+			$html .= '<option value="'.$value.'"'.$selected.'>'.$this->translator->lang($title).'</option>';
 		}
 		$html .= '</select>';
 
@@ -57,11 +57,11 @@ 
 	{
 		$selected_items = $this->ensure_array($selected_items);
 
-		$html = '<select id="' . $field . '" name="config[' . $field . '][]" multiple="multiple">';
+		$html = '<select id="'.$field.'" name="config['.$field.'][]" multiple="multiple">';
 		foreach ($option_ary as $value => $title)
 		{
 			$selected = $this->get_selected_option($value, $selected_items);
-			$html .= '<option value="' . $value . '"' . $selected . '>' . $this->translator->lang($title) . '</option>';
+			$html .= '<option value="'.$value.'"'.$selected.'>'.$this->translator->lang($title).'</option>';
 		}
 		$html .= '</select>';
 
@@ -120,7 +120,7 @@ 
 		foreach ($option_ary as $value => $title)
 		{
 			$selected = $this->get_selected_option($value, $selected_item, 'checked');
-			$html .= '<label><input type="radio" name="config[' . $key . ']" value="' . $value . '"' . $selected . ' class="radio" /> ' . $this->translator->lang($title) . '</label><br />';
+			$html .= '<label><input type="radio" name="config['.$key.']" value="'.$value.'"'.$selected.' class="radio" /> '.$this->translator->lang($title).'</label><br />';
 		}
 
 		return $html;
@@ -135,7 +135,7 @@ 
 	 */
 	public function build_hidden($value, $field)
 	{
-		return '<input type="hidden" name="config[' . $field . ']" value="' . $value . '" />';
+		return '<input type="hidden" name="config['.$field.']" value="'.$value.'" />';
 	}
 
 	/**
@@ -175,7 +175,7 @@ 
 	 */
 	protected function get_selected_option($needle, array $haystack, $type = 'selected')
 	{
-		return (in_array($needle, $haystack)) ? ' ' . $type . '="' . $type . '"' : '';
+		return (in_array($needle, $haystack)) ? ' '.$type.'="'.$type.'"' : '';
 	}
 
 	/**
@@ -189,12 +189,12 @@ 
 	 */
 	protected function get_checkbox_column(array $row, array $selected_items, $field, $column_class, $column_count, &$index)
 	{
-		$column = '<div class="' . $column_class . $field . '-checkbox" id="' . $field . '-col-' . $column_count . '">';
+		$column = '<div class="'.$column_class.$field.'-checkbox" id="'.$field.'-col-'.$column_count.'">';
 		foreach ($row as $value => $title)
 		{
 			$title = $this->translator->lang($title);
 			$selected = $this->get_selected_option($value, $selected_items, 'checked');
-			$column .= '<label><input type="checkbox" name="config[' . $field . '][' . $index . ']" value="' . $value . '"' . $selected . ' class="checkbox" /> ' . $title . '</label><br />';
+			$column .= '<label><input type="checkbox" name="config['.$field.']['.$index.']" value="'.$value.'"'.$selected.' class="checkbox" /> '.$title.'</label><br />';
 			$index++;
 		}
 		$column .= '</div>';

services/blocks/cfg_handler.php

Spacing +5 added lines, -5 removed lines

@@ -61,7 +61,7 @@ 
 		// @codeCoverageIgnoreStart
 		if (!function_exists('build_cfg_template'))
 		{
-			include($this->phpbb_root_path . 'includes/functions_acp.' . $this->php_ext);
+			include($this->phpbb_root_path.'includes/functions_acp.'.$this->php_ext);
 		}
 		// @codeCoverageIgnoreEnd
 
@@ -100,7 +100,7 @@ 
 		// @codeCoverageIgnoreStart
 		if (!function_exists('validate_config_vars'))
 		{
-			include($this->phpbb_root_path . 'includes/functions_acp.' . $this->php_ext);
+			include($this->phpbb_root_path.'includes/functions_acp.'.$this->php_ext);
 		}
 		// @codeCoverageIgnoreEnd
 
@@ -203,7 +203,7 @@ 
 		if (empty($vars['object']))
 		{
 			$object = $this;
-			$method = 'prep_' . $type[0] . '_field_for_display';
+			$method = 'prep_'.$type[0].'_field_for_display';
 
 			if (is_callable(array($this, $method)))
 			{
@@ -257,7 +257,7 @@ 
 		$l_explain = '';
 		if (!empty($vars['explain']))
 		{
-			$l_explain = (isset($vars['lang_explain'])) ? $this->translator->lang($vars['lang_explain']) : $this->translator->lang($vars['lang'] . '_EXPLAIN');
+			$l_explain = (isset($vars['lang_explain'])) ? $this->translator->lang($vars['lang_explain']) : $this->translator->lang($vars['lang'].'_EXPLAIN');
 		}
 
 		return $l_explain;
@@ -357,7 +357,7 @@ 
 	{
 		$this->prep_checkbox_field_for_display($vars, $type, $field);
 
-		$vars['method'] ='build_multi_select';
+		$vars['method'] = 'build_multi_select';
 	}
 
 	/**