Completed
Pull Request — master (#82)
by Jesus
02:02
created
classes/output/mobile.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,6 @@
 block discarded – undo
28 28
 defined('MOODLE_INTERNAL') || die();
29 29
 
30 30
 use context_module;
31
-use mod_bigbluebuttonbn_external;
32 31
 require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
33 32
 
34 33
 /**
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 
55 55
         global $OUTPUT, $SESSION, $CFG;
56 56
 
57
-        $args = (object) $args;
57
+        $args = (object)$args;
58 58
         $viewinstance = bigbluebuttonbn_view_validator($args->cmid, null);
59 59
         if (!$viewinstance) {
60 60
             $error = get_string('view_error_url_missing_parameters', 'bigbluebuttonbn');
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
         $bigbluebuttonbn = $viewinstance['bigbluebuttonbn'];
67 67
         $context = context_module::instance($cm->id);
68 68
 
69
-        require_login($course->id, false , $cm, true, true);
69
+        require_login($course->id, false, $cm, true, true);
70 70
         require_capability('mod/bigbluebuttonbn:join', $context);
71 71
 
72 72
         // Add view event.
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 
112 112
         // Check if the BBB server is working.
113 113
         $serverversion = bigbluebuttonbn_get_server_version();
114
-        $bbbsession['serverversion'] = (string) $serverversion;
114
+        $bbbsession['serverversion'] = (string)$serverversion;
115 115
         if (is_null($serverversion)) {
116 116
 
117 117
             if ($bbbsession['administrator']) {
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
 
139 139
         // Operation URLs.
140 140
         $bbbsession['bigbluebuttonbnURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/view.php?id=' . $bbbsession['cm']->id;
141
-        $bbbsession['logoutURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_view.php?action=logout&id='.$args->cmid .
141
+        $bbbsession['logoutURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_view.php?action=logout&id=' . $args->cmid .
142 142
             '&bn=' . $bbbsession['bigbluebuttonbn']->id;
143 143
         $bbbsession['recordingReadyURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_broker.php?action=recording_' .
144 144
             'ready&bigbluebuttonbn=' . $bbbsession['bigbluebuttonbn']->id;
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
             }
182 182
             if ($response['returncode'] == 'FAILED') {
183 183
                 // The meeting could not be created.
184
-                $errorkey = bigbluebuttonbn_get_error_key($response['messageKey'],  'view_error_create');
184
+                $errorkey = bigbluebuttonbn_get_error_key($response['messageKey'], 'view_error_create');
185 185
                 $e = get_string($errorkey, 'bigbluebuttonbn');
186 186
                 return(self::mobile_print_error($e));
187 187
             }
@@ -194,7 +194,7 @@  discard block
 block discarded – undo
194 194
             bigbluebuttonbn_event_log(\mod_bigbluebuttonbn\event\events::$events['meeting_create'], $bigbluebuttonbn);
195 195
             // Insert a record that meeting was created.
196 196
             $overrides = array('meetingid' => $bbbsession['meetingid']);
197
-            $meta = '{"record":'.($bbbsession['record'] ? 'true' : 'false').'}';
197
+            $meta = '{"record":' . ($bbbsession['record'] ? 'true' : 'false') . '}';
198 198
             bigbluebuttonbn_log($bbbsession['bigbluebuttonbn'], BIGBLUEBUTTONBN_LOG_EVENT_CREATE, $overrides, $meta);
199 199
         }
200 200
 
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
 
213 213
         $data = array(
214 214
             'bigbluebuttonbn' => $bigbluebuttonbn,
215
-            'bbbsession' => (object) $bbbsession,
215
+            'bbbsession' => (object)$bbbsession,
216 216
             'urltojoin' => $urltojoin,
217 217
             'cmid' => $cm->id,
218 218
             'courseid' => $args->courseid
Please login to merge, or discard this patch.
classes/locallib/mobileview.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
         $session['importrecordings'] = ($session['managerecordings']);
59 59
         $session['modPW'] = $session['bigbluebuttonbn']->moderatorpass;
60 60
         $session['viewerPW'] = $session['bigbluebuttonbn']->viewerpass;
61
-        $session['meetingid'] = $session['bigbluebuttonbn']->meetingid.'-'.$session['course']->id.'-'.
61
+        $session['meetingid'] = $session['bigbluebuttonbn']->meetingid . '-' . $session['course']->id . '-' .
62 62
             $session['bigbluebuttonbn']->id;
63 63
         $session['meetingname'] = $session['bigbluebuttonbn']->name;
64 64
         $session['meetingdescription'] = $session['bigbluebuttonbn']->intro;
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
             $session['welcome'] = get_string('mod_form_field_welcome_default', 'bigbluebuttonbn');
78 78
         }
79 79
         if ($session['bigbluebuttonbn']->record) {
80
-            $session['welcome'] .= '<br><br>'.get_string('bbbrecordwarning', 'bigbluebuttonbn');
80
+            $session['welcome'] .= '<br><br>' . get_string('bbbrecordwarning', 'bigbluebuttonbn');
81 81
         }
82 82
         $session['openingtime'] = $session['bigbluebuttonbn']->openingtime;
83 83
         $session['closingtime'] = $session['bigbluebuttonbn']->closingtime;
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
         $session['originServerName'] = $parsedurl['host'];
89 89
         $session['originServerUrl'] = $CFG->wwwroot;
90 90
         $session['originServerCommonName'] = '';
91
-        $session['originTag'] = 'moodle-mod_bigbluebuttonbn ('.get_config('mod_bigbluebuttonbn', 'version').')';
91
+        $session['originTag'] = 'moodle-mod_bigbluebuttonbn (' . get_config('mod_bigbluebuttonbn', 'version') . ')';
92 92
         $session['bnserver'] = bigbluebuttonbn_is_bn_server();
93 93
         $session['clienttype'] = \mod_bigbluebuttonbn\locallib\config::get('clienttype_default');
94 94
 
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
             $data['welcome'] .= '<br><br>';
202 202
             $data['welcome'] .= str_replace(
203 203
                 '%duration%',
204
-                (string) $durationtime,
204
+                (string)$durationtime,
205 205
                 get_string('bbbdurationwarning', 'bigbluebuttonbn')
206 206
             );
207 207
         }
Please login to merge, or discard this patch.