@@ -326,7 +326,7 @@ discard block  | 
                                                    ||
| 326 | 326 | * Helper function to retrieve imported recordings from the Moodle database.  | 
                                                        
| 327 | 327 | * The references are stored as events in bigbluebuttonbn_logs.  | 
                                                        
| 328 | 328 | *  | 
                                                        
| 329 | - * @param string $courseid  | 
                                                        |
| 329 | + * @param integer $courseid  | 
                                                        |
| 330 | 330 | * @param string $bigbluebuttonbnid  | 
                                                        
| 331 | 331 | * @param bool $subset  | 
                                                        
| 332 | 332 | *  | 
                                                        
@@ -354,7 +354,7 @@ discard block  | 
                                                    ||
| 354 | 354 | /**  | 
                                                        
| 355 | 355 | * Helper function to retrive the default config.xml file.  | 
                                                        
| 356 | 356 | *  | 
                                                        
| 357 | - * @return string  | 
                                                        |
| 357 | + * @return null|SimpleXMLElement  | 
                                                        |
| 358 | 358 | */  | 
                                                        
| 359 | 359 |  function bigbluebuttonbn_get_default_config_xml() { | 
                                                        
| 360 | 360 | $xml = bigbluebuttonbn_wrap_xml_load_file(  | 
                                                        
@@ -436,7 +436,7 @@ discard block  | 
                                                    ||
| 436 | 436 | * @param object $a  | 
                                                        
| 437 | 437 | * @param object $b  | 
                                                        
| 438 | 438 | *  | 
                                                        
| 439 | - * @return array  | 
                                                        |
| 439 | + * @return integer  | 
                                                        |
| 440 | 440 | */  | 
                                                        
| 441 | 441 |  function bigbluebuttonbn_recording_build_sorter($a, $b) { | 
                                                        
| 442 | 442 | global $CFG;  | 
                                                        
@@ -550,7 +550,7 @@ discard block  | 
                                                    ||
| 550 | 550 | * @param string $data  | 
                                                        
| 551 | 551 | * @param string $contenttype  | 
                                                        
| 552 | 552 | *  | 
                                                        
| 553 | - * @return object  | 
                                                        |
| 553 | + * @return null|SimpleXMLElement  | 
                                                        |
| 554 | 554 | */  | 
                                                        
| 555 | 555 |  function bigbluebuttonbn_wrap_xml_load_file($url, $method = 'GET', $data = null, $contenttype = 'text/xml') { | 
                                                        
| 556 | 556 |      if (extension_loaded('curl')) { | 
                                                        
@@ -591,7 +591,7 @@ discard block  | 
                                                    ||
| 591 | 591 | * @param string $data  | 
                                                        
| 592 | 592 | * @param string $contenttype  | 
                                                        
| 593 | 593 | *  | 
                                                        
| 594 | - * @return object  | 
                                                        |
| 594 | + * @return string  | 
                                                        |
| 595 | 595 | */  | 
                                                        
| 596 | 596 |  function bigbluebuttonbn_wrap_xml_load_file_curl_request($url, $method = 'GET', $data = null, $contenttype = 'text/xml') { | 
                                                        
| 597 | 597 | global $CFG;  | 
                                                        
@@ -1008,7 +1008,7 @@ discard block  | 
                                                    ||
| 1008 | 1008 | * @param integer $instance  | 
                                                        
| 1009 | 1009 | * @param integer $voicebridge  | 
                                                        
| 1010 | 1010 | *  | 
                                                        
| 1011 | - * @return string  | 
                                                        |
| 1011 | + * @return boolean  | 
                                                        |
| 1012 | 1012 | */  | 
                                                        
| 1013 | 1013 |  function bigbluebuttonbn_voicebridge_unique($instance, $voicebridge) { | 
                                                        
| 1014 | 1014 | global $DB;  | 
                                                        
@@ -1355,9 +1355,8 @@ discard block  | 
                                                    ||
| 1355 | 1355 | *  | 
                                                        
| 1356 | 1356 | * @param string $meetingid  | 
                                                        
| 1357 | 1357 | * @param string $configxml  | 
                                                        
| 1358 | - * @param string $server  | 
                                                        |
| 1359 | 1358 | *  | 
                                                        
| 1360 | - * @return object  | 
                                                        |
| 1359 | + * @return null|SimpleXMLElement  | 
                                                        |
| 1361 | 1360 | */  | 
                                                        
| 1362 | 1361 |  function bigbluebuttonbn_set_config_xml($meetingid, $configxml) { | 
                                                        
| 1363 | 1362 |      $urldefaultconfig = \mod_bigbluebuttonbn\locallib\config::get('server_url') . 'api/setConfigXML?'; | 
                                                        
@@ -1376,7 +1375,6 @@ discard block  | 
                                                    ||
| 1376 | 1375 | *  | 
                                                        
| 1377 | 1376 | * @param string $meetingid  | 
                                                        
| 1378 | 1377 | * @param string $configxml  | 
                                                        
| 1379 | - * @param string $server  | 
                                                        |
| 1380 | 1378 | *  | 
                                                        
| 1381 | 1379 | * @return string  | 
                                                        
| 1382 | 1380 | */  | 
                                                        
@@ -1412,7 +1410,7 @@ discard block  | 
                                                    ||
| 1412 | 1410 | * @param array $recording  | 
                                                        
| 1413 | 1411 | * @param array $tools  | 
                                                        
| 1414 | 1412 | *  | 
                                                        
| 1415 | - * @return array  | 
                                                        |
| 1413 | + * @return null|stdClass  | 
                                                        |
| 1416 | 1414 | */  | 
                                                        
| 1417 | 1415 |  function bigbluebuttonbn_get_recording_data_row($bbbsession, $recording, $tools = ['protect', 'publish', 'delete']) { | 
                                                        
| 1418 | 1416 |      if (!bigbluebuttonbn_include_recording_table_row($bbbsession, $recording)) { | 
                                                        
@@ -1996,7 +1994,7 @@ discard block  | 
                                                    ||
| 1996 | 1994 | *  | 
                                                        
| 1997 | 1995 | * @param array $bbbsession  | 
                                                        
| 1998 | 1996 | * @param array $recording  | 
                                                        
| 1999 | - * @param object $rowdata  | 
                                                        |
| 1997 | + * @param stdClass $rowdata  | 
                                                        |
| 2000 | 1998 | *  | 
                                                        
| 2001 | 1999 | * @return object  | 
                                                        
| 2002 | 2000 | */  | 
                                                        
@@ -2226,7 +2224,7 @@ discard block  | 
                                                    ||
| 2226 | 2224 | *  | 
                                                        
| 2227 | 2225 | * @param array $bbbsession  | 
                                                        
| 2228 | 2226 | * @param array $recordings  | 
                                                        
| 2229 | - * @param array $tools  | 
                                                        |
| 2227 | + * @param string[] $tools  | 
                                                        |
| 2230 | 2228 | *  | 
                                                        
| 2231 | 2229 | * @return array  | 
                                                        
| 2232 | 2230 | */  | 
                                                        
@@ -2307,7 +2305,7 @@ discard block  | 
                                                    ||
| 2307 | 2305 | * Helper function to define the sql used for gattering the bigbluebuttonbnids whose meetingids should be included  | 
                                                        
| 2308 | 2306 | * in the getRecordings request considering only those that belong to deleted activities.  | 
                                                        
| 2309 | 2307 | *  | 
                                                        
| 2310 | - * @param string $courseid  | 
                                                        |
| 2308 | + * @param integer $courseid  | 
                                                        |
| 2311 | 2309 | * @param string $bigbluebuttonbnid  | 
                                                        
| 2312 | 2310 | * @param bool $subset  | 
                                                        
| 2313 | 2311 | *  | 
                                                        
@@ -2331,7 +2329,7 @@ discard block  | 
                                                    ||
| 2331 | 2329 | * Helper function to define the sql used for gattering the bigbluebuttonbnids whose meetingids should be included  | 
                                                        
| 2332 | 2330 | * in the getRecordings request considering only those that belong to imported recordings.  | 
                                                        
| 2333 | 2331 | *  | 
                                                        
| 2334 | - * @param string $courseid  | 
                                                        |
| 2332 | + * @param integer $courseid  | 
                                                        |
| 2335 | 2333 | * @param string $bigbluebuttonbnid  | 
                                                        
| 2336 | 2334 | * @param bool $subset  | 
                                                        
| 2337 | 2335 | *  | 
                                                        
@@ -2354,7 +2352,7 @@ discard block  | 
                                                    ||
| 2354 | 2352 | /**  | 
                                                        
| 2355 | 2353 | * Helper function to get recordings and imported recordings together.  | 
                                                        
| 2356 | 2354 | *  | 
                                                        
| 2357 | - * @param string $courseid  | 
                                                        |
| 2355 | + * @param integer $courseid  | 
                                                        |
| 2358 | 2356 | * @param string $bigbluebuttonbnid  | 
                                                        
| 2359 | 2357 | * @param bool $subset  | 
                                                        
| 2360 | 2358 | * @param bool $includedeleted  | 
                                                        
@@ -2372,7 +2370,7 @@ discard block  | 
                                                    ||
| 2372 | 2370 | * Helper function to retrieve recordings from the BigBlueButton. The references are stored as events  | 
                                                        
| 2373 | 2371 | * in bigbluebuttonbn_logs.  | 
                                                        
| 2374 | 2372 | *  | 
                                                        
| 2375 | - * @param string $courseid  | 
                                                        |
| 2373 | + * @param integer $courseid  | 
                                                        |
| 2376 | 2374 | * @param string $bigbluebuttonbnid  | 
                                                        
| 2377 | 2375 | * @param bool $subset  | 
                                                        
| 2378 | 2376 | * @param bool $includedeleted  | 
                                                        
@@ -28,7 +28,7 @@  | 
                                                    ||
| 28 | 28 | |
| 29 | 29 | global $CFG, $PAGE;  | 
                                                        
| 30 | 30 | |
| 31 | -require_once(__DIR__.'/locallib.php');  | 
                                                        |
| 31 | +require_once(__DIR__ . '/locallib.php');  | 
                                                        |
| 32 | 32 | |
| 33 | 33 |  if ($hassiteconfig) { | 
                                                        
| 34 | 34 | // Configuration for BigBlueButton.  | 
                                                        
@@ -26,8 +26,8 @@ discard block  | 
                                                    ||
| 26 | 26 | |
| 27 | 27 |  defined('MOODLE_INTERNAL') || die(); | 
                                                        
| 28 | 28 | |
| 29 | -require_once(dirname(__FILE__).'/locallib.php');  | 
                                                        |
| 30 | -require_once($CFG->dirroot.'/course/moodleform_mod.php');  | 
                                                        |
| 29 | +require_once(dirname(__FILE__) . '/locallib.php');  | 
                                                        |
| 30 | +require_once($CFG->dirroot . '/course/moodleform_mod.php');  | 
                                                        |
| 31 | 31 | |
| 32 | 32 | /**  | 
                                                        
| 33 | 33 | * Moodle class for mod_form.  | 
                                                        
@@ -51,7 +51,7 @@ discard block  | 
                                                    ||
| 51 | 51 | $serverversion = bigbluebuttonbn_get_server_version();  | 
                                                        
| 52 | 52 |          if (is_null($serverversion)) { | 
                                                        
| 53 | 53 |              print_error('general_error_unable_connect', 'bigbluebuttonbn', | 
                                                        
| 54 | - $CFG->wwwroot.'/admin/settings.php?section=modsettingbigbluebuttonbn');  | 
                                                        |
| 54 | + $CFG->wwwroot . '/admin/settings.php?section=modsettingbigbluebuttonbn');  | 
                                                        |
| 55 | 55 | return;  | 
                                                        
| 56 | 56 | }  | 
                                                        
| 57 | 57 | $bigbluebuttonbn = null;  | 
                                                        
@@ -81,7 +81,7 @@ discard block  | 
                                                    ||
| 81 | 81 | // If still none is allowed, fail and return.  | 
                                                        
| 82 | 82 |              if (empty($jsvars['instanceTypeProfiles'])) { | 
                                                        
| 83 | 83 |                  print_error('general_error_not_allowed_to_create_instances)', 'bigbluebuttonbn', | 
                                                        
| 84 | - $CFG->wwwroot.'/admin/settings.php?section=modsettingbigbluebuttonbn');  | 
                                                        |
| 84 | + $CFG->wwwroot . '/admin/settings.php?section=modsettingbigbluebuttonbn');  | 
                                                        |
| 85 | 85 | return;  | 
                                                        
| 86 | 86 | }  | 
                                                        
| 87 | 87 | }  | 
                                                        
@@ -144,7 +144,7 @@ discard block  | 
                                                    ||
| 144 | 144 | );  | 
                                                        
| 145 | 145 | $defaultvalues['presentation'] = $draftitemid;  | 
                                                        
| 146 | 146 |              } catch (Exception $e) { | 
                                                        
| 147 | -                debugging('Presentation could not be loaded: '.$e->getMessage(), DEBUG_DEVELOPER); | 
                                                        |
| 147 | +                debugging('Presentation could not be loaded: ' . $e->getMessage(), DEBUG_DEVELOPER); | 
                                                        |
| 148 | 148 | return;  | 
                                                        
| 149 | 149 | }  | 
                                                        
| 150 | 150 | // Completion: tick if completion attendance settings is set to 1 or more.  | 
                                                        
@@ -295,22 +295,22 @@ discard block  | 
                                                    ||
| 295 | 295 | }  | 
                                                        
| 296 | 296 | }  | 
                                                        
| 297 | 297 | |
| 298 | - $connectedUsersBlock = '<div id="fitem_id_total_connected_users" class="form-group row fitem">'.  | 
                                                        |
| 299 | - '<div class="col-md-3">'.  | 
                                                        |
| 300 | - '<span class="float-sm-right text-nowrap">'.  | 
                                                        |
| 301 | - '</span>'.  | 
                                                        |
| 302 | - '<label class="col-form-label d-inline " for="id_total_connected_users">'.  | 
                                                        |
| 303 | - 'Connected Users'.  | 
                                                        |
| 304 | - '</label>'.  | 
                                                        |
| 305 | - '</div>'.  | 
                                                        |
| 306 | - '<div class="col-md-9 form-inline felement" data-fieldtype="text">'.  | 
                                                        |
| 307 | - '<input type="text" class="form-control text-center" name="total_connected_users" id="totalUsers" value="?" size="6" readonly="readonly">'.  | 
                                                        |
| 308 | - '<div class="form-control-feedback invalid-feedback" id="id_error_total_connected_users">'.  | 
                                                        |
| 309 | - '</div>'.  | 
                                                        |
| 310 | - '<input type="checkbox" name="show_total_connected_users" class="form-check-input ml-2" id="chkShowTotalUsers" value="1" size="">'.  | 
                                                        |
| 311 | -  | 
                                                        |
| 312 | - '</label>'.  | 
                                                        |
| 313 | - '</div>'.  | 
                                                        |
| 298 | + $connectedUsersBlock = '<div id="fitem_id_total_connected_users" class="form-group row fitem">' .  | 
                                                        |
| 299 | + '<div class="col-md-3">' .  | 
                                                        |
| 300 | + '<span class="float-sm-right text-nowrap">' .  | 
                                                        |
| 301 | + '</span>' .  | 
                                                        |
| 302 | + '<label class="col-form-label d-inline " for="id_total_connected_users">' .  | 
                                                        |
| 303 | + 'Connected Users' .  | 
                                                        |
| 304 | + '</label>' .  | 
                                                        |
| 305 | + '</div>' .  | 
                                                        |
| 306 | + '<div class="col-md-9 form-inline felement" data-fieldtype="text">' .  | 
                                                        |
| 307 | + '<input type="text" class="form-control text-center" name="total_connected_users" id="totalUsers" value="?" size="6" readonly="readonly">' .  | 
                                                        |
| 308 | + '<div class="form-control-feedback invalid-feedback" id="id_error_total_connected_users">' .  | 
                                                        |
| 309 | + '</div>' .  | 
                                                        |
| 310 | + '<input type="checkbox" name="show_total_connected_users" class="form-check-input ml-2" id="chkShowTotalUsers" value="1" size="">' .  | 
                                                        |
| 311 | +  | 
                                                        |
| 312 | + '</label>' .  | 
                                                        |
| 313 | + '</div>' .  | 
                                                        |
| 314 | 314 | '</div>';  | 
                                                        
| 315 | 315 |          $mform->addElement('html', $connectedUsersBlock); | 
                                                        
| 316 | 316 | |
@@ -730,7 +730,7 @@ discard block  | 
                                                    ||
| 730 | 730 | return;  | 
                                                        
| 731 | 731 | }  | 
                                                        
| 732 | 732 | $mform->addElement($type, $name, get_string($descriptionkey, 'bigbluebuttonbn'), $options);  | 
                                                        
| 733 | -        if (get_string_manager()->string_exists($descriptionkey.'_help', 'bigbluebuttonbn')) { | 
                                                        |
| 733 | +        if (get_string_manager()->string_exists($descriptionkey . '_help', 'bigbluebuttonbn')) { | 
                                                        |
| 734 | 734 | $mform->addHelpButton($name, $descriptionkey, 'bigbluebuttonbn');  | 
                                                        
| 735 | 735 | }  | 
                                                        
| 736 | 736 |          if (!empty($rule)) { |