Completed
Pull Request — master (#339)
by
unknown
02:39
created
bbb_broker.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -24,9 +24,9 @@  discard block
 block discarded – undo
24 24
  * @author    Darko Miletic  (darko.miletic [at] gmail [dt] com)
25 25
  */
26 26
 
27
-require(__DIR__.'/../../config.php');
28
-require_once(__DIR__.'/locallib.php');
29
-require_once(__DIR__.'/brokerlib.php');
27
+require(__DIR__ . '/../../config.php');
28
+require_once(__DIR__ . '/locallib.php');
29
+require_once(__DIR__ . '/brokerlib.php');
30 30
 
31 31
 use \Firebase\JWT\JWT;
32 32
 
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 $params = $_REQUEST;
36 36
 
37 37
 if (!isset($params['action']) || empty($params['action'])) {
38
-    header('HTTP/1.0 400 Bad Request. Parameter ['.$params['action'].'] was not included');
38
+    header('HTTP/1.0 400 Bad Request. Parameter [' . $params['action'] . '] was not included');
39 39
     return;
40 40
 }
41 41
 
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
 
51 51
 $error = bigbluebuttonbn_broker_validate_parameters($params);
52 52
 if (!empty($error)) {
53
-    header('HTTP/1.0 400 Bad Request. '.$error);
53
+    header('HTTP/1.0 400 Bad Request. ' . $error);
54 54
     return;
55 55
 }
56 56
 
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
         bigbluebuttonbn_broker_meeting_events($bigbluebuttonbn);
72 72
         return;
73 73
     }
74
-    header('HTTP/1.0 400 Bad request. The action '. $a . ' doesn\'t exist');
74
+    header('HTTP/1.0 400 Bad request. The action ' . $a . ' doesn\'t exist');
75 75
 } catch (Exception $e) {
76
-    header('HTTP/1.0 500 Internal Server Error. '.$e->getMessage());
76
+    header('HTTP/1.0 500 Internal Server Error. ' . $e->getMessage());
77 77
 }
Please login to merge, or discard this patch.
lib.php 3 patches
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
  * @uses FEATURE_GRADE_OUTCOMES
104 104
  * @uses FEATURE_SHOW_DESCRIPTION
105 105
  * @param string $feature
106
- * @return mixed True if yes (some features may use other values)
106
+ * @return null|boolean True if yes (some features may use other values)
107 107
  */
108 108
 function bigbluebuttonbn_supports($feature) {
109 109
     if (!$feature) {
@@ -272,7 +272,7 @@  discard block
 block discarded – undo
272 272
  *
273 273
  * @param object $bigbluebuttonbn Id of the module instance
274 274
  *
275
- * @return bool Success/Failure
275
+ * @return boolean|null Success/Failure
276 276
  */
277 277
 function bigbluebuttonbn_delete_instance_log($bigbluebuttonbn) {
278 278
     global $DB;
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
  * @param object $mod
294 294
  * @param object $bigbluebuttonbn
295 295
  *
296
- * @return bool
296
+ * @return string
297 297
  */
298 298
 function bigbluebuttonbn_user_outline($course, $user, $mod, $bigbluebuttonbn) {
299 299
     if ($completed = bigbluebuttonbn_user_complete($course, $user, $bigbluebuttonbn)) {
@@ -869,7 +869,7 @@  discard block
 block discarded – undo
869 869
  * @param stdClass $context       context object
870 870
  * @param string   $filearea      file area
871 871
  *
872
- * @return false|null false if file not valid
872
+ * @return boolean false if file not valid
873 873
  */
874 874
 function bigbluebuttonbn_pluginfile_valid($context, $filearea) {
875 875
 
Please login to merge, or discard this patch.
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -360,7 +360,7 @@  discard block
 block discarded – undo
360 360
     $sql = "SELECT COUNT(*) FROM {bigbluebuttonbn_logs} ";
361 361
     $sql .= "WHERE courseid = ? AND bigbluebuttonbnid = ? AND userid = ? AND (log = ? OR log = ?)";
362 362
     $result = $DB->count_records_sql($sql, array($course->id, $bigbluebuttonbn->id, $user->id,
363
-                                              BIGBLUEBUTTONBN_LOG_EVENT_JOIN, BIGBLUEBUTTONBN_LOG_EVENT_PLAYED));
363
+                                                BIGBLUEBUTTONBN_LOG_EVENT_JOIN, BIGBLUEBUTTONBN_LOG_EVENT_PLAYED));
364 364
     return $result;
365 365
 }
366 366
 
@@ -593,7 +593,7 @@  discard block
 block discarded – undo
593 593
     $str  = '<div class="bigbluebuttonbn overview">'."\n";
594 594
     $str .= '  <div class="name">'.get_string('modulename', 'bigbluebuttonbn').':&nbsp;'."\n";
595 595
     $str .= '    <a '.$classes.'href="'.$CFG->wwwroot.'/mod/bigbluebuttonbn/view.php?id='.$bigbluebuttonbn->coursemodule.
596
-      '">'.$bigbluebuttonbn->name.'</a>'."\n";
596
+        '">'.$bigbluebuttonbn->name.'</a>'."\n";
597 597
     $str .= '  </div>'."\n";
598 598
     $str .= '  <div class="info">'.get_string($start, 'bigbluebuttonbn').': '.userdate($bigbluebuttonbn->openingtime).
599 599
         '</div>'."\n";
@@ -846,7 +846,7 @@  discard block
 block discarded – undo
846 846
             'bigbluebuttonbn',
847 847
             $bigbluebuttonbn->id,
848 848
             $bigbluebuttonbn->completionexpected
849
-          );
849
+            );
850 850
     }
851 851
 }
852 852
 
Please login to merge, or discard this patch.
Spacing   +34 added lines, -34 removed lines patch added patch discarded remove patch
@@ -30,10 +30,10 @@  discard block
 block discarded – undo
30 30
 
31 31
 // JWT is included in Moodle 3.7 core, but a local package is still needed for backward compatibility.
32 32
 if (!class_exists('\Firebase\JWT\JWT')) {
33
-    if (file_exists($CFG->libdir.'/php-jwt/src/JWT.php')) {
34
-        require_once($CFG->libdir.'/php-jwt/src/JWT.php');
33
+    if (file_exists($CFG->libdir . '/php-jwt/src/JWT.php')) {
34
+        require_once($CFG->libdir . '/php-jwt/src/JWT.php');
35 35
     } else {
36
-        require_once($CFG->dirroot.'/mod/bigbluebuttonbn/vendor/firebase/php-jwt/src/JWT.php');
36
+        require_once($CFG->dirroot . '/mod/bigbluebuttonbn/vendor/firebase/php-jwt/src/JWT.php');
37 37
     }
38 38
 }
39 39
 
@@ -44,8 +44,8 @@  discard block
 block discarded – undo
44 44
         $CFG->bigbluebuttonbn = array();
45 45
     }
46 46
 
47
-    if (file_exists(dirname(__FILE__).'/config.php')) {
48
-        require_once(dirname(__FILE__).'/config.php');
47
+    if (file_exists(dirname(__FILE__) . '/config.php')) {
48
+        require_once(dirname(__FILE__) . '/config.php');
49 49
     }
50 50
 
51 51
     /*
@@ -103,19 +103,19 @@  discard block
 block discarded – undo
103 103
         return null;
104 104
     }
105 105
     $features = array(
106
-        (string) FEATURE_IDNUMBER => true,
107
-        (string) FEATURE_GROUPS => true,
108
-        (string) FEATURE_GROUPINGS => true,
109
-        (string) FEATURE_GROUPMEMBERSONLY => true,
110
-        (string) FEATURE_MOD_INTRO => true,
111
-        (string) FEATURE_BACKUP_MOODLE2 => true,
112
-        (string) FEATURE_COMPLETION_TRACKS_VIEWS => true,
113
-        (string) FEATURE_COMPLETION_HAS_RULES => true,
114
-        (string) FEATURE_GRADE_HAS_GRADE => false,
115
-        (string) FEATURE_GRADE_OUTCOMES => false,
116
-        (string) FEATURE_SHOW_DESCRIPTION => true,
106
+        (string)FEATURE_IDNUMBER => true,
107
+        (string)FEATURE_GROUPS => true,
108
+        (string)FEATURE_GROUPINGS => true,
109
+        (string)FEATURE_GROUPMEMBERSONLY => true,
110
+        (string)FEATURE_MOD_INTRO => true,
111
+        (string)FEATURE_BACKUP_MOODLE2 => true,
112
+        (string)FEATURE_COMPLETION_TRACKS_VIEWS => true,
113
+        (string)FEATURE_COMPLETION_HAS_RULES => true,
114
+        (string)FEATURE_GRADE_HAS_GRADE => false,
115
+        (string)FEATURE_GRADE_OUTCOMES => false,
116
+        (string)FEATURE_SHOW_DESCRIPTION => true,
117 117
     );
118
-    if (isset($features[(string) $feature])) {
118
+    if (isset($features[(string)$feature])) {
119 119
         return $features[$feature];
120 120
     }
121 121
     return null;
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
308 308
 function bigbluebuttonbn_delete_instance_log($bigbluebuttonbn) {
309 309
     global $DB;
310 310
     $sql  = "SELECT * FROM {bigbluebuttonbn_logs} ";
311
-    $sql .= "WHERE bigbluebuttonbnid = ? AND log = ? AND ". $DB->sql_compare_text('meta') . " = ?";
311
+    $sql .= "WHERE bigbluebuttonbnid = ? AND log = ? AND " . $DB->sql_compare_text('meta') . " = ?";
312 312
     $logs = $DB->get_records_sql($sql, array($bigbluebuttonbn->id, BIGBLUEBUTTONBN_LOG_EVENT_CREATE, "{\"record\":true}"));
313 313
     $meta = "{\"has_recordings\":" . empty($logs) ? "true" : "false" . "}";
314 314
     bigbluebuttonbn_log($bigbluebuttonbn, BIGBLUEBUTTONBN_LOG_EVENT_DELETE, [], $meta);
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
 function bigbluebuttonbn_user_outline($course, $user, $mod, $bigbluebuttonbn) {
330 330
     if ($completed = bigbluebuttonbn_user_complete($course, $user, $bigbluebuttonbn)) {
331 331
         return fullname($user) . ' ' . get_string('view_message_has_joined', 'bigbluebuttonbn') . ' ' .
332
-            get_string('view_message_session_for', 'bigbluebuttonbn') . ' ' . (string) $completed . ' ' .
332
+            get_string('view_message_session_for', 'bigbluebuttonbn') . ' ' . (string)$completed . ' ' .
333 333
             get_string('view_message_times', 'bigbluebuttonbn');
334 334
     }
335 335
     return '';
@@ -521,7 +521,7 @@  discard block
 block discarded – undo
521 521
  * @return array status array
522 522
  */
523 523
 function bigbluebuttonbn_reset_recordings($courseid) {
524
-    require_once(__DIR__.'/locallib.php');
524
+    require_once(__DIR__ . '/locallib.php');
525 525
     // Criteria for search [courseid | bigbluebuttonbn=null | subset=false | includedeleted=true].
526 526
     $recordings = bigbluebuttonbn_get_recordings($courseid, null, false, true);
527 527
     // Remove all the recordings.
@@ -590,18 +590,18 @@  discard block
 block discarded – undo
590 590
     if ($bigbluebuttonbn->visible) {
591 591
         $classes = 'class="dimmed" ';
592 592
     }
593
-    $str  = '<div class="bigbluebuttonbn overview">'."\n";
594
-    $str .= '  <div class="name">'.get_string('modulename', 'bigbluebuttonbn').':&nbsp;'."\n";
595
-    $str .= '    <a '.$classes.'href="'.$CFG->wwwroot.'/mod/bigbluebuttonbn/view.php?id='.$bigbluebuttonbn->coursemodule.
596
-      '">'.$bigbluebuttonbn->name.'</a>'."\n";
597
-    $str .= '  </div>'."\n";
598
-    $str .= '  <div class="info">'.get_string($start, 'bigbluebuttonbn').': '.userdate($bigbluebuttonbn->openingtime).
599
-        '</div>'."\n";
593
+    $str  = '<div class="bigbluebuttonbn overview">' . "\n";
594
+    $str .= '  <div class="name">' . get_string('modulename', 'bigbluebuttonbn') . ':&nbsp;' . "\n";
595
+    $str .= '    <a ' . $classes . 'href="' . $CFG->wwwroot . '/mod/bigbluebuttonbn/view.php?id=' . $bigbluebuttonbn->coursemodule .
596
+      '">' . $bigbluebuttonbn->name . '</a>' . "\n";
597
+    $str .= '  </div>' . "\n";
598
+    $str .= '  <div class="info">' . get_string($start, 'bigbluebuttonbn') . ': ' . userdate($bigbluebuttonbn->openingtime) .
599
+        '</div>' . "\n";
600 600
     if (!empty($bigbluebuttonbn->closingtime)) {
601
-        $str .= '  <div class="info">'.get_string('ends_at', 'bigbluebuttonbn').': '.userdate($bigbluebuttonbn->closingtime)
602
-                .'</div>'."\n";
601
+        $str .= '  <div class="info">' . get_string('ends_at', 'bigbluebuttonbn') . ': ' . userdate($bigbluebuttonbn->closingtime)
602
+                .'</div>' . "\n";
603 603
     }
604
-    $str .= '</div>'."\n";
604
+    $str .= '</div>' . "\n";
605 605
     return $str;
606 606
 }
607 607
 
@@ -689,7 +689,7 @@  discard block
 block discarded – undo
689 689
  * @return void
690 690
  **/
691 691
 function bigbluebuttonbn_process_pre_save_instance(&$bigbluebuttonbn) {
692
-    require_once(__DIR__.'/locallib.php');
692
+    require_once(__DIR__ . '/locallib.php');
693 693
     $bigbluebuttonbn->timemodified = time();
694 694
     if ((integer)$bigbluebuttonbn->instance == 0) {
695 695
         $bigbluebuttonbn->meetingid = 0;
@@ -795,7 +795,7 @@  discard block
 block discarded – undo
795 795
  **/
796 796
 function bigbluebuttonbn_process_post_save_event(&$bigbluebuttonbn) {
797 797
     global $CFG, $DB;
798
-    require_once($CFG->dirroot.'/calendar/lib.php');
798
+    require_once($CFG->dirroot . '/calendar/lib.php');
799 799
     $eventid = $DB->get_field('event', 'id', array('modulename' => 'bigbluebuttonbn',
800 800
         'instance' => $bigbluebuttonbn->id));
801 801
     // Delete the event from calendar when/if openingtime is NOT set.
@@ -881,7 +881,7 @@  discard block
 block discarded – undo
881 881
     if (count($files) == 1) {
882 882
         // Get the first (and only) file.
883 883
         $file = reset($files);
884
-        $filesrc = '/'.$file->get_filename();
884
+        $filesrc = '/' . $file->get_filename();
885 885
     }
886 886
     return $filesrc;
887 887
 }
@@ -950,7 +950,7 @@  discard block
 block discarded – undo
950 950
     if (!$filename) {
951 951
         return false;
952 952
     }
953
-    $fullpath = "/$context->id/mod_bigbluebuttonbn/$filearea/0/".$filename;
953
+    $fullpath = "/$context->id/mod_bigbluebuttonbn/$filearea/0/" . $filename;
954 954
     $fs = get_file_storage();
955 955
     $file = $fs->get_file_by_hash(sha1($fullpath));
956 956
     if (!$file || $file->is_directory()) {
Please login to merge, or discard this patch.
classes/locallib/notifier.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@
 block discarded – undo
111 111
      *
112 112
      * @param object $bigbluebuttonbn
113 113
      *
114
-     * @return void
114
+     * @return string
115 115
      */
116 116
     public static function htmlmsg_recording_ready($bigbluebuttonbn) {
117 117
         return '<p>'.get_string('email_body_recording_ready_for', 'bigbluebuttonbn').
Please login to merge, or discard this patch.
Spacing   +28 added lines, -28 removed lines patch added patch discarded remove patch
@@ -47,29 +47,29 @@  discard block
 block discarded – undo
47 47
      * @return string
48 48
      */
49 49
     public static function htmlmsg_instance_updated($msg) {
50
-        $messagetext = '<p>'.get_string('pluginname', 'bigbluebuttonbn').
51
-            ' <b>'.$msg->activity_url.'</b> '.
52
-            get_string('email_body_notification_meeting_has_been', 'bigbluebuttonbn').' '.$msg->action.'.</p>'."\n";
53
-        $messagetext .= '<p>'.get_string('email_body_notification_meeting_details', 'bigbluebuttonbn').':'."\n";
54
-        $messagetext .= '<table border="0" style="margin: 5px 0 0 20px"><tbody>'."\n";
55
-        $messagetext .= '<tr><td style="font-weight:bold;color:#555;">'.
56
-            get_string('email_body_notification_meeting_title', 'bigbluebuttonbn').': </td><td>'."\n";
57
-        $messagetext .= $msg->activity_title.'</td></tr>'."\n";
58
-        $messagetext .= '<tr><td style="font-weight:bold;color:#555;">'.
59
-            get_string('email_body_notification_meeting_description', 'bigbluebuttonbn').': </td><td>'."\n";
60
-        $messagetext .= $msg->activity_description.'</td></tr>'."\n";
61
-        $messagetext .= '<tr><td style="font-weight:bold;color:#555;">'.
62
-            get_string('email_body_notification_meeting_start_date', 'bigbluebuttonbn').': </td><td>'."\n";
63
-        $messagetext .= $msg->activity_openingtime.'</td></tr>'."\n";
64
-        $messagetext .= '<tr><td style="font-weight:bold;color:#555;">'.
65
-            get_string('email_body_notification_meeting_end_date', 'bigbluebuttonbn').': </td><td>'."\n";
66
-        $messagetext .= $msg->activity_closingtime.'</td></tr>'."\n";
67
-        $messagetext .= '<tr><td style="font-weight:bold;color:#555;">'.$msg->action.' '.
68
-            get_string('email_body_notification_meeting_by', 'bigbluebuttonbn').': </td><td>'."\n";
69
-        $messagetext .= $msg->activity_owner.'</td></tr></tbody></table></p>'."\n";
70
-        $messagetext .= '<p><hr/><br/>'.get_string('email_footer_sent_by', 'bigbluebuttonbn').' '.
71
-            $msg->user_name.' ';
72
-        $messagetext .= get_string('email_footer_sent_from', 'bigbluebuttonbn').' '.$msg->course_name.'.</p>';
50
+        $messagetext = '<p>' . get_string('pluginname', 'bigbluebuttonbn') .
51
+            ' <b>' . $msg->activity_url . '</b> ' .
52
+            get_string('email_body_notification_meeting_has_been', 'bigbluebuttonbn') . ' ' . $msg->action . '.</p>' . "\n";
53
+        $messagetext .= '<p>' . get_string('email_body_notification_meeting_details', 'bigbluebuttonbn') . ':' . "\n";
54
+        $messagetext .= '<table border="0" style="margin: 5px 0 0 20px"><tbody>' . "\n";
55
+        $messagetext .= '<tr><td style="font-weight:bold;color:#555;">' .
56
+            get_string('email_body_notification_meeting_title', 'bigbluebuttonbn') . ': </td><td>' . "\n";
57
+        $messagetext .= $msg->activity_title . '</td></tr>' . "\n";
58
+        $messagetext .= '<tr><td style="font-weight:bold;color:#555;">' .
59
+            get_string('email_body_notification_meeting_description', 'bigbluebuttonbn') . ': </td><td>' . "\n";
60
+        $messagetext .= $msg->activity_description . '</td></tr>' . "\n";
61
+        $messagetext .= '<tr><td style="font-weight:bold;color:#555;">' .
62
+            get_string('email_body_notification_meeting_start_date', 'bigbluebuttonbn') . ': </td><td>' . "\n";
63
+        $messagetext .= $msg->activity_openingtime . '</td></tr>' . "\n";
64
+        $messagetext .= '<tr><td style="font-weight:bold;color:#555;">' .
65
+            get_string('email_body_notification_meeting_end_date', 'bigbluebuttonbn') . ': </td><td>' . "\n";
66
+        $messagetext .= $msg->activity_closingtime . '</td></tr>' . "\n";
67
+        $messagetext .= '<tr><td style="font-weight:bold;color:#555;">' . $msg->action . ' ' .
68
+            get_string('email_body_notification_meeting_by', 'bigbluebuttonbn') . ': </td><td>' . "\n";
69
+        $messagetext .= $msg->activity_owner . '</td></tr></tbody></table></p>' . "\n";
70
+        $messagetext .= '<p><hr/><br/>' . get_string('email_footer_sent_by', 'bigbluebuttonbn') . ' ' .
71
+            $msg->user_name . ' ';
72
+        $messagetext .= get_string('email_footer_sent_from', 'bigbluebuttonbn') . ' ' . $msg->course_name . '.</p>';
73 73
         return $messagetext;
74 74
     }
75 75
 
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
         $course = $coursemodinfo->get_course($bigbluebuttonbn->course);
87 87
         $sender = $USER;
88 88
         // Prepare message.
89
-        $msg = (object) array();
89
+        $msg = (object)array();
90 90
         // Build the message_body.
91 91
         $msg->action = $action;
92 92
         $msg->activity_url = html_writer::link(
@@ -120,9 +120,9 @@  discard block
 block discarded – undo
120 120
      * @return void
121 121
      */
122 122
     public static function htmlmsg_recording_ready($bigbluebuttonbn) {
123
-        return '<p>'.get_string('email_body_recording_ready_for', 'bigbluebuttonbn').
124
-            ' &quot;' . $bigbluebuttonbn->name . '&quot; '.
125
-            get_string('email_body_recording_ready_is_ready', 'bigbluebuttonbn').'.</p>';
123
+        return '<p>' . get_string('email_body_recording_ready_for', 'bigbluebuttonbn') .
124
+            ' &quot;' . $bigbluebuttonbn->name . '&quot; ' .
125
+            get_string('email_body_recording_ready_is_ready', 'bigbluebuttonbn') . '.</p>';
126 126
     }
127 127
 
128 128
     /**
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
                     // Enqueue it.
165 165
                     \core\task\manager::queue_adhoc_task($task);
166 166
                 } catch (Exception $e) {
167
-                    mtrace("Error while enqueuing completion_uopdate_state task. " . (string) $e);
167
+                    mtrace("Error while enqueuing completion_uopdate_state task. " . (string)$e);
168 168
                 }
169 169
             }
170 170
         }
Please login to merge, or discard this patch.
classes/output/index.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 
36 36
 defined('MOODLE_INTERNAL') || die();
37 37
 
38
-require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
38
+require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
39 39
 
40 40
 /**
41 41
  * Class index
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
                 // Add a the data for the bigbluebuttonbn instance.
92 92
                 $groupobj = null;
93 93
                 if (groups_get_activity_groupmode($cm) > 0) {
94
-                    $groupobj = (object) array('id' => 0, 'name' => get_string('allparticipants'));
94
+                    $groupobj = (object)array('id' => 0, 'name' => get_string('allparticipants'));
95 95
                 }
96 96
                 $table->data[] = self::bigbluebuttonbn_index_display_room($canmoderate, $course, $bigbluebuttonbn, $groupobj);
97 97
                 // Add a the data for the groups belonging to the bigbluebuttonbn instance, if any.
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
             $attendeecount = 0;
182 182
             foreach ($meetinginfo['attendees']->attendee as $attendee) {
183 183
                 if ($attendee->role == $role) {
184
-                    $attendeelist .= ($attendeecount++ > 0 ? ', ' : '').$attendee->fullName;
184
+                    $attendeelist .= ($attendeecount++ > 0 ? ', ' : '') . $attendee->fullName;
185 185
                 }
186 186
             }
187 187
         }
@@ -215,18 +215,18 @@  discard block
 block discarded – undo
215 215
     public static function bigbluebuttonbn_index_display_room_actions($moderator, $course, $bigbluebuttonbn, $groupobj = null) {
216 216
         $actions = '';
217 217
         if ($moderator) {
218
-            $actions .= '<form name="form1" method="post" action="">'."\n";
219
-            $actions .= '  <INPUT type="hidden" name="id" value="'.$course->id.'">'."\n";
220
-            $actions .= '  <INPUT type="hidden" name="a" value="'.$bigbluebuttonbn->id.'">'."\n";
221
-            $actions .= '  <INPUT type="hidden" name="action" value="end">'."\n";
218
+            $actions .= '<form name="form1" method="post" action="">' . "\n";
219
+            $actions .= '  <INPUT type="hidden" name="id" value="' . $course->id . '">' . "\n";
220
+            $actions .= '  <INPUT type="hidden" name="a" value="' . $bigbluebuttonbn->id . '">' . "\n";
221
+            $actions .= '  <INPUT type="hidden" name="action" value="end">' . "\n";
222 222
             if ($groupobj != null) {
223
-                $actions .= '  <INPUT type="hidden" name="g" value="'.$groupobj->id.'">'."\n";
223
+                $actions .= '  <INPUT type="hidden" name="g" value="' . $groupobj->id . '">' . "\n";
224 224
             }
225 225
             $actions .= '  <INPUT type="submit" name="submit" value="' .
226 226
                 get_string('view_conference_action_end', 'bigbluebuttonbn') .
227 227
                 '" class="btn btn-primary btn-sm" onclick="return confirm(\'' .
228 228
                 get_string('index_confirm_end', 'bigbluebuttonbn') . '\')">' . "\n";
229
-            $actions .= '</form>'."\n";
229
+            $actions .= '</form>' . "\n";
230 230
         }
231 231
         return $actions;
232 232
     }
Please login to merge, or discard this patch.
brokerlib.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
 function bigbluebuttonbn_broker_recording_info_current($recording, $params) {
209 209
     $callbackresponse['status'] = true;
210 210
     $callbackresponse['found'] = true;
211
-    $callbackresponse['published'] = (string) $recording['published'];
211
+    $callbackresponse['published'] = (string)$recording['published'];
212 212
     if (!isset($params['meta']) || empty($params['meta'])) {
213 213
         return $callbackresponse;
214 214
     }
@@ -559,8 +559,8 @@  discard block
 block discarded – undo
559 559
             array('HS256')
560 560
         );
561 561
     } catch (Exception $e) {
562
-        $error = 'Caught exception: '.$e->getMessage();
563
-        header('HTTP/1.0 400 Bad Request. '.$error);
562
+        $error = 'Caught exception: ' . $e->getMessage();
563
+        header('HTTP/1.0 400 Bad Request. ' . $error);
564 564
         return;
565 565
     }
566 566
     // Validate that the bigbluebuttonbn activity corresponds to the meeting_id received.
@@ -590,8 +590,8 @@  discard block
 block discarded – undo
590 590
         bigbluebuttonbn_log($bigbluebuttonbn, BIGBLUEBUTTON_LOG_EVENT_CALLBACK, $overrides, json_encode($meta));
591 591
         header('HTTP/1.0 202 Accepted');
592 592
     } catch (Exception $e) {
593
-        $error = 'Caught exception: '.$e->getMessage();
594
-        header('HTTP/1.0 503 Service Unavailable. '.$error);
593
+        $error = 'Caught exception: ' . $e->getMessage();
594
+        header('HTTP/1.0 503 Service Unavailable. ' . $error);
595 595
     }
596 596
 }
597 597
 
@@ -612,13 +612,13 @@  discard block
 block discarded – undo
612 612
     $importrecordings = $SESSION->bigbluebuttonbn_importrecordings;
613 613
     if (!isset($importrecordings[$params['id']])) {
614 614
         $error = "Recording {$params['id']} could not be found. It can not be imported";
615
-        header('HTTP/1.0 404 Not found. '.$error);
615
+        header('HTTP/1.0 404 Not found. ' . $error);
616 616
         return;
617 617
     }
618 618
     $callbackresponse = array('status' => true);
619 619
     $importrecordings[$params['id']]['imported'] = true;
620 620
     $overrides = array('meetingid' => $importrecordings[$params['id']]['meetingID']);
621
-    $meta = '{"recording":'.json_encode($importrecordings[$params['id']]).'}';
621
+    $meta = '{"recording":' . json_encode($importrecordings[$params['id']]) . '}';
622 622
     bigbluebuttonbn_log($bbbsession['bigbluebuttonbn'], BIGBLUEBUTTONBN_LOG_EVENT_IMPORT, $overrides, $meta);
623 623
     // Moodle event logger: Create an event for recording imported.
624 624
     if (isset($bbbsession['bigbluebutton']) && isset($bbbsession['cm'])) {
@@ -712,7 +712,7 @@  discard block
 block discarded – undo
712 712
     $action = strtolower($params['action']);
713 713
     $requiredparams = bigbluebuttonbn_broker_required_parameters();
714 714
     if (!array_key_exists($action, $requiredparams)) {
715
-        return 'Action '.$params['action'].' can not be performed.';
715
+        return 'Action ' . $params['action'] . ' can not be performed.';
716 716
     }
717 717
     return bigbluebuttonbn_broker_validate_parameters_message($params, $requiredparams[$action]);
718 718
 }
@@ -858,7 +858,7 @@  discard block
 block discarded – undo
858 858
     $tabledata = array();
859 859
     $typeprofiles = bigbluebuttonbn_get_instance_type_profiles();
860 860
     $tabledata['activity'] = bigbluebuttonbn_view_get_activity_status($bbbsession);
861
-    $tabledata['ping_interval'] = (int) \mod_bigbluebuttonbn\locallib\config::get('waitformoderator_ping_interval') * 1000;
861
+    $tabledata['ping_interval'] = (int)\mod_bigbluebuttonbn\locallib\config::get('waitformoderator_ping_interval') * 1000;
862 862
     $tabledata['locale'] = bigbluebuttonbn_get_localcode();
863 863
     $tabledata['profile_features'] = $typeprofiles[0]['features'];
864 864
     $tabledata['recordings_html'] = $bbbsession['bigbluebuttonbn']->recordings_html == '1';
Please login to merge, or discard this patch.
config-dist.php 1 patch
Indentation   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
  * recordings from a different activity even from a different course.
104 104
  **/
105 105
 
106
- /*
106
+    /*
107 107
  * When the value is set to 1 (checked) the bigbluebuttonbn rooms or
108 108
  * activities will have the 'import recordings' capability enabled.
109 109
  * $CFG->bigbluebuttonbn['importrecordings_enabled'] = 0;
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
  * 'Join session' button enabled
125 125
  **/
126 126
 
127
- /*
127
+    /*
128 128
  * When the value is set to 1 (checked) the bigbluebuttonbn rooms or
129 129
  * activities will have the 'wait for moderator' capability enabled by
130 130
  * default.
@@ -276,7 +276,7 @@  discard block
 block discarded – undo
276 276
  * $CFG->bigbluebuttonbn['recordings_preview_editable'] = 0;
277 277
  */
278 278
 
279
- /* When the value is set to 1 (checked) the playback URLs will be validated
279
+    /* When the value is set to 1 (checked) the playback URLs will be validated
280 280
   * before the user access it.
281 281
   * $CFG->bigbluebuttonbn['recordings_validate_url'] = 1;
282 282
   */
@@ -347,7 +347,7 @@  discard block
 block discarded – undo
347 347
  * $CFG->bigbluebuttonbn['disablecam_editable'] = 0;
348 348
  */
349 349
 
350
- /*
350
+    /*
351 351
  * When the value is set to 1 (checked) the bigbluebuttonbn rooms or
352 352
  * activities will have user microphones disabled.
353 353
  * default.
@@ -360,7 +360,7 @@  discard block
 block discarded – undo
360 360
  * $CFG->bigbluebuttonbn['disablemic_editable'] = 0;
361 361
  */
362 362
 
363
- /*
363
+    /*
364 364
  * When the value is set to 1 (checked) the bigbluebuttonbn rooms or
365 365
  * activities will have private chat disabled.
366 366
  * default.
@@ -373,7 +373,7 @@  discard block
 block discarded – undo
373 373
  * $CFG->bigbluebuttonbn['disableprivatechat_editable'] = 0;
374 374
  */
375 375
 
376
- /*
376
+    /*
377 377
  * When the value is set to 1 (checked) the bigbluebuttonbn rooms or
378 378
  * activities will have public chat disabled.
379 379
  * default.
@@ -386,7 +386,7 @@  discard block
 block discarded – undo
386 386
  * $CFG->bigbluebuttonbn['disablepublicchat_editable'] = 0;
387 387
  */
388 388
 
389
- /*
389
+    /*
390 390
  * When the value is set to 1 (checked) the bigbluebuttonbn rooms or
391 391
  * activities will have shared notes disabled.
392 392
  * default.
@@ -399,7 +399,7 @@  discard block
 block discarded – undo
399 399
  * $CFG->bigbluebuttonbn['disablenote_editable'] = 0;
400 400
  */
401 401
 
402
- /*
402
+    /*
403 403
  * When the value is set to 1 (checked) the bigbluebuttonbn rooms or
404 404
  * activities will have the user list hidden.
405 405
  * default.
@@ -412,7 +412,7 @@  discard block
 block discarded – undo
412 412
  * $CFG->bigbluebuttonbn['hideuserlist_editable'] = 0;
413 413
  */
414 414
 
415
- /*
415
+    /*
416 416
  * When the value is set to 1 (checked) the bigbluebuttonbn rooms or
417 417
  * activities will have a locked layout.
418 418
  * default.
@@ -425,7 +425,7 @@  discard block
 block discarded – undo
425 425
  * $CFG->bigbluebuttonbn['lockedlayout_editable'] = 0;
426 426
  */
427 427
 
428
- /*
428
+    /*
429 429
  * When the value is set to 1 (checked) the bigbluebuttonbn rooms or
430 430
  * activities will ignore the locking settings.
431 431
  * default.
@@ -438,7 +438,7 @@  discard block
 block discarded – undo
438 438
  * $CFG->bigbluebuttonbn['lockonjoin_editable'] = 0;
439 439
  */
440 440
 
441
- /*
441
+    /*
442 442
  * When the value is set to 1 (checked) the capability to ignore
443 443
  * locking settings is enabled.
444 444
  * $CFG->bigbluebuttonbn['lockonjoinconfigurable_default'] = 0;
@@ -489,27 +489,27 @@  discard block
 block discarded – undo
489 489
  * $CFG->bigbluebuttonbn['general_warning_message'] = "Would you like to record your BigBlueButton sessions for later viewing? ";
490 490
  */
491 491
 
492
- /*
492
+    /*
493 493
  * The warning box is always shown to administrators, but it is also possible to define other roles
494 494
  * to whom the it will be shown. The roles are based on the shortnames defined by Moodle:
495 495
  *     'manager,coursecreator,editingteacher,teacher,student,guest,user,frontpage'
496 496
  * $CFG->bigbluebuttonbn['general_warning_roles'] = 'editingteacher,teacher';
497 497
  */
498 498
 
499
- /*
499
+    /*
500 500
  * As the general_warning_message is shown in a box, its type can be defined with general_warning_type
501 501
  * The default type is 'info' which is normaly rendered in blue when using a bootstrap theme.
502 502
  * All the modifiers for boxed in bootstrap can be used [info|success|warning|danger].
503 503
  * $CFG->bigbluebuttonbn['general_warning_box_type'] = 'info';
504 504
  */
505 505
 
506
- /*
506
+    /*
507 507
  * Additionally, when general_warning_button_href value is different than "", a button
508 508
  * can also be shown right after the message.
509 509
  * $CFG->bigbluebuttonbn['general_warning_button_href'] = "http://blindsidenetworks.com/";
510 510
  */
511 511
 
512
- /*
512
+    /*
513 513
  * Finally, the text and class for the button can be modified
514 514
  * $CFG->bigbluebuttonbn['general_warning_button_text'] = "Upgrade your site";
515 515
  * $CFG->bigbluebuttonbn['general_warning_button_class'] = "btn btn-primary";
Please login to merge, or discard this patch.
classes/settings/renderer.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
 defined('MOODLE_INTERNAL') || die();
29 29
 
30 30
 require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
31
-require_once($CFG->libdir.'/adminlib.php');
31
+require_once($CFG->libdir . '/adminlib.php');
32 32
 
33 33
 /**
34 34
  * Helper class for rendering HTML for settings.php.
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
             $itemname = get_string('config_' . $name, 'bigbluebuttonbn');
67 67
         }
68 68
         if ($itemdescription === null) {
69
-            $itemdescription = get_string('config_' .$name . '_description', 'bigbluebuttonbn');
69
+            $itemdescription = get_string('config_' . $name . '_description', 'bigbluebuttonbn');
70 70
         }
71 71
         $item = new \admin_setting_heading('bigbluebuttonbn_config_' . $name, $itemname, $itemdescription);
72 72
         $this->settings->add($item);
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
      */
167 167
     public function render_warning_message($name, $message, $type = 'warning', $closable = true) {
168 168
         $output = $this->output->box_start('box boxalignleft adminerror alert alert-' . $type . ' alert-block fade in',
169
-            'bigbluebuttonbn_' . $name)."\n";
169
+            'bigbluebuttonbn_' . $name) . "\n";
170 170
         if ($closable) {
171 171
             $output .= '  <button type="button" class="close" data-dismiss="alert">&times;</button>' . "\n";
172 172
         }
Please login to merge, or discard this patch.
classes/output/mobile.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,6 @@
 block discarded – undo
27 27
 
28 28
 defined('MOODLE_INTERNAL') || die();
29 29
 
30
-use context_module;
31 30
 use mod_bigbluebuttonbn\locallib\bigbluebutton;
32 31
 
33 32
 require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 
57 57
         global $OUTPUT, $SESSION;
58 58
 
59
-        $args = (object) $args;
59
+        $args = (object)$args;
60 60
         $viewinstance = bigbluebuttonbn_view_validator($args->cmid, null);
61 61
         if (!$viewinstance) {
62 62
             $error = get_string('view_error_url_missing_parameters', 'bigbluebuttonbn');
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
             }
165 165
             if ($response['returncode'] == 'FAILED') {
166 166
                 // The meeting could not be created.
167
-                $errorkey = bigbluebuttonbn_get_error_key($response['messageKey'],  'view_error_create');
167
+                $errorkey = bigbluebuttonbn_get_error_key($response['messageKey'], 'view_error_create');
168 168
                 $e = get_string($errorkey, 'bigbluebuttonbn');
169 169
                 return(self::mobile_print_error($e));
170 170
             }
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
             bigbluebuttonbn_event_log(\mod_bigbluebuttonbn\event\events::$events['meeting_create'], $bigbluebuttonbn);
178 178
             // Insert a record that meeting was created.
179 179
             $overrides = array('meetingid' => $bbbsession['meetingid']);
180
-            $meta = '{"record":'.($bbbsession['record'] ? 'true' : 'false').'}';
180
+            $meta = '{"record":' . ($bbbsession['record'] ? 'true' : 'false') . '}';
181 181
             bigbluebuttonbn_log($bbbsession['bigbluebuttonbn'], BIGBLUEBUTTONBN_LOG_EVENT_CREATE, $overrides, $meta);
182 182
         }
183 183
 
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
 
204 204
         $data = array(
205 205
             'bigbluebuttonbn' => $bigbluebuttonbn,
206
-            'bbbsession' => (object) $bbbsession,
206
+            'bbbsession' => (object)$bbbsession,
207 207
             'msjgroup' => $msjgroup,
208 208
             'urltojoin' => $urltojoin,
209 209
             'cmid' => $cm->id,
Please login to merge, or discard this patch.
view.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -27,9 +27,9 @@  discard block
 block discarded – undo
27 27
 
28 28
 use mod_bigbluebuttonbn\plugin;
29 29
 
30
-require(__DIR__.'/../../config.php');
31
-require_once(__DIR__.'/locallib.php');
32
-require_once(__DIR__.'/viewlib.php');
30
+require(__DIR__ . '/../../config.php');
31
+require_once(__DIR__ . '/locallib.php');
32
+require_once(__DIR__ . '/viewlib.php');
33 33
 
34 34
 $id = required_param('id', PARAM_INT);
35 35
 $bn = optional_param('bn', 0, PARAM_INT);
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 mod_bigbluebuttonbn\locallib\bigbluebutton::view_bbbsession_set($PAGE->context, $bbbsession);
59 59
 
60 60
 // Validates if the BigBlueButton server is working.
61
-$serverversion = bigbluebuttonbn_get_server_version();  // In locallib.
61
+$serverversion = bigbluebuttonbn_get_server_version(); // In locallib.
62 62
 if ($serverversion === null) {
63 63
     $errmsg = 'view_error_unable_join_student';
64 64
     $errurl = '/course/view.php';
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
     }
73 73
     print_error($errmsg, plugin::COMPONENT, new moodle_url($errurl, $errurlparams));
74 74
 }
75
-$bbbsession['serverversion'] = (string) $serverversion;
75
+$bbbsession['serverversion'] = (string)$serverversion;
76 76
 
77 77
 // Mark viewed by user (if required).
78 78
 $completion = new completion_info($course);
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
 echo $OUTPUT->footer();
117 117
 
118 118
 // Shows version as a comment.
119
-echo '<!-- '.$bbbsession['originTag'].' -->'."\n";
119
+echo '<!-- ' . $bbbsession['originTag'] . ' -->' . "\n";
120 120
 
121 121
 // Initialize session variable used across views.
122 122
 $SESSION->bigbluebuttonbn_bbbsession = $bbbsession;
123 123
\ No newline at end of file
Please login to merge, or discard this patch.