blindsidenetworks / moodle-mod_bigbluebuttonbn

classes/locallib/config.php

Indentation +59 added lines, -59 removed lines

@@ -191,64 +191,64 @@
      */
     public static function get_options() {
         return array(
-               'version_major' => self::get_moodle_version_major(),
-               'voicebridge_editable' => self::get('voicebridge_editable'),
-               'importrecordings_enabled' => self::get('importrecordings_enabled'),
-               'importrecordings_from_deleted_enabled' => self::get('importrecordings_from_deleted_enabled'),
-               'waitformoderator_default' => self::get('waitformoderator_default'),
-               'waitformoderator_editable' => self::get('waitformoderator_editable'),
-               'userlimit_default' => self::get('userlimit_default'),
-               'userlimit_editable' => self::get('userlimit_editable'),
-               'preuploadpresentation_enabled' => self::get('preuploadpresentation_enabled'),
-               'sendnotifications_enabled' => self::get('sendnotifications_enabled'),
-               'recordings_enabled' => self::get('recordings_enabled'),
-               'meetingevents_enabled' => self::get('meetingevents_enabled'),
-               'recordings_html_default' => self::get('recordings_html_default'),
-               'recordings_html_editable' => self::get('recordings_html_editable'),
-               'recordings_deleted_default' => self::get('recordings_deleted_default'),
-               'recordings_deleted_editable' => self::get('recordings_deleted_editable'),
-               'recordings_imported_default' => self::get('recordings_imported_default'),
-               'recordings_imported_editable' => self::get('recordings_imported_editable'),
-               'recordings_preview_default' => self::get('recordings_preview_default'),
-               'recordings_preview_editable' => self::get('recordings_preview_editable'),
-               'recordings_validate_url' => self::get('recordings_validate_url'),
-               'recording_default' => self::get('recording_default'),
-               'oc_recording' => self::get('oc_recording'),
-               'recording_editable' => self::get('recording_editable'),
-               'recording_icons_enabled' => self::get('recording_icons_enabled'),
-               'recording_all_from_start_default' => self::get('recording_all_from_start_default'),
-               'recording_all_from_start_editable' => self::get('recording_all_from_start_editable'),
-               'recording_hide_button_default' => self::get('recording_hide_button_default'),
-               'recording_hide_button_editable' => self::get('recording_hide_button_editable'),
-               'general_warning_message' => self::get('general_warning_message'),
-               'general_warning_box_type' => self::get('general_warning_box_type'),
-               'general_warning_button_text' => self::get('general_warning_button_text'),
-               'general_warning_button_href' => self::get('general_warning_button_href'),
-               'general_warning_button_class' => self::get('general_warning_button_class'),
-               'clienttype_enabled' => self::get('clienttype_enabled'),
-               'clienttype_editable' => self::get('clienttype_editable'),
-               'clienttype_default' => self::get('clienttype_default'),
-               'muteonstart_editable' => self::get('muteonstart_editable'),
-               'muteonstart_default' => self::get('muteonstart_default'),
-               'disablecam_editable' => self::get('disablecam_editable'),
-               'disablecam_default' => self::get('disablecam_default'),
-               'disablemic_editable' => self::get('disablemic_editable'),
-               'disablemic_default' => self::get('disablemic_default'),
-               'disableprivatechat_editable' => self::get('disableprivatechat_editable'),
-               'disableprivatechat_default' => self::get('disableprivatechat_default'),
-               'disablepublicchat_editable' => self::get('disablepublicchat_editable'),
-               'disablepublicchat_default' => self::get('disablepublicchat_default'),
-               'disablenote_editable' => self::get('disablenote_editable'),
-               'disablenote_default' => self::get('disablenote_default'),
-               'hideuserlist_editable' => self::get('hideuserlist_editable'),
-               'hideuserlist_default' => self::get('hideuserlist_default'),
-               'lockedlayout_editable' => self::get('lockedlayout_editable'),
-               'lockedlayout_default' => self::get('lockedlayout_default'),
-               'lockonjoin_editable' => self::get('lockonjoin_editable'),
-               'lockonjoin_default' => self::get('lockonjoin_default'),
-               'lockonjoinconfigurable_editable' => self::get('lockonjoinconfigurable_editable'),
-               'lockonjoinconfigurable_default' => self::get('lockonjoinconfigurable_default'),
-               'welcome_default' => self::get('welcome_default'),
-          );
+                'version_major' => self::get_moodle_version_major(),
+                'voicebridge_editable' => self::get('voicebridge_editable'),
+                'importrecordings_enabled' => self::get('importrecordings_enabled'),
+                'importrecordings_from_deleted_enabled' => self::get('importrecordings_from_deleted_enabled'),
+                'waitformoderator_default' => self::get('waitformoderator_default'),
+                'waitformoderator_editable' => self::get('waitformoderator_editable'),
+                'userlimit_default' => self::get('userlimit_default'),
+                'userlimit_editable' => self::get('userlimit_editable'),
+                'preuploadpresentation_enabled' => self::get('preuploadpresentation_enabled'),
+                'sendnotifications_enabled' => self::get('sendnotifications_enabled'),
+                'recordings_enabled' => self::get('recordings_enabled'),
+                'meetingevents_enabled' => self::get('meetingevents_enabled'),
+                'recordings_html_default' => self::get('recordings_html_default'),
+                'recordings_html_editable' => self::get('recordings_html_editable'),
+                'recordings_deleted_default' => self::get('recordings_deleted_default'),
+                'recordings_deleted_editable' => self::get('recordings_deleted_editable'),
+                'recordings_imported_default' => self::get('recordings_imported_default'),
+                'recordings_imported_editable' => self::get('recordings_imported_editable'),
+                'recordings_preview_default' => self::get('recordings_preview_default'),
+                'recordings_preview_editable' => self::get('recordings_preview_editable'),
+                'recordings_validate_url' => self::get('recordings_validate_url'),
+                'recording_default' => self::get('recording_default'),
+                'oc_recording' => self::get('oc_recording'),
+                'recording_editable' => self::get('recording_editable'),
+                'recording_icons_enabled' => self::get('recording_icons_enabled'),
+                'recording_all_from_start_default' => self::get('recording_all_from_start_default'),
+                'recording_all_from_start_editable' => self::get('recording_all_from_start_editable'),
+                'recording_hide_button_default' => self::get('recording_hide_button_default'),
+                'recording_hide_button_editable' => self::get('recording_hide_button_editable'),
+                'general_warning_message' => self::get('general_warning_message'),
+                'general_warning_box_type' => self::get('general_warning_box_type'),
+                'general_warning_button_text' => self::get('general_warning_button_text'),
+                'general_warning_button_href' => self::get('general_warning_button_href'),
+                'general_warning_button_class' => self::get('general_warning_button_class'),
+                'clienttype_enabled' => self::get('clienttype_enabled'),
+                'clienttype_editable' => self::get('clienttype_editable'),
+                'clienttype_default' => self::get('clienttype_default'),
+                'muteonstart_editable' => self::get('muteonstart_editable'),
+                'muteonstart_default' => self::get('muteonstart_default'),
+                'disablecam_editable' => self::get('disablecam_editable'),
+                'disablecam_default' => self::get('disablecam_default'),
+                'disablemic_editable' => self::get('disablemic_editable'),
+                'disablemic_default' => self::get('disablemic_default'),
+                'disableprivatechat_editable' => self::get('disableprivatechat_editable'),
+                'disableprivatechat_default' => self::get('disableprivatechat_default'),
+                'disablepublicchat_editable' => self::get('disablepublicchat_editable'),
+                'disablepublicchat_default' => self::get('disablepublicchat_default'),
+                'disablenote_editable' => self::get('disablenote_editable'),
+                'disablenote_default' => self::get('disablenote_default'),
+                'hideuserlist_editable' => self::get('hideuserlist_editable'),
+                'hideuserlist_default' => self::get('hideuserlist_default'),
+                'lockedlayout_editable' => self::get('lockedlayout_editable'),
+                'lockedlayout_default' => self::get('lockedlayout_default'),
+                'lockonjoin_editable' => self::get('lockonjoin_editable'),
+                'lockonjoin_default' => self::get('lockonjoin_default'),
+                'lockonjoinconfigurable_editable' => self::get('lockonjoinconfigurable_editable'),
+                'lockonjoinconfigurable_default' => self::get('lockonjoinconfigurable_default'),
+                'welcome_default' => self::get('welcome_default'),
+            );
     }
 }

locallib.php

Doc Comments +16 added lines, -16 removed lines

@@ -326,7 +326,7 @@ 
  * Helper function to retrieve imported recordings from the Moodle database.
  * The references are stored as events in bigbluebuttonbn_logs.
  *
- * @param string $courseid
+ * @param integer $courseid
  * @param string $bigbluebuttonbnid
  * @param bool   $subset
  *
@@ -354,7 +354,7 @@ 
 /**
  * Helper function to retrive the default config.xml file.
  *
- * @return string
+ * @return null|SimpleXMLElement
  */
 function bigbluebuttonbn_get_default_config_xml() {
     $xml = bigbluebuttonbn_wrap_xml_load_file(
@@ -436,7 +436,7 @@ 
  * @param object $a
  * @param object $b
  *
- * @return array
+ * @return integer
  */
 function bigbluebuttonbn_recording_build_sorter($a, $b) {
     global $CFG;
@@ -550,7 +550,7 @@ 
  * @param string $data
  * @param string $contenttype
  *
- * @return object
+ * @return null|SimpleXMLElement
  */
 function bigbluebuttonbn_wrap_xml_load_file($url, $method = 'GET', $data = null, $contenttype = 'text/xml') {
     if (extension_loaded('curl')) {
@@ -591,7 +591,7 @@ 
  * @param string $data
  * @param string $contenttype
  *
- * @return object
+ * @return string
  */
 function bigbluebuttonbn_wrap_xml_load_file_curl_request($url, $method = 'GET', $data = null, $contenttype = 'text/xml') {
     global $CFG;
@@ -1008,7 +1008,7 @@ 
  * @param integer $instance
  * @param integer $voicebridge
  *
- * @return string
+ * @return boolean
  */
 function bigbluebuttonbn_voicebridge_unique($instance, $voicebridge) {
     global $DB;
@@ -1356,7 +1356,7 @@ 
  * @param string $meetingid
  * @param string $configxml
  *
- * @return object
+ * @return null|SimpleXMLElement
  */
 function bigbluebuttonbn_set_config_xml($meetingid, $configxml) {
     $urldefaultconfig = \mod_bigbluebuttonbn\locallib\config::get('server_url') . 'api/setConfigXML?';
@@ -1410,7 +1410,7 @@ 
  * @param array $recording
  * @param array $tools
  *
- * @return array
+ * @return null|stdClass
  */
 function bigbluebuttonbn_get_recording_data_row($bbbsession, $recording, $tools = ['protect', 'publish', 'delete']) {
     if (!bigbluebuttonbn_include_recording_table_row($bbbsession, $recording)) {
@@ -1994,7 +1994,7 @@ 
  *
  * @param array $bbbsession
  * @param array $recording
- * @param object $rowdata
+ * @param stdClass $rowdata
  *
  * @return object
  */
@@ -2224,7 +2224,7 @@ 
  *
  * @param array $bbbsession
  * @param array $recordings
- * @param array $tools
+ * @param string[] $tools
  *
  * @return array
  */
@@ -2340,7 +2340,7 @@ 
  * @param array $bbbsession
  * @param array $ocrecording
  *
- * @return array
+ * @return stdClass
  */
 function bigbluebuttonbn_get_opencast_recording_data_row($bbbsession, $ocrecording) {
     $rowdata = new stdClass();
@@ -2521,7 +2521,7 @@ 
  *
  * @param array $bbbsession
  * @param object $ocrecording
- * @param object $rowdata
+ * @param stdClass $rowdata
  *
  * @return object
  */
@@ -2670,7 +2670,7 @@ 
  * Helper function to define the sql used for gattering the bigbluebuttonbnids whose meetingids should be included
  * in the getRecordings request considering only those that belong to deleted activities.
  *
- * @param string $courseid
+ * @param integer $courseid
  * @param string $bigbluebuttonbnid
  * @param bool   $subset
  *
@@ -2694,7 +2694,7 @@ 
  * Helper function to define the sql used for gattering the bigbluebuttonbnids whose meetingids should be included
  * in the getRecordings request considering only those that belong to imported recordings.
  *
- * @param string $courseid
+ * @param integer $courseid
  * @param string $bigbluebuttonbnid
  * @param bool   $subset
  *
@@ -2717,7 +2717,7 @@ 
 /**
  * Helper function to get recordings and imported recordings together.
  *
- * @param string $courseid
+ * @param integer $courseid
  * @param string $bigbluebuttonbnid
  * @param bool   $subset
  * @param bool   $includedeleted
@@ -2735,7 +2735,7 @@ 
  * Helper function to retrieve recordings from the BigBlueButton. The references are stored as events
  * in bigbluebuttonbn_logs.
  *
- * @param string $courseid
+ * @param integer $courseid
  * @param string $bigbluebuttonbnid
  * @param bool   $subset
  * @param bool   $includedeleted

Indentation +3 added lines, -3 removed lines

@@ -801,7 +801,7 @@ 
     $data['role'] = array(
         'name' => get_string('mod_form_field_participant_list_type_role', 'bigbluebuttonbn'),
         'children' => bigbluebuttonbn_get_roles_select($context, true)
-      );
+        );
     $data['user'] = array(
         'name' => get_string('mod_form_field_participant_list_type_user', 'bigbluebuttonbn'),
         'children' => bigbluebuttonbn_get_users_select($context, $bbactivity),
@@ -1709,7 +1709,7 @@ 
         'data-action' => 'play',
         'data-target' => $playback['type'],
         'data-href' => $href,
-      );
+        );
     if ($CFG->bigbluebuttonbn_recordings_validate_url && !bigbluebuttonbn_is_bn_server()
             && !bigbluebuttonbn_is_valid_resource(trim($playback['url']))) {
         $linkattributes['class'] = 'btn btn-sm btn-warning';
@@ -2396,7 +2396,7 @@ 
         'id' => 'opencast-player-redirect-' . $ocrecording['identifier'],
         'class' => 'btn btn-sm btn-default',
         'target' => '_blank'
-      );
+        );
     if ($href == '#' || empty($href)) {
         $linkattributes['class'] = 'btn btn-sm btn-warning';
         $linkattributes['title'] = get_string('view_recording_format_errror_unreachable', 'bigbluebuttonbn');

Spacing +69 added lines, -69 removed lines

@@ -150,8 +150,8 @@ 
     $payload = null;
     if (!is_null($pname) && !is_null($purl)) {
         $method = 'POST';
-        $payload = "<?xml version='1.0' encoding='UTF-8'?><modules><module name='presentation'><document url='".
-            $purl."' /></module></modules>";
+        $payload = "<?xml version='1.0' encoding='UTF-8'?><modules><module name='presentation'><document url='" .
+            $purl . "' /></module></modules>";
     }
     $xml = bigbluebuttonbn_wrap_xml_load_file($createmeetingurl, $method, $payload);
     if ($xml) {
@@ -195,7 +195,7 @@ 
     }
     if ($xml) {
         // Either failure or success without meeting info.
-        return (array) $xml;
+        return (array)$xml;
     }
     // If the server is unreachable, then prompts the user of the necessary action.
     return array('returncode' => 'FAILED', 'message' => 'unreachable', 'messageKey' => 'Server is unreachable');
@@ -288,7 +288,7 @@ 
                 foreach ($recordingxml->breakoutRooms->breakoutRoom as $breakoutroom) {
                     $url = \mod_bigbluebuttonbn\locallib\bigbluebutton::action_url(
                         'getRecordings',
-                        ['recordID' => implode(',', (array) $breakoutroom)]
+                        ['recordID' => implode(',', (array)$breakoutroom)]
                     );
                     $xml = bigbluebuttonbn_wrap_xml_load_file($url);
                     if ($xml && $xml->returncode == 'SUCCESS' && isset($xml->recordings)) {
@@ -344,7 +344,7 @@ 
         // Override imported flag with actual ID.
         $recording['imported'] = $recordimported->id;
         if (isset($recordimported->protected)) {
-            $recording['protected'] = (string) $recordimported->protected;
+            $recording['protected'] = (string)$recordimported->protected;
         }
         $recordsimportedarray[$recording['recordID']] = $recording;
     }
@@ -374,21 +374,21 @@ 
     // Add formats.
     $playbackarray = array();
     foreach ($recording->playback->format as $format) {
-        $playbackarray[(string) $format->type] = array('type' => (string) $format->type,
-            'url' => trim((string) $format->url), 'length' => (string) $format->length);
+        $playbackarray[(string)$format->type] = array('type' => (string)$format->type,
+            'url' => trim((string)$format->url), 'length' => (string)$format->length);
         // Add preview per format when existing.
         if ($format->preview) {
-            $playbackarray[(string) $format->type]['preview'] = bigbluebuttonbn_get_recording_preview_images($format->preview);
+            $playbackarray[(string)$format->type]['preview'] = bigbluebuttonbn_get_recording_preview_images($format->preview);
         }
     }
     // Add the metadata to the recordings array.
     $metadataarray = bigbluebuttonbn_get_recording_array_meta(get_object_vars($recording->metadata));
-    $recordingarray = array('recordID' => (string) $recording->recordID,
-        'meetingID' => (string) $recording->meetingID, 'meetingName' => (string) $recording->name,
-        'published' => (string) $recording->published, 'startTime' => (string) $recording->startTime,
-        'endTime' => (string) $recording->endTime, 'playbacks' => $playbackarray);
+    $recordingarray = array('recordID' => (string)$recording->recordID,
+        'meetingID' => (string)$recording->meetingID, 'meetingName' => (string)$recording->name,
+        'published' => (string)$recording->published, 'startTime' => (string)$recording->startTime,
+        'endTime' => (string)$recording->endTime, 'playbacks' => $playbackarray);
     if (isset($recording->protected)) {
-        $recordingarray['protected'] = (string) $recording->protected;
+        $recordingarray['protected'] = (string)$recording->protected;
     }
     return $recordingarray + $metadataarray;
 }
@@ -403,9 +403,9 @@ 
 function bigbluebuttonbn_get_recording_preview_images($preview) {
     $imagesarray = array();
     foreach ($preview->images->image as $image) {
-        $imagearray = array('url' => trim((string) $image));
+        $imagearray = array('url' => trim((string)$image));
         foreach ($image->attributes() as $attkey => $attvalue) {
-            $imagearray[$attkey] = (string) $attvalue;
+            $imagearray[$attkey] = (string)$attvalue;
         }
         array_push($imagesarray, $imagearray);
     }
@@ -500,7 +500,7 @@ 
     $ids = explode(',', $recordids);
     foreach ($ids as $id) {
         $xml = bigbluebuttonbn_wrap_xml_load_file(
-            \mod_bigbluebuttonbn\locallib\bigbluebutton::action_url('updateRecordings', ['recordID' => $id] + (array) $params)
+            \mod_bigbluebuttonbn\locallib\bigbluebutton::action_url('updateRecordings', ['recordID' => $id] + (array)$params)
         );
         if ($xml && $xml->returncode != 'SUCCESS') {
             return false;
@@ -671,7 +671,7 @@ 
  * @return array $users
  */
 function bigbluebuttonbn_get_users(context $context = null) {
-    $users = (array) get_enrolled_users($context, '', 0, 'u.*', null, 0, 0, true);
+    $users = (array)get_enrolled_users($context, '', 0, 'u.*', null, 0, 0, true);
     foreach ($users as $key => $value) {
         $users[$key] = fullname($value);
     }
@@ -690,7 +690,7 @@ 
 function bigbluebuttonbn_get_users_select(context_course $context, $bbactivity = null) {
     // CONTRIB-7972, check the group of current user and course group mode.
     $groups = null;
-    $users = (array) get_enrolled_users($context, '', 0, 'u.*', null, 0, 0, true);
+    $users = (array)get_enrolled_users($context, '', 0, 'u.*', null, 0, 0, true);
     $course = get_course($context->instanceid);
     $groupmode = groups_get_course_groupmode($course);
     if ($bbactivity) {
@@ -703,7 +703,7 @@ 
         $groups = groups_get_all_groups($course->id, $USER->id);
         $users = [];
         foreach ($groups as $g) {
-            $users += (array) get_enrolled_users($context, '', $g->id, 'u.*', null, 0, 0, true);
+            $users += (array)get_enrolled_users($context, '', $g->id, 'u.*', null, 0, 0, true);
         }
     }
     return array_map(
@@ -725,12 +725,12 @@ 
     global $CFG;
 
     if ($onlyviewableroles == true && $CFG->branch >= 35) {
-        $roles = (array) get_viewable_roles($context);
+        $roles = (array)get_viewable_roles($context);
         foreach ($roles as $key => $value) {
             $roles[$key] = $value;
         }
     } else {
-        $roles = (array) role_get_names($context);
+        $roles = (array)role_get_names($context);
         foreach ($roles as $key => $value) {
             $roles[$key] = $value->localname;
         }
@@ -751,12 +751,12 @@ 
     global $CFG;
 
     if ($onlyviewableroles == true && $CFG->branch >= 35) {
-        $roles = (array) get_viewable_roles($context);
+        $roles = (array)get_viewable_roles($context);
         foreach ($roles as $key => $value) {
             $roles[$key] = array('id' => $key, 'name' => $value);
         }
     } else {
-        $roles = (array) role_get_names($context);
+        $roles = (array)role_get_names($context);
         foreach ($roles as $key => $value) {
             $roles[$key] = array('id' => $value->id, 'name' => $value->localname);
         }
@@ -773,9 +773,9 @@ 
  * @return object $role
  */
 function bigbluebuttonbn_get_role($id) {
-    $roles = (array) role_get_names();
+    $roles = (array)role_get_names();
     if (is_numeric($id) && isset($roles[$id])) {
-        return (object) $roles[$id];
+        return (object)$roles[$id];
     }
     foreach ($roles as $role) {
         if ($role->shortname == $id) {
@@ -855,7 +855,7 @@ 
             if (!empty($ownerid) && is_enrolled($context, $ownerid)) {
                 $participantlist[] = array(
                     'selectiontype' => 'user',
-                    'selectionid' => (string) $ownerid,
+                    'selectionid' => (string)$ownerid,
                     'role' => BIGBLUEBUTTONBN_ROLE_MODERATOR);
             }
             continue;
@@ -1037,7 +1037,7 @@ 
     $now = time();
     if ($closingtime > 0 && $now < $closingtime) {
         $duration = ceil(($closingtime - $now) / 60);
-        $compensationtime = intval((int) \mod_bigbluebuttonbn\locallib\config::get('scheduled_duration_compensation'));
+        $compensationtime = intval((int)\mod_bigbluebuttonbn\locallib\config::get('scheduled_duration_compensation'));
         $duration = intval($duration) + $compensationtime;
     }
     return $duration;
@@ -1239,16 +1239,16 @@ 
  * @return array
  */
 function bigbluebuttonbn_get_meeting_info($meetingid, $updatecache = false) {
-    $cachettl = (int) \mod_bigbluebuttonbn\locallib\config::get('waitformoderator_cache_ttl');
+    $cachettl = (int)\mod_bigbluebuttonbn\locallib\config::get('waitformoderator_cache_ttl');
     $cache = cache::make_from_params(cache_store::MODE_APPLICATION, 'mod_bigbluebuttonbn', 'meetings_cache');
     $result = $cache->get($meetingid);
     $now = time();
     if (!$updatecache && !empty($result) && $now < ($result['creation_time'] + $cachettl)) {
         // Use the value in the cache.
-        return (array) json_decode($result['meeting_info']);
+        return (array)json_decode($result['meeting_info']);
     }
     // Ping again and refresh the cache.
-    $meetinginfo = (array) bigbluebuttonbn_wrap_xml_load_file(
+    $meetinginfo = (array)bigbluebuttonbn_wrap_xml_load_file(
         \mod_bigbluebuttonbn\locallib\bigbluebutton::action_url('getMeetingInfo', ['meetingID' => $meetingid])
     );
     $cache->set($meetingid, array('creation_time' => time(), 'meeting_info' => json_encode($meetinginfo)));
@@ -1395,7 +1395,7 @@ 
  */
 function bigbluebuttonbn_set_config_xml_array($meetingid, $configxml) {
     $configxml = bigbluebuttonbn_set_config_xml($meetingid, $configxml);
-    $configxmlarray = (array) $configxml;
+    $configxmlarray = (array)$configxml;
     if ($configxmlarray['returncode'] != 'SUCCESS') {
         debugging('BigBlueButton was not able to set the custom config.xml file', DEBUG_DEVELOPER);
         return '';
@@ -1448,7 +1448,7 @@ 
  * @return boolean
  */
 function bigbluebuttonbn_get_recording_data_row_editable($bbbsession) {
-    return ($bbbsession['managerecordings'] && ((double) $bbbsession['serverversion'] >= 1.0 || $bbbsession['bnserver']));
+    return ($bbbsession['managerecordings'] && ((double)$bbbsession['serverversion'] >= 1.0 || $bbbsession['bnserver']));
 }
 
 /**
@@ -1459,7 +1459,7 @@ 
  * @return boolean
  */
 function bigbluebuttonbn_get_recording_data_preview_enabled($bbbsession) {
-    return ((double) $bbbsession['serverversion'] >= 1.0 && $bbbsession['bigbluebuttonbn']->recordings_preview == '1');
+    return ((double)$bbbsession['serverversion'] >= 1.0 && $bbbsession['bigbluebuttonbn']->recordings_preview == '1');
 }
 
 /**
@@ -1885,7 +1885,7 @@ 
     }
     $id = 'recording-' . $target . '-' . $recording['recordID'];
     $onclick = 'M.mod_bigbluebuttonbn.recordings.recording' . ucfirst($data['action']) . '(this); return false;';
-    if ((boolean) \mod_bigbluebuttonbn\locallib\config::get('recording_icons_enabled')) {
+    if ((boolean)\mod_bigbluebuttonbn\locallib\config::get('recording_icons_enabled')) {
         // With icon for $manageaction.
         $iconattributes = array('id' => $id, 'class' => 'iconsmall');
         $linkattributes = array(
@@ -2148,7 +2148,7 @@ 
         // Enqueue it.
         \core\task\manager::queue_adhoc_task($task);
     } catch (Exception $e) {
-        mtrace("Error while enqueuing completion_update_state task. " . (string) $e);
+        mtrace("Error while enqueuing completion_update_state task. " . (string)$e);
     }
 }
 
@@ -2162,7 +2162,7 @@ 
  */
 function bigbluebuttonbn_completion_update_state($bigbluebuttonbn, $userid) {
     global $CFG;
-    require_once($CFG->libdir.'/completionlib.php');
+    require_once($CFG->libdir . '/completionlib.php');
     list($course, $cm) = get_course_and_cm_from_instance($bigbluebuttonbn, 'bigbluebuttonbn');
     $completion = new completion_info($course);
     if (!$completion->is_enabled($cm)) {
@@ -2952,7 +2952,7 @@ 
  */
 function bigbluebuttonbn_format_activity_time($time) {
     global $CFG;
-    require_once($CFG->dirroot.'/calendar/lib.php');
+    require_once($CFG->dirroot . '/calendar/lib.php');
     $activitytime = '';
     if ($time) {
         $activitytime = calendar_day_representation($time) . ' ' .
@@ -3050,7 +3050,7 @@ 
  */
 function bigbluebuttonbn_settings_general(&$renderer) {
     // Configuration for BigBlueButton.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_general_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_general_shown()) {
         $renderer->render_group_header('general');
         $renderer->render_group_element(
             'server_url',
@@ -3072,7 +3072,7 @@ 
  */
 function bigbluebuttonbn_settings_record(&$renderer) {
     // Configuration for 'recording' feature.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_record_meeting_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_record_meeting_shown()) {
         $renderer->render_group_header('recording');
         $renderer->render_group_element(
             'recording_default',
@@ -3116,7 +3116,7 @@ 
  */
 function bigbluebuttonbn_settings_importrecordings(&$renderer) {
     // Configuration for 'import recordings' feature.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_import_recordings_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_import_recordings_shown()) {
         $renderer->render_group_header('importrecordings');
         $renderer->render_group_element(
             'importrecordings_enabled',
@@ -3138,7 +3138,7 @@ 
  */
 function bigbluebuttonbn_settings_showrecordings(&$renderer) {
     // Configuration for 'show recordings' feature.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_show_recordings_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_show_recordings_shown()) {
         $renderer->render_group_header('recordings');
         $renderer->render_group_element(
             'recordings_html_default',
@@ -3192,7 +3192,7 @@ 
  */
 function bigbluebuttonbn_settings_waitmoderator(&$renderer) {
     // Configuration for wait for moderator feature.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_wait_moderator_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_wait_moderator_shown()) {
         $renderer->render_group_header('waitformoderator');
         $renderer->render_group_element(
             'waitformoderator_default',
@@ -3222,7 +3222,7 @@ 
  */
 function bigbluebuttonbn_settings_voicebridge(&$renderer) {
     // Configuration for "static voice bridge" feature.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_static_voice_bridge_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_static_voice_bridge_shown()) {
         $renderer->render_group_header('voicebridge');
         $renderer->render_group_element(
             'voicebridge_editable',
@@ -3240,7 +3240,7 @@ 
  */
 function bigbluebuttonbn_settings_preupload(&$renderer) {
     // Configuration for "preupload presentation" feature.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_preupload_presentation_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_preupload_presentation_shown()) {
         // This feature only works if curl is installed.
         $preuploaddescripion = get_string('config_preuploadpresentation_description', 'bigbluebuttonbn');
         if (!extension_loaded('curl')) {
@@ -3268,7 +3268,7 @@ 
  */
 function bigbluebuttonbn_settings_preupload_manage_default_file(&$renderer) {
     // Configuration for "preupload presentation" feature.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_preupload_presentation_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_preupload_presentation_shown()) {
         if (extension_loaded('curl')) {
             // This feature only works if curl is installed.
             $renderer->render_filemanager_default_file_presentation("presentation_default");
@@ -3285,7 +3285,7 @@ 
  */
 function bigbluebuttonbn_settings_userlimit(&$renderer) {
     // Configuration for "user limit" feature.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_user_limit_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_user_limit_shown()) {
         $renderer->render_group_header('userlimit');
         $renderer->render_group_element(
             'userlimit_default',
@@ -3307,7 +3307,7 @@ 
  */
 function bigbluebuttonbn_settings_duration(&$renderer) {
     // Configuration for "scheduled duration" feature.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_scheduled_duration_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_scheduled_duration_shown()) {
         $renderer->render_group_header('scheduled');
         $renderer->render_group_element(
             'scheduled_duration_enabled',
@@ -3333,7 +3333,7 @@ 
  */
 function bigbluebuttonbn_settings_participants(&$renderer) {
     // Configuration for defining the default role/user that will be moderator on new activities.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_moderator_default_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_moderator_default_shown()) {
         $renderer->render_group_header('participant');
         // UI for 'participants' feature.
         $roles = bigbluebuttonbn_get_roles(null, false);
@@ -3358,7 +3358,7 @@ 
  */
 function bigbluebuttonbn_settings_notifications(&$renderer) {
     // Configuration for "send notifications" feature.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_send_notifications_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_send_notifications_shown()) {
         $renderer->render_group_header('sendnotifications');
         $renderer->render_group_element(
             'sendnotifications_enabled',
@@ -3376,14 +3376,14 @@ 
  */
 function bigbluebuttonbn_settings_clienttype(&$renderer) {
     // Configuration for "clienttype" feature.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_clienttype_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_clienttype_shown()) {
         $renderer->render_group_header('clienttype');
         $renderer->render_group_element(
             'clienttype_editable',
             $renderer->render_group_element_checkbox('clienttype_editable', 0)
         );
         // Web Client default.
-        $default = intval((int) \mod_bigbluebuttonbn\locallib\config::get('clienttype_default'));
+        $default = intval((int)\mod_bigbluebuttonbn\locallib\config::get('clienttype_default'));
         $choices = array(BIGBLUEBUTTON_CLIENTTYPE_FLASH => get_string('mod_form_block_clienttype_flash', 'bigbluebuttonbn'),
             BIGBLUEBUTTON_CLIENTTYPE_HTML5 => get_string('mod_form_block_clienttype_html5', 'bigbluebuttonbn'));
         $renderer->render_group_element(
@@ -3406,7 +3406,7 @@ 
  */
 function bigbluebuttonbn_settings_muteonstart(&$renderer) {
     // Configuration for BigBlueButton.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_muteonstart_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_muteonstart_shown()) {
         $renderer->render_group_header('muteonstart');
         $renderer->render_group_element(
             'muteonstart_default',
@@ -3449,7 +3449,7 @@ 
  */
 function bigbluebuttonbn_settings_disablecam(&$renderer) {
     // Configuration for BigBlueButton.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_disablecam_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_disablecam_shown()) {
         $renderer->render_group_element(
             'disablecam_default',
             $renderer->render_group_element_checkbox('disablecam_default', 0)
@@ -3470,7 +3470,7 @@ 
  */
 function bigbluebuttonbn_settings_disablemic(&$renderer) {
     // Configuration for BigBlueButton.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_disablemic_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_disablemic_shown()) {
         $renderer->render_group_element(
             'disablemic_default',
             $renderer->render_group_element_checkbox('disablemic_default', 0)
@@ -3491,7 +3491,7 @@ 
  */
 function bigbluebuttonbn_settings_disableprivatechat(&$renderer) {
     // Configuration for BigBlueButton.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_disableprivatechat_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_disableprivatechat_shown()) {
         $renderer->render_group_element(
             'disableprivatechat_default',
             $renderer->render_group_element_checkbox('disableprivatechat_default', 0)
@@ -3512,7 +3512,7 @@ 
  */
 function bigbluebuttonbn_settings_disablepublicchat(&$renderer) {
     // Configuration for BigBlueButton.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_disablepublicchat_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_disablepublicchat_shown()) {
         $renderer->render_group_element(
             'disablepublicchat_default',
             $renderer->render_group_element_checkbox('disablepublicchat_default', 0)
@@ -3533,7 +3533,7 @@ 
  */
 function bigbluebuttonbn_settings_disablenote(&$renderer) {
     // Configuration for BigBlueButton.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_disablenote_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_disablenote_shown()) {
         $renderer->render_group_element(
             'disablenote_default',
             $renderer->render_group_element_checkbox('disablenote_default', 0)
@@ -3554,7 +3554,7 @@ 
  */
 function bigbluebuttonbn_settings_hideuserlist(&$renderer) {
     // Configuration for BigBlueButton.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_hideuserlist_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_hideuserlist_shown()) {
         $renderer->render_group_element(
             'hideuserlist_default',
             $renderer->render_group_element_checkbox('hideuserlist_default', 0)
@@ -3575,7 +3575,7 @@ 
  */
 function bigbluebuttonbn_settings_lockedlayout(&$renderer) {
     // Configuration for BigBlueButton.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_lockedlayout_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_lockedlayout_shown()) {
         $renderer->render_group_element(
             'lockedlayout_default',
             $renderer->render_group_element_checkbox('lockedlayout_default', 0)
@@ -3596,7 +3596,7 @@ 
  */
 function bigbluebuttonbn_settings_lockonjoin(&$renderer) {
     // Configuration for BigBlueButton.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_lockonjoin_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_lockonjoin_shown()) {
         $renderer->render_group_element(
             'lockonjoin_default',
             $renderer->render_group_element_checkbox('lockonjoin_default', 0)
@@ -3617,7 +3617,7 @@ 
  */
 function bigbluebuttonbn_settings_lockonjoinconfigurable(&$renderer) {
     // Configuration for BigBlueButton.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_lockonjoinconfigurable_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_lockonjoinconfigurable_shown()) {
         $renderer->render_group_element(
             'lockonjoinconfigurable_default',
             $renderer->render_group_element_checkbox('lockonjoinconfigurable_default', 0)
@@ -3653,7 +3653,7 @@ 
  */
 function bigbluebuttonbn_settings_extended(&$renderer) {
     // Configuration for extended capabilities.
-    if (!(boolean) \mod_bigbluebuttonbn\settings\validator::section_settings_extended_shown()) {
+    if (!(boolean)\mod_bigbluebuttonbn\settings\validator::section_settings_extended_shown()) {
         return;
     }
     $renderer->render_group_header('extended_capabilities');
@@ -3691,7 +3691,7 @@ 
     global $DB;
     do {
         $encodedseed = sha1(bigbluebuttonbn_random_password(12));
-        $meetingid = (string) $DB->get_field('bigbluebuttonbn', 'meetingid', array('meetingid' => $encodedseed));
+        $meetingid = (string)$DB->get_field('bigbluebuttonbn', 'meetingid', array('meetingid' => $encodedseed));
     } while ($meetingid == $encodedseed);
     return $encodedseed;
 }
@@ -3904,7 +3904,7 @@ 
 function bigbluebuttonbn_instance_ownerid($bigbluebuttonbn) {
     global $DB;
     $filters = array('bigbluebuttonbnid' => $bigbluebuttonbn->id, 'log' => 'Add');
-    $ownerid = (integer) $DB->get_field('bigbluebuttonbn_logs', 'userid', $filters);
+    $ownerid = (integer)$DB->get_field('bigbluebuttonbn_logs', 'userid', $filters);
     return $ownerid;
 }
 
@@ -4011,7 +4011,7 @@ 
         'bbb-recording-tags' => bigbluebuttonbn_get_tags($bbbsession['cm']->id), // Same as $id.
     ];
     // Special metadata for recording processing.
-    if ((boolean) \mod_bigbluebuttonbn\locallib\config::get('recordingstatus_enabled')) {
+    if ((boolean)\mod_bigbluebuttonbn\locallib\config::get('recordingstatus_enabled')) {
         $metadata["bn-recording-status"] = json_encode(
             array(
                 'email' => array('"' . fullname($USER) . '" <' . $USER->email . '>'),
@@ -4019,14 +4019,14 @@ 
             )
         );
     }
-    if ((boolean) \mod_bigbluebuttonbn\locallib\config::get('recordingready_enabled')) {
+    if ((boolean)\mod_bigbluebuttonbn\locallib\config::get('recordingready_enabled')) {
         $metadata['bn-recording-ready-url'] = $bbbsession['recordingReadyURL'];
     }
-    if ((boolean) \mod_bigbluebuttonbn\locallib\config::get('meetingevents_enabled')) {
+    if ((boolean)\mod_bigbluebuttonbn\locallib\config::get('meetingevents_enabled')) {
         $metadata['analytics-callback-url'] = $bbbsession['meetingEventsURL'];
     }
     // Special metadata for Opencast recordings (passing opencast seriesid of the course as opencast-dc-isPartOf as metadata).
-    if ((boolean) \mod_bigbluebuttonbn\locallib\config::get('oc_recording')) {
+    if ((boolean)\mod_bigbluebuttonbn\locallib\config::get('oc_recording')) {
         $ocseriesid = bigbluebuttonbn_check_opencast($bbbsession['course']->id);
         if ($ocseriesid != false) {
             $metadata['opencast-dc-isPartOf'] = $ocseriesid;
@@ -4083,7 +4083,7 @@ 
  */
 function bigbluebuttonbn_settings_opencastintegration(&$renderer) {
     // Configuration for 'Opencast integration' feature when Opencast plugins are installed.
-    if ((boolean) bigbluebuttonbn_check_opencast()) {
+    if ((boolean)bigbluebuttonbn_check_opencast()) {
         $renderer->render_group_header('opencast');
         $renderer->render_group_element(
             'oc_recording',

oc_player.php

Spacing +2 added lines, -2 removed lines

@@ -25,8 +25,8 @@
 
 global $PAGE, $OUTPUT, $CFG;
 
-require_once(dirname(dirname(dirname(__FILE__))).'/config.php');
-require_once(dirname(__FILE__).'/locallib.php');
+require_once(dirname(dirname(dirname(__FILE__))) . '/config.php');
+require_once(dirname(__FILE__) . '/locallib.php');
 
 require_once($CFG->dirroot . '/mod/lti/locallib.php');
 require_once($CFG->dirroot . '/lib/oauthlib.php');

viewlib.php

Spacing +14 added lines, -14 removed lines

@@ -54,8 +54,8 @@ 
         $groupname = groups_get_group_name($bbbsession['group']);
     }
     // Assign group default values.
-    $bbbsession['meetingid'] .= '['.$bbbsession['group'].']';
-    $bbbsession['meetingname'] .= ' ('.$groupname.')';
+    $bbbsession['meetingid'] .= '[' . $bbbsession['group'] . ']';
+    $bbbsession['meetingname'] .= ' (' . $groupname . ')';
     if (count($groups) == 0) {
         // Only the All participants group exists.
         bigbluebuttonbn_view_message_box($bbbsession, get_string('view_groups_notenrolled_warning', 'bigbluebuttonbn'), 'info');
@@ -65,7 +65,7 @@ 
     if (has_capability('moodle/site:accessallgroups', $context)) {
         bigbluebuttonbn_view_message_box($bbbsession, get_string('view_groups_selection_warning', 'bigbluebuttonbn'));
     }
-    $urltoroot = $CFG->wwwroot.'/mod/bigbluebuttonbn/view.php?id='.$bbbsession['cm']->id;
+    $urltoroot = $CFG->wwwroot . '/mod/bigbluebuttonbn/view.php?id=' . $bbbsession['cm']->id;
     groups_print_activity_menu($bbbsession['cm'], $urltoroot);
     echo '<br><br>';
 }
@@ -138,7 +138,7 @@ 
         $recordingsdisabled = get_string('view_message_recordings_disabled', 'bigbluebuttonbn');
         $output .= bigbluebuttonbn_render_warning($recordingsdisabled, 'danger');
     }
-    echo $output.html_writer::empty_tag('br').html_writer::empty_tag('br').html_writer::empty_tag('br');
+    echo $output . html_writer::empty_tag('br') . html_writer::empty_tag('br') . html_writer::empty_tag('br');
     $PAGE->requires->yui_module('moodle-mod_bigbluebuttonbn-broker', 'M.mod_bigbluebuttonbn.broker.init', array($jsvars));
 }
 
@@ -172,7 +172,7 @@ 
     // Repeating the above conditions to show Opencast Recordings, when Opencast series id is available in the current course and
     // bigbluebuttonbn_oc_show_recording config is enabled.
     $seriesid = bigbluebuttonbn_check_opencast($bbbsession['course']->id);
-    if ((boolean) \mod_bigbluebuttonbn\locallib\config::get('oc_show_recording') && !empty($seriesid)) {
+    if ((boolean)\mod_bigbluebuttonbn\locallib\config::get('oc_show_recording') && !empty($seriesid)) {
         if ($type == BIGBLUEBUTTONBN_TYPE_ALL && $bbbsession['record']) {
             $output .= html_writer::start_tag('div', array('id' => 'bigbluebuttonbn_view_opencast_recordings_header', 'class' => 'mt-3'));
             $output .= html_writer::tag('h4', get_string('view_section_title_opencast_recordings', 'bigbluebuttonbn'));
@@ -223,12 +223,12 @@ 
     // JavaScript variables for room.
     $openingtime = '';
     if ($bbbsession['openingtime']) {
-        $openingtime = get_string('mod_form_field_openingtime', 'bigbluebuttonbn').': '.
+        $openingtime = get_string('mod_form_field_openingtime', 'bigbluebuttonbn') . ': ' .
             userdate($bbbsession['openingtime']);
     }
     $closingtime = '';
     if ($bbbsession['closingtime']) {
-        $closingtime = get_string('mod_form_field_closingtime', 'bigbluebuttonbn').': '.
+        $closingtime = get_string('mod_form_field_closingtime', 'bigbluebuttonbn') . ': ' .
             userdate($bbbsession['closingtime']);
     }
     $jsvars += array(
@@ -245,7 +245,7 @@ 
     $output .= $OUTPUT->box_end();
     // Action button box.
     $output .= $OUTPUT->box_start('generalbox boxaligncenter', 'bigbluebuttonbn_view_action_button_box');
-    $output .= '<br><br><span id="join_button"></span>&nbsp;<span id="end_button"></span>'."\n";
+    $output .= '<br><br><span id="join_button"></span>&nbsp;<span id="end_button"></span>' . "\n";
     $output .= $OUTPUT->box_end();
     if ($activity == 'ended') {
         $output .= bigbluebuttonbn_view_ended($bbbsession);
@@ -278,7 +278,7 @@ 
     // If there are meetings with recordings load the data to the table.
     if ($bbbsession['bigbluebuttonbn']->recordings_html) {
         // Render a plain html table.
-        return bigbluebuttonbn_output_recording_table($bbbsession, $recordings)."\n";
+        return bigbluebuttonbn_output_recording_table($bbbsession, $recordings) . "\n";
     }
     // JavaScript variables for recordings with YUI.
     $jsvars += array(
@@ -335,8 +335,8 @@ 
         array('type' => 'button',
             'value' => get_string('view_recording_button_import', 'bigbluebuttonbn'),
             'class' => 'btn btn-secondary',
-            'onclick' => 'window.location=\''.$CFG->wwwroot.'/mod/bigbluebuttonbn/import_view.php?bn='.
-                $bbbsession['bigbluebuttonbn']->id.'\''));
+            'onclick' => 'window.location=\'' . $CFG->wwwroot . '/mod/bigbluebuttonbn/import_view.php?bn=' .
+                $bbbsession['bigbluebuttonbn']->id . '\''));
     $output  = html_writer::empty_tag('br');
     $output .= html_writer::tag('span', $button, array('id' => 'import_recording_links_button'));
     $output .= html_writer::tag('span', '', array('id' => 'import_recording_links_table'));
@@ -355,10 +355,10 @@ 
     if (!is_null($bbbsession['presentation']['url'])) {
         $attributes = array('title' => $bbbsession['presentation']['name']);
         $icon = new pix_icon($bbbsession['presentation']['icon'], $bbbsession['presentation']['mimetype_description']);
-        return '<h4>'.get_string('view_section_title_presentation', 'bigbluebuttonbn').'</h4>'.
-            $OUTPUT->action_icon($bbbsession['presentation']['url'], $icon, null, array(), false).
+        return '<h4>' . get_string('view_section_title_presentation', 'bigbluebuttonbn') . '</h4>' .
+            $OUTPUT->action_icon($bbbsession['presentation']['url'], $icon, null, array(), false) .
             $OUTPUT->action_link($bbbsession['presentation']['url'],
-                $bbbsession['presentation']['name'], null, $attributes).'<br><br>';
+                $bbbsession['presentation']['name'], null, $attributes) . '<br><br>';
     }
     return '';
 }