blindsidenetworks / moodle-mod_bigbluebuttonbn

classes/event/bigbluebuttonbn_activity_management_viewed.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
      */
     protected function init() {
         parent::init();
-        $this->description = "The user with id '##userid' viewed the bigbluebuttonbn activity management page for ".
+        $this->description = "The user with id '##userid' viewed the bigbluebuttonbn activity management page for " .
         "the course module id '##contextinstanceid'.";
     }
 

classes/privacy/provider.php

Spacing +1 added lines, -1 removed lines

@@ -212,7 +212,7 @@
             function($instanceid, $data) use ($user, $instanceidstocmids) {
                 $context = \context_module::instance($instanceidstocmids[$instanceid]);
                 $contextdata = helper::get_context_data($context, $user);
-                $finaldata = (object) array_merge((array) $contextdata, ['logs' => $data]);
+                $finaldata = (object)array_merge((array)$contextdata, ['logs' => $data]);
                 helper::export_context_files($context, $user);
                 writer::with_context($context)->export_data([], $finaldata);
             }

Indentation +6 added lines, -6 removed lines

@@ -61,11 +61,11 @@ 
      */
     public static function _get_metadata(collection $collection) {
 
-         // The table bigbluebuttonbn stores only the room properties.
-         // However, there is a chance that some personal information is stored as metadata.
-         // This would be done in the column 'participants' where rules can be set to define BBB roles.
-         // It is fair to say that only the userid is stored, which is useless if user is removed.
-         // But if this is a concern a refactoring on the way the rules are stored will be required.
+            // The table bigbluebuttonbn stores only the room properties.
+            // However, there is a chance that some personal information is stored as metadata.
+            // This would be done in the column 'participants' where rules can be set to define BBB roles.
+            // It is fair to say that only the userid is stored, which is useless if user is removed.
+            // But if this is a concern a refactoring on the way the rules are stored will be required.
         $collection->add_database_table('bigbluebuttonbn', [
             'participants' => 'privacy:metadata:bigbluebuttonbn:participants',
         ], 'privacy:metadata:bigbluebuttonbn');
@@ -208,7 +208,7 @@ 
                     'meetingid' => $record->meetingid,
                     'log' => $record->log,
                     'meta' => $record->meta,
-                  ];
+                    ];
                 return $carry;
             },
             function($instanceid, $data) use ($user, $instanceidstocmids) {

view.php

Indentation +9 added lines, -9 removed lines

@@ -434,12 +434,12 @@ 
     $recordings = bigbluebuttonbn_get_recordings(
         $bbbsession['course']->id, $bigbluebuttonbnid, $enabledfeatures['showroom'],
         $bbbsession['bigbluebuttonbn']->recordings_deleted
-      );
+        );
     if ($enabledfeatures['importrecordings']) {
         // Get recording links.
         $recordingsimported = bigbluebuttonbn_get_recordings_imported_array(
             $bbbsession['course']->id, $bigbluebuttonbnid, $enabledfeatures['showroom']
-          );
+            );
         /* Perform aritmetic addition instead of merge so the imported recordings corresponding to existent
          * recordings are not included. */
         if ($bbbsession['bigbluebuttonbn']->recordings_imported) {
@@ -457,7 +457,7 @@ 
     // JavaScript variables for recordings.
     $jsvars += array(
             'recordings_html' => $bbbsession['bigbluebuttonbn']->recordings_html == '1',
-          );
+            );
     // If there are meetings with recordings load the data to the table.
     if ($bbbsession['bigbluebuttonbn']->recordings_html) {
         // Render a plain html table.
@@ -467,7 +467,7 @@ 
     $jsvars += array(
             'columns' => bigbluebuttonbn_get_recording_columns($bbbsession),
             'data' => bigbluebuttonbn_get_recording_data($bbbsession, $recordings),
-          );
+            );
     // Render a YUI table.
     return html_writer::div('', '', array('id' => 'bigbluebuttonbn_recordings_table'));
 }
@@ -487,10 +487,10 @@ 
     }
     $button = html_writer::tag('input', '',
         array('type' => 'button',
-              'value' => get_string('view_recording_button_import', 'bigbluebuttonbn'),
-              'class' => 'btn btn-secondary',
-              'onclick' => 'window.location=\''.$CFG->wwwroot.'/mod/bigbluebuttonbn/import_view.php?bn='.
-                  $bbbsession['bigbluebuttonbn']->id.'\''));
+                'value' => get_string('view_recording_button_import', 'bigbluebuttonbn'),
+                'class' => 'btn btn-secondary',
+                'onclick' => 'window.location=\''.$CFG->wwwroot.'/mod/bigbluebuttonbn/import_view.php?bn='.
+                    $bbbsession['bigbluebuttonbn']->id.'\''));
     $output  = html_writer::empty_tag('br');
     $output .= html_writer::tag('span', $button, array('id' => 'import_recording_links_button'));
     $output .= html_writer::tag('span', '', array('id' => 'import_recording_links_table'));
@@ -569,5 +569,5 @@ 
         (string)\mod_bigbluebuttonbn\locallib\config::get('general_warning_button_href'),
         (string)\mod_bigbluebuttonbn\locallib\config::get('general_warning_button_text'),
         (string)\mod_bigbluebuttonbn\locallib\config::get('general_warning_button_class')
-      );
+        );
 }

classes/locallib/config.php

Indentation +28 added lines, -28 removed lines

@@ -152,33 +152,33 @@
      */
     public static function get_options() {
         return array(
-               'version_major' => self::get_moodle_version_major(),
-               'voicebridge_editable' => self::get('voicebridge_editable'),
-               'importrecordings_enabled' => self::get('importrecordings_enabled'),
-               'importrecordings_from_deleted_enabled' => self::get('importrecordings_from_deleted_enabled'),
-               'waitformoderator_default' => self::get('waitformoderator_default'),
-               'waitformoderator_editable' => self::get('waitformoderator_editable'),
-               'userlimit_default' => self::get('userlimit_default'),
-               'userlimit_editable' => self::get('userlimit_editable'),
-               'preuploadpresentation_enabled' => self::get('preuploadpresentation_enabled'),
-               'sendnotifications_enabled' => self::get('sendnotifications_enabled'),
-               'recordings_enabled' => self::get('recordings_enabled'),
-               'recordings_html_default' => self::get('recordings_html_default'),
-               'recordings_html_editable' => self::get('recordings_html_editable'),
-               'recordings_deleted_default' => self::get('recordings_deleted_default'),
-               'recordings_deleted_editable' => self::get('recordings_deleted_editable'),
-               'recordings_imported_default' => self::get('recordings_imported_default'),
-               'recordings_imported_editable' => self::get('recordings_imported_editable'),
-               'recordings_preview_default' => self::get('recordings_preview_default'),
-               'recordings_preview_editable' => self::get('recordings_preview_editable'),
-               'recording_default' => self::get('recording_default'),
-               'recording_editable' => self::get('recording_editable'),
-               'recording_icons_enabled' => self::get('recording_icons_enabled'),
-               'general_warning_message' => self::get('general_warning_message'),
-               'general_warning_box_type' => self::get('general_warning_box_type'),
-               'general_warning_button_text' => self::get('general_warning_button_text'),
-               'general_warning_button_href' => self::get('general_warning_button_href'),
-               'general_warning_button_class' => self::get('general_warning_button_class'),
-          );
+                'version_major' => self::get_moodle_version_major(),
+                'voicebridge_editable' => self::get('voicebridge_editable'),
+                'importrecordings_enabled' => self::get('importrecordings_enabled'),
+                'importrecordings_from_deleted_enabled' => self::get('importrecordings_from_deleted_enabled'),
+                'waitformoderator_default' => self::get('waitformoderator_default'),
+                'waitformoderator_editable' => self::get('waitformoderator_editable'),
+                'userlimit_default' => self::get('userlimit_default'),
+                'userlimit_editable' => self::get('userlimit_editable'),
+                'preuploadpresentation_enabled' => self::get('preuploadpresentation_enabled'),
+                'sendnotifications_enabled' => self::get('sendnotifications_enabled'),
+                'recordings_enabled' => self::get('recordings_enabled'),
+                'recordings_html_default' => self::get('recordings_html_default'),
+                'recordings_html_editable' => self::get('recordings_html_editable'),
+                'recordings_deleted_default' => self::get('recordings_deleted_default'),
+                'recordings_deleted_editable' => self::get('recordings_deleted_editable'),
+                'recordings_imported_default' => self::get('recordings_imported_default'),
+                'recordings_imported_editable' => self::get('recordings_imported_editable'),
+                'recordings_preview_default' => self::get('recordings_preview_default'),
+                'recordings_preview_editable' => self::get('recordings_preview_editable'),
+                'recording_default' => self::get('recording_default'),
+                'recording_editable' => self::get('recording_editable'),
+                'recording_icons_enabled' => self::get('recording_icons_enabled'),
+                'general_warning_message' => self::get('general_warning_message'),
+                'general_warning_box_type' => self::get('general_warning_box_type'),
+                'general_warning_button_text' => self::get('general_warning_button_text'),
+                'general_warning_button_href' => self::get('general_warning_button_href'),
+                'general_warning_button_class' => self::get('general_warning_button_class'),
+            );
     }
 }

Spacing +4 added lines, -4 removed lines

@@ -55,8 +55,8 @@ 
      */
     public static function defaultvalues() {
         return array(
-            'server_url' => (string) BIGBLUEBUTTONBN_DEFAULT_SERVER_URL,
-            'shared_secret' => (string) BIGBLUEBUTTONBN_DEFAULT_SHARED_SECRET,
+            'server_url' => (string)BIGBLUEBUTTONBN_DEFAULT_SERVER_URL,
+            'shared_secret' => (string)BIGBLUEBUTTONBN_DEFAULT_SHARED_SECRET,
             'voicebridge_editable' => 'false',
             'importrecordings_enabled' => 'false',
             'importrecordings_from_deleted_enabled' => 'false',
@@ -121,8 +121,8 @@ 
         if (isset($CFG->bigbluebuttonbn[$setting])) {
             return (string)$CFG->bigbluebuttonbn[$setting];
         }
-        if (isset($CFG->{'bigbluebuttonbn_'.$setting})) {
-            return (string)$CFG->{'bigbluebuttonbn_'.$setting};
+        if (isset($CFG->{'bigbluebuttonbn_' . $setting})) {
+            return (string)$CFG->{'bigbluebuttonbn_' . $setting};
         }
         return self::defaultvalue($setting);
     }

mod_form.php

Indentation +8 added lines, -8 removed lines

@@ -213,8 +213,8 @@ 
             $this->bigbluebuttonbn_mform_add_element($mform, $field['type'], $field['name'], $field['data_type'],
                 $field['description_key'], 0, ['maxlength' => 4, 'size' => 6],
                 ['message' => get_string('mod_form_field_voicebridge_format_error', 'bigbluebuttonbn'),
-                 'type' => 'numeric', 'rule' => '####', 'validator' => 'server']
-              );
+                    'type' => 'numeric', 'rule' => '####', 'validator' => 'server']
+                );
         } else {
             $this->bigbluebuttonbn_mform_add_element($mform, $field['type'], $field['name'], $field['data_type'],
                 $field['description_key'], 0, ['maxlength' => 4, 'size' => 6]);
@@ -252,7 +252,7 @@ 
      */
     private function bigbluebuttonbn_mform_add_block_room_recordings(&$mform, $cfg) {
         $field = ['type' => 'hidden', 'name' => 'recordings_html', 'data_type' => PARAM_INT,
-                  'description_key' => null];
+                    'description_key' => null];
         if ($cfg['recordings_html_editable']) {
             $field['type'] = 'checkbox';
             $field['description_key'] = 'mod_form_field_recordings_html';
@@ -260,7 +260,7 @@ 
         $this->bigbluebuttonbn_mform_add_element($mform, $field['type'], $field['name'], $field['data_type'],
             $field['description_key'], $cfg['recordings_html_default']);
         $field = ['type' => 'hidden', 'name' => 'recordings_deleted', 'data_type' => PARAM_INT,
-                  'description_key' => null];
+                    'description_key' => null];
         if ($cfg['recordings_deleted_editable']) {
             $field['type'] = 'checkbox';
             $field['description_key'] = 'mod_form_field_recordings_deleted';
@@ -268,7 +268,7 @@ 
         $this->bigbluebuttonbn_mform_add_element($mform, $field['type'], $field['name'], $field['data_type'],
             $field['description_key'], $cfg['recordings_deleted_default']);
         $field = ['type' => 'hidden', 'name' => 'recordings_imported', 'data_type' => PARAM_INT,
-                  'description_key' => null];
+                    'description_key' => null];
         if ($cfg['importrecordings_enabled'] && $cfg['recordings_imported_editable']) {
             $field['type'] = 'checkbox';
             $field['description_key'] = 'mod_form_field_recordings_imported';
@@ -276,7 +276,7 @@ 
         $this->bigbluebuttonbn_mform_add_element($mform, $field['type'], $field['name'], $field['data_type'],
             $field['description_key'], $cfg['recordings_imported_default']);
         $field = ['type' => 'hidden', 'name' => 'recordings_preview', 'data_type' => PARAM_INT,
-                  'description_key' => null];
+                    'description_key' => null];
         if ($cfg['recordings_preview_editable']) {
             $field['type'] = 'checkbox';
             $field['description_key'] = 'mod_form_field_recordings_preview';
@@ -347,7 +347,7 @@ 
         $htmlselectiontype = html_writer::select($participantselection['type_options'],
             'bigbluebuttonbn_participant_selection_type', $participantselection['type_selected'], array(),
             array('id' => 'bigbluebuttonbn_participant_selection_type',
-                  'onchange' => 'M.mod_bigbluebuttonbn.modform.participantSelectionSet(); return 0;'));
+                    'onchange' => 'M.mod_bigbluebuttonbn.modform.participantSelectionSet(); return 0;'));
         $htmlselectionoptions = html_writer::select($participantselection['options'], 'bigbluebuttonbn_participant_selection',
             $participantselection['selected'], array(),
             array('id' => 'bigbluebuttonbn_participant_selection', 'disabled' => 'disabled'));
@@ -355,7 +355,7 @@ 
             'type' => 'button', 'class' => 'btn btn-secondary',
             'value' => get_string('mod_form_field_participant_list_action_add', 'bigbluebuttonbn'),
             'onclick' => 'M.mod_bigbluebuttonbn.modform.participantAdd(); return 0;'
-          ));
+            ));
         $htmladdparticipant = html_writer::tag('div',
             $htmlselectiontype . '  ' . $htmlselectionoptions . '  ' . $htmlselectioninput, null);
         $mform->addElement('html', "\n\n");

locallib.php

Indentation +47 added lines, -47 removed lines

@@ -121,9 +121,9 @@ 
  */
 function bigbluebuttonbn_get_join_url($meetingid, $username, $pw, $logouturl, $configtoken = null, $userid = null) {
     $data = ['meetingID' => $meetingid,
-              'fullName' => $username,
-              'password' => $pw,
-              'logoutURL' => $logouturl,
+                'fullName' => $username,
+                'password' => $pw,
+                'logoutURL' => $logouturl,
             ];
     if (!is_null($configtoken)) {
         $data['configToken'] = $configtoken;
@@ -175,23 +175,23 @@ 
 function bigbluebuttonbn_get_meeting_info_array($meetingid) {
     $xml = bigbluebuttonbn_wrap_xml_load_file(
         \mod_bigbluebuttonbn\locallib\bigbluebutton::action_url('getMeetingInfo', ['meetingID' => $meetingid])
-      );
+        );
     if ($xml && $xml->returncode == 'SUCCESS' && empty($xml->messageKey)) {
         // Meeting info was returned.
         return array('returncode' => $xml->returncode,
-                     'meetingID' => $xml->meetingID,
-                     'moderatorPW' => $xml->moderatorPW,
-                     'attendeePW' => $xml->attendeePW,
-                     'hasBeenForciblyEnded' => $xml->hasBeenForciblyEnded,
-                     'running' => $xml->running,
-                     'recording' => $xml->recording,
-                     'startTime' => $xml->startTime,
-                     'endTime' => $xml->endTime,
-                     'participantCount' => $xml->participantCount,
-                     'moderatorCount' => $xml->moderatorCount,
-                     'attendees' => $xml->attendees,
-                     'metadata' => $xml->metadata,
-                   );
+                        'meetingID' => $xml->meetingID,
+                        'moderatorPW' => $xml->moderatorPW,
+                        'attendeePW' => $xml->attendeePW,
+                        'hasBeenForciblyEnded' => $xml->hasBeenForciblyEnded,
+                        'running' => $xml->running,
+                        'recording' => $xml->recording,
+                        'startTime' => $xml->startTime,
+                        'endTime' => $xml->endTime,
+                        'participantCount' => $xml->participantCount,
+                        'moderatorCount' => $xml->moderatorCount,
+                        'attendees' => $xml->attendees,
+                        'metadata' => $xml->metadata,
+                    );
     }
     if ($xml) {
         // Either failure or success without meeting info.
@@ -327,7 +327,7 @@ 
 function bigbluebuttonbn_get_default_config_xml() {
     $xml = bigbluebuttonbn_wrap_xml_load_file(
         \mod_bigbluebuttonbn\locallib\bigbluebutton::action_url('getDefaultConfigXML')
-      );
+        );
     return $xml;
 }
 
@@ -428,7 +428,7 @@ 
     foreach ($ids as $id) {
         $xml = bigbluebuttonbn_wrap_xml_load_file(
             \mod_bigbluebuttonbn\locallib\bigbluebutton::action_url('deleteRecordings', ['recordID' => $id])
-          );
+            );
         if ($xml && $xml->returncode != 'SUCCESS') {
             return false;
         }
@@ -447,7 +447,7 @@ 
     foreach ($ids as $id) {
         $xml = bigbluebuttonbn_wrap_xml_load_file(
             \mod_bigbluebuttonbn\locallib\bigbluebutton::action_url('publishRecordings', ['recordID' => $id, 'publish' => $publish])
-          );
+            );
         if ($xml && $xml->returncode != 'SUCCESS') {
             return false;
         }
@@ -466,7 +466,7 @@ 
     foreach ($ids as $id) {
         $xml = bigbluebuttonbn_wrap_xml_load_file(
             \mod_bigbluebuttonbn\locallib\bigbluebutton::action_url('updateRecordings', ['recordID' => $id] + (array) $params)
-          );
+            );
         if ($xml && $xml->returncode != 'SUCCESS') {
             return false;
         }
@@ -483,7 +483,7 @@ 
 function bigbluebuttonbn_end_meeting($meetingid, $modpw) {
     $xml = bigbluebuttonbn_wrap_xml_load_file(
         \mod_bigbluebuttonbn\locallib\bigbluebutton::action_url('end', ['meetingID' => $meetingid, 'password' => $modpw])
-      );
+        );
     if ($xml) {
         // If the xml packet returned failure it displays the message to the user.
         return array('returncode' => $xml->returncode, 'message' => $xml->message, 'messageKey' => $xml->messageKey);
@@ -500,7 +500,7 @@ 
 function bigbluebuttonbn_get_server_version() {
     $xml = bigbluebuttonbn_wrap_xml_load_file(
         \mod_bigbluebuttonbn\locallib\bigbluebutton::action_url()
-      );
+        );
     if ($xml && $xml->returncode == 'SUCCESS') {
         return $xml->version;
     }
@@ -567,10 +567,10 @@ 
         }
         $options = array();
         $options['CURLOPT_HTTPHEADER'] = array(
-                 'Content-Type: '.$contenttype,
-                 'Content-Length: '.strlen($data),
-                 'Content-Language: en-US',
-               );
+                    'Content-Type: '.$contenttype,
+                    'Content-Length: '.strlen($data),
+                    'Content-Language: en-US',
+                );
 
         return $c->post($url, $data, $options);
     }
@@ -717,16 +717,16 @@ 
         'all' => array(
             'name' => get_string('mod_form_field_participant_list_type_all', 'bigbluebuttonbn'),
             'children' => []
-          )
-      );
+            )
+        );
     $data['role'] = array(
         'name' => get_string('mod_form_field_participant_list_type_role', 'bigbluebuttonbn'),
         'children' => bigbluebuttonbn_get_roles_select($context)
-      );
+        );
     $data['user'] = array(
         'name' => get_string('mod_form_field_participant_list_type_user', 'bigbluebuttonbn'),
         'children' => bigbluebuttonbn_get_users_select($context)
-      );
+        );
     return $data;
 }
 
@@ -771,9 +771,9 @@ 
             continue;
         }
         $participantlistarray[] = array(
-              'selectiontype' => 'role',
-              'selectionid' => $moderatordefault,
-              'role' => BIGBLUEBUTTONBN_ROLE_MODERATOR);
+                'selectiontype' => 'role',
+                'selectionid' => $moderatordefault,
+                'role' => BIGBLUEBUTTONBN_ROLE_MODERATOR);
     }
     return $participantlistarray;
 }
@@ -816,11 +816,11 @@ 
             'all' => get_string('mod_form_field_participant_list_type_all', 'bigbluebuttonbn'),
             'role' => get_string('mod_form_field_participant_list_type_role', 'bigbluebuttonbn'),
             'user' => get_string('mod_form_field_participant_list_type_user', 'bigbluebuttonbn'),
-          ],
+            ],
         'type_selected' => 'all',
         'options' => ['all' => '---------------'],
         'selected' => 'all',
-      ];
+        ];
 }
 
 /**
@@ -1100,7 +1100,7 @@ 
     // Ping again and refresh the cache.
     $meetinginfo = (array) bigbluebuttonbn_wrap_xml_load_file(
         \mod_bigbluebuttonbn\locallib\bigbluebutton::action_url('getMeetingInfo', ['meetingID' => $meetingid])
-      );
+        );
     $cache->set($meetingid, array('creation_time' => time(), 'meeting_info' => json_encode($meetinginfo)));
     return $meetinginfo;
 }
@@ -1512,8 +1512,8 @@ 
     }
     $id = 'playbacks-'.$recording['recordID'];
     $recordingtypes = html_writer::start_tag('div', array('id' => $id, 'data-imported' => $dataimported,
-          'data-meetingid' => $recording['meetingID'], 'data-recordingid' => $recording['recordID'],
-          'title' => $title, $visibility => $visibility));
+            'data-meetingid' => $recording['meetingID'], 'data-recordingid' => $recording['recordID'],
+            'title' => $title, $visibility => $visibility));
     foreach ($recording['playbacks'] as $playback) {
         $recordingtypes .= bigbluebuttonbn_get_recording_data_row_type($recording, $bbbsession, $playback);
     }
@@ -1537,7 +1537,7 @@ 
     }
     $text = get_string('view_recording_format_'.$playback['type'], 'bigbluebuttonbn');
     $href = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_view.php?action=play&bn=' . $bbbsession['bigbluebuttonbn']->id .
-      '&mid='.$recording['meetingID'] . '&rid=' . $recording['recordID'] . '&rtype=' . $playback['type'];
+        '&mid='.$recording['meetingID'] . '&rid=' . $recording['recordID'] . '&rtype=' . $playback['type'];
     if (!isset($recording['imported']) || !isset($recording['protected']) || $recording['protected'] === 'false') {
         $href .= '&href='.urlencode(trim($playback['url']));
     }
@@ -1548,7 +1548,7 @@ 
         'data-action' => 'play',
         'data-target' => $playback['type'],
         'data-href' => $href,
-      );
+        );
     if (!bigbluebuttonbn_validate_resource(trim($playback['url']))) {
         $linkattributes['class'] = 'btn btn-sm btn-warning';
         $linkattributes['title'] = get_string('view_recording_format_errror_unreachable', 'bigbluebuttonbn');
@@ -1684,10 +1684,10 @@ 
             'id' => $id,
             'onclick' => $onclick,
             'data-action' => $data['action']
-          );
+            );
         if (!isset($recording['imported'])) {
             $linkattributes['data-links'] = bigbluebuttonbn_count_recording_imported_instances(
-              $recording['recordID']);
+                $recording['recordID']);
         }
         if (isset($data['disabled'])) {
             $iconattributes['class'] .= ' fa-' . $data['disabled'];
@@ -2228,8 +2228,8 @@ 
     $activitytime = '';
     if ($time) {
         $activitytime = calendar_day_representation($time).' '.
-          get_string('mod_form_field_notification_msg_at', 'bigbluebuttonbn').' '.
-          calendar_time_representation($time);
+            get_string('mod_form_field_notification_msg_at', 'bigbluebuttonbn').' '.
+            calendar_time_representation($time);
     }
     return $activitytime;
 }
@@ -2529,7 +2529,7 @@ 
         $renderer->render_group_element('participant_moderator_default',
             $renderer->render_group_element_configmultiselect('participant_moderator_default',
                 array_keys($owner), array_merge($owner, $roles))
-          );
+            );
     }
 }
 
@@ -2633,7 +2633,7 @@ 
         return $output;
     }
     $output .= $OUTPUT->box_start('box boxalignleft adminerror alert alert-' . $type . ' alert-block fade in',
-      'bigbluebuttonbn_view_general_warning') . "\n";
+        'bigbluebuttonbn_view_general_warning') . "\n";
     $output .= '    ' . $message . "\n";
     $output .= '  <div class="singlebutton pull-right">' . "\n";
     if (!empty($href)) {

Spacing +57 added lines, -57 removed lines

@@ -28,7 +28,7 @@ 
 
 global $CFG;
 
-require_once(dirname(__FILE__).'/lib.php');
+require_once(dirname(__FILE__) . '/lib.php');
 
 /** @var BIGBLUEBUTTONBN_UPDATE_CACHE boolean set to true indicates that cache has to be updated */
 const BIGBLUEBUTTONBN_UPDATE_CACHE = true;
@@ -102,7 +102,7 @@ 
     if (isset($meta)) {
         $log->meta = $meta;
     } else if ($event == BIGBLUEBUTTONBN_LOG_EVENT_CREATE) {
-        $log->meta = '{"record":'.($bbbsession['record'] ? 'true' : 'false').'}';
+        $log->meta = '{"record":' . ($bbbsession['record'] ? 'true' : 'false') . '}';
     }
     $DB->insert_record('bigbluebuttonbn_logs', $log);
 }
@@ -150,8 +150,8 @@ 
     $data = null;
     if (!is_null($pname) && !is_null($purl)) {
         $method = 'POST';
-        $data = "<?xml version='1.0' encoding='UTF-8'?><modules><module name='presentation'><document url='".
-            $purl."' /></module></modules>";
+        $data = "<?xml version='1.0' encoding='UTF-8'?><modules><module name='presentation'><document url='" .
+            $purl . "' /></module></modules>";
     }
     $xml = bigbluebuttonbn_wrap_xml_load_file($createmeetingurl, $method, $data);
     if ($xml) {
@@ -312,7 +312,7 @@ 
         // Override imported flag with actual ID.
         $recording['imported'] = $recordimported->id;
         if (isset($recordimported->protected)) {
-            $recording['protected'] = (string) $recordimported->protected;
+            $recording['protected'] = (string)$recordimported->protected;
         }
         $recordsimportedarray[$recording['recordID']] = $recording;
     }
@@ -342,21 +342,21 @@ 
     // Add formats.
     $playbackarray = array();
     foreach ($recording->playback->format as $format) {
-        $playbackarray[(string) $format->type] = array('type' => (string) $format->type,
-            'url' => trim((string) $format->url), 'length' => (string) $format->length);
+        $playbackarray[(string)$format->type] = array('type' => (string)$format->type,
+            'url' => trim((string)$format->url), 'length' => (string)$format->length);
         // Add preview per format when existing.
         if ($format->preview) {
-            $playbackarray[(string) $format->type]['preview'] = bigbluebuttonbn_get_recording_preview_images($format->preview);
+            $playbackarray[(string)$format->type]['preview'] = bigbluebuttonbn_get_recording_preview_images($format->preview);
         }
     }
     // Add the metadata to the recordings array.
     $metadataarray = bigbluebuttonbn_get_recording_array_meta(get_object_vars($recording->metadata));
-    $recordingarray = array('recordID' => (string) $recording->recordID,
-        'meetingID' => (string) $recording->meetingID, 'meetingName' => (string) $recording->name,
-        'published' => (string) $recording->published, 'startTime' => (string) $recording->startTime,
-        'endTime' => (string) $recording->endTime, 'playbacks' => $playbackarray);
+    $recordingarray = array('recordID' => (string)$recording->recordID,
+        'meetingID' => (string)$recording->meetingID, 'meetingName' => (string)$recording->name,
+        'published' => (string)$recording->published, 'startTime' => (string)$recording->startTime,
+        'endTime' => (string)$recording->endTime, 'playbacks' => $playbackarray);
     if (isset($recording->protected)) {
-        $recordingarray['protected'] = (string) $recording->protected;
+        $recordingarray['protected'] = (string)$recording->protected;
     }
     return $recordingarray + $metadataarray;
 }
@@ -371,9 +371,9 @@ 
 function bigbluebuttonbn_get_recording_preview_images($preview) {
     $imagesarray = array();
     foreach ($preview->images->image as $image) {
-        $imagearray = array('url' => trim((string) $image));
+        $imagearray = array('url' => trim((string)$image));
         foreach ($image->attributes() as $attkey => $attvalue) {
-            $imagearray[$attkey] = (string) $attvalue;
+            $imagearray[$attkey] = (string)$attvalue;
         }
         array_push($imagesarray, $imagearray);
     }
@@ -393,7 +393,7 @@ 
         if (is_object($value)) {
             $value = '';
         }
-        $metadataarray['meta_'.$key] = $value;
+        $metadataarray['meta_' . $key] = $value;
     }
     return $metadataarray;
 }
@@ -465,7 +465,7 @@ 
     $ids = explode(',', $recordids);
     foreach ($ids as $id) {
         $xml = bigbluebuttonbn_wrap_xml_load_file(
-            \mod_bigbluebuttonbn\locallib\bigbluebutton::action_url('updateRecordings', ['recordID' => $id] + (array) $params)
+            \mod_bigbluebuttonbn\locallib\bigbluebutton::action_url('updateRecordings', ['recordID' => $id] + (array)$params)
           );
         if ($xml && $xml->returncode != 'SUCCESS') {
             return false;
@@ -530,7 +530,7 @@ 
             return $xml;
         } catch (Exception $e) {
             libxml_use_internal_errors($previous);
-            $error = 'Caught exception: '.$e->getMessage();
+            $error = 'Caught exception: ' . $e->getMessage();
             debugging($error, DEBUG_DEVELOPER);
             return null;
         }
@@ -541,7 +541,7 @@ 
         $response = simplexml_load_file($url, 'SimpleXMLElement', LIBXML_NOCDATA | LIBXML_NOBLANKS);
         return $response;
     } catch (Exception $e) {
-        $error = 'Caught exception: '.$e->getMessage();
+        $error = 'Caught exception: ' . $e->getMessage();
         debugging($error, DEBUG_DEVELOPER);
         libxml_use_internal_errors($previous);
         return null;
@@ -567,8 +567,8 @@ 
         }
         $options = array();
         $options['CURLOPT_HTTPHEADER'] = array(
-                 'Content-Type: '.$contenttype,
-                 'Content-Length: '.strlen($data),
+                 'Content-Type: ' . $contenttype,
+                 'Content-Length: ' . strlen($data),
                  'Content-Language: en-US',
                );
 
@@ -589,7 +589,7 @@ 
  * @return void
  */
 function bigbluebuttonbn_end_meeting_if_running($bigbluebuttonbn) {
-    $meetingid = $bigbluebuttonbn->meetingid.'-'.$bigbluebuttonbn->course.'-'.$bigbluebuttonbn->id;
+    $meetingid = $bigbluebuttonbn->meetingid . '-' . $bigbluebuttonbn->course . '-' . $bigbluebuttonbn->id;
     if (bigbluebuttonbn_is_meeting_running($meetingid)) {
         bigbluebuttonbn_end_meeting($meetingid, $bigbluebuttonbn->moderatorpass);
     }
@@ -609,9 +609,9 @@ 
     if ($userroles) {
         $where = '';
         foreach ($userroles as $userrole) {
-            $where .= (empty($where) ? ' WHERE' : ' OR').' id=' . $userrole->roleid;
+            $where .= (empty($where) ? ' WHERE' : ' OR') . ' id=' . $userrole->roleid;
         }
-        $userroles = $DB->get_records_sql('SELECT * FROM {role}'.$where);
+        $userroles = $DB->get_records_sql('SELECT * FROM {role}' . $where);
     }
     return $userroles;
 }
@@ -634,7 +634,7 @@ 
  * @return array $users
  */
 function bigbluebuttonbn_get_users(context $context = null) {
-    $users = (array) get_enrolled_users($context, '', 0, 'u.*', null, 0, 0, true);
+    $users = (array)get_enrolled_users($context, '', 0, 'u.*', null, 0, 0, true);
     foreach ($users as $key => $value) {
         $users[$key] = fullname($value);
     }
@@ -649,7 +649,7 @@ 
  * @return array $users
  */
 function bigbluebuttonbn_get_users_select(context $context = null) {
-    $users = (array) get_enrolled_users($context, '', 0, 'u.*', null, 0, 0, true);
+    $users = (array)get_enrolled_users($context, '', 0, 'u.*', null, 0, 0, true);
     foreach ($users as $key => $value) {
         $users[$key] = array('id' => $value->id, 'name' => fullname($value));
     }
@@ -664,7 +664,7 @@ 
  * @return array $roles
  */
 function bigbluebuttonbn_get_roles(context $context = null) {
-    $roles = (array) role_get_names($context);
+    $roles = (array)role_get_names($context);
     foreach ($roles as $key => $value) {
         $roles[$key] = $value->localname;
     }
@@ -679,7 +679,7 @@ 
  * @return array $users
  */
 function bigbluebuttonbn_get_roles_select(context $context = null) {
-    $roles = (array) role_get_names($context);
+    $roles = (array)role_get_names($context);
     foreach ($roles as $key => $value) {
         $roles[$key] = array('id' => $value->id, 'name' => $value->localname);
     }
@@ -694,7 +694,7 @@ 
  * @return object $role
  */
 function bigbluebuttonbn_get_role($id) {
-    $roles = (array) role_get_names();
+    $roles = (array)role_get_names();
     if (is_numeric($id) && isset($roles[$id])) {
         return (object)$roles[$id];
     }
@@ -849,7 +849,7 @@ 
     if (!isguestuser()) {
         $userroles = bigbluebuttonbn_get_user_roles($context, $userid);
     }
-    return bigbluebuttonbn_is_moderator_validator($participantlist, $userid , $userroles);
+    return bigbluebuttonbn_is_moderator_validator($participantlist, $userid, $userroles);
 }
 
 /**
@@ -1005,7 +1005,7 @@ 
 function bigbluebuttonbn_generate_nonce() {
     $mt = microtime();
     $rand = mt_rand();
-    return md5($mt.$rand);
+    return md5($mt . $rand);
 }
 
 /**
@@ -1095,10 +1095,10 @@ 
     $now = time();
     if (!$updatecache && isset($result) && $now < ($result['creation_time'] + $cachettl)) {
         // Use the value in the cache.
-        return (array) json_decode($result['meeting_info']);
+        return (array)json_decode($result['meeting_info']);
     }
     // Ping again and refresh the cache.
-    $meetinginfo = (array) bigbluebuttonbn_wrap_xml_load_file(
+    $meetinginfo = (array)bigbluebuttonbn_wrap_xml_load_file(
         \mod_bigbluebuttonbn\locallib\bigbluebutton::action_url('getMeetingInfo', ['meetingID' => $meetingid])
       );
     $cache->set($meetingid, array('creation_time' => time(), 'meeting_info' => json_encode($meetinginfo)));
@@ -1209,7 +1209,7 @@ 
  * @return object
  */
 function bigbluebuttonbn_set_config_xml($meetingid, $configxml) {
-    $urldefaultconfig = \mod_bigbluebuttonbn\locallib\config::get('server_url').'api/setConfigXML?';
+    $urldefaultconfig = \mod_bigbluebuttonbn\locallib\config::get('server_url') . 'api/setConfigXML?';
     $configxmlparams = bigbluebuttonbn_set_config_xml_params($meetingid, $configxml);
     $xml = bigbluebuttonbn_wrap_xml_load_file($urldefaultconfig, 'POST',
         $configxmlparams, 'application/x-www-form-urlencoded');
@@ -1225,8 +1225,8 @@ 
  * @return string
  */
 function bigbluebuttonbn_set_config_xml_params($meetingid, $configxml) {
-    $params = 'configXML='.urlencode($configxml).'&meetingID='.urlencode($meetingid);
-    $configxmlparams = $params.'&checksum='.sha1('setConfigXML'.$params.\mod_bigbluebuttonbn\locallib\config::get('shared_secret'));
+    $params = 'configXML=' . urlencode($configxml) . '&meetingID=' . urlencode($meetingid);
+    $configxmlparams = $params . '&checksum=' . sha1('setConfigXML' . $params . \mod_bigbluebuttonbn\locallib\config::get('shared_secret'));
     return $configxmlparams;
 }
 
@@ -1240,7 +1240,7 @@ 
  */
 function bigbluebuttonbn_set_config_xml_array($meetingid, $configxml) {
     $configxml = bigbluebuttonbn_setConfigXML($meetingid, $configxml);
-    $configxmlarray = (array) $configxml;
+    $configxmlarray = (array)$configxml;
     if ($configxmlarray['returncode'] != 'SUCCESS') {
         debugging('BigBlueButton was not able to set the custom config.xml file', DEBUG_DEVELOPER);
         return '';
@@ -1332,7 +1332,7 @@ 
     global $USER;
     $starttime = $starttime - ($starttime % 1000);
     // Set formatted date.
-    $dateformat = get_string('strftimerecentfull', 'langconfig').' %Z';
+    $dateformat = get_string('strftimerecentfull', 'langconfig') . ' %Z';
     return userdate($starttime / 1000, $dateformat, usertimezone($USER->timezone));
 }
 
@@ -1448,7 +1448,7 @@ 
  * @return string
  */
 function bigbluebuttonbn_get_recording_data_row_preview($recording) {
-    $options = array('id' => 'preview-'.$recording['recordID']);
+    $options = array('id' => 'preview-' . $recording['recordID']);
     if ($recording['published'] === 'false') {
         $options['hidden'] = 'hidden';
     }
@@ -1510,7 +1510,7 @@ 
     if ($recording['published'] === 'false') {
         $visibility = 'hidden ';
     }
-    $id = 'playbacks-'.$recording['recordID'];
+    $id = 'playbacks-' . $recording['recordID'];
     $recordingtypes = html_writer::start_tag('div', array('id' => $id, 'data-imported' => $dataimported,
           'data-meetingid' => $recording['meetingID'], 'data-recordingid' => $recording['recordID'],
           'title' => $title, $visibility => $visibility));
@@ -1535,11 +1535,11 @@ 
     if (!bigbluebuttonbn_include_recording_data_row_type($recording, $bbbsession, $playback)) {
         return '';
     }
-    $text = get_string('view_recording_format_'.$playback['type'], 'bigbluebuttonbn');
+    $text = get_string('view_recording_format_' . $playback['type'], 'bigbluebuttonbn');
     $href = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_view.php?action=play&bn=' . $bbbsession['bigbluebuttonbn']->id .
-      '&mid='.$recording['meetingID'] . '&rid=' . $recording['recordID'] . '&rtype=' . $playback['type'];
+      '&mid=' . $recording['meetingID'] . '&rid=' . $recording['recordID'] . '&rtype=' . $playback['type'];
     if (!isset($recording['imported']) || !isset($recording['protected']) || $recording['protected'] === 'false') {
-        $href .= '&href='.urlencode(trim($playback['url']));
+        $href .= '&href=' . urlencode(trim($playback['url']));
     }
     $linkattributes = array(
         'id' => 'recording-play-' . $playback['type'] . '-' . $recording['recordID'],
@@ -1694,7 +1694,7 @@ 
             $linkattributes['class'] = 'disabled';
             unset($linkattributes['onclick']);
         }
-        $icon = new pix_icon('i/'.$data['tag'],
+        $icon = new pix_icon('i/' . $data['tag'],
             get_string('view_recording_list_actionbar_' . $data['action'], 'bigbluebuttonbn'),
             'moodle', $iconattributes);
         return $OUTPUT->action_icon('#', $icon, null, $linkattributes, false);
@@ -1811,7 +1811,7 @@ 
  */
 function bigbluebuttonbn_get_recording_table_row($bbbsession, $recording, $rowdata) {
     $row = new html_table_row();
-    $row->id = 'recording-tr-'.$recording['recordID'];
+    $row->id = 'recording-tr-' . $recording['recordID'];
     $row->attributes['data-imported'] = 'false';
     $texthead = '';
     $texttail = '';
@@ -1871,9 +1871,9 @@ 
 function bigbluebuttonbn_send_notification_recording_ready($bigbluebuttonbn) {
     $sender = get_admin();
     // Prepare message.
-    $messagetext = '<p>'.get_string('email_body_recording_ready_for', 'bigbluebuttonbn').
-        ' &quot;' . $bigbluebuttonbn->name . '&quot; '.
-        get_string('email_body_recording_ready_is_ready', 'bigbluebuttonbn').'.</p>';
+    $messagetext = '<p>' . get_string('email_body_recording_ready_for', 'bigbluebuttonbn') .
+        ' &quot;' . $bigbluebuttonbn->name . '&quot; ' .
+        get_string('email_body_recording_ready_is_ready', 'bigbluebuttonbn') . '.</p>';
     $context = context_course::instance($bigbluebuttonbn->course);
     \mod_bigbluebuttonbn\locallib\notifier::notification_send($context, $sender, $bigbluebuttonbn, $messagetext);
 }
@@ -2095,7 +2095,7 @@ 
     }
     // Prepare select for loading records based on existent bigbluebuttonbns.
     $sql = 'SELECT DISTINCT meetingid, bigbluebuttonbnid FROM {bigbluebuttonbn_logs} WHERE ';
-    $sql .= '(bigbluebuttonbnid='.implode(' OR bigbluebuttonbnid=', array_keys($bigbluebuttonbns)).')';
+    $sql .= '(bigbluebuttonbnid=' . implode(' OR bigbluebuttonbnid=', array_keys($bigbluebuttonbns)) . ')';
     // Include only Create events and exclude those with record not true.
     $sql .= ' AND log = ? AND meta LIKE ? AND meta LIKE ?';
     // Execute select for loading records based on existent bigbluebuttonbns.
@@ -2227,8 +2227,8 @@ 
 function bigbluebuttonbn_format_activity_time($time) {
     $activitytime = '';
     if ($time) {
-        $activitytime = calendar_day_representation($time).' '.
-          get_string('mod_form_field_notification_msg_at', 'bigbluebuttonbn').' '.
+        $activitytime = calendar_day_representation($time) . ' ' .
+          get_string('mod_form_field_notification_msg_at', 'bigbluebuttonbn') . ' ' .
           calendar_time_representation($time);
     }
     return $activitytime;
@@ -2625,7 +2625,7 @@ 
  *
  * @return string
  */
-function bigbluebuttonbn_render_warning($message, $type='info', $href='', $text='', $class='') {
+function bigbluebuttonbn_render_warning($message, $type = 'info', $href = '', $text = '', $class = '') {
     global $OUTPUT;
     $output = "\n";
     // Evaluates if config_warning is enabled.
@@ -2664,11 +2664,11 @@ 
     if ($class == '') {
         $class = 'btn btn-secondary';
     }
-    $output  = '  <form method="post" action="' . $href . '" class="form-inline">'."\n";
-    $output .= '      <button type="submit" class="' . $class . '"'."\n";
-    $output .= '          title="' . $title . '"'."\n";
-    $output .= '          >' . $text . '</button>'."\n";
-    $output .= '  </form>'."\n";
+    $output  = '  <form method="post" action="' . $href . '" class="form-inline">' . "\n";
+    $output .= '      <button type="submit" class="' . $class . '"' . "\n";
+    $output .= '          title="' . $title . '"' . "\n";
+    $output .= '          >' . $text . '</button>' . "\n";
+    $output .= '  </form>' . "\n";
     return $output;
 }