bkintanar / HRis

app/Api/Controllers/LookupTableController.php

Doc Comments +2 added lines, -2 removed lines

@@ -207,7 +207,7 @@ 
 
     /**
      * @param      $model
-     * @param null $custom_attribute
+     * @param string $custom_attribute
      *
      * @return \Illuminate\Http\JsonResponse
      *
@@ -224,7 +224,7 @@ 
 
     /**
      * @param      $model
-     * @param null $custom_attribute
+     * @param string[] $custom_attribute
      *
      * @return \Illuminate\Http\JsonResponse
      *

app/Api/Controllers/PIM/Configuration/CustomFieldsController.php

Spacing +1 added lines, -1 removed lines

@@ -353,7 +353,7 @@
 
         $custom_field_sections = $this->custom_field_section->with('customFields.options')->whereScreenId($screen_id)->get();
 
-        $custom_field_sections->each(function ($custom_field_section) {
+        $custom_field_sections->each(function($custom_field_section) {
             $custom_fields = $custom_field_section->customFields;
 
             $custom_field_section->fields = array_chunk($custom_fields->toArray(), 2);

app/Api/Eloquent/Navlink.php

Spacing +3 added lines, -3 removed lines

@@ -406,7 +406,7 @@ 
     {
         $parent_links = self::where('parent_id', 0)->get();
 
-        $parent_links->each(function ($item) {
+        $parent_links->each(function($item) {
             $item->route = str_replace('/', '-', $item->href);
         })->toArray();
 
@@ -428,7 +428,7 @@ 
         foreach ($children as $k => $child) {
             $grand_children = self::where('parent_id', $child['id'])->get();
 
-            $grand_children->each(function ($item) {
+            $grand_children->each(function($item) {
                 $item->route = str_replace('/', '-', $item->href);
             })->toArray();
 
@@ -450,7 +450,7 @@ 
      */
     private static function filterPermission($user, $links)
     {
-        return $links->filter(function (Navlink $item) use ($user) {
+        return $links->filter(function(Navlink $item) use ($user) {
             $permission = str_replace('/', '.', $item->href);
 
             return $user->hasAccess($permission.'.view');

app/Providers/RouteServiceProvider.php

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
      */
     public function map(Router $router)
     {
-        $router->group(['namespace' => $this->namespace], function ($router) {
+        $router->group(['namespace' => $this->namespace], function($router) {
             require app_path('Http/routes.php');
         });
     }

app/Http/routes.php

Spacing +57 added lines, -57 removed lines

@@ -5,7 +5,7 @@ 
 $api = app(Router::class);
 
 // Version 1 of our API
-$api->version('v1', function (Router $api) {
+$api->version('v1', function(Router $api) {
 
     // Set our namespace for the underlying routes
     $api->group([
@@ -15,40 +15,40 @@ 
             'api.throttle',
         ],
         'limit'   => 200,
-        'expires' => 5, ], function (Router $api) {
+        'expires' => 5, ], function(Router $api) {
 
         // Login route
-        $api->post('login', 'Auth\AuthController@authenticate');                                            // docs done
+        $api->post('login', 'Auth\AuthController@authenticate'); // docs done
         $api->post('register', 'Auth\AuthController@register');
 
         $api->get('auth/refresh', 'Auth\AuthController@token');
 
         // All routes in here are protected and thus need a valid token
-        $api->group(['protected' => true, 'middleware' => 'jwt.auth'], function (Router $api) {
+        $api->group(['protected' => true, 'middleware' => 'jwt.auth'], function(Router $api) {
 
             // Authentication
-            $api->get('logout', 'Auth\AuthController@logout');                                              // docs done
+            $api->get('logout', 'Auth\AuthController@logout'); // docs done
             $api->get('users/me', 'Auth\AuthController@me');
             $api->post('sidebar', 'Auth\AuthController@sidebar');
 
             // Profile
-            $api->group(['prefix' => 'profile', 'namespace' => 'Profile'], function (Router $api) {
-                $api->patch('personal-details', 'PersonalDetailsController@update');                        // docs done
+            $api->group(['prefix' => 'profile', 'namespace' => 'Profile'], function(Router $api) {
+                $api->patch('personal-details', 'PersonalDetailsController@update'); // docs done
 
-                $api->patch('contact-details', 'PersonalDetailsController@update');                         // docs done
+                $api->patch('contact-details', 'PersonalDetailsController@update'); // docs done
 
-                $api->post('emergency-contacts', 'EmergencyContactsController@store');                      // docs done
-                $api->patch('emergency-contacts', 'EmergencyContactsController@update');                    // docs done
-                $api->delete('emergency-contacts', 'EmergencyContactsController@destroy');                  // docs done
+                $api->post('emergency-contacts', 'EmergencyContactsController@store'); // docs done
+                $api->patch('emergency-contacts', 'EmergencyContactsController@update'); // docs done
+                $api->delete('emergency-contacts', 'EmergencyContactsController@destroy'); // docs done
 
-                $api->post('dependents', 'DependentsController@store');                                     // docs done
-                $api->patch('dependents', 'DependentsController@update');                                   // docs done
-                $api->delete('dependents', 'DependentsController@destroy');                                 // docs done
+                $api->post('dependents', 'DependentsController@store'); // docs done
+                $api->patch('dependents', 'DependentsController@update'); // docs done
+                $api->delete('dependents', 'DependentsController@destroy'); // docs done
 
                 $api->patch('job', 'JobController@update');
                 $api->delete('job', 'JobController@destroy');
 
-                $api->group(['prefix' => 'qualifications'], function (Router $api) {
+                $api->group(['prefix' => 'qualifications'], function(Router $api) {
                     $api->post('work-experiences', 'QualificationsController@storeWorkExperience');
                     $api->delete('work-experiences', 'QualificationsController@destroyWorkExperience');
                     $api->patch('work-experiences', 'QualificationsController@updateWorkExperience');
@@ -64,21 +64,21 @@ 
             });
 
             // Employee
-            $api->group(['prefix' => 'employee'], function (Router $api) {
+            $api->group(['prefix' => 'employee'], function(Router $api) {
                 $api->post('get-by-employee-id', 'EmployeeController@getByEmployeeId');
             });
 
             // PIM
-            $api->group(['prefix' => 'pim', 'namespace' => 'PIM'], function (Router $api) {
+            $api->group(['prefix' => 'pim', 'namespace' => 'PIM'], function(Router $api) {
                 $api->get('employee-list', 'EmployeeListController@index');
 
                 // Configuration
-                $api->group(['prefix' => 'configuration', 'namespace' => 'Configuration'], function (Router $api) {
+                $api->group(['prefix' => 'configuration', 'namespace' => 'Configuration'], function(Router $api) {
 
-                    $api->get('termination-reasons', 'TerminationReasonsController@index');                  // docs done
-                    $api->post('termination-reasons', 'TerminationReasonsController@store');                 // docs done
-                    $api->patch('termination-reasons', 'TerminationReasonsController@update');               // docs done
-                    $api->delete('termination-reasons', 'TerminationReasonsController@destroy');             // docs done
+                    $api->get('termination-reasons', 'TerminationReasonsController@index'); // docs done
+                    $api->post('termination-reasons', 'TerminationReasonsController@store'); // docs done
+                    $api->patch('termination-reasons', 'TerminationReasonsController@update'); // docs done
+                    $api->delete('termination-reasons', 'TerminationReasonsController@destroy'); // docs done
 
                     $api->get('custom-field-sections', 'CustomFieldsController@index');
                     $api->post('custom-field-sections', 'CustomFieldsController@store');
@@ -94,50 +94,50 @@ 
             });
 
             // Admin
-            $api->group(['prefix' => 'admin', 'namespace' => 'Admin'], function (Router $api) {
+            $api->group(['prefix' => 'admin', 'namespace' => 'Admin'], function(Router $api) {
 
                 // Job
-                $api->group(['prefix' => 'job', 'namespace' => 'Job'], function (Router $api) {
-                    $api->get('titles', 'JobTitlesController@index');                                       // docs done
-                    $api->post('titles', 'JobTitlesController@store');                                      // docs done
-                    $api->patch('titles', 'JobTitlesController@update');                                    // docs done
-                    $api->delete('titles', 'JobTitlesController@destroy');                                  // docs done
-
-                    $api->get('employment-status', 'EmploymentStatusController@index');                     // docs done
-                    $api->post('employment-status', 'EmploymentStatusController@store');                    // docs done
-                    $api->patch('employment-status', 'EmploymentStatusController@update');                  // docs done
-                    $api->delete('employment-status', 'EmploymentStatusController@destroy');                // docs done
-
-                    $api->get('pay-grades', 'PayGradesController@index');                                   // docs done
-                    $api->post('pay-grades', 'PayGradesController@store');                                  // docs done
-                    $api->patch('pay-grades', 'PayGradesController@update');                                // docs done
-                    $api->delete('pay-grades', 'PayGradesController@destroy');                              // docs done
+                $api->group(['prefix' => 'job', 'namespace' => 'Job'], function(Router $api) {
+                    $api->get('titles', 'JobTitlesController@index'); // docs done
+                    $api->post('titles', 'JobTitlesController@store'); // docs done
+                    $api->patch('titles', 'JobTitlesController@update'); // docs done
+                    $api->delete('titles', 'JobTitlesController@destroy'); // docs done
+
+                    $api->get('employment-status', 'EmploymentStatusController@index'); // docs done
+                    $api->post('employment-status', 'EmploymentStatusController@store'); // docs done
+                    $api->patch('employment-status', 'EmploymentStatusController@update'); // docs done
+                    $api->delete('employment-status', 'EmploymentStatusController@destroy'); // docs done
+
+                    $api->get('pay-grades', 'PayGradesController@index'); // docs done
+                    $api->post('pay-grades', 'PayGradesController@store'); // docs done
+                    $api->patch('pay-grades', 'PayGradesController@update'); // docs done
+                    $api->delete('pay-grades', 'PayGradesController@destroy'); // docs done
                 });
 
                 // Qualification
-                $api->group(['prefix' => 'qualifications', 'namespace' => 'Qualifications'], function (Router $api) {
-                    $api->get('educations', 'EducationsController@index');                                  // docs done
-                    $api->post('educations', 'EducationsController@store');                                 // docs done
-                    $api->patch('educations', 'EducationsController@update');                               // docs done
-                    $api->delete('educations', 'EducationsController@destroy');                             // docs done
+                $api->group(['prefix' => 'qualifications', 'namespace' => 'Qualifications'], function(Router $api) {
+                    $api->get('educations', 'EducationsController@index'); // docs done
+                    $api->post('educations', 'EducationsController@store'); // docs done
+                    $api->patch('educations', 'EducationsController@update'); // docs done
+                    $api->delete('educations', 'EducationsController@destroy'); // docs done
                 });
             });
 
             // Chosen
-            $api->get('cities', 'LookupTableController@cities');                                            // docs done
-            $api->get('countries', 'LookupTableController@countries');                                      // docs done
-            $api->get('departments', 'LookupTableController@departments');                                  // docs done
-            $api->get('education-levels', 'LookupTableController@educationLevels');                         // docs done
-            $api->get('employment-statuses', 'LookupTableController@employmentStatuses');                   // docs done
-            $api->get('job-titles', 'LookupTableController@jobTitles');                                     // docs done
-            $api->get('locations', 'LookupTableController@locations');                                      // docs done
-            $api->get('marital-statuses', 'LookupTableController@maritalStatuses');                         // docs done
-            $api->get('screens', 'LookupTableController@screens');                                          // docs done
-            $api->get('types', 'LookupTableController@types');                                              // docs done
-            $api->get('nationalities', 'LookupTableController@nationalities');                              // docs done
-            $api->get('provinces', 'LookupTableController@provinces');                                      // docs done
-            $api->get('relationships', 'LookupTableController@relationships');                              // docs done
-            $api->get('skills', 'LookupTableController@skills');                                            // docs done
+            $api->get('cities', 'LookupTableController@cities'); // docs done
+            $api->get('countries', 'LookupTableController@countries'); // docs done
+            $api->get('departments', 'LookupTableController@departments'); // docs done
+            $api->get('education-levels', 'LookupTableController@educationLevels'); // docs done
+            $api->get('employment-statuses', 'LookupTableController@employmentStatuses'); // docs done
+            $api->get('job-titles', 'LookupTableController@jobTitles'); // docs done
+            $api->get('locations', 'LookupTableController@locations'); // docs done
+            $api->get('marital-statuses', 'LookupTableController@maritalStatuses'); // docs done
+            $api->get('screens', 'LookupTableController@screens'); // docs done
+            $api->get('types', 'LookupTableController@types'); // docs done
+            $api->get('nationalities', 'LookupTableController@nationalities'); // docs done
+            $api->get('provinces', 'LookupTableController@provinces'); // docs done
+            $api->get('relationships', 'LookupTableController@relationships'); // docs done
+            $api->get('skills', 'LookupTableController@skills'); // docs done
         });
 
     });

app/Http/Requests/Request.php

Doc Comments +1 added lines, -1 removed lines

@@ -56,7 +56,7 @@
     /**
      * Check if logged user has access.
      *
-     * @param $permission
+     * @param string $permission
      * @return bool
      */
     public function hasAccess($permission)