ApplicationServerImpl::__construct() - Code Metrics - Inspection of "chore: delete debug" - bingo-soft/jabe - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — main ( d01f4c...5af89f )

by Bingo

created 2022-05-18 13:34 UTC

ApplicationServerImpl::__construct() A

↳ Parent: ApplicationServerImpl

Complexity

Conditions	3
Paths	4

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	2
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	3
nc	4
nop	2

<?php

namespace Jabe\Engine\Impl\Telemetry\Dto;

use Jabe\Engine\Impl\Util\ParseUtil;
use Jabe\Engine\Telemetry\ApplicationServerInterface;

class ApplicationServerImpl implements ApplicationServerInterface
{
    protected $vendor;
    protected $version;

    public function __construct(string $vendorOrVersion, string $version = null)
    {
        $this->vendor = $version == null ? ParseUtil::parseServerVendor($vendorOrVersion) : $vendorOrVersion;

        $this->version = $version == null ? $vendorOrVersion : $version;

    }

    public function __toString()
    {
        return json_encode([
            'vendor' => $this->vendor,
            'version' => $this->version
        ]);
    }

    public function getVendor(): string
    {
        return $this->vendor;
    }

    public function setVendor(string $vendor): void
    {
        $this->vendor = $vendor;
    }

    public function getVersion(): string
    {
        return $this->version;
    }

    public function setVersion(string $version): void
    {
        $this->version = $version;
    }
}


1			<?php
2
3			namespace Jabe\Engine\Impl\Telemetry\Dto;
4
5			use Jabe\Engine\Impl\Util\ParseUtil;
6			use Jabe\Engine\Telemetry\ApplicationServerInterface;
7
8			class ApplicationServerImpl implements ApplicationServerInterface
9			{
10			protected $vendor;
11			protected $version;
12
13			public function __construct(string $vendorOrVersion, string $version = null)
14			{
15			$this->vendor = $version == null ? ParseUtil::parseServerVendor($vendorOrVersion) : $vendorOrVersion;
			0 ignored issues – show Bug introduced 2022-05-18 13:50 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$version` of type `null\|string` against `null`; this is ambiguous if the string can be empty. Consider using a strict comparison `===` instead. Loading history...
16			$this->version = $version == null ? $vendorOrVersion : $version;
			0 ignored issues – show Bug introduced 2022-05-18 13:50 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$version` of type `null\|string` against `null`; this is ambiguous if the string can be empty. Consider using a strict comparison `===` instead. Loading history...
17			}
18
19			public function __toString()
20			{
21			return json_encode([
22			'vendor' => $this->vendor,
23			'version' => $this->version
24			]);
25			}
26
27			public function getVendor(): string
28			{
29			return $this->vendor;
30			}
31
32			public function setVendor(string $vendor): void
33			{
34			$this->vendor = $vendor;
35			}
36
37			public function getVersion(): string
38			{
39			return $this->version;
40			}
41
42			public function setVersion(string $version): void
43			{
44			$this->version = $version;
45			}
46			}
47

bingo-soft / jabe

Push — main ( d01f4c...5af89f )

ApplicationServerImpl::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like