Jabe\Engine\Impl\Telemetry\Dto\ApplicationServerImpl

Complexity

Total Complexity

8

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getVersion()	0	3	1
A	setVersion()	0	3	1
A	__toString()	0	5	1
A	getVendor()	0	3	1
A	setVendor()	0	3	1
A	__construct()	0	4	3

<?php

namespace Jabe\Engine\Impl\Telemetry\Dto;

use Jabe\Engine\Impl\Util\ParseUtil;
use Jabe\Engine\Telemetry\ApplicationServerInterface;

class ApplicationServerImpl implements ApplicationServerInterface
{
    protected $vendor;
    protected $version;

    public function __construct(string $vendorOrVersion, string $version = null)
    {
        $this->vendor = $version == null ? ParseUtil::parseServerVendor($vendorOrVersion) : $vendorOrVersion;

It seems like you are loosely comparing $version of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison === instead.

        $this->version = $version == null ? $vendorOrVersion : $version;

It seems like you are loosely comparing $version of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison === instead.

    }

    public function __toString()
    {
        return json_encode([
            'vendor' => $this->vendor,
            'version' => $this->version
        ]);
    }

    public function getVendor(): string
    {
        return $this->vendor;
    }

    public function setVendor(string $vendor): void
    {
        $this->vendor = $vendor;
    }

    public function getVersion(): string
    {
        return $this->version;
    }

    public function setVersion(string $version): void
    {
        $this->version = $version;
    }
}