Completed
Pull Request — master (#17)
by
unknown
10:41
created
src/AbTesting.php 2 patches
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -181,7 +181,6 @@  discard block
 block discarded – undo
181 181
     /**
182 182
      * Returns all the completed goals.
183 183
      *
184
-     * @param integer $visitor_id An optional visitor identifier
185 184
      *
186 185
      * @return \Illuminate\Support\Collection|false
187 186
      */
@@ -201,7 +200,7 @@  discard block
 block discarded – undo
201 200
      *
202 201
      * @param integer $visitor_id An optional visitor identifier
203 202
      *
204
-     * @return \Ben182\AbTesting\Models\SessionVisitor|\Ben182\AbTesting\Models\DatabaseVisitor
203
+     * @return VisitorInterface
205 204
      */
206 205
     public function getVisitor($visitor_id = null)
207 206
     {
Please login to merge, or discard this patch.
Unused Use Statements   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -2,15 +2,15 @@
 block discarded – undo
2 2
 
3 3
 namespace Ben182\AbTesting;
4 4
 
5
-use Illuminate\Support\Collection;
6
-use Ben182\AbTesting\Models\Goal;
7
-use Ben182\AbTesting\Models\Experiment;
8
-use Ben182\AbTesting\Models\DatabaseVisitor;
9
-use Ben182\AbTesting\Models\SessionVisitor;
10
-use Ben182\AbTesting\Events\GoalCompleted;
5
+use Ben182\AbTesting\Contracts\VisitorInterface;
11 6
 use Ben182\AbTesting\Events\ExperimentNewVisitor;
7
+use Ben182\AbTesting\Events\GoalCompleted;
12 8
 use Ben182\AbTesting\Exceptions\InvalidConfiguration;
13
-use Ben182\AbTesting\Contracts\VisitorInterface;
9
+use Ben182\AbTesting\Models\DatabaseVisitor;
10
+use Ben182\AbTesting\Models\Experiment;
11
+use Ben182\AbTesting\Models\Goal;
12
+use Ben182\AbTesting\Models\SessionVisitor;
13
+use Illuminate\Support\Collection;
14 14
 
15 15
 class AbTesting
16 16
 {
Please login to merge, or discard this patch.
src/Commands/ResetCommand.php 1 patch
Unused Use Statements   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -2,10 +2,10 @@
 block discarded – undo
2 2
 
3 3
 namespace Ben182\AbTesting\Commands;
4 4
 
5
-use Illuminate\Console\Command;
6
-use Ben182\AbTesting\Models\Goal;
7
-use Ben182\AbTesting\Models\Experiment;
8 5
 use Ben182\AbTesting\Models\DatabaseVisitor;
6
+use Ben182\AbTesting\Models\Experiment;
7
+use Ben182\AbTesting\Models\Goal;
8
+use Illuminate\Console\Command;
9 9
 
10 10
 
11 11
 class ResetCommand extends Command
Please login to merge, or discard this patch.
src/Events/ExperimentNewVisitor.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -8,6 +8,9 @@
 block discarded – undo
8 8
 {
9 9
     public $experiment;
10 10
 
11
+    /**
12
+     * @param \Ben182\AbTesting\Models\Experiment|null $experiment
13
+     */
11 14
     public function __construct($experiment, VisitorInterface $visitor)
12 15
     {
13 16
         $this->experiment = $experiment;
Please login to merge, or discard this patch.