Bavix\Wallet\Traits\CanExchange::forceExchange()

Complexity

Conditions	1
Paths	1

Size

Total Lines	22
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

0

<?php
    public function forceExchange(Wallet $to, int $amount): Transfer
    {
        /**
         * @var Wallet $from
         */
        $from = $this;

        return DB::transaction(function () use ($from, $to, $amount) {
            $rate = app(CurrencyService::class)->rate($from, $to);
            $withdraw = $this->withdraw($amount);

It seems like withdraw() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $deposit = $to->deposit($amount * $rate);

$amount * $rate of type double is incompatible with the type integer expected by parameter $amount of Bavix\Wallet\Interfaces\Wallet::deposit().

            $transfers = app(CommonService::class)->multiBrings([
                (new Bring())
                    ->setStatus(Transfer::STATUS_EXCHANGE)
                    ->setDeposit($deposit)
                    ->setWithdraw($withdraw)
                    ->setFrom($from)
                    ->setTo($to)
            ]);

            return current($transfers);
        });