Bavix\Wallet\Traits\CanExchange

Complexity

Total Complexity

4

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	exchange()	0	4	1
A	forceExchange()	0	22	1
A	safeExchange()	0	6	2

<?php

namespace Bavix\Wallet\Traits;

use Bavix\Wallet\Interfaces\Wallet;
use Bavix\Wallet\Models\Transfer;
use Bavix\Wallet\Objects\Bring;
use Bavix\Wallet\Services\CommonService;
use Bavix\Wallet\Services\CurrencyService;
use Illuminate\Support\Facades\DB;

trait CanExchange
{

    /**
     * @inheritDoc
     */
    public function exchange(Wallet $to, int $amount): Transfer
    {
        // todo: check
        return $this->forceExchange($to, $amount);
    }

    /**
     * @inheritDoc
     */
    public function safeExchange(Wallet $to, int $amount): ?Transfer
    {
       try {
           return $this->exchange($to, $amount);
       } catch (\Throwable $throwable) {
           return null;
       }
    }

    /**
     * @inheritDoc
     */
    public function forceExchange(Wallet $to, int $amount): Transfer
    {
        /**
         * @var Wallet $from
         */
        $from = $this;

        return DB::transaction(function () use ($from, $to, $amount) {
            $rate = app(CurrencyService::class)->rate($from, $to);
            $withdraw = $this->withdraw($amount);

It seems like withdraw() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $deposit = $to->deposit($amount * $rate);

$amount * $rate of type double is incompatible with the type integer expected by parameter $amount of Bavix\Wallet\Interfaces\Wallet::deposit().

            $transfers = app(CommonService::class)->multiBrings([
                (new Bring())
                    ->setStatus(Transfer::STATUS_EXCHANGE)
                    ->setDeposit($deposit)
                    ->setWithdraw($withdraw)
                    ->setFrom($from)
                    ->setTo($to)
            ]);

            return current($transfers);
        });
    }

}