Bavix\Wallet\Services\CommonService::addBalance()

Complexity

Conditions	3
Paths	4

Size

Total Lines	19
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	3.009

Importance

Changes

0

<?php
    public function addBalance(Wallet $wallet, int $amount): bool
    {
        /**
         * @var ProxyService $proxy
         * @var \Bavix\Wallet\Models\Wallet $wallet
         */
        $proxy = \app(ProxyService::class);
        $balance = $wallet->balance;
        if ($proxy->has($wallet->getKey())) {

It seems like $wallet->getKey() can also be of type boolean and null; however, parameter $key of Bavix\Wallet\Services\ProxyService::has() does only seem to accept string, maybe add an additional type check?

            $balance = $proxy->get($wallet->getKey());

It seems like $wallet->getKey() can also be of type boolean and null; however, parameter $key of Bavix\Wallet\Services\ProxyService::get() does only seem to accept string, maybe add an additional type check?

        }

        $balance += $amount;
        if ($wallet->update(\compact('balance'))) {
            $proxy->set($wallet->getKey(), $balance);

It seems like $wallet->getKey() can also be of type boolean and null; however, parameter $key of Bavix\Wallet\Services\ProxyService::set() does only seem to accept string, maybe add an additional type check?

            return true;
        }

        return false;
    }