Bavix\Wallet\Services\CommonService

Complexity

Total Complexity

6

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Test Coverage

Coverage

94.74%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	addBalance()	0	19	3
A	enforce()	0	15	3

<?php

namespace Bavix\Wallet\Services;

use Bavix\Wallet\Interfaces\Wallet;
use Bavix\Wallet\Models\Transaction;
use Bavix\Wallet\Objects\Operation;

class CommonService
{

    /**
     * @param Wallet $self
     * @param Operation[] $transactions
     * @return Transaction[]
     */
    public function enforce(Wallet $self, array $transactions): array
    {
        $objects = [];
        $amount = 0;

        foreach ($transactions as $transaction) {
            if ($transaction->isConfirmed()) {
                $amount += $transaction->getAmount();
            }

            $objects[] = $transaction->create($self);
        }

        $this->addBalance($self, $amount);
        return $objects;
    }

    /**
     * @param Wallet $wallet
     * @param int $amount
     * @return bool
     * @throws
     */
    public function addBalance(Wallet $wallet, int $amount): bool
    {
        /**
         * @var ProxyService $proxy
         * @var \Bavix\Wallet\Models\Wallet $wallet
         */
        $proxy = \app(ProxyService::class);
        $balance = $wallet->balance;
        if ($proxy->has($wallet->getKey())) {

It seems like $wallet->getKey() can also be of type boolean and null; however, parameter $key of Bavix\Wallet\Services\ProxyService::has() does only seem to accept string, maybe add an additional type check?

            $balance = $proxy->get($wallet->getKey());

It seems like $wallet->getKey() can also be of type boolean and null; however, parameter $key of Bavix\Wallet\Services\ProxyService::get() does only seem to accept string, maybe add an additional type check?

        }

        $balance += $amount;
        if ($wallet->update(\compact('balance'))) {
            $proxy->set($wallet->getKey(), $balance);

It seems like $wallet->getKey() can also be of type boolean and null; however, parameter $key of Bavix\Wallet\Services\ProxyService::set() does only seem to accept string, maybe add an additional type check?

            return true;
        }

        return false;
    }

}