Assets::map() - Code Metrics - Inspection of "add type hints" - basis-company/framework.php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e7b929...ba2691 )

by Dmitry

created 2017-08-26 09:44 UTC

Assets::map() A

↳ Parent: Assets

Complexity

Conditions	3
Paths	2

Size

Total Lines	13
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	13
ccs	0
cts	13
cp	0
rs	9.4285
cc	3
eloc	9
nc	2
nop	1
crap	12

<?php

namespace Basis\Job\Module;

use Basis\Filesystem;
use Basis\Job;

class Assets extends Job
{
    private $fs;
    public function __construct(Filesystem $fs)
    {
        $this->fs = $fs;
    }
    public function run()
    {
        $artifacts = [
            'js' => $this->map('js'),
            'styl' => $this->map('styl'),
        ];

        $artifacts['hash'] = md5(json_encode($artifacts));
        return $artifacts;
    }

    public function map($type)
    {
        $mapping = [];
        if (is_dir($type)) {
            exec('find '.$type.' -name "*.'.$type.'" -exec md5sum {} \; | sort', $contents);
            foreach ($contents as $i => $row) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                list($hash, $file) = explode("  ", $row);
                $file = substr($file, strlen($type) + 1);
                $mapping[$file] = $hash;
            }
        }
        return $mapping;
    }
}


1			<?php
2
3			namespace Basis\Job\Module;
4
5			use Basis\Filesystem;
6			use Basis\Job;
7
8			class Assets extends Job
9			{
10			private $fs;
11			public function __construct(Filesystem $fs)
12			{
13			$this->fs = $fs;
14			}
15			public function run()
16			{
17			$artifacts = [
18			'js' => $this->map('js'),
19			'styl' => $this->map('styl'),
20			];
21
22			$artifacts['hash'] = md5(json_encode($artifacts));
23			return $artifacts;
24			}
25
26			public function map($type)
27			{
28			$mapping = [];
29			if (is_dir($type)) {
30			exec('find '.$type.' -name "*.'.$type.'" -exec md5sum {} \; \| sort', $contents);
31			foreach ($contents as $i => $row) {
			0 ignored issues – show Bug introduced 2017-05-22 19:51 UTC by Report Bug Copy Issue Report The expression `$contents` of type `null\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
32			list($hash, $file) = explode(" ", $row);
33			$file = substr($file, strlen($type) + 1);
34			$mapping[$file] = $hash;
35			}
36			}
37			return $mapping;
38			}
39			}
40

basis-company / framework.php

Push — master ( e7b929...ba2691 )

Assets::map() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like