Basis\Job\Module\Assets

Complexity

Total Complexity

5

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	run()	0	10	1
A	map()	0	13	3

<?php

namespace Basis\Job\Module;

use Basis\Filesystem;
use Basis\Job;

class Assets extends Job
{
    private $fs;
    public function __construct(Filesystem $fs)
    {
        $this->fs = $fs;
    }
    public function run()
    {
        $artifacts = [
            'js' => $this->map('js'),
            'styl' => $this->map('styl'),
        ];

        $artifacts['hash'] = md5(json_encode($artifacts));
        return $artifacts;
    }

    public function map($type)
    {
        $mapping = [];
        if (is_dir($type)) {
            exec('find '.$type.' -name "*.'.$type.'" -exec md5sum {} \; | sort', $contents);
            foreach ($contents as $i => $row) {

The expression $contents of type null|array is not guaranteed to be traversable. How about adding an additional type check?

                list($hash, $file) = explode("  ", $row);
                $file = substr($file, strlen($type) + 1);
                $mapping[$file] = $hash;
            }
        }
        return $mapping;
    }
}