NodeInfo::isRoot() - Code Metrics - Inspection of "scope support added" - bartko-s/stefano-tree - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( d0fbe3...729812 )

by Bartko

created 2016-05-23 17:39 UTC

NodeInfo::isRoot() A

↳ Parent: NodeInfo

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	8
ccs	4
cts	4
cp	1
rs	9.4285
cc	2
eloc	5
nc	2
nop	0
crap	2

<?php
namespace StefanoTree\NestedSet;

class NodeInfo
{
    private $id;
    private $parentId;
    private $level;
    private $left;
    private $right;
    private $scope;

    public function __construct($id, $parentId, $level, $left, $right, $scope=null)
    {
        $this->id       = $id;
        $this->parentId = $parentId;
        $this->level    = $level;
        $this->left     = $left;
        $this->right    = $right;
        $this->scope    = $scope;
    }

    /**
     * @return int|null
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * @return int|null
     */
    public function getParentId()
    {
        return $this->parentId;
    }

    /**
     * @return int|null
     */
    public function getLevel()
    {
        return $this->level;
    }

    /**
     * @return int|null
     */
    public function getLeft()
    {
        return $this->left;
    }

    /**
     * @return int|null
     */
    public function getRight()
    {
        return $this->right;
    }

    /**
     * @return null|int
     */
    public function getScope()
    {
        return $this->scope;
    }

    /**
     * @return bool
     */
    public function isRoot()
    {
        if (0 == $this->getParentId()) {

            return true;
        } else {
            return false;
        }
    }
}


1		<?php
2		namespace StefanoTree\NestedSet;
3
4		class NodeInfo
5		{
6		private $id;
7		private $parentId;
8		private $level;
9		private $left;
10		private $right;
11		private $scope;
12
13	73	public function __construct($id, $parentId, $level, $left, $right, $scope=null)
14		{
15	73	$this->id = $id;
16	73	$this->parentId = $parentId;
17	73	$this->level = $level;
18	73	$this->left = $left;
19	73	$this->right = $right;
20	73	$this->scope = $scope;
21	73	}
22
23		/**
24		* @return int\|null
25		*/
26	17	public function getId()
27		{
28	17	return $this->id;
29		}
30
31		/**
32		* @return int\|null
33		*/
34	46	public function getParentId()
35		{
36	46	return $this->parentId;
37		}
38
39		/**
40		* @return int\|null
41		*/
42	53	public function getLevel()
43		{
44	53	return $this->level;
45		}
46
47		/**
48		* @return int\|null
49		*/
50	68	public function getLeft()
51		{
52	68	return $this->left;
53		}
54
55		/**
56		* @return int\|null
57		*/
58	68	public function getRight()
59		{
60	68	return $this->right;
61		}
62
63		/**
64		* @return null\|int
65		*/
66	53	public function getScope()
67		{
68	53	return $this->scope;
69		}
70
71		/**
72		* @return bool
73		*/
74	17	public function isRoot()
75		{
76	17	if (0 == $this->getParentId()) {
		0 ignored issues – show Bug introduced 2016-05-23 17:54 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$this->getParentId()` of type `integer\|null` to `0`; this is ambiguous as not only `0 == 0` is true, but `null == 0` is true, too. Consider using a strict comparison `===`. Loading history...
77	13	return true;
78		} else {
79	16	return false;
80		}
81		}
82		}
83

bartko-s / stefano-tree

Push — develop ( d0fbe3...729812 )

NodeInfo::isRoot() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like