StefanoTree\NestedSet\NodeInfo

Complexity

Total Complexity

9

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes	5
Bugs	1	Features	1

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	1
A	getId()	0	4	1
A	getParentId()	0	4	1
A	getLevel()	0	4	1
A	getLeft()	0	4	1
A	getRight()	0	4	1
A	getScope()	0	4	1
A	isRoot()	0	8	2

<?php
namespace StefanoTree\NestedSet;

class NodeInfo
{
    private $id;
    private $parentId;
    private $level;
    private $left;
    private $right;
    private $scope;

    public function __construct($id, $parentId, $level, $left, $right, $scope=null)
    {
        $this->id       = $id;
        $this->parentId = $parentId;
        $this->level    = $level;
        $this->left     = $left;
        $this->right    = $right;
        $this->scope    = $scope;
    }

    /**
     * @return int|null
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * @return int|null
     */
    public function getParentId()
    {
        return $this->parentId;
    }

    /**
     * @return int|null
     */
    public function getLevel()
    {
        return $this->level;
    }

    /**
     * @return int|null
     */
    public function getLeft()
    {
        return $this->left;
    }

    /**
     * @return int|null
     */
    public function getRight()
    {
        return $this->right;
    }

    /**
     * @return null|int
     */
    public function getScope()
    {
        return $this->scope;
    }

    /**
     * @return bool
     */
    public function isRoot()
    {
        if (0 == $this->getParentId()) {

It seems like you are loosely comparing $this->getParentId() of type integer|null to 0; this is ambiguous as not only 0 == 0 is true, but null == 0 is true, too. Consider using a strict comparison ===.

            return true;
        } else {
            return false;
        }
    }
}