LocationController::detailProvince() - Code Metrics - Inspection of "Merge pull request #12 from achmadhadikurnia/maste..." - bantenprov/wilayah-indonesia - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 364942...120590 )

unknown

created 2018-04-17 09:23 UTC

LocationController::detailProvince() A

↳ Parent: LocationController

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	6

Duplication

Lines	11
Ratio	100 %

Importance

Changes

Metric	Value
cc	1
eloc	6
nc	1
nop	1
dl	11
loc	11
rs	9.4285
c	0
b	0
f	0

<?php
namespace Bantenprov\WilayahIndonesia\Http\Controllers;

/* Require */
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;

/* Models */
use Laravolt\Indonesia\Indonesia;
use Laravolt\Indonesia\Models\Province;
use Laravolt\Indonesia\Models\City;
use Laravolt\Indonesia\Models\District;
use Laravolt\Indonesia\Models\Village;

/* Etc */

/**
 * The LocationController class.
 *
 * @package Bantenprov\WilayahIndonesia
 * @author  bantenprov <[email protected]>
 */
class LocationController extends Controller
{
    protected $indonesia;
    protected $province;
    protected $city;
    protected $district;
    protected $village;

    /**
     * Create a new controller instance.
     *
     * @return void

     */
    public function __construct()
    {
		$this->indonesia    = new Indonesia;
		$this->province     = new Province;
		$this->city         = new City;
		$this->district     = new District;
		$this->village      = new Village;
    }

    /**
     * Display a listing of the province resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function allProvince()

    {
        $provinces = $this->indonesia->allProvinces();

        foreach($provinces as $province){
            array_set($province, 'label', $province->name);
        }

        $response['province']   = $provinces;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Display a listing of the province resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function detailProvince($id)

    {
        $provinces = $this->indonesia->findProvince($id);

        array_set($provinces, 'label', $provinces->name);

        $response['province']   = $provinces;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Display a listing of the city resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function allCity()

    {
        $cities = $this->indonesia->allCities();

        foreach($cities as $city){
            array_set($city, 'label', $city->name);
        }

        $response['city']   = $cities;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Display a listing of the city resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function allCityByProvince($id)

    {
        $cities = $this->indonesia->findProvince($id, ['cities']);

        if (isset($cities->cities)) {
            $cities = $cities->cities;
        } else {
            $cities = $this->city->getAttributes();
        }

        foreach($cities as $city){
            array_set($city, 'label', $city->name);
        }

        $response['city']   = $cities;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Display a listing of the city resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function detailCity($id)

    {
        $cities = $this->indonesia->findCity($id);

        array_set($cities, 'label', $cities->name);

        $response['city']   = $cities;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Display a listing of the district resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function allDistrict()

    {
        $districts = $this->indonesia->allDistricts();

        foreach($districts as $district){
            array_set($district, 'label', $district->name);
        }

        $response['district']   = $districts;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Display a listing of the district resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function allDistrictByCity($id)

    {
        $districts = $this->indonesia->findCity($id, ['districts']);

        if (isset($districts->districts)) {
            $districts = $districts->districts;
        } else {
            $districts = $this->district->getAttributes();
        }

        foreach($districts as $district){
            array_set($district, 'label', $district->name);
        }

        $response['district']   = $districts;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Display a listing of the district resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function detailDistrict($id)

    {
        $districts = $this->indonesia->findDistrict($id);

        array_set($districts, 'label', $districts->name);

        $response['district']   = $districts;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Display a listing of the village resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function allVillage()

    {
        $villages = $this->indonesia->allVillages();

        foreach($villages as $village){
            array_set($village, 'label', $village->name);
        }

        $response['village']    = $villages;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Display a listing of the village resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function allVillageByDistrict($id)

    {
        $villages = $this->indonesia->findDistrict($id, ['villages']);

        if (isset($villages->villages)) {
            $villages = $villages->villages;
        } else {
            $villages = $this->village->getAttributes();
        }

        foreach($villages as $village){
            array_set($village, 'label', $village->name);
        }

        $response['village']    = $villages;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Display a listing of the village resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function detailVillage($id)

    {
        $villages = $this->indonesia->findVillage($id);

        array_set($villages, 'label', $villages->name);

        $response['village']    = $villages;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['status']     = true;

        return response()->json($response);
    }
}


1			<?php
2			namespace Bantenprov\WilayahIndonesia\Http\Controllers;
3
4			/* Require */
5			use App\Http\Controllers\Controller;
6			use Illuminate\Http\Request;
7
8			/* Models */
9			use Laravolt\Indonesia\Indonesia;
10			use Laravolt\Indonesia\Models\Province;
11			use Laravolt\Indonesia\Models\City;
12			use Laravolt\Indonesia\Models\District;
13			use Laravolt\Indonesia\Models\Village;
14
15			/* Etc */
16
17			/**
18			* The LocationController class.
19			*
20			* @package Bantenprov\WilayahIndonesia
21			* @author bantenprov <[email protected]>
22			*/
23			class LocationController extends Controller
24			{
25			protected $indonesia;
26			protected $province;
27			protected $city;
28			protected $district;
29			protected $village;
30
31			/**
32			* Create a new controller instance.
33			*
34			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2018-04-17 09:22 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
35			*/
36			public function __construct()
37			{
38			$this->indonesia = new Indonesia;
39			$this->province = new Province;

bantenprov / wilayah-indonesia

Push — master ( 364942...120590 )

LocationController::detailProvince() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like