Bantenprov\WilayahIndonesia\Http\Controllers\LocationController

Complexity

Total Complexity

22

Size/Duplication

Total Lines	241
Duplicated Lines	63.49 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

12 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	allProvince()	13	13	2
A	detailProvince()	11	11	1
A	allCity()	13	13	2
A	allCityByProvince()	19	19	3
A	detailCity()	11	11	1
A	allDistrict()	13	13	2
A	allDistrictByCity()	19	19	3
A	detailDistrict()	11	11	1
A	allVillage()	13	13	2
A	allVillageByDistrict()	19	19	3
A	detailVillage()	11	11	1

<?php
namespace Bantenprov\WilayahIndonesia\Http\Controllers;

/* Require */
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;

/* Models */
use Laravolt\Indonesia\Indonesia;
use Laravolt\Indonesia\Models\Province;
use Laravolt\Indonesia\Models\City;
use Laravolt\Indonesia\Models\District;
use Laravolt\Indonesia\Models\Village;

/* Etc */

/**
 * The LocationController class.
 *
 * @package Bantenprov\WilayahIndonesia
 * @author  bantenprov <developer.bantenprov@gmail.com>
 */
class LocationController extends Controller
{
    protected $indonesia;
    protected $province;
    protected $city;
    protected $district;
    protected $village;

    /**
     * Create a new controller instance.
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct()
    {
		$this->indonesia    = new Indonesia;
		$this->province     = new Province;
		$this->city         = new City;
		$this->district     = new District;
		$this->village      = new Village;
    }

    /**
     * Display a listing of the province resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function allProvince()

This method seems to be duplicated in your project.

    {
        $provinces = $this->indonesia->allProvinces();

        foreach($provinces as $province){
            array_set($province, 'label', $province->name);
        }

        $response['province']   = $provinces;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Display a listing of the province resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function detailProvince($id)

This method seems to be duplicated in your project.

    {
        $provinces = $this->indonesia->findProvince($id);

        array_set($provinces, 'label', $provinces->name);

        $response['province']   = $provinces;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Display a listing of the city resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function allCity()

This method seems to be duplicated in your project.

    {
        $cities = $this->indonesia->allCities();

        foreach($cities as $city){
            array_set($city, 'label', $city->name);
        }

        $response['city']   = $cities;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Display a listing of the city resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function allCityByProvince($id)

This method seems to be duplicated in your project.

    {
        $cities = $this->indonesia->findProvince($id, ['cities']);

        if (isset($cities->cities)) {
            $cities = $cities->cities;
        } else {
            $cities = $this->city->getAttributes();
        }

        foreach($cities as $city){
            array_set($city, 'label', $city->name);
        }

        $response['city']   = $cities;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Display a listing of the city resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function detailCity($id)

This method seems to be duplicated in your project.

    {
        $cities = $this->indonesia->findCity($id);

        array_set($cities, 'label', $cities->name);

        $response['city']   = $cities;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Display a listing of the district resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function allDistrict()

This method seems to be duplicated in your project.

    {
        $districts = $this->indonesia->allDistricts();

        foreach($districts as $district){
            array_set($district, 'label', $district->name);
        }

        $response['district']   = $districts;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Display a listing of the district resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function allDistrictByCity($id)

This method seems to be duplicated in your project.

    {
        $districts = $this->indonesia->findCity($id, ['districts']);

        if (isset($districts->districts)) {
            $districts = $districts->districts;
        } else {
            $districts = $this->district->getAttributes();
        }

        foreach($districts as $district){
            array_set($district, 'label', $district->name);
        }

        $response['district']   = $districts;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Display a listing of the district resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function detailDistrict($id)

This method seems to be duplicated in your project.

    {
        $districts = $this->indonesia->findDistrict($id);

        array_set($districts, 'label', $districts->name);

        $response['district']   = $districts;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Display a listing of the village resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function allVillage()

This method seems to be duplicated in your project.

    {
        $villages = $this->indonesia->allVillages();

        foreach($villages as $village){
            array_set($village, 'label', $village->name);
        }

        $response['village']    = $villages;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Display a listing of the village resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function allVillageByDistrict($id)

This method seems to be duplicated in your project.

    {
        $villages = $this->indonesia->findDistrict($id, ['villages']);

        if (isset($villages->villages)) {
            $villages = $villages->villages;
        } else {
            $villages = $this->village->getAttributes();
        }

        foreach($villages as $village){
            array_set($village, 'label', $village->name);
        }

        $response['village']    = $villages;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Display a listing of the village resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function detailVillage($id)

This method seems to be duplicated in your project.

    {
        $villages = $this->indonesia->findVillage($id);

        array_set($villages, 'label', $villages->name);

        $response['village']    = $villages;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['status']     = true;

        return response()->json($response);
    }
}