SekolahController::update() - Code Metrics - Inspection of "remove logo, foto_sekolah and modified migrations" - bantenprov/sekolah - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Pull Request — master (#26)

unknown
created 2018-04-22 12:40 UTC
SekolahController::update() A

↳ Parent: SekolahController
Complexity

Conditions	2
Paths	2
Size

Total Lines	51
Code Lines	42
Duplication

Lines	23
Ratio	45.1 %
Importance

Changes	1
Bugs	0	Features	0
Metric	Value
cc	2
eloc	42
c	1
b	0
f	0
nc	2
nop	2
dl	23
loc	51
rs	9.4109
How to fix Long Method

<?php

namespace Bantenprov\Sekolah\Http\Controllers;

/* Require */
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Bantenprov\Sekolah\Facades\SekolahFacade;

/* Models */
use Bantenprov\Sekolah\Models\Bantenprov\Sekolah\Sekolah;
use Bantenprov\Sekolah\Models\Bantenprov\Sekolah\JenisSekolah;
use Laravolt\Indonesia\Models\Province;
use Laravolt\Indonesia\Models\City;
use Laravolt\Indonesia\Models\District;
use Laravolt\Indonesia\Models\Village;
use Bantenprov\Zona\Models\Bantenprov\Zona\MasterZona;
use App\User;

/* Etc */
use Validator;
use Auth;

/**
 * The SekolahController class.
 *
 * @package Bantenprov\Sekolah
 * @author  bantenprov <[email protected]>
 */
class SekolahController extends Controller
{
    protected $sekolah;
    protected $jenis_sekolah;
    protected $master_zona;
    protected $user;

    /**
     * Create a new controller instance.
     *
     * @return void

     */
    public function __construct()
    {
        $this->sekolah          = new Sekolah;
        $this->jenis_sekolah    = new JenisSekolah;
        $this->province         = new Province;
        $this->city             = new City;
        $this->district         = new District;
        $this->village          = new Village;
        $this->master_zona      = new MasterZona;
        $this->user             = new User;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        if (request()->has('sort')) {

            list($sortCol, $sortDir) = explode('|', request()->sort);

            $query = $this->sekolah->orderBy($sortCol, $sortDir);
        } else {
            $query = $this->sekolah->orderBy('id', 'asc');
        }

        if ($request->exists('filter')) {
            $query->where(function($q) use($request) {
                $value = "%{$request->filter}%";

                $q->where('nama', 'like', $value)
                    ->orWhere('npsn', 'like', $value)
                    ->orWhere('alamat', 'like', $value)
                    ->orWhere('email', 'like', $value);
            });
        }

        $perPage = request()->has('per_page') ? (int) request()->per_page : null;

        $response = $query->with(['jenis_sekolah', 'province', 'city', 'district', 'village', 'master_zona', 'user'])->paginate($perPage);

        return response()->json($response)
            ->header('Access-Control-Allow-Origin', '*')
            ->header('Access-Control-Allow-Methods', 'GET');
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function get()
    {
        $sekolahs = $this->sekolah->with(['jenis_sekolah', 'province', 'city', 'district', 'village', 'master_zona', 'user'])->get();

        foreach($sekolahs as $sekolah){
            array_set($sekolah, 'label', $sekolah->nama);
        }

        $response['sekolahs']   = $sekolahs;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['error']      = false;
        $response['message']    = 'Success';
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        $user_id        = isset(Auth::User()->id) ? Auth::User()->id : null;
        $sekolah        = $this->sekolah->getAttributes();
        $jenis_sekolahs = $this->jenis_sekolah->getAttributes();
        $provinces      = $this->province->getAttributes();
        $cities         = $this->city->getAttributes();
        $districts      = $this->district->getAttributes();
        $villages       = $this->village->getAttributes();
        $master_zonas   = $this->master_zona->all();
        $users          = $this->user->getAttributes();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $users_special  = $this->user->all();
        $users_standar  = $this->user->findOrFail($user_id);
        $current_user   = Auth::User();

        foreach($jenis_sekolahs as $jenis_sekolah){
            array_set($jenis_sekolah, 'label', $jenis_sekolah->jenis_sekolah);
        }

        foreach($provinces as $province){
            array_set($province, 'label', $province->name);
        }

        foreach($cities as $city){
            array_set($city, 'label', $city->name);
        }

        foreach($districts as $district){
            array_set($district, 'label', $district->name);
        }

        foreach($villages as $village){
            array_set($village, 'label', $village->name);
        }

        foreach($master_zonas as $master_zona){
            array_set($master_zona, 'label', $master_zona->label);
        }

        $role_check = Auth::User()->hasRole(['superadministrator','administrator']);

        if($role_check){

            $user_special = true;

            foreach($users_special as $user){
                array_set($user, 'label', $user->name);
            }

            $users = $users_special;
        }else{
            $user_special = false;

            array_set($users_standar, 'label', $users_standar->name);

            $users = $users_standar;
        }

        array_set($current_user, 'label', $current_user->name);

        $response['sekolah']        = $sekolah;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['jenis_sekolahs'] = $jenis_sekolahs;
        $response['provinces']      = $provinces;
        $response['cities']         = $cities;
        $response['districts']      = $districts;
        $response['villages']       = $villages;
        $response['master_zonas']   = $master_zonas;
        $response['users']          = $users;
        $response['user_special']   = $user_special;
        $response['current_user']   = $current_user;
        $response['error']          = false;
        $response['message']        = 'Success';
        $response['status']         = true;

        return response()->json($response);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $sekolah = $this->sekolah;

        $validator = Validator::make($request->all(), [
            'nama'              => 'required|max:255',
            'npsn'              => "required|between:4,17|unique:{$this->sekolah->getTable()},npsn,NULL,id,deleted_at,NULL",
            'jenis_sekolah_id'  => "required|exists:{$this->jenis_sekolah->getTable()},id",
            'alamat'            => 'required|max:255',
            'logo'              => 'max:255',
            'foto_gedung'       => 'max:255',
            'province_id'       => "required|exists:{$this->province->getTable()},id",
            'city_id'           => "required|exists:{$this->city->getTable()},id",
            'district_id'       => "required|exists:{$this->district->getTable()},id",
            'village_id'        => "required|exists:{$this->village->getTable()},id",
            'no_telp'           => 'required|digits_between:10,12',
            'email'             => 'required|email|max:255',
            'kode_zona'         => "required|exists:{$this->master_zona->getTable()},id",
            'user_id'           => "required|exists:{$this->user->getTable()},id",
        ]);

        if ($validator->fails()) {

            $error      = true;
            $message    = $validator->errors()->first();
        } else {
            $sekolah->nama              = $request->input('nama');
            $sekolah->npsn              = $request->input('npsn');
            $sekolah->jenis_sekolah_id  = $request->input('jenis_sekolah_id');
            $sekolah->alamat            = $request->input('alamat');
            $sekolah->logo              = $request->input('logo');
            $sekolah->foto_gedung       = $request->input('foto_gedung');
            $sekolah->province_id       = $request->input('province_id');
            $sekolah->city_id           = $request->input('city_id');
            $sekolah->district_id       = $request->input('district_id');
            $sekolah->village_id        = $request->input('village_id');
            $sekolah->no_telp           = $request->input('no_telp');
            $sekolah->email             = $request->input('email');
            $sekolah->kode_zona         = $request->input('kode_zona');
            $sekolah->user_id           = $request->input('user_id');
            $sekolah->save();

            $error      = false;
            $message    = 'Success';
        }

        $response['error']      = $error;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['message']    = $message;
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Display the specified resource.
     *
     * @param  \App\Sekolah  $sekolah
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        $sekolah = $this->sekolah->with(['jenis_sekolah', 'province', 'city', 'district', 'village', 'master_zona', 'user'])->findOrFail($id);

        $response['sekolah']    = $sekolah;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['error']      = false;
        $response['message']    = 'Success';
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \App\Sekolah  $sekolah
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function edit($id)
    {
        $sekolah = $this->sekolah->with(['jenis_sekolah', 'province', 'city', 'district', 'village', 'master_zona', 'user'])->findOrFail($id);
        
        $response['sekolah']['province'] = array_add($sekolah->province, 'label', $sekolah->province->name);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

        $response['sekolah']['city'] = array_add($sekolah->city, 'label', $sekolah->city->name);

        $response['sekolah']['district'] = array_add($sekolah->district, 'label', $sekolah->district->name);

        $response['sekolah']['village'] = array_add($sekolah->village, 'label', $sekolah->village->name);

        $response['sekolah']['jenis_sekolah'] = array_add($sekolah->jenis_sekolah, 'label', $sekolah->jenis_sekolah->jenis_sekolah);


        

        $response['sekolah']    = $sekolah;
        $response['error']      = false;
        $response['message']    = 'Success';
        $response['status']     = true;


        return response()->json($response);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \App\Sekolah  $sekolah
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $sekolah = $this->sekolah->with(['jenis_sekolah', 'province', 'city', 'district', 'village', 'master_zona', 'user'])->findOrFail($id);

        $validator = Validator::make($request->all(), [
            'nama'              => 'required|max:255',
            'npsn'              => "required|between:4,17|unique:{$this->sekolah->getTable()},npsn,{$id},id,deleted_at,NULL",
            'jenis_sekolah_id'  => "required|exists:{$this->jenis_sekolah->getTable()},id",
            'alamat'            => 'required|max:255',
            'logo'              => 'max:255',
            'foto_gedung'       => 'max:255',
            'province_id'       => "required|exists:{$this->province->getTable()},id",
            'city_id'           => "required|exists:{$this->city->getTable()},id",
            'district_id'       => "required|exists:{$this->district->getTable()},id",
            'village_id'        => "required|exists:{$this->village->getTable()},id",
            'no_telp'           => 'required|digits_between:10,12',
            'email'             => 'required|email|max:255',
            'kode_zona'         => "required|exists:{$this->master_zona->getTable()},id",
            'user_id'           => "required|exists:{$this->user->getTable()},id",
        ]);

        if ($validator->fails()) {

            $error      = true;
            $message    = $validator->errors()->first();
        } else {
            $sekolah->nama              = $request->input('nama');
            $sekolah->npsn              = $request->input('npsn');
            $sekolah->jenis_sekolah_id  = $request->input('jenis_sekolah_id');
            $sekolah->alamat            = $request->input('alamat');
            $sekolah->logo              = $request->input('logo');
            $sekolah->foto_gedung       = $request->input('foto_gedung');
            $sekolah->province_id       = $request->input('province_id');
            $sekolah->city_id           = $request->input('city_id');
            $sekolah->district_id       = $request->input('district_id');
            $sekolah->village_id        = $request->input('village_id');
            $sekolah->no_telp           = $request->input('no_telp');
            $sekolah->email             = $request->input('email');
            $sekolah->kode_zona         = $request->input('kode_zona');
            $sekolah->user_id           = $request->input('user_id');
            $sekolah->save();

            $error      = false;
            $message    = 'Success';
        }

        $response['error']      = $error;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['message']    = $message;
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \App\Sekolah  $sekolah
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)

    {
        $sekolah = $this->sekolah->findOrFail($id);

        if ($sekolah->delete()) {
            $response['message']    = 'Success';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $response['success']    = true;
            $response['status']     = true;
        } else {
            $response['message']    = 'Failed';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $response['success']    = false;
            $response['status']     = false;
        }

        return json_encode($response);
    }
}

1			<?php
2
3			namespace Bantenprov\Sekolah\Http\Controllers;
4
5			/* Require */
6			use App\Http\Controllers\Controller;
7			use Illuminate\Http\Request;
8			use Bantenprov\Sekolah\Facades\SekolahFacade;
9
10			/* Models */
11			use Bantenprov\Sekolah\Models\Bantenprov\Sekolah\Sekolah;
12			use Bantenprov\Sekolah\Models\Bantenprov\Sekolah\JenisSekolah;
13			use Laravolt\Indonesia\Models\Province;
14			use Laravolt\Indonesia\Models\City;
15			use Laravolt\Indonesia\Models\District;
16			use Laravolt\Indonesia\Models\Village;
17			use Bantenprov\Zona\Models\Bantenprov\Zona\MasterZona;
18			use App\User;
19
20			/* Etc */
21			use Validator;
22			use Auth;
23
24			/**
25			* The SekolahController class.
26			*
27			* @package Bantenprov\Sekolah
28			* @author bantenprov <[email protected]>
29			*/
30			class SekolahController extends Controller
31			{
32			protected $sekolah;
33			protected $jenis_sekolah;
34			protected $master_zona;
35			protected $user;
36
37			/**
38			* Create a new controller instance.
39			*
40			* @return void
bantenprov / sekolah

Pull Request — master (#26)

SekolahController::update() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
