Bantenprov\Sekolah\Http\Controllers\SekolahController

Complexity

Total Complexity

25

Size/Duplication

Total Lines	351
Duplicated Lines	23.93 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	1
B	index()	7	29	4
A	get()	0	15	2
D	create()	15	75	10
A	show()	0	11	1
B	edit()	0	25	1
A	store()	23	51	2
A	update()	23	51	2
A	destroy()	16	16	2

<?php

namespace Bantenprov\Sekolah\Http\Controllers;

/* Require */
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Bantenprov\Sekolah\Facades\SekolahFacade;

/* Models */
use Bantenprov\Sekolah\Models\Bantenprov\Sekolah\Sekolah;
use Bantenprov\Sekolah\Models\Bantenprov\Sekolah\JenisSekolah;
use Laravolt\Indonesia\Models\Province;
use Laravolt\Indonesia\Models\City;
use Laravolt\Indonesia\Models\District;
use Laravolt\Indonesia\Models\Village;
use Bantenprov\Zona\Models\Bantenprov\Zona\MasterZona;
use App\User;

/* Etc */
use Validator;
use Auth;

/**
 * The SekolahController class.
 *
 * @package Bantenprov\Sekolah
 * @author  bantenprov <developer.bantenprov@gmail.com>
 */
class SekolahController extends Controller
{
    protected $sekolah;
    protected $jenis_sekolah;
    protected $master_zona;
    protected $user;

    /**
     * Create a new controller instance.
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct()
    {
        $this->sekolah          = new Sekolah;
        $this->jenis_sekolah    = new JenisSekolah;
        $this->province         = new Province;
        $this->city             = new City;
        $this->district         = new District;
        $this->village          = new Village;
        $this->master_zona      = new MasterZona;
        $this->user             = new User;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        if (request()->has('sort')) {

This code seems to be duplicated across your project.

            list($sortCol, $sortDir) = explode('|', request()->sort);

            $query = $this->sekolah->orderBy($sortCol, $sortDir);
        } else {
            $query = $this->sekolah->orderBy('id', 'asc');
        }

        if ($request->exists('filter')) {
            $query->where(function($q) use($request) {
                $value = "%{$request->filter}%";

                $q->where('nama', 'like', $value)
                    ->orWhere('npsn', 'like', $value)
                    ->orWhere('alamat', 'like', $value)
                    ->orWhere('email', 'like', $value);
            });
        }

        $perPage = request()->has('per_page') ? (int) request()->per_page : null;

        $response = $query->with(['jenis_sekolah', 'province', 'city', 'district', 'village', 'master_zona', 'user'])->paginate($perPage);

        return response()->json($response)
            ->header('Access-Control-Allow-Origin', '*')
            ->header('Access-Control-Allow-Methods', 'GET');
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function get()
    {
        $sekolahs = $this->sekolah->with(['jenis_sekolah', 'province', 'city', 'district', 'village', 'master_zona', 'user'])->get();

        foreach($sekolahs as $sekolah){
            array_set($sekolah, 'label', $sekolah->nama);
        }

        $response['sekolahs']   = $sekolahs;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['error']      = false;
        $response['message']    = 'Success';
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        $user_id        = isset(Auth::User()->id) ? Auth::User()->id : null;
        $sekolah        = $this->sekolah->getAttributes();
        $jenis_sekolahs = $this->jenis_sekolah->getAttributes();
        $provinces      = $this->province->getAttributes();
        $cities         = $this->city->getAttributes();
        $districts      = $this->district->getAttributes();
        $villages       = $this->village->getAttributes();
        $master_zonas   = $this->master_zona->all();
        $users          = $this->user->getAttributes();

$users is not used, you could remove the assignment.

        $users_special  = $this->user->all();
        $users_standar  = $this->user->findOrFail($user_id);
        $current_user   = Auth::User();

        foreach($jenis_sekolahs as $jenis_sekolah){
            array_set($jenis_sekolah, 'label', $jenis_sekolah->jenis_sekolah);
        }

        foreach($provinces as $province){
            array_set($province, 'label', $province->name);
        }

        foreach($cities as $city){
            array_set($city, 'label', $city->name);
        }

        foreach($districts as $district){
            array_set($district, 'label', $district->name);
        }

        foreach($villages as $village){
            array_set($village, 'label', $village->name);
        }

        foreach($master_zonas as $master_zona){
            array_set($master_zona, 'label', $master_zona->label);
        }

        $role_check = Auth::User()->hasRole(['superadministrator','administrator']);

        if($role_check){

This code seems to be duplicated across your project.

            $user_special = true;

            foreach($users_special as $user){
                array_set($user, 'label', $user->name);
            }

            $users = $users_special;
        }else{
            $user_special = false;

            array_set($users_standar, 'label', $users_standar->name);

            $users = $users_standar;
        }

        array_set($current_user, 'label', $current_user->name);

        $response['sekolah']        = $sekolah;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['jenis_sekolahs'] = $jenis_sekolahs;
        $response['provinces']      = $provinces;
        $response['cities']         = $cities;
        $response['districts']      = $districts;
        $response['villages']       = $villages;
        $response['master_zonas']   = $master_zonas;
        $response['users']          = $users;
        $response['user_special']   = $user_special;
        $response['current_user']   = $current_user;
        $response['error']          = false;
        $response['message']        = 'Success';
        $response['status']         = true;

        return response()->json($response);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $sekolah = $this->sekolah;

        $validator = Validator::make($request->all(), [
            'nama'              => 'required|max:255',
            'npsn'              => "required|between:4,17|unique:{$this->sekolah->getTable()},npsn,NULL,id,deleted_at,NULL",
            'jenis_sekolah_id'  => "required|exists:{$this->jenis_sekolah->getTable()},id",
            'alamat'            => 'required|max:255',
            'logo'              => 'max:255',
            'foto_gedung'       => 'max:255',
            'province_id'       => "required|exists:{$this->province->getTable()},id",
            'city_id'           => "required|exists:{$this->city->getTable()},id",
            'district_id'       => "required|exists:{$this->district->getTable()},id",
            'village_id'        => "required|exists:{$this->village->getTable()},id",
            'no_telp'           => 'required|digits_between:10,12',
            'email'             => 'required|email|max:255',
            'kode_zona'         => "required|exists:{$this->master_zona->getTable()},id",
            'user_id'           => "required|exists:{$this->user->getTable()},id",
        ]);

        if ($validator->fails()) {

This code seems to be duplicated across your project.

            $error      = true;
            $message    = $validator->errors()->first();
        } else {
            $sekolah->nama              = $request->input('nama');
            $sekolah->npsn              = $request->input('npsn');
            $sekolah->jenis_sekolah_id  = $request->input('jenis_sekolah_id');
            $sekolah->alamat            = $request->input('alamat');
            $sekolah->logo              = $request->input('logo');
            $sekolah->foto_gedung       = $request->input('foto_gedung');
            $sekolah->province_id       = $request->input('province_id');
            $sekolah->city_id           = $request->input('city_id');
            $sekolah->district_id       = $request->input('district_id');
            $sekolah->village_id        = $request->input('village_id');
            $sekolah->no_telp           = $request->input('no_telp');
            $sekolah->email             = $request->input('email');
            $sekolah->kode_zona         = $request->input('kode_zona');
            $sekolah->user_id           = $request->input('user_id');
            $sekolah->save();

            $error      = false;
            $message    = 'Success';
        }

        $response['error']      = $error;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['message']    = $message;
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Display the specified resource.
     *
     * @param  \App\Sekolah  $sekolah

There is no parameter named $sekolah. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        $sekolah = $this->sekolah->with(['jenis_sekolah', 'province', 'city', 'district', 'village', 'master_zona', 'user'])->findOrFail($id);

        $response['sekolah']    = $sekolah;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['error']      = false;
        $response['message']    = 'Success';
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \App\Sekolah  $sekolah

There is no parameter named $sekolah. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function edit($id)
    {
        $sekolah = $this->sekolah->with(['jenis_sekolah', 'province', 'city', 'district', 'village', 'master_zona', 'user'])->findOrFail($id);
        
        $response['sekolah']['province'] = array_add($sekolah->province, 'label', $sekolah->province->name);

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['sekolah']['city'] = array_add($sekolah->city, 'label', $sekolah->city->name);

        $response['sekolah']['district'] = array_add($sekolah->district, 'label', $sekolah->district->name);

        $response['sekolah']['village'] = array_add($sekolah->village, 'label', $sekolah->village->name);

        $response['sekolah']['jenis_sekolah'] = array_add($sekolah->jenis_sekolah, 'label', $sekolah->jenis_sekolah->jenis_sekolah);


        

        $response['sekolah']    = $sekolah;
        $response['error']      = false;
        $response['message']    = 'Success';
        $response['status']     = true;


        return response()->json($response);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \App\Sekolah  $sekolah

There is no parameter named $sekolah. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $sekolah = $this->sekolah->with(['jenis_sekolah', 'province', 'city', 'district', 'village', 'master_zona', 'user'])->findOrFail($id);

        $validator = Validator::make($request->all(), [
            'nama'              => 'required|max:255',
            'npsn'              => "required|between:4,17|unique:{$this->sekolah->getTable()},npsn,{$id},id,deleted_at,NULL",
            'jenis_sekolah_id'  => "required|exists:{$this->jenis_sekolah->getTable()},id",
            'alamat'            => 'required|max:255',
            'logo'              => 'max:255',
            'foto_gedung'       => 'max:255',
            'province_id'       => "required|exists:{$this->province->getTable()},id",
            'city_id'           => "required|exists:{$this->city->getTable()},id",
            'district_id'       => "required|exists:{$this->district->getTable()},id",
            'village_id'        => "required|exists:{$this->village->getTable()},id",
            'no_telp'           => 'required|digits_between:10,12',
            'email'             => 'required|email|max:255',
            'kode_zona'         => "required|exists:{$this->master_zona->getTable()},id",
            'user_id'           => "required|exists:{$this->user->getTable()},id",
        ]);

        if ($validator->fails()) {

This code seems to be duplicated across your project.

            $error      = true;
            $message    = $validator->errors()->first();
        } else {
            $sekolah->nama              = $request->input('nama');
            $sekolah->npsn              = $request->input('npsn');
            $sekolah->jenis_sekolah_id  = $request->input('jenis_sekolah_id');
            $sekolah->alamat            = $request->input('alamat');
            $sekolah->logo              = $request->input('logo');
            $sekolah->foto_gedung       = $request->input('foto_gedung');
            $sekolah->province_id       = $request->input('province_id');
            $sekolah->city_id           = $request->input('city_id');
            $sekolah->district_id       = $request->input('district_id');
            $sekolah->village_id        = $request->input('village_id');
            $sekolah->no_telp           = $request->input('no_telp');
            $sekolah->email             = $request->input('email');
            $sekolah->kode_zona         = $request->input('kode_zona');
            $sekolah->user_id           = $request->input('user_id');
            $sekolah->save();

            $error      = false;
            $message    = 'Success';
        }

        $response['error']      = $error;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['message']    = $message;
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \App\Sekolah  $sekolah

There is no parameter named $sekolah. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function destroy($id)

This method seems to be duplicated in your project.

    {
        $sekolah = $this->sekolah->findOrFail($id);

        if ($sekolah->delete()) {
            $response['message']    = 'Success';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            $response['success']    = true;
            $response['status']     = true;
        } else {
            $response['message']    = 'Failed';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            $response['success']    = false;
            $response['status']     = false;
        }

        return json_encode($response);
    }
}