Bankiru\Api\JsonRpc\Listener\ViewListener::onPlainResponse()

Complexity

Conditions	4
Paths	3

Size

Total Lines	25
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	15
CRAP Score	4.0039

Importance

Changes

0

<?php
    public function onPlainResponse(ViewEvent $event)
    {
        $request  = $event->getRequest();
        $response = $event->getResponse();

        // No need to perform JSON-RPC serialization here
        if (!$request instanceof RichJsonRpcRequest || $request->isNotification()) {
            return;
        }

        // Response is already properly formatted
        if ($response instanceof JsonRpcResponseInterface) {
            return;
        }

        $response = new JsonRpcResponse(
            $request->getId(),
            $this->normalizer->normalize(

It seems like $this->normalizer->normalize($event->getResponse(), $request->getAttributes()->get('_context')) targeting Bankiru\Api\JsonRpc\NormalizerInterface::normalize() can also be of type array; however, Bankiru\Api\JsonRpc\Specification\JsonRpcResponse::__construct() does only seem to accept null|object<stdClass>|array<integer,object<stdClass>>, maybe add an additional type check?

                $event->getResponse(),
                $request->getAttributes()->get('_context')
            )
        );

        $event->setResponse($response);
    }