Bankiru\Api\JsonRpc\Listener\ViewListener

Complexity

Total Complexity

5

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

94.74%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
B	onPlainResponse()	0	25	4

<?php

namespace Bankiru\Api\JsonRpc\Listener;

use Bankiru\Api\JsonRpc\NormalizerInterface;
use Bankiru\Api\JsonRpc\Specification\JsonRpcResponse;
use Bankiru\Api\JsonRpc\Specification\RichJsonRpcRequest;
use Bankiru\Api\Rpc\Event\ViewEvent;
use ScayTrase\Api\JsonRpc\JsonRpcResponseInterface;

final class ViewListener
{
    /**
     * @var NormalizerInterface
     */
    private $normalizer;

    /**
     * ViewListener constructor.
     *
     * @param NormalizerInterface $normalizer
     */
    public function __construct(NormalizerInterface $normalizer)
    {
        $this->normalizer = $normalizer;
    }

    public function onPlainResponse(ViewEvent $event)
    {
        $request  = $event->getRequest();
        $response = $event->getResponse();

        // No need to perform JSON-RPC serialization here
        if (!$request instanceof RichJsonRpcRequest || $request->isNotification()) {
            return;
        }

        // Response is already properly formatted
        if ($response instanceof JsonRpcResponseInterface) {
            return;
        }

        $response = new JsonRpcResponse(
            $request->getId(),
            $this->normalizer->normalize(

It seems like $this->normalizer->normalize($event->getResponse(), $request->getAttributes()->get('_context')) targeting Bankiru\Api\JsonRpc\NormalizerInterface::normalize() can also be of type array; however, Bankiru\Api\JsonRpc\Specification\JsonRpcResponse::__construct() does only seem to accept null|object<stdClass>|array<integer,object<stdClass>>, maybe add an additional type check?

                $event->getResponse(),
                $request->getAttributes()->get('_context')
            )
        );

        $event->setResponse($response);
    }

}