bankiru / jsonrpc-server-bundle

DependencyInjection/BankiruJsonRpcServerExtension.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace Bankiru\Api\JsonRpc\DependencyInjection;
 
-use Bankiru\Api\JsonRpc\Adapters\JMS\Compiler\JmsDriverPass;
 use Bankiru\Api\JsonRpc\Adapters\JMS\Compiler\RelationHandlerHelper;
 use Bankiru\Api\Rpc\RpcEvents;
 use JMS\SerializerBundle\JMSSerializerBundle;

Indentation +9 added lines, -9 removed lines

@@ -28,15 +28,15 @@
 
         if (!empty($config['view_listener'])) {
             $container->getDefinition($config['view_listener'])
-                      ->setPublic(true)
-                      ->addTag(
-                          'kernel.event_listener',
-                          [
-                              'event'    => RpcEvents::VIEW,
-                              'method'   => 'onPlainResponse',
-                              'priority' => -254,
-                          ]
-                      );
+                        ->setPublic(true)
+                        ->addTag(
+                            'kernel.event_listener',
+                            [
+                                'event'    => RpcEvents::VIEW,
+                                'method'   => 'onPlainResponse',
+                                'priority' => -254,
+                            ]
+                        );
         }
     }
 

Tests/JsonRpcControllerTest.php

Doc Comments +3 added lines

@@ -165,6 +165,9 @@
         );
     }
 
+    /**
+     * @param string $uri
+     */
     private function createJsonRequest($uri, $content)
     {
         return Request::create($uri, 'POST', [], [], [], [], json_encode($content));

Spacing +7 added lines, -7 removed lines

@@ -93,7 +93,7 @@ 
                 'method'  => 'test',
             ]
         );
-        $response   = $controller->jsonRpcAction($request);
+        $response = $controller->jsonRpcAction($request);
 
         self::assertTrue($response->isSuccessful());
         self::assertEquals('{"jsonrpc":"2.0","id":"test","result":{"success":true}}', $response->getContent());
@@ -112,7 +112,7 @@ 
                 ],
             ]
         );
-        $response   = $controller->jsonRpcAction($request);
+        $response = $controller->jsonRpcAction($request);
 
         self::assertTrue($response->isSuccessful());
         self::assertEquals('[{"jsonrpc":"2.0","id":"test","result":{"success":true}}]', $response->getContent());
@@ -129,7 +129,7 @@ 
                 'method'  => 'exception',
             ]
         );
-        $response   = $controller->jsonRpcAction($request);
+        $response = $controller->jsonRpcAction($request);
 
         self::assertTrue($response->isSuccessful());
         self::assertEquals(
@@ -156,7 +156,7 @@ 
                 ],
             ]
         );
-        $response   = $controller->jsonRpcAction($request);
+        $response = $controller->jsonRpcAction($request);
 
         self::assertTrue($response->isSuccessful());
         self::assertEquals(
@@ -176,7 +176,7 @@ 
         $kernel   = $this->prophesize(KernelInterface::class);
         $resolver = $this->prophesize(ControllerResolverInterface::class);
         $resolver->getController(Argument::type(RpcRequestInterface::class))->willReturn(
-            function (JsonRpcRequestInterface $request) {
+            function(JsonRpcRequestInterface $request) {
                 if ($request->getMethod() === 'exception') {
                     throw new \LogicException('Failure!');
                 }
@@ -185,7 +185,7 @@ 
             }
         );
         $resolver->getArguments(Argument::type(RpcRequestInterface::class), Argument::any())->will(
-            function (array $args) {
+            function(array $args) {
                 return [
                     $args[0],
                 ];
@@ -195,7 +195,7 @@ 
         $evm = $this->prophesize(EventDispatcherInterface::class);
         $evm->dispatch(Argument::exact(RpcEvents::EXCEPTION), Argument::type(GetExceptionResponseEvent::class))
             ->will(
-                function ($args) {
+                function($args) {
                     /** @var GetExceptionResponseEvent $event */
                     $event = $args[1];
 

DependencyInjection/Configuration.php

Indentation +3 added lines, -3 removed lines

@@ -15,9 +15,9 @@
         $root    = $builder->root('jsonrpc_server');
 
         $root->children()
-             ->scalarNode('view_listener')
-             ->info('View listener service ID')
-             ->defaultValue('jsonrpc_server.builtin_adapter.view_listener');
+                ->scalarNode('view_listener')
+                ->info('View listener service ID')
+                ->defaultValue('jsonrpc_server.builtin_adapter.view_listener');
 
         $adapters = $root->children()->arrayNode('adapters');
         $this->configureJms($adapters);

Tests/JsonRpcHttpResponseTest.php

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
             'empty array'    => [[]],
             'single success' => [clone $success],
             'single failure' => [clone $error],
-            'mixed array'    => [[clone $success, clone $error,]],
+            'mixed array'    => [[clone $success, clone $error, ]],
         ];
     }
 

Test/Tests/RouterTest.php

Braces +3 added lines, -1 removed lines

@@ -23,9 +23,11 @@
     {
         $client = self::createClient();
 
-        foreach (['test', 'test_private'] as $endpoint) /** @var MethodCollection $collection */ {
+        foreach (['test', 'test_private'] as $endpoint) {
+            /** @var MethodCollection $collection */ {
             /** @var Router $router */
             $router = $client->getContainer()->get('rpc_server.endpoint_router.' . $endpoint);
+        }
             self::assertNotNull($router);
             $collection = $router->getMethodCollection();
             self::assertNotNull($router);