bankiru / doctrine-api-client

src/Bankiru/Api/Doctrine/ApiEntityCache.php

Doc Comments +2 added lines, -2 removed lines

@@ -85,7 +85,7 @@ 
      * @param ApiMetadata $metadata
      * @param array       $identifiers
      *
-     * @return mixed
+     * @return string
      */
     private function getEntityKey(ApiMetadata $metadata, array $identifiers)
     {
@@ -101,7 +101,7 @@ 
      * @param ApiMetadata $metadata
      * @param array       $identifiers
      *
-     * @return bool
+     * @return boolean|null
      */
     public function set($data, ApiMetadata $metadata, array $identifiers)
     {

src/Bankiru/Api/Doctrine/Configuration.php

Doc Comments +1 added lines, -1 removed lines

@@ -81,7 +81,7 @@
     /**
      * Returns class cache configuration
      *
-     * @param $class
+     * @param string $class
      *
      * @return array|null Null if cache is not enabled for this class (use implementation defaults)
      */

src/Bankiru/Api/Doctrine/EntityManager.php

Doc Comments +1 added lines

@@ -80,6 +80,7 @@
 
     /**
      * @param array|mixed $id
+     * @param string $className
      *
      * @return array
      * @throws \LogicException

src/Bankiru/Api/Doctrine/EntityRepository.php

Doc Comments +2 added lines, -2 removed lines

@@ -57,7 +57,7 @@ 
     /**
      * Finds all objects in the repository.
      *
-     * @return array The objects.
+     * @return ApiCollection The objects.
      */
     public function findAll()
     {
@@ -76,7 +76,7 @@ 
      * @param int|null   $limit
      * @param int|null   $offset
      *
-     * @return array The objects.
+     * @return ApiCollection The objects.
      *
      * @throws \UnexpectedValueException
      */

src/Bankiru/Api/Doctrine/Mapping/EntityMetadata.php

Doc Comments +6 added lines

@@ -125,6 +125,9 @@ 
         return $this->identifier;
     }
 
+    /**
+     * @param string[] $identifier
+     */
     public function setIdentifier($identifier)
     {
         $this->identifier            = $identifier;
@@ -345,6 +348,9 @@ 
         return $this->associations[$fieldName];
     }
 
+    /**
+     * @param string $customRepositoryClassName
+     */
     public function setCustomRepositoryClass($customRepositoryClassName)
     {
         $this->repositoryClass = $customRepositoryClassName;

src/Bankiru/Api/Doctrine/Persister/ApiPersister.php

Doc Comments +3 added lines, -3 removed lines

@@ -98,7 +98,7 @@ 
      * @param int|null   $limit
      * @param int|null   $offset
      *
-     * @return array
+     * @return ArrayCollection
      */
     public function loadAll(array $criteria = [], array $orderBy = null, $limit = null, $offset = null)
     {
@@ -251,7 +251,7 @@ 
      * @param object                 $sourceEntity
      * @param AbstractLazyCollection $collection The collection to load/fill.
      *
-     * @return array
+     * @return AbstractLazyCollection
      */
     public function loadOneToManyCollection(array $assoc, $sourceEntity, AbstractLazyCollection $collection)
     {
@@ -273,7 +273,7 @@ 
      *
      * @param int|null $offset
      *
-     * @return array
+     * @return ApiCollection
      */
     public function getOneToManyCollection(array $assoc, $sourceEntity, $limit = null, $offset = null)
     {

Indentation +4 added lines, -4 removed lines

@@ -175,10 +175,10 @@
      * @todo Check identity map? loadById method? Try to guess whether $criteria is the id?
      */
     public function load(array $criteria,
-                         $entity = null,
-                         $assoc = null,
-                         $limit = null,
-                         array $orderBy = null)
+                            $entity = null,
+                            $assoc = null,
+                            $limit = null,
+                            array $orderBy = null)
     {
         // TODO: Implement load() method.
     }

Spacing +1 added lines, -1 removed lines

@@ -115,7 +115,7 @@
                 /** @var EntityMetadata $target */
                 $target = $this->manager->getClassMetadata($mapping['target']);
 
-                $converter = function ($value) use ($target) {
+                $converter = function($value) use ($target) {
                     if (!is_object($value)) {
                         return $value;
                     }

src/Bankiru/Api/Doctrine/UnitOfWork.php

Doc Comments +2 added lines, -2 removed lines

@@ -85,7 +85,7 @@ 
     }
 
     /**
-     * @param $className
+     * @param string $className
      *
      * @return EntityPersister
      */
@@ -142,7 +142,7 @@ 
     }
 
     /**
-     * @param             $className
+     * @param             string $className
      * @param \stdClass   $data
      * @param object|null $unmanagedProxy
      *

Unused Use Statements -3 removed lines

@@ -13,11 +13,8 @@
 use Bankiru\Api\Doctrine\Mapping\EntityMetadata;
 use Bankiru\Api\Doctrine\Persister\ApiPersister;
 use Bankiru\Api\Doctrine\Persister\EntityPersister;
-use Bankiru\Api\Doctrine\Proxy\ApiCollection;
 use Bankiru\Api\Doctrine\Utility\IdentifierFlattener;
 use Bankiru\Api\Doctrine\Utility\ReflectionPropertiesGetter;
-use Doctrine\Common\Collections\ArrayCollection;
-use Doctrine\Common\Collections\Collection;
 use Doctrine\Common\NotifyPropertyChanged;
 use Doctrine\Common\Persistence\Mapping\RuntimeReflectionService;
 use Doctrine\Common\Persistence\ObjectManagerAware;

src/Bankiru/Api/Tests/AbstractEntityManagerTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
     private $mocks = [];
 
     /**
-     * @return mixed
+     * @return ClientRegistry
      */
     public function getRegistry()
     {

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 use Bankiru\Api\Doctrine\EntityManager;
 use Bankiru\Api\Doctrine\EntityMetadataFactory;
 use Bankiru\Api\Doctrine\Mapping\Driver\YmlMetadataDriver;
-use Bankiru\Api\Doctrine\Proxy\ProxyFactory;
 use Bankiru\Api\Doctrine\Type\BaseTypeRegistry;
 use Bankiru\Api\Doctrine\Type\TypeRegistry;
 use Bankiru\Api\Test\TestClient;

src/Bankiru/Api/Tests/EntityCacheTest.php

Spacing +3 added lines, -3 removed lines

@@ -103,14 +103,14 @@ 
         static $items = [];
         $cache = $this->prophesize(CacheItemPoolInterface::class);
         $that  = $this;
-        $cache->getItem(Argument::type('string'))->will(function ($args) use (&$items, $that) {
+        $cache->getItem(Argument::type('string'))->will(function($args) use (&$items, $that) {
             $key = $args[0];
             if (!array_key_exists($key, $items)) {
                 $item = $that->prophesize(CacheItemInterface::class);
                 $item->getKey()->willReturn($key);
                 $item->isHit()->willReturn(false);
                 $item->get()->willReturn(null);
-                $item->set(Argument::any())->will(function ($args) use ($item) {
+                $item->set(Argument::any())->will(function($args) use ($item) {
                     $item->get()->willReturn($args[0]);
                 });
                 $item->expiresAfter(Argument::type('int'))->willReturn($item);
@@ -122,7 +122,7 @@ 
 
             return $items[$key]->reveal();
         });
-        $cache->save(Argument::type(CacheItemInterface::class))->will(function ($args) use (&$items) {
+        $cache->save(Argument::type(CacheItemInterface::class))->will(function($args) use (&$items) {
             $item = $args[0];
             $items[$item->getKey()]->isHit()->willReturn(true);
         });