bankiru / doctrine-api-client

Proxy/ApiCollection.php

Doc Comments +4 added lines, -1 removed lines

@@ -188,6 +188,9 @@ 
         return $this->snapshot;
     }
 
+    /**
+     * @param boolean $state
+     */
     public function setInitialized($state)
     {
         $this->initialized = (bool)$state;
@@ -452,7 +455,7 @@ 
      * Internal note: Tried to implement Serializable first but that did not work well
      *                with circular references. This solution seems simpler and works well.
      *
-     * @return array
+     * @return string[]
      */
     public function __sleep()
     {

Spacing +2 added lines, -2 removed lines

@@ -204,7 +204,7 @@ 
         return array_udiff_assoc(
             $this->snapshot,
             $this->collection->toArray(),
-            function ($a, $b) {
+            function($a, $b) {
                 return $a === $b ? 0 : 1;
             }
         );
@@ -221,7 +221,7 @@ 
         return array_udiff_assoc(
             $this->collection->toArray(),
             $this->snapshot,
-            function ($a, $b) {
+            function($a, $b) {
                 return $a === $b ? 0 : 1;
             }
         );

Tests/AbstractEntityManagerTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
     private $clients = [];
 
     /**
-     * @return mixed
+     * @return ClientRegistryInterface
      */
     public function getRegistry()
     {

Spacing +2 added lines, -2 removed lines

@@ -101,14 +101,14 @@
         $configuration->setRegistry($this->registry);
         $configuration->setTypeRegistry(new BaseTypeRegistry(new TypeRegistry()));
         $configuration->setResolver(new ConstructorFactoryResolver());
-        $configuration->setProxyDir(CACHE_DIR.'/doctrine/proxy/');
+        $configuration->setProxyDir(CACHE_DIR . '/doctrine/proxy/');
         $configuration->setProxyNamespace('Bankiru\Api\Doctrine\Test\Proxy');
         $driver = new MappingDriverChain();
         $driver->addDriver(
             new YmlMetadataDriver(
                 new SymfonyFileLocator(
                     [
-                        __DIR__.'/../Test/Resources/config/api/' => 'Bankiru\Api\Doctrine\Test\Entity',
+                        __DIR__ . '/../Test/Resources/config/api/' => 'Bankiru\Api\Doctrine\Test\Entity',
                     ],
                     '.api.yml',
                     DIRECTORY_SEPARATOR

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 use Bankiru\Api\Doctrine\EntityManager;
 use Bankiru\Api\Doctrine\EntityMetadataFactory;
 use Bankiru\Api\Doctrine\Mapping\Driver\YmlMetadataDriver;
-use Bankiru\Api\Doctrine\Test\TestApiFactory;
 use Bankiru\Api\Doctrine\Type\BaseTypeRegistry;
 use Bankiru\Api\Doctrine\Type\TypeRegistry;
 use Doctrine\Common\Persistence\Mapping\Driver\MappingDriverChain;

Cache/KeyStrategyInterface.php

Spacing +1 added lines, -1 removed lines

@@ -24,5 +24,5 @@
      *
      * @return string
      */
-    public function getEntityKey(ApiMetadata $metadata,array $identifier);
+    public function getEntityKey(ApiMetadata $metadata, array $identifier);
 }

Rpc/SearchArgumentsTransformer.php

Spacing +2 added lines, -2 removed lines

@@ -44,7 +44,7 @@ 
                 /** @var EntityMetadata $target */
                 $target = $this->manager->getClassMetadata($mapping['target']);
 
-                $converter = function ($value) use ($target) {
+                $converter = function($value) use ($target) {
                     if (!is_object($value)) {
                         return $value;
                     }
@@ -70,7 +70,7 @@ 
                     $values = $converter($values);
                 }
             } else {
-                $caster = function ($value) use ($field) {
+                $caster = function($value) use ($field) {
                     $type = $this->manager
                         ->getConfiguration()
                         ->getTypeRegistry()->get($this->metadata->getTypeOfField($field));

Tests/EntityFactoryTest.php

Spacing +3 added lines, -3 removed lines

@@ -21,7 +21,7 @@ 
                     'payload' => 'test-payload',
                 ]
             ),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('test-entity/find', $request->getMethod());
                 self::assertEquals(['id' => 1], $request->getParameters());
 
@@ -50,7 +50,7 @@ 
                     'sub-payload' => 'sub-payload',
                 ]
             ),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('test-entity/find', $request->getMethod());
                 self::assertEquals(['id' => 2], $request->getParameters());
 
@@ -79,7 +79,7 @@ 
                     'payload'    => 'test-payload',
                 ]
             ),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('composite-key-entity/find', $request->getMethod());
                 self::assertEquals(['first_key' => 2, 'second_key' => 'test'], $request->getParameters());
 

Tests/EntityCacheTest.php

Spacing +4 added lines, -4 removed lines

@@ -23,7 +23,7 @@ 
                     'payload' => 'test-payload',
                 ]
             ),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('custom-entity/find', $request->getMethod());
                 self::assertEquals(['id' => 1], $request->getParameters());
 
@@ -98,7 +98,7 @@ 
         $cache = $this->prophesize(CacheItemPoolInterface::class);
         $that  = $this;
         $cache->getItem(Argument::type('string'))->will(
-            function ($args) use (&$items, $that) {
+            function($args) use (&$items, $that) {
                 $key = $args[0];
                 if (!array_key_exists($key, $items)) {
                     $item = $that->prophesize(CacheItemInterface::class);
@@ -106,7 +106,7 @@ 
                     $item->isHit()->willReturn(false);
                     $item->get()->willReturn(null);
                     $item->set(Argument::any())->will(
-                        function ($args) use ($item) {
+                        function($args) use ($item) {
                             $item->get()->willReturn($args[0]);
 
                             return $item;
@@ -123,7 +123,7 @@ 
             }
         );
         $cache->save(Argument::type(CacheItemInterface::class))->will(
-            function ($args) use (&$items) {
+            function($args) use (&$items) {
                 $item = $args[0];
                 $items[$item->getKey()]->isHit()->willReturn(true);
             }

Tests/CollectionLoadingTest.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
                     ],
                 ]
             ),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('test-entity/search', $request->getMethod());
                 self::assertEquals(
                     [

Mapping/Driver/YmlMetadataDriver.php

Spacing +1 added lines, -2 removed lines

@@ -61,8 +61,7 @@
             if (array_key_exists('entityPath', $element['client'])) {
                 $pathSeparator  =
                     array_key_exists('entityPathSeparator', $element['client']) ?
-                        $element['client']['entityPathSeparator'] :
-                        EntityMethodProvider::DEFAULT_PATH_SEPARATOR;
+                        $element['client']['entityPathSeparator'] : EntityMethodProvider::DEFAULT_PATH_SEPARATOR;
                 $methodProvider =
                     new EntityMethodProvider($element['client']['entityPath'], $pathSeparator, $methodProvider);
             }

Tests/IndirectFieldsTest.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
                     ],
                 ]
             ),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('test-entity/search', $request->getMethod());
                 self::assertEquals(
                     [